Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41272/?format=api
{ "id": 41272, "url": "https://patches.dpdk.org/api/patches/41272/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-4-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180619213058.12273-4-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180619213058.12273-4-ajit.khaparde@broadcom.com", "date": "2018-06-19T21:30:30", "name": "[03/31] net/bnxt: Rx processing optimization", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "30d0ea81bf3e280f5049456633cc211cb7f82598", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-4-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 171, "url": "https://patches.dpdk.org/api/series/171/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=171", "date": "2018-06-19T21:30:31", "name": "bnxt patchset", "version": 1, "mbox": "https://patches.dpdk.org/series/171/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41272/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/41272/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0BA5F1B059;\n\tTue, 19 Jun 2018 23:31:14 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id B77121B057\n\tfor <dev@dpdk.org>; Tue, 19 Jun 2018 23:31:07 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 9B36530C08C;\n\tTue, 19 Jun 2018 14:31:02 -0700 (PDT)", "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 7F442AC06AD;\n\tTue, 19 Jun 2018 14:31:02 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 9B36530C08C", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1529443862;\n\tbh=xEmSipGGTkLtumQ141pU1gNSJTPQlK/L1QRmqFMKWUc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gbJvaQD8YZHYKSmYr0hfcedFvm0sfO+yHRiTdRShLUTX9hfBxch33hSQrEtAu0oC6\n\tIobEz9OagOWLKgjE8si45/up7TDm127vK+FqslQWsbTqsU50HYKQkau8AJUqQUgjkN\n\tLFQ1bpZSL++69o9wMkWmzODAEys5dKVYQU0sao9o=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Tue, 19 Jun 2018 14:30:30 -0700", "Message-Id": "<20180619213058.12273-4-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.15.1 (Apple Git-101)", "In-Reply-To": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "References": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 03/31] net/bnxt: Rx processing optimization", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "1) Use nb_rx_pkts instead of checking producer indices of Rx and\naggregator rings to decide if any Rx completions were processed.\n2) Post Rx buffers early in Rx processing instead of waiting for\nthe budgeted burst quota.\n3) Ring Rx CQ DB after Rx buffers are posted.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_rxr.c | 12 ++++++++----\n drivers/net/bnxt/bnxt_rxr.h | 2 ++\n 2 files changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c\nindex 9d8842926..b6b72c553 100644\n--- a/drivers/net/bnxt/bnxt_rxr.c\n+++ b/drivers/net/bnxt/bnxt_rxr.c\n@@ -540,8 +540,8 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tint rc = 0;\n \tbool evt = false;\n \n-\t/* If Rx Q was stopped return */\n-\tif (rxq->rx_deferred_start)\n+\t/* If Rx Q was stopped return. RxQ0 cannot be stopped. */\n+\tif (rxq->rx_deferred_start && rxq->queue_id)\n \t\treturn 0;\n \n \t/* Handle RX burst request */\n@@ -572,10 +572,13 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\traw_cons = NEXT_RAW_CMP(raw_cons);\n \t\tif (nb_rx_pkts == nb_pkts || evt)\n \t\t\tbreak;\n+\t\t/* Post some Rx buf early in case of larger burst processing */\n+\t\tif (nb_rx_pkts == BNXT_RX_POST_THRESH)\n+\t\t\tB_RX_DB(rxr->rx_doorbell, rxr->rx_prod);\n \t}\n \n \tcpr->cp_raw_cons = raw_cons;\n-\tif ((prod == rxr->rx_prod && ag_prod == rxr->ag_prod) && !evt) {\n+\tif (!nb_rx_pkts && !evt) {\n \t\t/*\n \t\t * For PMD, there is no need to keep on pushing to REARM\n \t\t * the doorbell if there are no new completions\n@@ -583,7 +586,6 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\treturn nb_rx_pkts;\n \t}\n \n-\tB_CP_DIS_DB(cpr, cpr->cp_raw_cons);\n \tif (prod != rxr->rx_prod)\n \t\tB_RX_DB(rxr->rx_doorbell, rxr->rx_prod);\n \n@@ -591,6 +593,8 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tif (ag_prod != rxr->ag_prod)\n \t\tB_RX_DB(rxr->ag_doorbell, rxr->ag_prod);\n \n+\tB_CP_DIS_DB(cpr, cpr->cp_raw_cons);\n+\n \t/* Attempt to alloc Rx buf in case of a previous allocation failure. */\n \tif (rc == -ENOMEM) {\n \t\tint i;\ndiff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h\nindex 5b28f0321..3815a2199 100644\n--- a/drivers/net/bnxt/bnxt_rxr.h\n+++ b/drivers/net/bnxt/bnxt_rxr.h\n@@ -54,6 +54,8 @@\n #define RX_CMP_IP_CS_UNKNOWN(rxcmp1)\t\t\t\t\t\\\n \t\t!((rxcmp1)->flags2 & RX_CMP_IP_CS_BITS)\n \n+#define BNXT_RX_POST_THRESH\t32\n+\n enum pkt_hash_types {\n \tPKT_HASH_TYPE_NONE,\t/* Undefined type */\n \tPKT_HASH_TYPE_L2,\t/* Input: src_MAC, dest_MAC */\n", "prefixes": [ "03/31" ] }