Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41221,
    "url": "https://patches.dpdk.org/api/patches/41221/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1529205194-87434-3-git-send-email-jiayu.hu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1529205194-87434-3-git-send-email-jiayu.hu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1529205194-87434-3-git-send-email-jiayu.hu@intel.com",
    "date": "2018-06-17T03:13:13",
    "name": "[v2,2/3] app/testpmd: enable UDP GSO in csum engine",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "267591449e50a4c252a3056839d4d29317eb7fb3",
    "submitter": {
        "id": 539,
        "url": "https://patches.dpdk.org/api/people/539/?format=api",
        "name": "Hu, Jiayu",
        "email": "jiayu.hu@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1529205194-87434-3-git-send-email-jiayu.hu@intel.com/mbox/",
    "series": [
        {
            "id": 149,
            "url": "https://patches.dpdk.org/api/series/149/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=149",
            "date": "2018-06-17T03:13:11",
            "name": "Support UDP/IPv4 GSO",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/149/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/41221/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/41221/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 147C41B4DE;\n\tSun, 17 Jun 2018 05:05:36 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 70CD81B3B6\n\tfor <dev@dpdk.org>; Sun, 17 Jun 2018 05:05:27 +0200 (CEST)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t16 Jun 2018 20:05:27 -0700",
            "from dpdk15.sh.intel.com ([10.67.111.146])\n\tby orsmga008.jf.intel.com with ESMTP; 16 Jun 2018 20:05:25 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,233,1526367600\"; d=\"scan'208\";a=\"49937437\"",
        "From": "Jiayu Hu <jiayu.hu@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "konstantin.ananyev@intel.com, yuwei1.zhang@intel.com,\n\tbernard.iremonger@intel.com, Jiayu Hu <jiayu.hu@intel.com>",
        "Date": "Sun, 17 Jun 2018 11:13:13 +0800",
        "Message-Id": "<1529205194-87434-3-git-send-email-jiayu.hu@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1529205194-87434-1-git-send-email-jiayu.hu@intel.com>",
        "References": "<1527579670-91026-1-git-send-email-jiayu.hu@intel.com>\n\t<1529205194-87434-1-git-send-email-jiayu.hu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 2/3] app/testpmd: enable UDP GSO in csum engine",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch enables GSO for UDP/IPv4 packets. Oversized UDP/IPv4\npackets transmitted over a GSO-enabled port will undergo segmentation.\n\nSigned-off-by: Jiayu Hu <jiayu.hu@intel.com>\n---\n app/test-pmd/cmdline.c  | 5 +++--\n app/test-pmd/csumonly.c | 2 ++\n app/test-pmd/testpmd.c  | 2 +-\n 3 files changed, 6 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 27e2aa8..4239e91 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -4792,8 +4792,9 @@ cmd_gso_show_parsed(void *parsed_result,\n \t\tif (gso_ports[res->cmd_pid].enable) {\n \t\t\tprintf(\"Max GSO'd packet size: %uB\\n\"\n \t\t\t\t\t\"Supported GSO types: TCP/IPv4, \"\n-\t\t\t\t\t\"VxLAN with inner TCP/IPv4 packet, \"\n-\t\t\t\t\t\"GRE with inner TCP/IPv4  packet\\n\",\n+\t\t\t\t\t\"UDP/IPv4, VxLAN with inner \"\n+\t\t\t\t\t\"TCP/IPv4 packet, GRE with inner \"\n+\t\t\t\t\t\"TCP/IPv4 packet\\n\",\n \t\t\t\t\tgso_max_segment_size);\n \t\t} else\n \t\t\tprintf(\"GSO is not enabled on Port %u\\n\", res->cmd_pid);\ndiff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c\nindex 0bb88cf..4948292 100644\n--- a/app/test-pmd/csumonly.c\n+++ b/app/test-pmd/csumonly.c\n@@ -411,6 +411,8 @@ process_inner_cksums(void *l3_hdr, const struct testpmd_offload_info *info,\n \t\t\t\t\t\tinfo->ethertype);\n \t\t\t}\n \t\t}\n+\t\tif (info->gso_enable)\n+\t\t\tol_flags |= PKT_TX_UDP_SEG;\n \t} else if (info->l4_proto == IPPROTO_TCP) {\n \t\ttcp_hdr = (struct tcp_hdr *)((char *)l3_hdr + info->l3_len);\n \t\ttcp_hdr->cksum = 0;\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 35cf266..b5766ff 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -777,7 +777,7 @@ init_config(void)\n \tinit_port_config();\n \n \tgso_types = DEV_TX_OFFLOAD_TCP_TSO | DEV_TX_OFFLOAD_VXLAN_TNL_TSO |\n-\t\tDEV_TX_OFFLOAD_GRE_TNL_TSO;\n+\t\tDEV_TX_OFFLOAD_GRE_TNL_TSO | DEV_TX_OFFLOAD_UDP_TSO;\n \t/*\n \t * Records which Mbuf pool to use by each logical core, if needed.\n \t */\n",
    "prefixes": [
        "v2",
        "2/3"
    ]
}