Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41218/?format=api
{ "id": 41218, "url": "https://patches.dpdk.org/api/patches/41218/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1529163397-88330-2-git-send-email-ido@cgstowernetworks.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1529163397-88330-2-git-send-email-ido@cgstowernetworks.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1529163397-88330-2-git-send-email-ido@cgstowernetworks.com", "date": "2018-06-16T15:36:37", "name": "[2/2] net/pcap: duplicate code consolidation", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "14e7a57a2006560ec8526a3b0a1a65ab2b3cc91a", "submitter": { "id": 1047, "url": "https://patches.dpdk.org/api/people/1047/?format=api", "name": "Ido Goshen", "email": "ido@cgstowernetworks.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1529163397-88330-2-git-send-email-ido@cgstowernetworks.com/mbox/", "series": [ { "id": 148, "url": "https://patches.dpdk.org/api/series/148/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=148", "date": "2018-06-16T15:36:36", "name": "[1/2] net/pcap: multiple queues fix", "version": 1, "mbox": "https://patches.dpdk.org/series/148/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41218/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/41218/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 48BF31B5D7;\n\tSat, 16 Jun 2018 22:22:22 +0200 (CEST)", "from EUR02-HE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr10106.outbound.protection.outlook.com [40.107.1.106])\n\tby dpdk.org (Postfix) with ESMTP id BDA591B1FC\n\tfor <dev@dpdk.org>; Sat, 16 Jun 2018 17:37:17 +0200 (CEST)", "from ubuntu.localdomain (81.218.57.230) by\n\tHE1PR0901MB1436.eurprd09.prod.outlook.com (2603:10a6:3:54::8) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.863.19; Sat, 16 Jun 2018 15:37:15 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cgstowernetworks.onmicrosoft.com; s=selector1-cgstowernetworks-com; \n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=YZcx0sbZh4MsrprgOm6UWgCFo5Q3uX9jiSE+BDVKYpw=;\n\tb=PLG1J+YQrWp37UCthVWVR2MNKXXbmW7SHkAMEVvL8j1Ig3y4XDMYwGL/MMA4c8PuUdbrTTPEKsOFOfmnatuG5YVjKxgkeRBcav+neQ/o4jA5OHWYynTpeuf4go+Zj8UJpkK7aDizjkIUbZWapQa1wDs6ecYdeMES7rkKH3i3x70=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Ido@cgstowernetworks.com; ", "From": "ido goshen <ido@cgstowernetworks.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org,\n\tido goshen <ido@cgstowernetworks.com>", "Date": "Sat, 16 Jun 2018 18:36:37 +0300", "Message-Id": "<1529163397-88330-2-git-send-email-ido@cgstowernetworks.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1529163397-88330-1-git-send-email-ido@cgstowernetworks.com>", "References": "<1529163397-88330-1-git-send-email-ido@cgstowernetworks.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[81.218.57.230]", "X-ClientProxiedBy": "CWXP265CA0032.GBRP265.PROD.OUTLOOK.COM\n\t(2603:10a6:400:2d::20) To HE1PR0901MB1436.eurprd09.prod.outlook.com\n\t(2603:10a6:3:54::8)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "2603e9e1-e3d2-45d5-63e6-08d5d39f0a3f", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020);\n\tSRVR:HE1PR0901MB1436; ", "X-Microsoft-Exchange-Diagnostics": [ "1; HE1PR0901MB1436;\n\t3:3AKO2NhfnuhwdQdys/e67IyjkWYTKdZwheqK2rgl6jw4ugf6WMFZPsURQVAsjogVZnT3y3uGJoxnsTZUILVZPhtUhNeSuox9yahE868eZg12l18IoXGouusk5pt1ZSTXc0VzJ/LtStqE8yRpoltMNmSLiGhQN4G8ViuvQ+/rMp0cFi16ZQAfwzpDljr8ifERLqoVK+7b+YoJ/5HZnXh5KhTEZF7RS+gVdAcLECF1boTHbu306I7OkPD1DnBok2bb;\n\t25:qZ9E3tUdhODMVQjJFRxFLntGLDNz1oWIXSGzwWRyus7nGYLnGmZ97CkRVsgU477TaY1TwHYCnqthEjrC8cIq87bDBVTodxM0h/cMzEfw23q+0AYzprid9EqucjjdAa6/8TR+tLFhhQrBA1r/6NSexLq4aStR9oJOmeqLuu+w564FUdMR3S5czrkqiss4Ls+HN39OuOCEReDYvJRqyYcEBGnpdy5K9XJ09u9qKhKPBuKzG5l8jRLF4HXXbE+fcEbwWD0+if2cQCM3vUOkPAG5MoL+a7GX4JaesJ9EnfMKCT0Hr3Z44wMc5P+HpxjMHjNTsNkKo/4b0X5Do3EVzQbVGw==;\n\t31:1/Rcw+qFdRrqsVvI9GQZDOqZNf+8XOABi3fYXDNE9rDoAdG1+G52xbVYFi0cjPHOcPOGNoFBYQwwKubG+gA43WCXcvgXIrQhygdk2OgfByH5L9/9VKPAPA6LqMajHlAptNQ/Si3rAJDtL/OAqA9fMFNwfYaYxvorcg9avH4XpuzkUhHa8xQ2q+qglVtyjAaNpKq67eivDrvXjw2ScDayXjnsKmOHdKye3z3LLCA6Pck=", "1; HE1PR0901MB1436;\n\t4:7qnfEB41JTyo1J8DWGrpWZ5m0BC8OshfjRknWCUsPCafAicwZgfK75phFsjCXaEWSWvVwZmVXOcmKclUcvFB/4XlXPwgtJVxeu45UqzL2quzgqxbenn2cSLnLZDJcYgKeQh3aK74H9tuudw/qncJPlsBBktvwtArHdjWNgmoa36iFf2WR1szq+FeMI5pJjmJ9Dl/Emc65ZFCih233YDjob58UtUmAlxTzTIlOxvzPclf2QpRz6jnsn0/ZZLHRB+EcJRVyzWcep1WohJ3vyGOLQ==", "=?us-ascii?Q?1; HE1PR0901MB1436;\n\t23:O5Y08cFDWsTg+ZPPf/aIo1ofG7m+HpcXAXgZWI0?=\n\th0uVnNN0EnMUMScslHo47yQqRRPLvQKZk51tnDF0rQln8uGW0lniv276v9rUjkFC9cOwNx9C33JsqDOIcm5me7YEx0rjtrYGiqzowJDdvMjv/DaphgTx9gb4k0MJdwuB7TVmTgwuRPzldCq+8qLglbmWFHSapoHdL9EtYjUGkPU1Ox9jNQp5wRwv84HTA76jCKzPH89x4aWzjLsKmhvy7fiRRZoq+RfZZVnbhACGBWh97HGOsyqL096DYSeZyOx4dII6/2p7K+Sq3f0BIEDVsCN1G0zR8cRHiIGdo07mQKOu7HpS8ILLI88e/Ss8Ilc3fgu7QD+JZPWfs9NPbwn6Dl/xQj8eavDmDvU69lAdHItjqyym0BOzcIhebjgRpLHymVTccVSnJ57gL5jU9Xg5O2+PTWe4rgW8wSOcz5Gu64T/fiaKJcyWTDJsy6WqPS480xFLlhyGK3SFifCdsBnSpCBj14J9GLLqyCXBz3G1/+1PPrg/cKGC8SxAAgIt10PzLCpRJ4SUc0eLHzB1ZR9Gk0PkxgRws+FIROIuhGvQ8Iwde+jNJgIqamOZHL5lHl+z1PfrVwD0wCJTzgvDtbC2B4yv5mazKPtW4e2n/wqlcQgEkFsR0bSd4gnt6qMKjOXzq2MQuyaZ3aCSmzQLS4ekMMoVXvDNPC1yuhb+H0TaT8z57qmTRkcrvOgd3rF+2h9ljqw/tPLqQRsg6bz45eN+F5NObBbnIL7uVAwQ4bPVQ1NwPEU+0nP3mjRuXwC1OrppVR+Udu5LXztQmEojmtiiF8F+8Ff6++i3wMsgX7hIcvWmQKj7pG2wBl9HCHR9vb3iEC8eskfGh6mUOaRrV+LkvqzK+ZwAdQ4KO4hD03H9OIb4EJfjIOAxGrF0yPxtwpk8Lmk8/dQWzriezkOskXVR+j6+fcIRGsLU1/pcMaSPFP9KfkU/7O9m7wsOs3atHMPB5QCejhpHvUqZV/qTHq05umqKBOg9GT7lozTG3BasKbTPQpsxQpQh8R7a/VQtVkxaD4jRt3zRQUqoMX7tyWJE4yjuoxCYwmXRsJbXLTHvXQgyfoj+EEajO48SsGJ8qm/+K1wGc+Bz2yT+y33Tg4eEkRsBffGpNdcW/apK3ksi+1xugTQCpGYO0LgklggLS/Vej7R+fqXZI1OunPifB3aDiP4CJv6WmSMEWAczzz12Fgf+J69RvgwFmDzxgnXnz5L5zvx81sUm3gvcvdywtJRu0Dqs3", "1; HE1PR0901MB1436;\n\t6:vxbeDk4Lpq3HnfImZjfCq5lcUjBQA8KWEek2L42YYE3sblvGxu717sBFOi1LSL9ejDCyH8rkIetqRYxodBykRoPhGcu7pTqbVkBCOEWGZMW026iUB33m5k1a/hqrO8a3RbMHkoXHj6WbRq5/gTyODDpk6JLkn2WaJW5kaarJbmcHrcItZG0y4gue1ZXpkCb7abzOanx7OVo0tr6tG9dHy5r8Z8V/NgtEHR1ESusD2+FSNccgb2of9F28davdxoWXQWhu9b9gETP7GsX4yvHQqoFU8UuyLc8E7SAe7pAgw3Pxch/B4dicql8KZAXN/4PkHWq5KRBmB8CJoFribHKoeZ2F4L6LDIIADVBUl32cxQKCOP9OfdKevMun1Mc9y574B+5pfJlqPgCAR6Ii9e8gHz6OETleeUgzolfI2axH/mycAj0bXOi2vTsDilTMOlC/3NU/GZGe+lBxDanDAYGZOg==;\n\t5:y/gs5XsMTSS9lOT6Db7IjlJ5zdTFfQhZFqtjVzGS7nzsBfLkeSxM9DPzSVWM1ptxI85wMIWe86UgYTHp7JPQfTnuQDYODDjTiChnVn+G5LTGdefDmk4INQurWscztF/E6srY7cDRhgaY5b8EAKH/BzRlbFDY9IYxsRV4iFuOOhU=;\n\t24:6WWxEG10qg72Jw4bRWe+IODdpMTeDchMIH5eyYbt5nlbmZyxC0ZEcJDfMBSYKX5cKkHNB/neBpGsHkZiZbBbd1sDz9eMLE+zhjeJWWXT24c=", "1; HE1PR0901MB1436;\n\t7:FgFZ3FRz4t/LkTw5+PgEXYCGo68JV2+TpJcrVXPx8PQ2AewZUk/NNICou2l7mm2c0xp0R39szJLpDqtUke2bJIFLSMF0DBrebCWHsuAvc8es7/nta8SaDril9yQymOYgjR1vp+nFx0RmVF1PGR1Fi3TlBrBosFAnQAtq8Ydd9fQVh0yWuxbbdbqGlgetUqlY4L9j9WBp/BgswHCfLbUCzwY8XfikG60nArF0r6P6vdfHKZb/XtSikY18eylzdxER" ], "X-MS-TrafficTypeDiagnostic": "HE1PR0901MB1436:", "X-Microsoft-Antispam-PRVS": "<HE1PR0901MB14363D7CF0DBA3C243874BBBD6730@HE1PR0901MB1436.eurprd09.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016);\n\tSRVR:HE1PR0901MB1436; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0901MB1436; ", "X-Forefront-PRVS": "0705EB1700", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10019020)(396003)(39830400003)(366004)(346002)(39380400002)(376002)(189003)(199004)(3846002)(6116002)(5660300001)(956004)(47776003)(476003)(2616005)(50226002)(16526019)(86152003)(16586007)(6916009)(186003)(6666003)(6486002)(7736002)(316002)(305945005)(68736007)(486006)(26005)(478600001)(52116002)(86362001)(36756003)(6512007)(51416003)(11346002)(106356001)(76176011)(105586002)(8936002)(72206003)(66066001)(25786009)(48376002)(386003)(50466002)(6506007)(53936002)(8676002)(107886003)(81166006)(97736004)(81156014)(4326008)(446003)(2906002)(80792005);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:HE1PR0901MB1436; H:ubuntu.localdomain;\n\tFPR:; \n\tSPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; ", "Received-SPF": "None (protection.outlook.com: cgstowernetworks.com does not\n\tdesignate permitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "JxRiN1F8jTvRhzjTzn5kMk3QgZgDy15brPjJ8RwLNc3vLwrlwKyOIubP7r0GLrTWF0cD6NG8Y97evvFpke8myGOdd1GO6CKisUplfz0kA3LICC5nVD9jZ1GRgxmsn4ANa/BqqoOSl9PI4/EVVUM0FGLXqZqjO4S6XSkH4P3X6aNLrugEszIFMPY/xMl4Uu1N", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "cgstowernetworks.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "16 Jun 2018 15:37:15.9983\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "2603e9e1-e3d2-45d5-63e6-08d5d39f0a3f", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fc9e9498-07e8-4b82-b4cf-365bba23cbbf", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "HE1PR0901MB1436", "X-Mailman-Approved-At": "Sat, 16 Jun 2018 22:22:15 +0200", "Subject": "[dpdk-dev] [PATCH 2/2] net/pcap: duplicate code consolidation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: ido goshen <ido@cgstowernetworks.com>\n---\n drivers/net/pcap/rte_eth_pcap.c | 58 ++++++++++++++++++++---------------------\n 1 file changed, 29 insertions(+), 29 deletions(-)", "diff": "diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c\nindex 444abbb..e63998b 100644\n--- a/drivers/net/pcap/rte_eth_pcap.c\n+++ b/drivers/net/pcap/rte_eth_pcap.c\n@@ -658,6 +658,20 @@ struct pmd_devargs {\n \t.stats_reset = eth_stats_reset,\n };\n \n+static int\n+add_queue(struct pmd_devargs *pmd, const char *name, const char *type,\n+\t\tpcap_t *pcap, pcap_dumper_t *dumper)\n+{\n+\tif (pcap)\n+\t\tpmd->queue[pmd->num_of_queue].pcap = pcap;\n+\tif (dumper)\n+\t\tpmd->queue[pmd->num_of_queue].dumper = dumper;\n+\tpmd->queue[pmd->num_of_queue].name = name;\n+\tpmd->queue[pmd->num_of_queue].type = type;\n+\tpmd->num_of_queue++;\n+\treturn 0;\n+}\n+\n /*\n * Function handler that opens the pcap file for reading a stores a\n * reference of it for use it later on.\n@@ -672,10 +686,7 @@ struct pmd_devargs {\n \tif (open_single_rx_pcap(pcap_filename, &pcap) < 0)\n \t\treturn -1;\n \n-\trx->queue[rx->num_of_queue].pcap = pcap;\n-\trx->queue[rx->num_of_queue].name = pcap_filename;\n-\trx->queue[rx->num_of_queue].type = key;\n-\trx->num_of_queue++;\n+\tadd_queue(rx, pcap_filename, key, pcap, NULL);\n \n \treturn 0;\n }\n@@ -694,10 +705,7 @@ struct pmd_devargs {\n \tif (open_single_tx_pcap(pcap_filename, &dumper) < 0)\n \t\treturn -1;\n \n-\tdumpers->queue[dumpers->num_of_queue].dumper = dumper;\n-\tdumpers->queue[dumpers->num_of_queue].name = pcap_filename;\n-\tdumpers->queue[dumpers->num_of_queue].type = key;\n-\tdumpers->num_of_queue++;\n+\tadd_queue(dumpers, pcap_filename, key, NULL, dumper);\n \n \treturn 0;\n }\n@@ -722,44 +730,36 @@ struct pmd_devargs {\n \treturn 0;\n }\n \n-/*\n- * Opens a NIC for reading packets from it\n- */\n static inline int\n-open_rx_iface(const char *key, const char *value, void *extra_args)\n+open_iface(const char *key, const char *value, void *extra_args)\n {\n \tconst char *iface = value;\n-\tstruct pmd_devargs *rx = extra_args;\n+\tstruct pmd_devargs *pmd = extra_args;\n \tpcap_t *pcap = NULL;\n \n \tif (open_single_iface(iface, &pcap) < 0)\n \t\treturn -1;\n-\trx->queue[rx->num_of_queue].pcap = pcap;\n-\trx->queue[rx->num_of_queue].name = iface;\n-\trx->queue[rx->num_of_queue].type = key;\n-\trx->num_of_queue++;\n+\tadd_queue(pmd, iface, key, pcap, NULL);\n \n \treturn 0;\n }\n \n /*\n+ * Opens a NIC for reading packets from it\n+ */\n+static inline int\n+open_rx_iface(const char *key, const char *value, void *extra_args)\n+{\n+\treturn open_iface(key, value, extra_args);\n+}\n+\n+/*\n * Opens a NIC for writing packets to it\n */\n static int\n open_tx_iface(const char *key, const char *value, void *extra_args)\n {\n-\tconst char *iface = value;\n-\tstruct pmd_devargs *tx = extra_args;\n-\tpcap_t *pcap;\n-\n-\tif (open_single_iface(iface, &pcap) < 0)\n-\t\treturn -1;\n-\ttx->queue[tx->num_of_queue].pcap = pcap;\n-\ttx->queue[tx->num_of_queue].name = iface;\n-\ttx->queue[tx->num_of_queue].type = key;\n-\ttx->num_of_queue++;\n-\n-\treturn 0;\n+\treturn open_iface(key, value, extra_args);\n }\n \n static struct rte_vdev_driver pmd_pcap_drv;\n", "prefixes": [ "2/2" ] }