Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41194/?format=api
{ "id": 41194, "url": "https://patches.dpdk.org/api/patches/41194/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180615151304.32032-1-darek.stojaczyk@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180615151304.32032-1-darek.stojaczyk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180615151304.32032-1-darek.stojaczyk@gmail.com", "date": "2018-06-15T15:13:04", "name": "[v2] memory: make eal_get_virtual_area() aware of base-virtaddr alignment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fa0ba238f6923becd15e93d324231277949f81c9", "submitter": { "id": 1051, "url": "https://patches.dpdk.org/api/people/1051/?format=api", "name": "Dariusz Stojaczyk", "email": "darek.stojaczyk@gmail.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180615151304.32032-1-darek.stojaczyk@gmail.com/mbox/", "series": [ { "id": 146, "url": "https://patches.dpdk.org/api/series/146/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=146", "date": "2018-06-15T15:13:04", "name": "[v2] memory: make eal_get_virtual_area() aware of base-virtaddr alignment", "version": 2, "mbox": "https://patches.dpdk.org/series/146/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41194/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/41194/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A48BF1B526;\n\tFri, 15 Jun 2018 17:13:16 +0200 (CEST)", "from mail-lf0-f68.google.com (mail-lf0-f68.google.com\n\t[209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 37ABC1B525;\n\tFri, 15 Jun 2018 17:13:16 +0200 (CEST)", "by mail-lf0-f68.google.com with SMTP id v135-v6so15140386lfa.9;\n\tFri, 15 Jun 2018 08:13:16 -0700 (PDT)", "from localhost.localdomain (89-68-115-185.dynamic.chello.pl.\n\t[89.68.115.185]) by smtp.gmail.com with ESMTPSA id\n\tf8-v6sm1533138lfc.29.2018.06.15.08.13.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Jun 2018 08:13:14 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=M+H83Tcb0f52QKFM/18/wmEVs02A1FQtz36SYLO1LAw=;\n\tb=j5J3DEhoUtuFrvTHgKSkG9NPPgmyr3xWc6AfuGd1Pgb+SoYAgpJZqePbua2WMAINc7\n\t0MQjwItkMriGWdpwHRFc0vDcknidrEI5FZKKGAubrVN+Ex1dp9gnNgVneKw5lSt4dkLI\n\tcIQ6g+MuzoKns3FaCPzAuZr3TIEmtSSXmW+exdP/hy5oXzS6BuZ6cThsykWXIS7gDw0z\n\tc0BZc7RYAcQAXyH0NsOHgbtAd3r54LDwGcTfaek5yQJVI+YYKlYJIBTTfBUitCqDIFck\n\tMvTQsMV13dBUPEkD3NJmZhEJihF0dhXqTovrZ1EoC0f+U116Pf+cgyGqOC4YD754CaHe\n\tR+Rg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=M+H83Tcb0f52QKFM/18/wmEVs02A1FQtz36SYLO1LAw=;\n\tb=Slu2JJROMcejcubSPfhuOMEwdmvXR9o0xOZUbIaHyEireFKyZYlGiK9kB1V5K78Nt+\n\t5rfORgulmj/f3NQc1wTGfK/ikQf3Xr0H72SGFt8Q7uptBJx00hd7Rm1FFH8QMNrSgQrM\n\tyE/3HWHk02XAwSPE5ft7kTplDl+zkdUOrT1lFgdI2UIMZFyPiqELtxu0YGV38CDEflcl\n\tjAmoBuwYQBaJDlqS1aHx+FhxXmFa2dXFi/S/qGi3eVHhT/odADnvCg7aUceBheZehpaE\n\tfu/1E/9olg72ubBuKbMB3A8eV3bIMT55k0ZdKnCHzT4pkW0vBW2mkcuC0FZyg4t56aal\n\tSeSw==", "X-Gm-Message-State": "APt69E3qKfyEMrJqB74hisxrDcWJ2V+yybPHUXEqXu3QdAKigVveulHH\n\t8J4JQdOWZYKedZ8kzIzGdPkKcVbW", "X-Google-Smtp-Source": "ADUXVKKqRvHGud+dyIwYpoUd/swJN981UQLB9VkBBN7t59yhXctXZ4iV6m2p0iMW0E7qcvOjU6LDjg==", "X-Received": "by 2002:a2e:529c:: with SMTP id\n\tn28-v6mr1701677lje.62.1529075595516; \n\tFri, 15 Jun 2018 08:13:15 -0700 (PDT)", "From": "Dariusz Stojaczyk <darek.stojaczyk@gmail.com>", "To": "dev@dpdk.org,\n\tAnatoly Burakov <anatoly.burakov@intel.com>", "Cc": "Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 15 Jun 2018 17:13:04 +0200", "Message-Id": "<20180615151304.32032-1-darek.stojaczyk@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20180615122448.28118-1-darek.stojaczyk@gmail.com>", "References": "<20180615122448.28118-1-darek.stojaczyk@gmail.com>", "Subject": "[dpdk-dev] [PATCH v2] memory: make eal_get_virtual_area() aware of\n\tbase-virtaddr alignment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>\n\nWhenever a calculated base-virtaddr offset had to be\nmanually aligned to requested page_sz, we did not take\naccount of that alignment in incrementing the base-virtaddr\noffset further. The next requested virtual area could print\na warning \"hint [...] not respected!\" and let the system\npick an address instead. As a result, this breaks secondary\nprocess support on many system configurations.\n\nFixes: b7cc54187ea4 (\"mem: move virtual area function in common directory\")\nCc: anatoly.burakov@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>\nAcked-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\nChanges from v1:\n * do not increment next_baseaddr if its currently NULL.\n Otherwise this patch breaks applications without base-virtaddr specified\n * switched to explicit `!= NULL` comparisons\n\n lib/librte_eal/common/eal_common_memory.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c\nindex 4f0688f9d..2413ce1e7 100644\n--- a/lib/librte_eal/common/eal_common_memory.c\n+++ b/lib/librte_eal/common/eal_common_memory.c\n@@ -34,7 +34,7 @@\n \n #define MEMSEG_LIST_FMT \"memseg-%\" PRIu64 \"k-%i-%i\"\n \n-static uint64_t baseaddr_offset;\n+static void *next_baseaddr;\n static uint64_t system_page_sz;\n \n void *\n@@ -56,9 +56,11 @@ eal_get_virtual_area(void *requested_addr, size_t *size,\n \tallow_shrink = (flags & EAL_VIRTUAL_AREA_ALLOW_SHRINK) > 0;\n \tunmap = (flags & EAL_VIRTUAL_AREA_UNMAP) > 0;\n \n-\tif (requested_addr == NULL && internal_config.base_virtaddr != 0) {\n-\t\trequested_addr = (void *) (internal_config.base_virtaddr +\n-\t\t\t\t(size_t)baseaddr_offset);\n+\tif (next_baseaddr == NULL && internal_config.base_virtaddr != 0)\n+\t\tnext_baseaddr = (void *) internal_config.base_virtaddr;\n+\n+\tif (requested_addr == NULL && next_baseaddr != NULL) {\n+\t\trequested_addr = next_baseaddr;\n \t\trequested_addr = RTE_PTR_ALIGN(requested_addr, page_sz);\n \t\taddr_is_hint = true;\n \t}\n@@ -116,6 +118,8 @@ eal_get_virtual_area(void *requested_addr, size_t *size,\n \t\tRTE_LOG(WARNING, EAL, \"WARNING! Base virtual address hint (%p != %p) not respected!\\n\",\n \t\t\trequested_addr, aligned_addr);\n \t\tRTE_LOG(WARNING, EAL, \" This may cause issues with mapping memory into secondary processes\\n\");\n+\t} else if (next_baseaddr != NULL) {\n+\t\tnext_baseaddr = RTE_PTR_ADD(aligned_addr, *size);\n \t}\n \n \tRTE_LOG(DEBUG, EAL, \"Virtual area found at %p (size = 0x%zx)\\n\",\n@@ -148,8 +152,6 @@ eal_get_virtual_area(void *requested_addr, size_t *size,\n \t\t\tmunmap(aligned_end, after_len);\n \t}\n \n-\tbaseaddr_offset += *size;\n-\n \treturn aligned_addr;\n }\n \n", "prefixes": [ "v2" ] }