Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41182/?format=api
{ "id": 41182, "url": "https://patches.dpdk.org/api/patches/41182/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1529059456-25450-1-git-send-email-jananeex.m.parthasarathy@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1529059456-25450-1-git-send-email-jananeex.m.parthasarathy@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1529059456-25450-1-git-send-email-jananeex.m.parthasarathy@intel.com", "date": "2018-06-15T10:44:16", "name": "crypto/null: add dynamic logging to null driver", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e2a30df16ffe3daf862a0ec611cd66552571139c", "submitter": { "id": 1024, "url": "https://patches.dpdk.org/api/people/1024/?format=api", "name": "Jananee Parthasarathy", "email": "jananeex.m.parthasarathy@intel.com" }, "delegate": { "id": 22, "url": "https://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1529059456-25450-1-git-send-email-jananeex.m.parthasarathy@intel.com/mbox/", "series": [ { "id": 142, "url": "https://patches.dpdk.org/api/series/142/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=142", "date": "2018-06-15T10:44:16", "name": "crypto/null: add dynamic logging to null driver", "version": 1, "mbox": "https://patches.dpdk.org/series/142/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41182/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/41182/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DE0611D3E2;\n\tFri, 15 Jun 2018 12:44:41 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id A69301D3A0\n\tfor <dev@dpdk.org>; Fri, 15 Jun 2018 12:44:39 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 Jun 2018 03:44:38 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga006.jf.intel.com with ESMTP; 15 Jun 2018 03:44:37 -0700", "from wgcvswdev001.ir.intel.com (wgcvswdev001.ir.intel.com\n\t[10.102.246.100])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw5FAiaXo026024; Fri, 15 Jun 2018 11:44:36 +0100", "from wgcvswdev001.ir.intel.com (localhost [127.0.0.1])\n\tby wgcvswdev001.ir.intel.com with ESMTP id w5FAiaTX025516;\n\tFri, 15 Jun 2018 11:44:36 +0100", "(from jmparthx@localhost)\n\tby wgcvswdev001.ir.intel.com with ? id w5FAiap5025512;\n\tFri, 15 Jun 2018 11:44:36 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,226,1526367600\"; d=\"scan'208\";a=\"50136199\"", "From": "Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>", "To": "dev@dpdk.org", "Cc": "pablo.de.lara.guarch@intel.com, reshma.pattan@intel.com,\n\tJananee Parthasarathy <jananeex.m.parthasarathy@intel.com>,\n\tPallantla Poornima <pallantlax.poornima@intel.com>", "Date": "Fri, 15 Jun 2018 11:44:16 +0100", "Message-Id": "<1529059456-25450-1-git-send-email-jananeex.m.parthasarathy@intel.com>", "X-Mailer": "git-send-email 1.7.12.2", "Subject": "[dpdk-dev] [PATCH] crypto/null: add dynamic logging to null driver", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "1.added new logtype for null driver.\n2.registered new logtype.\n3.NULL_CRYPTO_LOG_ERR, RTE_LOG_ERR and CDEV_LOG_ERR\nare replaced with new logtype name NULL_PMD_LOG.\n\nSigned-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>\nReviewed-by: Reshma Pattan <reshma.pattan@intel.com>\n---\n drivers/crypto/null/null_crypto_pmd.c | 15 ++++++++++----\n drivers/crypto/null/null_crypto_pmd_ops.c | 29 ++++++++++++++-------------\n drivers/crypto/null/null_crypto_pmd_private.h | 23 +++++----------------\n 3 files changed, 31 insertions(+), 36 deletions(-)", "diff": "diff --git a/drivers/crypto/null/null_crypto_pmd.c b/drivers/crypto/null/null_crypto_pmd.c\nindex 052b6546c..4e1c4575c 100644\n--- a/drivers/crypto/null/null_crypto_pmd.c\n+++ b/drivers/crypto/null/null_crypto_pmd.c\n@@ -161,10 +161,9 @@ cryptodev_null_create(const char *name,\n {\n \tstruct rte_cryptodev *dev;\n \tstruct null_crypto_private *internals;\n-\n \tdev = rte_cryptodev_pmd_create(name, &vdev->device, init_params);\n \tif (dev == NULL) {\n-\t\tNULL_CRYPTO_LOG_ERR(\"failed to create cryptodev vdev\");\n+\t\tNULL_PMD_LOG(ERR, \"failed to create cryptodev vdev\");\n \t\treturn -EFAULT;\n \t}\n \n@@ -209,8 +208,9 @@ cryptodev_null_probe(struct rte_vdev_device *dev)\n \n \tretval = rte_cryptodev_pmd_parse_input_args(&init_params, args);\n \tif (retval) {\n-\t\tRTE_LOG(ERR, PMD,\n-\t\t\t\"Failed to parse initialisation arguments[%s]\\n\", args);\n+\t\tNULL_PMD_LOG(ERR,\n+\t\t\t\t\"Failed to parse initialisation arguments[%s]\",\n+\t\t\t\targs);\n \t\treturn -EINVAL;\n \t}\n \n@@ -249,3 +249,10 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_NULL_PMD,\n \t\"socket_id=<int>\");\n RTE_PMD_REGISTER_CRYPTO_DRIVER(null_crypto_drv, cryptodev_null_pmd_drv.driver,\n \t\tcryptodev_driver_id);\n+\n+RTE_INIT(null_init_log);\n+static void\n+null_init_log(void)\n+{\n+\tnull_logtype_driver = rte_log_register(\"pmd.crypto.null\");\n+}\ndiff --git a/drivers/crypto/null/null_crypto_pmd_ops.c b/drivers/crypto/null/null_crypto_pmd_ops.c\nindex f8e5f61f1..02202f07c 100644\n--- a/drivers/crypto/null/null_crypto_pmd_ops.c\n+++ b/drivers/crypto/null/null_crypto_pmd_ops.c\n@@ -163,15 +163,15 @@ null_crypto_pmd_qp_create_processed_pkts_ring(struct null_crypto_qp *qp,\n \tr = rte_ring_lookup(qp->name);\n \tif (r) {\n \t\tif (rte_ring_get_size(r) >= ring_size) {\n-\t\t\tNULL_CRYPTO_LOG_INFO(\n-\t\t\t\t\"Reusing existing ring %s for processed packets\",\n-\t\t\t\tqp->name);\n+\t\t\tNULL_PMD_LOG(INFO,\n+\t\t\t\t\t\"Reusing existing ring %s for \"\n+\t\t\t\t\t\" processed packets\", qp->name);\n \t\t\treturn r;\n \t\t}\n \n-\t\tNULL_CRYPTO_LOG_INFO(\n-\t\t\t\"Unable to reuse existing ring %s for processed packets\",\n-\t\t\t qp->name);\n+\t\tNULL_PMD_LOG(INFO,\n+\t\t\t\t\"Unable to reuse existing ring %s for \"\n+\t\t\t\t\" processed packets\", qp->name);\n \t\treturn NULL;\n \t}\n \n@@ -190,7 +190,7 @@ null_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \tint retval;\n \n \tif (qp_id >= internals->max_nb_qpairs) {\n-\t\tNULL_CRYPTO_LOG_ERR(\"Invalid qp_id %u, greater than maximum \"\n+\t\tNULL_PMD_LOG(ERR, \"Invalid qp_id %u, greater than maximum \"\n \t\t\t\t\"number of queue pairs supported (%u).\",\n \t\t\t\tqp_id, internals->max_nb_qpairs);\n \t\treturn (-EINVAL);\n@@ -204,7 +204,7 @@ null_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \tqp = rte_zmalloc_socket(\"Null Crypto PMD Queue Pair\", sizeof(*qp),\n \t\t\t\t\tRTE_CACHE_LINE_SIZE, socket_id);\n \tif (qp == NULL) {\n-\t\tNULL_CRYPTO_LOG_ERR(\"Failed to allocate queue pair memory\");\n+\t\tNULL_PMD_LOG(ERR, \"Failed to allocate queue pair memory\");\n \t\treturn (-ENOMEM);\n \t}\n \n@@ -213,15 +213,16 @@ null_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \n \tretval = null_crypto_pmd_qp_set_unique_name(dev, qp);\n \tif (retval) {\n-\t\tNULL_CRYPTO_LOG_ERR(\"Failed to create unique name for null \"\n+\t\tNULL_PMD_LOG(ERR, \"Failed to create unique name for null \"\n \t\t\t\t\"crypto device\");\n+\n \t\tgoto qp_setup_cleanup;\n \t}\n \n \tqp->processed_pkts = null_crypto_pmd_qp_create_processed_pkts_ring(qp,\n \t\t\tqp_conf->nb_descriptors, socket_id);\n \tif (qp->processed_pkts == NULL) {\n-\t\tNULL_CRYPTO_LOG_ERR(\"Failed to create unique name for null \"\n+\t\tNULL_PMD_LOG(ERR, \"Failed to create unique name for null \"\n \t\t\t\t\"crypto device\");\n \t\tgoto qp_setup_cleanup;\n \t}\n@@ -280,19 +281,19 @@ null_crypto_pmd_session_configure(struct rte_cryptodev *dev __rte_unused,\n \tint ret;\n \n \tif (unlikely(sess == NULL)) {\n-\t\tNULL_CRYPTO_LOG_ERR(\"invalid session struct\");\n+\t\tNULL_PMD_LOG(ERR, \"invalid session struct\");\n \t\treturn -EINVAL;\n \t}\n \n \tif (rte_mempool_get(mp, &sess_private_data)) {\n-\t\tCDEV_LOG_ERR(\n-\t\t\t\"Couldn't get object from session mempool\");\n+\t\tNULL_PMD_LOG(ERR,\n+\t\t\t\t\"Couldn't get object from session mempool\");\n \t\treturn -ENOMEM;\n \t}\n \n \tret = null_crypto_set_session_parameters(sess_private_data, xform);\n \tif (ret != 0) {\n-\t\tNULL_CRYPTO_LOG_ERR(\"failed configure session parameters\");\n+\t\tNULL_PMD_LOG(ERR, \"failed configure session parameters\");\n \n \t\t/* Return session to mempool */\n \t\trte_mempool_put(mp, sess_private_data);\ndiff --git a/drivers/crypto/null/null_crypto_pmd_private.h b/drivers/crypto/null/null_crypto_pmd_private.h\nindex 0fd133625..31bd8c2a5 100644\n--- a/drivers/crypto/null/null_crypto_pmd_private.h\n+++ b/drivers/crypto/null/null_crypto_pmd_private.h\n@@ -8,25 +8,12 @@\n #define CRYPTODEV_NAME_NULL_PMD\t\tcrypto_null\n /**< Null crypto PMD device name */\n \n-#define NULL_CRYPTO_LOG_ERR(fmt, args...) \\\n-\tRTE_LOG(ERR, CRYPTODEV, \"[%s] %s() line %u: \" fmt \"\\n\", \\\n-\t\t\tRTE_STR(CRYPTODEV_NAME_NULL_PMD), \\\n-\t\t\t__func__, __LINE__, ## args)\n+int null_logtype_driver;\n \n-#ifdef RTE_LIBRTE_NULL_CRYPTO_DEBUG\n-#define NULL_CRYPTO_LOG_INFO(fmt, args...) \\\n-\tRTE_LOG(INFO, CRYPTODEV, \"[%s] %s() line %u: \" fmt \"\\n\", \\\n-\t\t\tRTE_STR(CRYPTODEV_NAME_NULL_PMD), \\\n-\t\t\t__func__, __LINE__, ## args)\n-\n-#define NULL_CRYPTO_LOG_DBG(fmt, args...) \\\n-\tRTE_LOG(DEBUG, CRYPTODEV, \"[%s] %s() line %u: \" fmt \"\\n\", \\\n-\t\t\tRTE_STR(CRYPTODEV_NAME_NULL_PMD), \\\n-\t\t\t__func__, __LINE__, ## args)\n-#else\n-#define NULL_CRYPTO_LOG_INFO(fmt, args...)\n-#define NULL_CRYPTO_LOG_DBG(fmt, args...)\n-#endif\n+#define NULL_PMD_LOG(level, fmt, ...) \\\n+\trte_log(RTE_LOG_ ## level, null_logtype_driver, \\\n+\t\t\t\"%s() line %u: \"fmt \"\\n\", __func__, __LINE__, \\\n+\t\t\t\t\t## __VA_ARGS__)\n \n \n /** private data structure for each NULL crypto device */\n", "prefixes": [] }