Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41114/?format=api
{ "id": 41114, "url": "https://patches.dpdk.org/api/patches/41114/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1528974186-13370-3-git-send-email-tomaszx.jozwiak@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1528974186-13370-3-git-send-email-tomaszx.jozwiak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1528974186-13370-3-git-send-email-tomaszx.jozwiak@intel.com", "date": "2018-06-14T11:03:03", "name": "[v2,2/5] crypto/qat: move to dynamic logging for non-dp trace", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d3ccbf86c6bbd7d993277f28025dc4d10b77acc2", "submitter": { "id": 949, "url": "https://patches.dpdk.org/api/people/949/?format=api", "name": "Tomasz Jozwiak", "email": "tomaszx.jozwiak@intel.com" }, "delegate": { "id": 22, "url": "https://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1528974186-13370-3-git-send-email-tomaszx.jozwiak@intel.com/mbox/", "series": [ { "id": 123, "url": "https://patches.dpdk.org/api/series/123/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=123", "date": "2018-06-14T11:03:01", "name": "crypto/qat: move to dynamic logging", "version": 2, "mbox": "https://patches.dpdk.org/series/123/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41114/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/41114/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1CBE31E3BC;\n\tThu, 14 Jun 2018 13:03:21 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 344C91E34B\n\tfor <dev@dpdk.org>; Thu, 14 Jun 2018 13:03:17 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Jun 2018 04:03:16 -0700", "from tjozwiax-mobl.ger.corp.intel.com (HELO\n\ttojo-VirtualBox.MobicaPL.local) ([10.103.104.42])\n\tby orsmga002.jf.intel.com with ESMTP; 14 Jun 2018 04:03:15 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,222,1526367600\"; d=\"scan'208\";a=\"66939747\"", "From": "Tomasz Jozwiak <tomaszx.jozwiak@intel.com>", "To": "fiona.trahe@intel.com,\n\ttomaszx.jozwiak@intel.com,\n\tdev@dpdk.org", "Date": "Thu, 14 Jun 2018 13:03:03 +0200", "Message-Id": "<1528974186-13370-3-git-send-email-tomaszx.jozwiak@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1528974186-13370-1-git-send-email-tomaszx.jozwiak@intel.com>", "References": "<1526038308-12043-1-git-send-email-fiona.trahe@intel.com>\n\t<1528974186-13370-1-git-send-email-tomaszx.jozwiak@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 2/5] crypto/qat: move to dynamic logging for\n\tnon-dp trace", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For all trace not on the data-path move to dynamic logging.\n\nSigned-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>\nSigned-off-by: Fiona Trahe <fiona.trahe@intel.com>\n---\n config/common_base | 1 -\n drivers/crypto/qat/Makefile | 1 +\n drivers/crypto/qat/meson.build | 1 +\n drivers/crypto/qat/qat_logs.c | 17 +++++++++++++++++\n drivers/crypto/qat/qat_logs.h | 12 ++++--------\n 5 files changed, 23 insertions(+), 9 deletions(-)\n create mode 100644 drivers/crypto/qat/qat_logs.c", "diff": "diff --git a/config/common_base b/config/common_base\nindex 0e6f2fb..7a9b26e 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -488,7 +488,6 @@ CONFIG_RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS=2048\n CONFIG_RTE_LIBRTE_PMD_QAT=n\n CONFIG_RTE_LIBRTE_PMD_QAT_DEBUG_TX=n\n CONFIG_RTE_LIBRTE_PMD_QAT_DEBUG_RX=n\n-CONFIG_RTE_LIBRTE_PMD_QAT_DEBUG_DRIVER=n\n #\n # Max. number of QuickAssist devices, which can be detected and attached\n #\ndiff --git a/drivers/crypto/qat/Makefile b/drivers/crypto/qat/Makefile\nindex d467683..ef4a567 100644\n--- a/drivers/crypto/qat/Makefile\n+++ b/drivers/crypto/qat/Makefile\n@@ -26,6 +26,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_device.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_qp.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_sym_session.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_common.c\n+SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_logs.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_sym_pmd.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_asym_pmd.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_comp_pmd.c\ndiff --git a/drivers/crypto/qat/meson.build b/drivers/crypto/qat/meson.build\nindex e22e08f..bcab16e 100644\n--- a/drivers/crypto/qat/meson.build\n+++ b/drivers/crypto/qat/meson.build\n@@ -8,6 +8,7 @@ endif\n sources = files('qat_common.c',\n \t\t'qat_qp.c',\n \t\t'qat_device.c',\n+\t\t'qat_logs.c',\n \t\t'qat_sym_pmd.c', 'qat_sym.c', 'qat_sym_session.c',\n \t\t'qat_asym_pmd.c',\n \t\t'qat_comp_pmd.c')\ndiff --git a/drivers/crypto/qat/qat_logs.c b/drivers/crypto/qat/qat_logs.c\nnew file mode 100644\nindex 0000000..fc8d9a7\n--- /dev/null\n+++ b/drivers/crypto/qat/qat_logs.c\n@@ -0,0 +1,17 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018 Intel Corporation\n+ */\n+\n+#include <rte_log.h>\n+\n+int qat_gen_logtype;\n+\n+RTE_INIT(qat_pci_init_log);\n+static void\n+qat_pci_init_log(void)\n+{\n+\t/* Non-data-path logging for pci device and all services */\n+\tqat_gen_logtype = rte_log_register(\"pmd.qat_general\");\n+\tif (qat_gen_logtype >= 0)\n+\t\trte_log_set_level(qat_gen_logtype, RTE_LOG_NOTICE);\n+}\ndiff --git a/drivers/crypto/qat/qat_logs.h b/drivers/crypto/qat/qat_logs.h\nindex e6f8a01..b00a06b 100644\n--- a/drivers/crypto/qat/qat_logs.h\n+++ b/drivers/crypto/qat/qat_logs.h\n@@ -5,14 +5,10 @@\n #ifndef _QAT_LOGS_H_\n #define _QAT_LOGS_H_\n \n-#ifdef RTE_LIBRTE_PMD_QAT_DEBUG_DRIVER\n-#define PMD_DRV_LOG_RAW(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"%s(): \" fmt, __func__, ## args)\n-#else\n-#define PMD_DRV_LOG_RAW(level, fmt, args...) do { } while (0)\n-#endif\n+extern int qat_gen_logtype;\n \n-#define PMD_DRV_LOG(level, fmt, args...) \\\n-\tPMD_DRV_LOG_RAW(level, fmt \"\\n\", ## args)\n+#define PMD_DRV_LOG(level, fmt, args...)\t\t\t\\\n+\trte_log(RTE_LOG_ ## level, qat_gen_logtype,\t\t\\\n+\t\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n \n #endif /* _QAT_LOGS_H_ */\n", "prefixes": [ "v2", "2/5" ] }