Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41113/?format=api
{ "id": 41113, "url": "https://patches.dpdk.org/api/patches/41113/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1528974186-13370-2-git-send-email-tomaszx.jozwiak@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1528974186-13370-2-git-send-email-tomaszx.jozwiak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1528974186-13370-2-git-send-email-tomaszx.jozwiak@intel.com", "date": "2018-06-14T11:03:02", "name": "[v2,1/5] crypto/qat: cleanup unused and useless trace", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "60d59a11c2e0dcda760fa5ab22a754abaa15e142", "submitter": { "id": 949, "url": "https://patches.dpdk.org/api/people/949/?format=api", "name": "Tomasz Jozwiak", "email": "tomaszx.jozwiak@intel.com" }, "delegate": { "id": 22, "url": "https://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1528974186-13370-2-git-send-email-tomaszx.jozwiak@intel.com/mbox/", "series": [ { "id": 123, "url": "https://patches.dpdk.org/api/series/123/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=123", "date": "2018-06-14T11:03:01", "name": "crypto/qat: move to dynamic logging", "version": 2, "mbox": "https://patches.dpdk.org/series/123/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41113/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/41113/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 051421E367;\n\tThu, 14 Jun 2018 13:03:19 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id F04EE1E2CF\n\tfor <dev@dpdk.org>; Thu, 14 Jun 2018 13:03:15 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Jun 2018 04:03:15 -0700", "from tjozwiax-mobl.ger.corp.intel.com (HELO\n\ttojo-VirtualBox.MobicaPL.local) ([10.103.104.42])\n\tby orsmga002.jf.intel.com with ESMTP; 14 Jun 2018 04:03:14 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,222,1526367600\"; d=\"scan'208\";a=\"66939740\"", "From": "Tomasz Jozwiak <tomaszx.jozwiak@intel.com>", "To": "fiona.trahe@intel.com,\n\ttomaszx.jozwiak@intel.com,\n\tdev@dpdk.org", "Date": "Thu, 14 Jun 2018 13:03:02 +0200", "Message-Id": "<1528974186-13370-2-git-send-email-tomaszx.jozwiak@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1528974186-13370-1-git-send-email-tomaszx.jozwiak@intel.com>", "References": "<1526038308-12043-1-git-send-email-fiona.trahe@intel.com>\n\t<1528974186-13370-1-git-send-email-tomaszx.jozwiak@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/5] crypto/qat: cleanup unused and useless\n\ttrace", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Removed INIT_FUNC trace and other unused macros.\n\nSigned-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>\nSigned-off-by: Fiona Trahe <fiona.trahe@intel.com>\n---\n config/common_base | 1 -\n drivers/crypto/qat/qat_logs.h | 31 -------------------------------\n drivers/crypto/qat/qat_qp.c | 11 +----------\n drivers/crypto/qat/qat_sym_pmd.c | 7 +------\n drivers/crypto/qat/qat_sym_session.c | 9 ---------\n 5 files changed, 2 insertions(+), 57 deletions(-)", "diff": "diff --git a/config/common_base b/config/common_base\nindex f03f9c3..0e6f2fb 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -486,7 +486,6 @@ CONFIG_RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS=2048\n # Compile PMD for QuickAssist based devices\n #\n CONFIG_RTE_LIBRTE_PMD_QAT=n\n-CONFIG_RTE_LIBRTE_PMD_QAT_DEBUG_INIT=n\n CONFIG_RTE_LIBRTE_PMD_QAT_DEBUG_TX=n\n CONFIG_RTE_LIBRTE_PMD_QAT_DEBUG_RX=n\n CONFIG_RTE_LIBRTE_PMD_QAT_DEBUG_DRIVER=n\ndiff --git a/drivers/crypto/qat/qat_logs.h b/drivers/crypto/qat/qat_logs.h\nindex c9144bf..e6f8a01 100644\n--- a/drivers/crypto/qat/qat_logs.h\n+++ b/drivers/crypto/qat/qat_logs.h\n@@ -5,37 +5,6 @@\n #ifndef _QAT_LOGS_H_\n #define _QAT_LOGS_H_\n \n-#define PMD_INIT_LOG(level, fmt, args...) \\\n-\trte_log(RTE_LOG_ ## level, RTE_LOGTYPE_PMD, \\\n-\t\t\"PMD: %s(): \" fmt \"\\n\", __func__, ##args)\n-\n-#ifdef RTE_LIBRTE_PMD_QAT_DEBUG_INIT\n-#define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, \" >>\")\n-#else\n-#define PMD_INIT_FUNC_TRACE() do { } while (0)\n-#endif\n-\n-#ifdef RTE_LIBRTE_PMD_QAT_DEBUG_RX\n-#define PMD_RX_LOG(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n-#else\n-#define PMD_RX_LOG(level, fmt, args...) do { } while (0)\n-#endif\n-\n-#ifdef RTE_LIBRTE_PMD_QAT_DEBUG_TX\n-#define PMD_TX_LOG(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n-#else\n-#define PMD_TX_LOG(level, fmt, args...) do { } while (0)\n-#endif\n-\n-#ifdef RTE_LIBRTE_PMD_QAT_DEBUG_TX_FREE\n-#define PMD_TX_FREE_LOG(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n-#else\n-#define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)\n-#endif\n-\n #ifdef RTE_LIBRTE_PMD_QAT_DEBUG_DRIVER\n #define PMD_DRV_LOG_RAW(level, fmt, args...) \\\n \tRTE_LOG(level, PMD, \"%s(): \" fmt, __func__, ## args)\ndiff --git a/drivers/crypto/qat/qat_qp.c b/drivers/crypto/qat/qat_qp.c\nindex f9d3762..531752b 100644\n--- a/drivers/crypto/qat/qat_qp.c\n+++ b/drivers/crypto/qat/qat_qp.c\n@@ -120,7 +120,6 @@ queue_dma_zone_reserve(const char *queue_name, uint32_t queue_size,\n {\n \tconst struct rte_memzone *mz;\n \n-\tPMD_INIT_FUNC_TRACE();\n \tmz = rte_memzone_lookup(queue_name);\n \tif (mz != 0) {\n \t\tif (((size_t)queue_size <= mz->len) &&\n@@ -194,7 +193,7 @@ int qat_qp_setup(struct qat_pci_device *qat_dev,\n \n \tif (qat_queue_create(qat_dev, &(qp->tx_q), qat_qp_conf,\n \t\t\t\t\tADF_RING_DIR_TX) != 0) {\n-\t\tPMD_INIT_LOG(ERR, \"Tx queue create failed \"\n+\t\tPMD_DRV_LOG(ERR, \"Tx queue create failed \"\n \t\t\t\t\"queue_pair_id=%u\", queue_pair_id);\n \t\tgoto create_err;\n \t}\n@@ -261,7 +260,6 @@ int qat_qp_release(struct qat_qp **qp_addr)\n \tstruct qat_qp *qp = *qp_addr;\n \tuint32_t i;\n \n-\tPMD_INIT_FUNC_TRACE();\n \tif (qp == NULL) {\n \t\tPMD_DRV_LOG(DEBUG, \"qp already freed\");\n \t\treturn 0;\n@@ -418,7 +416,6 @@ qat_queue_create(struct qat_pci_device *qat_dev, struct qat_queue *queue,\n static int qat_qp_check_queue_alignment(uint64_t phys_addr,\n \t\t\t\t\tuint32_t queue_size_bytes)\n {\n-\tPMD_INIT_FUNC_TRACE();\n \tif (((queue_size_bytes - 1) & phys_addr) != 0)\n \t\treturn -EINVAL;\n \treturn 0;\n@@ -429,7 +426,6 @@ static int adf_verify_queue_size(uint32_t msg_size, uint32_t msg_num,\n {\n \tuint8_t i = ADF_MIN_RING_SIZE;\n \n-\tPMD_INIT_FUNC_TRACE();\n \tfor (; i <= ADF_MAX_RING_SIZE; i++)\n \t\tif ((msg_size * msg_num) ==\n \t\t\t\t(uint32_t)ADF_SIZE_TO_RING_SIZE_IN_BYTES(i)) {\n@@ -448,8 +444,6 @@ static void adf_queue_arb_enable(struct qat_queue *txq, void *base_addr,\n \t\t\t\t\t\t\ttxq->hw_bundle_number);\n \tuint32_t value;\n \n-\tPMD_INIT_FUNC_TRACE();\n-\n \trte_spinlock_lock(lock);\n \tvalue = ADF_CSR_RD(base_addr, arb_csr_offset);\n \tvalue |= (0x01 << txq->hw_queue_number);\n@@ -465,8 +459,6 @@ static void adf_queue_arb_disable(struct qat_queue *txq, void *base_addr,\n \t\t\t\t\t\t\ttxq->hw_bundle_number);\n \tuint32_t value;\n \n-\tPMD_INIT_FUNC_TRACE();\n-\n \trte_spinlock_lock(lock);\n \tvalue = ADF_CSR_RD(base_addr, arb_csr_offset);\n \tvalue &= ~(0x01 << txq->hw_queue_number);\n@@ -479,7 +471,6 @@ static void adf_configure_queues(struct qat_qp *qp)\n \tuint32_t queue_config;\n \tstruct qat_queue *queue = &qp->tx_q;\n \n-\tPMD_INIT_FUNC_TRACE();\n \tqueue_config = BUILD_RING_CONFIG(queue->queue_size);\n \n \tWRITE_CSR_RING_CONFIG(qp->mmap_bar_addr, queue->hw_bundle_number,\ndiff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c\nindex c94a8a1..8797c0e 100644\n--- a/drivers/crypto/qat/qat_sym_pmd.c\n+++ b/drivers/crypto/qat/qat_sym_pmd.c\n@@ -33,27 +33,23 @@ static int qat_sym_qp_release(struct rte_cryptodev *dev,\n static int qat_sym_dev_config(__rte_unused struct rte_cryptodev *dev,\n \t\t__rte_unused struct rte_cryptodev_config *config)\n {\n-\tPMD_INIT_FUNC_TRACE();\n \treturn 0;\n }\n \n static int qat_sym_dev_start(__rte_unused struct rte_cryptodev *dev)\n {\n-\tPMD_INIT_FUNC_TRACE();\n \treturn 0;\n }\n \n static void qat_sym_dev_stop(__rte_unused struct rte_cryptodev *dev)\n {\n-\tPMD_INIT_FUNC_TRACE();\n+\treturn;\n }\n \n static int qat_sym_dev_close(struct rte_cryptodev *dev)\n {\n \tint i, ret;\n \n-\tPMD_INIT_FUNC_TRACE();\n-\n \tfor (i = 0; i < dev->data->nb_queue_pairs; i++) {\n \t\tret = qat_sym_qp_release(dev, i);\n \t\tif (ret < 0)\n@@ -71,7 +67,6 @@ static void qat_sym_dev_info_get(struct rte_cryptodev *dev,\n \t\tqat_gen_config[internals->qat_dev->qat_dev_gen]\n \t\t\t .qp_hw_data[QAT_SERVICE_SYMMETRIC];\n \n-\tPMD_INIT_FUNC_TRACE();\n \tif (info != NULL) {\n \t\tinfo->max_nb_queue_pairs =\n \t\t\tqat_qps_per_service(sym_hw_qps, QAT_SERVICE_SYMMETRIC);\ndiff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c\nindex 689596d..83d0fb1 100644\n--- a/drivers/crypto/qat/qat_sym_session.c\n+++ b/drivers/crypto/qat/qat_sym_session.c\n@@ -111,7 +111,6 @@ void\n qat_sym_session_clear(struct rte_cryptodev *dev,\n \t\tstruct rte_cryptodev_sym_session *sess)\n {\n-\tPMD_INIT_FUNC_TRACE();\n \tuint8_t index = dev->driver_id;\n \tvoid *sess_priv = get_session_private_data(sess, index);\n \tstruct qat_sym_session *s = (struct qat_sym_session *)sess_priv;\n@@ -411,8 +410,6 @@ qat_sym_session_set_parameters(struct rte_cryptodev *dev,\n \tint ret;\n \tint qat_cmd_id;\n \n-\tPMD_INIT_FUNC_TRACE();\n-\n \t/* Set context descriptor physical address */\n \tsession->cd_paddr = rte_mempool_virt2iova(session) +\n \t\t\toffsetof(struct qat_sym_session, cd);\n@@ -936,7 +933,6 @@ static int partial_hash_compute(enum icp_qat_hw_auth_algo hash_alg,\n \tuint64_t *hash_state_out_be64;\n \tint i;\n \n-\tPMD_INIT_FUNC_TRACE();\n \tdigest_size = qat_hash_get_digest_size(hash_alg);\n \tif (digest_size <= 0)\n \t\treturn -EFAULT;\n@@ -1006,7 +1002,6 @@ static int qat_sym_do_precomputes(enum icp_qat_hw_auth_algo hash_alg,\n \tuint8_t opad[qat_hash_get_block_size(ICP_QAT_HW_AUTH_ALGO_DELIMITER)];\n \tint i;\n \n-\tPMD_INIT_FUNC_TRACE();\n \tif (hash_alg == ICP_QAT_HW_AUTH_ALGO_AES_XCBC_MAC) {\n \t\tstatic uint8_t qat_aes_xcbc_key_seed[\n \t\t\t\t\tICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ] = {\n@@ -1129,7 +1124,6 @@ static void\n qat_sym_session_init_common_hdr(struct icp_qat_fw_comn_req_hdr *header,\n \t\tenum qat_sym_proto_flag proto_flags)\n {\n-\tPMD_INIT_FUNC_TRACE();\n \theader->hdr_flags =\n \t\tICP_QAT_FW_COMN_HDR_FLAGS_BUILD(ICP_QAT_FW_COMN_REQ_FLAG_SET);\n \theader->service_type = ICP_QAT_FW_COMN_REQ_CPM_FW_LA;\n@@ -1212,7 +1206,6 @@ int qat_sym_session_aead_create_cd_cipher(struct qat_sym_session *cdesc,\n \tuint16_t cipher_offset, cd_size;\n \tuint32_t wordIndex = 0;\n \tuint32_t *temp_key = NULL;\n-\tPMD_INIT_FUNC_TRACE();\n \n \tif (cdesc->qat_cmd == ICP_QAT_FW_LA_CMD_CIPHER) {\n \t\tcd_pars->u.s.content_desc_addr = cdesc->cd_paddr;\n@@ -1369,8 +1362,6 @@ int qat_sym_session_aead_create_cd_auth(struct qat_sym_session *cdesc,\n \tenum qat_sym_proto_flag qat_proto_flag =\n \t\tQAT_CRYPTO_PROTO_FLAG_NONE;\n \n-\tPMD_INIT_FUNC_TRACE();\n-\n \tif (cdesc->qat_cmd == ICP_QAT_FW_LA_CMD_AUTH) {\n \t\tICP_QAT_FW_COMN_CURR_ID_SET(hash_cd_ctrl,\n \t\t\t\t\tICP_QAT_FW_SLICE_AUTH);\n", "prefixes": [ "v2", "1/5" ] }