Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41064/?format=api
{ "id": 41064, "url": "https://patches.dpdk.org/api/patches/41064/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1528892062-4997-32-git-send-email-tomaszx.jozwiak@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1528892062-4997-32-git-send-email-tomaszx.jozwiak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1528892062-4997-32-git-send-email-tomaszx.jozwiak@intel.com", "date": "2018-06-13T12:14:15", "name": "[v3,31/38] crypto/qat: register appropriately named device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7d347e6d50b25374e9c78c3e0c02243709c267db", "submitter": { "id": 949, "url": "https://patches.dpdk.org/api/people/949/?format=api", "name": "Tomasz Jozwiak", "email": "tomaszx.jozwiak@intel.com" }, "delegate": { "id": 22, "url": "https://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1528892062-4997-32-git-send-email-tomaszx.jozwiak@intel.com/mbox/", "series": [ { "id": 111, "url": "https://patches.dpdk.org/api/series/111/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=111", "date": "2018-06-13T12:13:44", "name": "crypto/qat: refactor to support multiple services", "version": 3, "mbox": "https://patches.dpdk.org/series/111/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41064/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/41064/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 69FA71F015;\n\tWed, 13 Jun 2018 14:15:53 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 2801E1EF5E\n\tfor <dev@dpdk.org>; Wed, 13 Jun 2018 14:15:08 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Jun 2018 05:15:07 -0700", "from tjozwiax-mobl.ger.corp.intel.com (HELO localhost.localdomain)\n\t([10.103.104.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 13 Jun 2018 05:15:06 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,218,1526367600\"; d=\"scan'208\";a=\"63727837\"", "From": "Tomasz Jozwiak <tomaszx.jozwiak@intel.com>", "To": "fiona.trahe@intel.com,\n\ttomaszx.jozwiak@intel.com,\n\tdev@dpdk.org", "Date": "Wed, 13 Jun 2018 14:14:15 +0200", "Message-Id": "<1528892062-4997-32-git-send-email-tomaszx.jozwiak@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1528892062-4997-1-git-send-email-tomaszx.jozwiak@intel.com>", "References": "<1523040732-3290-1-git-send-email-fiona.trahe@intel.com>\n\t<1528892062-4997-1-git-send-email-tomaszx.jozwiak@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 31/38] crypto/qat: register appropriately\n\tnamed device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Fiona Trahe <fiona.trahe@intel.com>\n\nFor every QAT PCI device probed, populate a local rte_device\ncontaining an rte_driver. The rte_driver was created in a previous\npatch to provide a crypto-specific driver name: \"crypto_qat\".\nThis was previously only used for driver registration, now it's also\nused in device creation.\nThis allows applications to find devices driven by \"crypto_qat\".\n\nSigned-off-by: Fiona Trahe <fiona.trahe@intel.com>\n---\n drivers/crypto/qat/qat_device.h | 5 +++++\n drivers/crypto/qat/qat_sym_pmd.c | 38 ++++++++++++++++++++------------\n 2 files changed, 29 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_device.h b/drivers/crypto/qat/qat_device.h\nindex 4201a1c71..3df6520c3 100644\n--- a/drivers/crypto/qat/qat_device.h\n+++ b/drivers/crypto/qat/qat_device.h\n@@ -50,6 +50,11 @@ struct qat_pci_device {\n \t/* Data relating to symmetric crypto service */\n \tstruct qat_sym_dev_private *sym_dev;\n \t/**< link back to cryptodev private data */\n+\tstruct rte_device sym_rte_dev;\n+\t/**< This represents the crypto subset of this pci device.\n+\t * Register with this rather than with the one in\n+\t * pci_dev so that its driver can have a crypto-specific name\n+\t */\n \n \t/* Data relating to compression service */\n \ndiff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c\nindex e6760b8f8..28e579b77 100644\n--- a/drivers/crypto/qat/qat_sym_pmd.c\n+++ b/drivers/crypto/qat/qat_sym_pmd.c\n@@ -232,6 +232,18 @@ qat_sym_pmd_dequeue_op_burst(void *qp, struct rte_crypto_op **ops,\n \treturn qat_dequeue_op_burst(qp, (void **)ops, nb_ops);\n }\n \n+/* An rte_driver is needed in the registration of both the device and the driver\n+ * with cryptodev.\n+ * The actual qat pci's rte_driver can't be used as its name represents\n+ * the whole pci device with all services. Think of this as a holder for a name\n+ * for the crypto part of the pci device.\n+ */\n+static const char qat_sym_drv_name[] = RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD);\n+static const struct rte_driver cryptodev_qat_sym_driver = {\n+\t.name = qat_sym_drv_name,\n+\t.alias = qat_sym_drv_name\n+};\n+\n int\n qat_sym_dev_create(struct qat_pci_device *qat_pci_dev)\n {\n@@ -249,12 +261,19 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev)\n \t\t\tqat_pci_dev->name, \"sym\");\n \tPMD_DRV_LOG(DEBUG, \"Creating QAT SYM device %s\", name);\n \n+\t/* Populate subset device to use in cryptodev device creation */\n+\tqat_pci_dev->sym_rte_dev.driver = &cryptodev_qat_sym_driver;\n+\tqat_pci_dev->sym_rte_dev.numa_node =\n+\t\t\t\tqat_pci_dev->pci_dev->device.numa_node;\n+\tqat_pci_dev->sym_rte_dev.devargs = NULL;\n+\n \tcryptodev = rte_cryptodev_pmd_create(name,\n-\t\t\t&qat_pci_dev->pci_dev->device, &init_params);\n+\t\t\t&(qat_pci_dev->sym_rte_dev), &init_params);\n \n \tif (cryptodev == NULL)\n \t\treturn -ENODEV;\n \n+\tqat_pci_dev->sym_rte_dev.name = cryptodev->data->name;\n \tcryptodev->driver_id = cryptodev_qat_driver_id;\n \tcryptodev->dev_ops = &crypto_qat_ops;\n \n@@ -287,7 +306,7 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev)\n \t}\n \n \tPMD_DRV_LOG(DEBUG, \"Created QAT SYM device %s as cryptodev instance %d\",\n-\t\t\tname, internals->sym_dev_id);\n+\t\t\tcryptodev->data->name, internals->sym_dev_id);\n \treturn 0;\n }\n \n@@ -304,23 +323,14 @@ qat_sym_dev_destroy(struct qat_pci_device *qat_pci_dev)\n \t/* free crypto device */\n \tcryptodev = rte_cryptodev_pmd_get_dev(qat_pci_dev->sym_dev->sym_dev_id);\n \trte_cryptodev_pmd_destroy(cryptodev);\n+\tqat_pci_dev->sym_rte_dev.name = NULL;\n \tqat_pci_dev->sym_dev = NULL;\n \n \treturn 0;\n }\n \n \n-/* An rte_driver is needed in the registration of both the device and the driver\n- * with cryptodev.\n- * The actual qat pci's rte_driver can't be used as its name represents\n- * the whole pci device with all services. Think of this as a holder for a name\n- * for the crypto part of the pci device.\n- */\n-static const char qat_sym_drv_name[] = RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD);\n-static struct rte_driver cryptodev_qat_sym_driver = {\n-\t.name = qat_sym_drv_name,\n-\t.alias = qat_sym_drv_name\n-};\n static struct cryptodev_driver qat_crypto_drv;\n-RTE_PMD_REGISTER_CRYPTO_DRIVER(qat_crypto_drv, cryptodev_qat_sym_driver,\n+RTE_PMD_REGISTER_CRYPTO_DRIVER(qat_crypto_drv,\n+\t\tcryptodev_qat_sym_driver,\n \t\tcryptodev_qat_driver_id);\n", "prefixes": [ "v3", "31/38" ] }