Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41026,
    "url": "https://patches.dpdk.org/api/patches/41026/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1528877530-5133-1-git-send-email-wei.zhao1@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1528877530-5133-1-git-send-email-wei.zhao1@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1528877530-5133-1-git-send-email-wei.zhao1@intel.com",
    "date": "2018-06-13T08:12:10",
    "name": "net/ixgbe: fix mask bits register set error for FDIR",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "db764bb0f4c32ef449329339503b3edb4b610a33",
    "submitter": {
        "id": 495,
        "url": "https://patches.dpdk.org/api/people/495/?format=api",
        "name": "Zhao1, Wei",
        "email": "wei.zhao1@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "https://patches.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1528877530-5133-1-git-send-email-wei.zhao1@intel.com/mbox/",
    "series": [
        {
            "id": 106,
            "url": "https://patches.dpdk.org/api/series/106/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=106",
            "date": "2018-06-13T08:12:10",
            "name": "net/ixgbe: fix mask bits register set error for FDIR",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/106/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/41026/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/41026/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E9DB71EF40;\n\tWed, 13 Jun 2018 10:32:54 +0200 (CEST)",
            "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id D4A3F1EF37;\n\tWed, 13 Jun 2018 10:32:53 +0200 (CEST)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Jun 2018 01:32:52 -0700",
            "from dpdk6.bj.intel.com ([172.16.182.94])\n\tby orsmga008.jf.intel.com with ESMTP; 13 Jun 2018 01:32:51 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,218,1526367600\"; d=\"scan'208\";a=\"48957408\"",
        "From": "Wei Zhao <wei.zhao1@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "wenzhuo.lu@intel.com,\n\tstable@dpdk.org,\n\tWei Zhao <wei.zhao1@intel.com>",
        "Date": "Wed, 13 Jun 2018 16:12:10 +0800",
        "Message-Id": "<1528877530-5133-1-git-send-email-wei.zhao1@intel.com>",
        "X-Mailer": "git-send-email 2.7.5",
        "Subject": "[dpdk-dev] [PATCH] net/ixgbe: fix mask bits register set error for\n\tFDIR",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "MAC address bits in mask registers should be set to zero\nwhen the is mac mask is 0xFF, otherwise if it is 0x0\nthese bits should be to 0x3F.\n\nFixes: 82fb702077f6 (\"ixgbe: support new flow director modes for X550\")\n\nSigned-off-by: Wei Zhao <wei.zhao1@intel.com>\n---\n drivers/net/ixgbe/ixgbe_fdir.c | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c\nindex 3feb815..6d97aa3 100644\n--- a/drivers/net/ixgbe/ixgbe_fdir.c\n+++ b/drivers/net/ixgbe/ixgbe_fdir.c\n@@ -394,9 +394,15 @@ fdir_set_input_mask_x550(struct rte_eth_dev *dev)\n \t\t\t\tIXGBE_FDIRIP6M_TNI_VNI;\n \n \tif (mode == RTE_FDIR_MODE_PERFECT_TUNNEL) {\n-\t\tmac_mask = info->mask.mac_addr_byte_mask;\n-\t\tfdiripv6m |= (mac_mask << IXGBE_FDIRIP6M_INNER_MAC_SHIFT)\n-\t\t\t\t& IXGBE_FDIRIP6M_INNER_MAC;\n+\t\tmac_mask = info->mask.mac_addr_byte_mask & 0x3F;\n+\t\tif (mac_mask == 0x3F)\n+\t\t\tfdiripv6m &= ~IXGBE_FDIRIP6M_INNER_MAC;\n+\t\telse if (mac_mask == 0)\n+\t\t\tfdiripv6m |= IXGBE_FDIRIP6M_INNER_MAC;\n+\t\telse{\n+\t\t\tPMD_INIT_LOG(ERR, \"invalid mac_addr_byte_mask\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n \n \t\tswitch (info->mask.tunnel_type_mask) {\n \t\tcase 0:\n",
    "prefixes": []
}