Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41008/?format=api
{ "id": 41008, "url": "https://patches.dpdk.org/api/patches/41008/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180612103946.34385-1-marko.kovacevic@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180612103946.34385-1-marko.kovacevic@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180612103946.34385-1-marko.kovacevic@intel.com", "date": "2018-06-12T10:39:46", "name": "[v1] crypto/qat: add support for 8 byte 3DES", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "71da2cba08a648b9a4e8a701082d30b3f647827c", "submitter": { "id": 853, "url": "https://patches.dpdk.org/api/people/853/?format=api", "name": "Kovacevic, Marko", "email": "marko.kovacevic@intel.com" }, "delegate": { "id": 22, "url": "https://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180612103946.34385-1-marko.kovacevic@intel.com/mbox/", "series": [ { "id": 94, "url": "https://patches.dpdk.org/api/series/94/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=94", "date": "2018-06-12T10:39:46", "name": "[v1] crypto/qat: add support for 8 byte 3DES", "version": 1, "mbox": "https://patches.dpdk.org/series/94/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41008/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/41008/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 50F591E93A;\n\tTue, 12 Jun 2018 12:40:03 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id EB0031E937\n\tfor <dev@dpdk.org>; Tue, 12 Jun 2018 12:40:00 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Jun 2018 03:39:59 -0700", "from silpixa00399502.ir.intel.com (HELO\n\tsilpixa00399502.ger.corp.intel.com) ([10.237.223.218])\n\tby fmsmga006.fm.intel.com with ESMTP; 12 Jun 2018 03:39:58 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,214,1526367600\"; d=\"scan'208\";a=\"236728298\"", "From": "\"Kovacevic, Marko\" <marko.kovacevic@intel.com>", "To": "dev@dpdk.org", "Cc": "pablo.de.lara.guarch@intel.com, deepak.k.jain@intel.com,\n\t\"Kovacevic, Marko\" <marko.kovacevic@intel.com>, Marko@dpdk.org", "Date": "Tue, 12 Jun 2018 11:39:46 +0100", "Message-Id": "<20180612103946.34385-1-marko.kovacevic@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[dpdk-dev] [PATCH v1] crypto/qat: add support for 8 byte 3DES", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Added extra case to support 8 byte key size\nfor 3DES CBC. Also changed capabilities to reflect\nthe change.\n\nSigned-off-by: Marko, Kovacevic <marko.kovacevic@intel.com>\n---\n drivers/crypto/qat/qat_adf/qat_algs.h | 1 +\n drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 1 +\n drivers/crypto/qat/qat_crypto_capabilities.h | 2 +-\n test/test/test_cryptodev_des_test_vectors.h | 6 ++++--\n 4 files changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_adf/qat_algs.h b/drivers/crypto/qat/qat_adf/qat_algs.h\nindex 88bd5f00e..a3a3545ef 100644\n--- a/drivers/crypto/qat/qat_adf/qat_algs.h\n+++ b/drivers/crypto/qat/qat_adf/qat_algs.h\n@@ -21,6 +21,7 @@\n /* 3DES key sizes */\n #define QAT_3DES_KEY_SZ_OPT1 24 /* Keys are independent */\n #define QAT_3DES_KEY_SZ_OPT2 16 /* K3=K1 */\n+#define QAT_3DES_KEY_SZ_OPT3 8 /* K1=K2=K3 */\n \n #define QAT_AES_HW_CONFIG_CBC_ENC(alg) \\\n \tICP_QAT_HW_CIPHER_CONFIG_BUILD(ICP_QAT_HW_CIPHER_CBC_MODE, alg, \\\ndiff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c\nindex c87ed40fe..e89858d22 100644\n--- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c\n+++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c\n@@ -994,6 +994,7 @@ int qat_alg_validate_3des_key(int key_len, enum icp_qat_hw_cipher_algo *alg)\n \tswitch (key_len) {\n \tcase QAT_3DES_KEY_SZ_OPT1:\n \tcase QAT_3DES_KEY_SZ_OPT2:\n+\tcase QAT_3DES_KEY_SZ_OPT3:\n \t\t*alg = ICP_QAT_HW_CIPHER_ALGO_3DES;\n \t\tbreak;\n \tdefault:\ndiff --git a/drivers/crypto/qat/qat_crypto_capabilities.h b/drivers/crypto/qat/qat_crypto_capabilities.h\nindex 001c32c5d..1d6110970 100644\n--- a/drivers/crypto/qat/qat_crypto_capabilities.h\n+++ b/drivers/crypto/qat/qat_crypto_capabilities.h\n@@ -434,7 +434,7 @@\n \t\t\t\t.algo = RTE_CRYPTO_CIPHER_3DES_CBC,\t\\\n \t\t\t\t.block_size = 8,\t\t\t\\\n \t\t\t\t.key_size = {\t\t\t\t\\\n-\t\t\t\t\t.min = 16,\t\t\t\\\n+\t\t\t\t\t.min = 8,\t\t\t\\\n \t\t\t\t\t.max = 24,\t\t\t\\\n \t\t\t\t\t.increment = 8\t\t\t\\\n \t\t\t\t},\t\t\t\t\t\\\ndiff --git a/test/test/test_cryptodev_des_test_vectors.h b/test/test/test_cryptodev_des_test_vectors.h\nindex 7479e70f0..103345605 100644\n--- a/test/test/test_cryptodev_des_test_vectors.h\n+++ b/test/test/test_cryptodev_des_test_vectors.h\n@@ -1233,14 +1233,16 @@ static const struct blockcipher_test_case triple_des_cipheronly_test_cases[] = {\n \t\t.test_data = &triple_des64cbc_test_vector,\n \t\t.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,\n \t\t.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |\n-\t\t\tBLOCKCIPHER_TEST_TARGET_PMD_OPENSSL\n+\t\t\tBLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |\n+\t\t\tBLOCKCIPHER_TEST_TARGET_PMD_QAT\n \t},\n \t{\n \t\t.test_descr = \"3DES-64-CBC Decryption\",\n \t\t.test_data = &triple_des64cbc_test_vector,\n \t\t.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,\n \t\t.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |\n-\t\t\tBLOCKCIPHER_TEST_TARGET_PMD_OPENSSL\n+\t\t\tBLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |\n+\t\t\tBLOCKCIPHER_TEST_TARGET_PMD_QAT\n \t},\n \t{\n \t\t.test_descr = \"3DES-128-CBC Encryption\",\n", "prefixes": [ "v1" ] }