Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40936/?format=api
{ "id": 40936, "url": "https://patches.dpdk.org/api/patches/40936/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1528481718-7241-4-git-send-email-nikhil.rao@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1528481718-7241-4-git-send-email-nikhil.rao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1528481718-7241-4-git-send-email-nikhil.rao@intel.com", "date": "2018-06-08T18:15:16", "name": "[dpdk-dev,v1,3/4] eventdev: move Rx adapter eth receive code to separate function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "8e478da806f89d0c58cb451f542939c7e4280dfb", "submitter": { "id": 528, "url": "https://patches.dpdk.org/api/people/528/?format=api", "name": "Rao, Nikhil", "email": "nikhil.rao@intel.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1528481718-7241-4-git-send-email-nikhil.rao@intel.com/mbox/", "series": [ { "id": 64, "url": "https://patches.dpdk.org/api/series/64/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=64", "date": "2018-06-08T18:15:13", "name": "eventdev: add interrupt driven queues to Rx adapter", "version": 1, "mbox": "https://patches.dpdk.org/series/64/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/40936/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/40936/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6568B1CFEA;\n\tFri, 8 Jun 2018 20:14:57 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 846111BB71\n\tfor <dev@dpdk.org>; Fri, 8 Jun 2018 20:14:55 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jun 2018 11:14:55 -0700", "from unknown (HELO localhost.localdomain.localdomain)\n\t([10.224.122.193])\n\tby orsmga002.jf.intel.com with ESMTP; 08 Jun 2018 11:14:53 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,490,1520924400\"; d=\"scan'208\";a=\"65468523\"", "From": "Nikhil Rao <nikhil.rao@intel.com>", "To": "jerin.jacob@caviumnetworks.com", "Cc": "dev@dpdk.org,\n\tNikhil Rao <nikhil.rao@intel.com>", "Date": "Fri, 8 Jun 2018 23:45:16 +0530", "Message-Id": "<1528481718-7241-4-git-send-email-nikhil.rao@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1528481718-7241-1-git-send-email-nikhil.rao@intel.com>", "References": "<1528481718-7241-1-git-send-email-nikhil.rao@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 3/4] eventdev: move Rx adapter eth receive\n\tcode to separate function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Create a separate function that handles eth receive and\nenqueue to event buffer. This function will also be called for\ninterrupt driven receive queues.\n\nSigned-off-by: Nikhil Rao <nikhil.rao@intel.com>\n---\n lib/librte_eventdev/rte_event_eth_rx_adapter.c | 67 ++++++++++++++++++--------\n 1 file changed, 47 insertions(+), 20 deletions(-)", "diff": "diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c\nindex c8db11b..40e9bc9 100644\n--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c\n+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c\n@@ -616,6 +616,45 @@ static uint16_t rxa_gcd_u16(uint16_t a, uint16_t b)\n \t}\n }\n \n+/* Enqueue packets from <port, q> to event buffer */\n+static inline uint32_t\n+rxa_eth_rx(struct rte_event_eth_rx_adapter *rx_adapter,\n+\tuint16_t port_id,\n+\tuint16_t queue_id,\n+\tuint32_t rx_count,\n+\tuint32_t max_rx)\n+{\n+\tstruct rte_mbuf *mbufs[BATCH_SIZE];\n+\tstruct rte_eth_event_enqueue_buffer *buf =\n+\t\t\t\t\t&rx_adapter->event_enqueue_buffer;\n+\tstruct rte_event_eth_rx_adapter_stats *stats =\n+\t\t\t\t\t&rx_adapter->stats;\n+\tuint16_t n;\n+\tuint32_t nb_rx = 0;\n+\n+\t/* Don't do a batch dequeue from the rx queue if there isn't\n+\t * enough space in the enqueue buffer.\n+\t */\n+\twhile (BATCH_SIZE <= (RTE_DIM(buf->events) - buf->count)) {\n+\t\tif (buf->count >= BATCH_SIZE)\n+\t\t\trxa_flush_event_buffer(rx_adapter);\n+\n+\t\tstats->rx_poll_count++;\n+\t\tn = rte_eth_rx_burst(port_id, queue_id, mbufs, BATCH_SIZE);\n+\t\tif (unlikely(!n))\n+\t\t\tbreak;\n+\t\trxa_buffer_mbufs(rx_adapter, port_id, queue_id, mbufs, n);\n+\t\tnb_rx += n;\n+\t\tif (rx_count + nb_rx > max_rx)\n+\t\t\tbreak;\n+\t}\n+\n+\tif (buf->count >= BATCH_SIZE)\n+\t\trxa_flush_event_buffer(rx_adapter);\n+\n+\treturn nb_rx;\n+}\n+\n /*\n * Polls receive queues added to the event adapter and enqueues received\n * packets to the event device.\n@@ -633,17 +672,16 @@ static uint16_t rxa_gcd_u16(uint16_t a, uint16_t b)\n rxa_poll(struct rte_event_eth_rx_adapter *rx_adapter)\n {\n \tuint32_t num_queue;\n-\tuint16_t n;\n \tuint32_t nb_rx = 0;\n-\tstruct rte_mbuf *mbufs[BATCH_SIZE];\n \tstruct rte_eth_event_enqueue_buffer *buf;\n \tuint32_t wrr_pos;\n \tuint32_t max_nb_rx;\n+\tstruct rte_event_eth_rx_adapter_stats *stats;\n \n \twrr_pos = rx_adapter->wrr_pos;\n \tmax_nb_rx = rx_adapter->max_nb_rx;\n \tbuf = &rx_adapter->event_enqueue_buffer;\n-\tstruct rte_event_eth_rx_adapter_stats *stats = &rx_adapter->stats;\n+\tstats = &rx_adapter->stats;\n \n \t/* Iterate through a WRR sequence */\n \tfor (num_queue = 0; num_queue < rx_adapter->wrr_len; num_queue++) {\n@@ -658,32 +696,21 @@ static uint16_t rxa_gcd_u16(uint16_t a, uint16_t b)\n \t\t\trxa_flush_event_buffer(rx_adapter);\n \t\tif (BATCH_SIZE > (ETH_EVENT_BUFFER_SIZE - buf->count)) {\n \t\t\trx_adapter->wrr_pos = wrr_pos;\n-\t\t\treturn;\n+\t\t\tbreak;\n \t\t}\n \n-\t\tstats->rx_poll_count++;\n-\t\tn = rte_eth_rx_burst(d, qid, mbufs, BATCH_SIZE);\n-\n-\t\tif (n) {\n-\t\t\tstats->rx_packets += n;\n-\t\t\t/* The check before rte_eth_rx_burst() ensures that\n-\t\t\t * all n mbufs can be buffered\n-\t\t\t */\n-\t\t\trxa_buffer_mbufs(rx_adapter, d, qid, mbufs, n);\n-\t\t\tnb_rx += n;\n-\t\t\tif (nb_rx > max_nb_rx) {\n-\t\t\t\trx_adapter->wrr_pos =\n+\t\tnb_rx += rxa_eth_rx(rx_adapter, d, qid, nb_rx, max_nb_rx);\n+\t\tif (nb_rx > max_nb_rx) {\n+\t\t\trx_adapter->wrr_pos =\n \t\t\t\t (wrr_pos + 1) % rx_adapter->wrr_len;\n-\t\t\t\tbreak;\n-\t\t\t}\n+\t\t\tbreak;\n \t\t}\n \n \t\tif (++wrr_pos == rx_adapter->wrr_len)\n \t\t\twrr_pos = 0;\n \t}\n \n-\tif (buf->count >= BATCH_SIZE)\n-\t\trxa_flush_event_buffer(rx_adapter);\n+\tstats->rx_packets += nb_rx;\n }\n \n static int\n", "prefixes": [ "dpdk-dev", "v1", "3/4" ] }