Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40732/?format=api
{ "id": 40732, "url": "https://patches.dpdk.org/api/patches/40732/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180607094322.14312-19-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180607094322.14312-19-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180607094322.14312-19-mk@semihalf.com", "date": "2018-06-07T09:43:14", "name": "[dpdk-dev,v3,19/27] net/ena: validate Tx req id", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bcb1531824fc826033c05c12f7eda8b05d31ce9f", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180607094322.14312-19-mk@semihalf.com/mbox/", "series": [ { "id": 26, "url": "https://patches.dpdk.org/api/series/26/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26", "date": "2018-06-07T09:43:00", "name": "net/ena: new features and fixes", "version": 3, "mbox": "https://patches.dpdk.org/series/26/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/40732/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/40732/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 167C21B404;\n\tThu, 7 Jun 2018 11:44:06 +0200 (CEST)", "from mail-lf0-f68.google.com (mail-lf0-f68.google.com\n\t[209.85.215.68]) by dpdk.org (Postfix) with ESMTP id AEDFA1B1C7\n\tfor <dev@dpdk.org>; Thu, 7 Jun 2018 11:44:04 +0200 (CEST)", "by mail-lf0-f68.google.com with SMTP id g21-v6so11670304lfb.4\n\tfor <dev@dpdk.org>; Thu, 07 Jun 2018 02:44:04 -0700 (PDT)", "from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\tp28-v6sm3612368lfh.24.2018.06.07.02.44.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 07 Jun 2018 02:44:02 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=/kfiPClVLW8UBUzJEh1yi7ZvDw9p9uTLR9veQRPE9FM=;\n\tb=0mR8owbnv0zG05/wOJXo4b+z+uV+32o4x/vf4O0WSAvoSJLR8M3Z94JxYpkRiSJ20o\n\t48zLkqPMfyrWP7naXDqeATAp61lXK0h3JxU1zzjC/BooerMH+fmKkN+EqR3r56bKnhZ4\n\tJrrA6012Gzh4kPIplikA39bemI8FbNyF032dWeE4Ex1tqppVAqRWaEw2jJZkupP8b6DO\n\tBxSrQdTQrzSSN6NfEdxvHdoUfMS/A+2s97pz7snGySDxfn99cmc8tSzZz4jWrW2nxiu3\n\tmtX2WdVlsI7FuTjy9I4JqCnSQj7htFeVaImXdNuih9YMV/6hTEPEraTMvqLq+1AgQGqR\n\txnDg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=/kfiPClVLW8UBUzJEh1yi7ZvDw9p9uTLR9veQRPE9FM=;\n\tb=knWr1fwt6veZU8uW/EWM0EPslXl5Rkvme09iJAwkc0880fx1R88dKs1+OreGjIlzdJ\n\t06gNVnxX1whCjUFr7lyHcyS0AQMnFtAxhhILw3KuggybK8Dury2zyKkna80mE27J384U\n\ttfEQIdq68r+0i6sXfkiAb4HgHg1chXqJeC4aWv0vUz4f5G+OP9dLiqhVWVsoeD8S22CQ\n\tq/yEknkr9DGXzw2UTdqsJ/PfD5Vpa0ajzjmVube++saITJp8IFC2j+T5jUczCs4+G5B+\n\t1EXcgQUbiOwv6dJLHEn4GnycqC9BwJ05AxopGWRlFcao01wjCJ1N7Yhfc5z1HqRQv/62\n\tUxkA==", "X-Gm-Message-State": "APt69E1QkLxeCx9nGRWk9Vq8YyjxuwpzPxKF8eq5WtF4ujl//xC0Glbh\n\tASmRJvfX45KUkaKnrCy7C0xZcg==", "X-Google-Smtp-Source": "ADUXVKKRiqalYSEzZWN4X2qGCcTu56yXQ5aSO0waX9Lqmj1H8hCLDuaBMBccH9tmL18o75X8yHdRBQ==", "X-Received": "by 2002:a19:8f1d:: with SMTP id\n\tr29-v6mr866378lfd.88.1528364644358; \n\tThu, 07 Jun 2018 02:44:04 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>,\n\tGuy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>", "Cc": "dev@dpdk.org,\n\tmatua@amazon.com,\n\tRafal Kozik <rk@semihalf.com>", "Date": "Thu, 7 Jun 2018 11:43:14 +0200", "Message-Id": "<20180607094322.14312-19-mk@semihalf.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20180607094322.14312-1-mk@semihalf.com>", "References": "<20180607094322.14312-1-mk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v3 19/27] net/ena: validate Tx req id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Rafal Kozik <rk@semihalf.com>\n\nValidate Tx req id during clearing completed packets.\nIf id is wrong, trigger NIC reset.\n\nSigned-off-by: Rafal Kozik <rk@semihalf.com>\nAcked-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 25 +++++++++++++++++++++++++\n 1 file changed, 25 insertions(+)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 1f7463496..5fbf0e5d5 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -384,6 +384,27 @@ static inline int validate_rx_req_id(struct ena_ring *rx_ring, uint16_t req_id)\n \treturn -EFAULT;\n }\n \n+static int validate_tx_req_id(struct ena_ring *tx_ring, u16 req_id)\n+{\n+\tstruct ena_tx_buffer *tx_info = NULL;\n+\n+\tif (likely(req_id < tx_ring->ring_size)) {\n+\t\ttx_info = &tx_ring->tx_buffer_info[req_id];\n+\t\tif (likely(tx_info->mbuf))\n+\t\t\treturn 0;\n+\t}\n+\n+\tif (tx_info)\n+\t\tRTE_LOG(ERR, PMD, \"tx_info doesn't have valid mbuf\\n\");\n+\telse\n+\t\tRTE_LOG(ERR, PMD, \"Invalid req_id: %hu\\n\", req_id);\n+\n+\t/* Trigger device reset */\n+\ttx_ring->adapter->reset_reason = ENA_REGS_RESET_INV_TX_REQ_ID;\n+\ttx_ring->adapter->trigger_reset\t= true;\n+\treturn -EFAULT;\n+}\n+\n static void ena_config_host_info(struct ena_com_dev *ena_dev)\n {\n \tstruct ena_admin_host_info *host_info;\n@@ -2093,6 +2114,10 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \n \t/* Clear complete packets */\n \twhile (ena_com_tx_comp_req_id_get(tx_ring->ena_com_io_cq, &req_id) >= 0) {\n+\t\trc = validate_tx_req_id(tx_ring, req_id);\n+\t\tif (rc)\n+\t\t\tbreak;\n+\n \t\t/* Get Tx info & store how many descs were processed */\n \t\ttx_info = &tx_ring->tx_buffer_info[req_id];\n \t\ttotal_tx_descs += tx_info->tx_descs;\n", "prefixes": [ "dpdk-dev", "v3", "19/27" ] }