Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40715/?format=api
{ "id": 40715, "url": "https://patches.dpdk.org/api/patches/40715/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180607094322.14312-3-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180607094322.14312-3-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180607094322.14312-3-mk@semihalf.com", "date": "2018-06-07T09:42:58", "name": "[dpdk-dev,v3,03/27] net/ena: remove support of legacy LLQ", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b809ed52e16d9a8f4fb201a02451480b00dc6732", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180607094322.14312-3-mk@semihalf.com/mbox/", "series": [ { "id": 26, "url": "https://patches.dpdk.org/api/series/26/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26", "date": "2018-06-07T09:43:00", "name": "net/ena: new features and fixes", "version": 3, "mbox": "https://patches.dpdk.org/series/26/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/40715/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/40715/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 319CB1B172;\n\tThu, 7 Jun 2018 11:43:37 +0200 (CEST)", "from mail-lf0-f67.google.com (mail-lf0-f67.google.com\n\t[209.85.215.67]) by dpdk.org (Postfix) with ESMTP id 1A3E41B052\n\tfor <dev@dpdk.org>; Thu, 7 Jun 2018 11:43:33 +0200 (CEST)", "by mail-lf0-f67.google.com with SMTP id i15-v6so3336620lfc.2\n\tfor <dev@dpdk.org>; Thu, 07 Jun 2018 02:43:33 -0700 (PDT)", "from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\tp28-v6sm3612368lfh.24.2018.06.07.02.43.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 07 Jun 2018 02:43:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=SKw514H8Bvh6MK508oguM3Pu0V1eoGhzBBXemJPRnmo=;\n\tb=NjKfoql1OkS+vhVQkkrXj+mrLqw+IjeZfZoQcOWJCkHyfybxZHBCpWEo+pD5DtQdys\n\thTJbTR+addrLpGagd1invu6VlTaj5wQnScgoWlgTLRhYBnfNxtHub0JnIvsMqD5hZKi4\n\tLMlGStJ2p9ZZAAGmuHQIvWgpEi8I8Br/ervWQZW32LR5IYs9uh4qjnkaQKRcbmUPxvhv\n\th4pAbOOrDY1juF7TAKf0+fwEOAAZEKsGsUA2utJylEiMz3Ytogbq9T450jmSp6Aask1n\n\t3cuf6o0akTuy4pMa7rJwC+t1bOvKCJr8Gu67SQZvh5cBbRK5ckK/XXD/GXbX0AStDbdS\n\tCz2Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=SKw514H8Bvh6MK508oguM3Pu0V1eoGhzBBXemJPRnmo=;\n\tb=FztkB0Z1PkHkuydotvFeom7d2iDgNZjtne7ofRP5duB8Vh35LhMStW3OXU+J6GHUGB\n\tOsu0hk1Rsje4Wn0afs/LOZgOfGgzh/c8sQssR/tFgt6jod+ck1cBrIDCa1ZavhMZ7S/K\n\tD6o8szCRRqRryXOU/bOECkJEeZrvaKOLJVvNUiKVSpuEfE/K06zcQ6QI/iHoU2B5H7A2\n\t5Un556Rt0mqi+jct4fF2K3iZGZi0jlT7gU+QwfNtCFJDJqDtbCnrHq/U9nc0eVeAfVlW\n\t865zPsBI+P30e5UzBMmH9DE0zgJgm4CLUNqvvYwxskqHcKdBXOajhYJ0l+asDIBZnlv/\n\th/nA==", "X-Gm-Message-State": "APt69E2JzOmjqL6eLfK3bQEwM3iYHOPDbvck/x0m6KL2AHSwiuexwdLR\n\tiPXFkzh0wOK6kx4DloF3GnStOg==", "X-Google-Smtp-Source": "ADUXVKIp7jROScNHerhhzM+a0wGIR4glLIot6j3QBF6EYLX7TH+Me/49aZiUbckz4/sHqF8L20SCNg==", "X-Received": "by 2002:a2e:9a44:: with SMTP id\n\tk4-v6mr961199ljj.17.1528364612273; \n\tThu, 07 Jun 2018 02:43:32 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>,\n\tGuy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>", "Cc": "dev@dpdk.org,\n\tmatua@amazon.com,\n\tRafal Kozik <rk@semihalf.com>", "Date": "Thu, 7 Jun 2018 11:42:58 +0200", "Message-Id": "<20180607094322.14312-3-mk@semihalf.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20180607094322.14312-1-mk@semihalf.com>", "References": "<20180607094322.14312-1-mk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v3 03/27] net/ena: remove support of legacy LLQ", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Rafal Kozik <rk@semihalf.com>\n\nThe legacy LLQ should no longer be supported by the drivers, as this API\nis deprecated. Because of that, it was removed from the driver.\n\nSigned-off-by: Rafal Kozik <rk@semihalf.com>\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 29 +++++------------------------\n 1 file changed, 5 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 71d6838a0..f4b137a83 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1327,16 +1327,11 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)\n \tadapter->regs = pci_dev->mem_resource[ENA_REGS_BAR].addr;\n \tadapter->dev_mem_base = pci_dev->mem_resource[ENA_MEM_BAR].addr;\n \n-\t/* Present ENA_MEM_BAR indicates available LLQ mode.\n-\t * Use corresponding policy\n-\t */\n-\tif (adapter->dev_mem_base)\n-\t\tena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_DEV;\n-\telse if (adapter->regs)\n-\t\tena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST;\n-\telse\n+\tif (!adapter->regs) {\n \t\tPMD_INIT_LOG(CRIT, \"Failed to access registers BAR(%d)\",\n \t\t\t ENA_REGS_BAR);\n+\t\treturn -ENXIO;\n+\t}\n \n \tena_dev->reg_bar = adapter->regs;\n \tena_dev->dmadev = adapter->pdev;\n@@ -1353,22 +1348,8 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)\n \t\treturn -1;\n \t}\n \n-\tif (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV) {\n-\t\tif (get_feat_ctx.max_queues.max_llq_num == 0) {\n-\t\t\tPMD_INIT_LOG(ERR,\n-\t\t\t\t \"Trying to use LLQ but llq_num is 0.\\n\"\n-\t\t\t\t \"Fall back into regular queues.\");\n-\t\t\tena_dev->tx_mem_queue_type =\n-\t\t\t\tENA_ADMIN_PLACEMENT_POLICY_HOST;\n-\t\t\tadapter->num_queues =\n-\t\t\t\tget_feat_ctx.max_queues.max_sq_num;\n-\t\t} else {\n-\t\t\tadapter->num_queues =\n-\t\t\t\tget_feat_ctx.max_queues.max_llq_num;\n-\t\t}\n-\t} else {\n-\t\tadapter->num_queues = get_feat_ctx.max_queues.max_sq_num;\n-\t}\n+\tena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST;\n+\tadapter->num_queues = get_feat_ctx.max_queues.max_sq_num;\n \n \tqueue_size = ena_calc_queue_size(ena_dev, &get_feat_ctx);\n \tif ((queue_size <= 0) || (adapter->num_queues <= 0))\n", "prefixes": [ "dpdk-dev", "v3", "03/27" ] }