Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40687/?format=api
{ "id": 40687, "url": "https://patches.dpdk.org/api/patches/40687/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1528282041-20380-1-git-send-email-radu.nicolau@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1528282041-20380-1-git-send-email-radu.nicolau@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1528282041-20380-1-git-send-email-radu.nicolau@intel.com", "date": "2018-06-06T10:47:20", "name": "[dpdk-dev,1/2] power: add get capabilities API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2bb665060edcbb04a4c97cff20d028c9b2b15133", "submitter": { "id": 743, "url": "https://patches.dpdk.org/api/people/743/?format=api", "name": "Radu Nicolau", "email": "radu.nicolau@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1528282041-20380-1-git-send-email-radu.nicolau@intel.com/mbox/", "series": [ { "id": 17, "url": "https://patches.dpdk.org/api/series/17/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17", "date": "2018-06-06T10:47:20", "name": "[dpdk-dev,1/2] power: add get capabilities API", "version": 1, "mbox": "https://patches.dpdk.org/series/17/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/40687/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/40687/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<radu.nicolau@intel.com>", "Received": [ "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 852B01B67C\n\tfor <dev@dpdk.org>; Wed, 6 Jun 2018 12:53:57 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Jun 2018 03:53:54 -0700", "from silpixa00383879.ir.intel.com (HELO\n\tsilpixa00383879.ger.corp.intel.com) ([10.237.223.127])\n\tby orsmga001.jf.intel.com with ESMTP; 06 Jun 2018 03:53:52 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,483,1520924400\"; d=\"scan'208\";a=\"62245971\"", "From": "Radu Nicolau <radu.nicolau@intel.com>", "To": "dev@dpdk.org", "Cc": "david.hunt@intel.com, chris.macnamara@intel.com,\n\tmichael.j.glynn@intel.com, Radu Nicolau <radu.nicolau@intel.com>", "Date": "Wed, 6 Jun 2018 11:47:20 +0100", "Message-Id": "<1528282041-20380-1-git-send-email-radu.nicolau@intel.com>", "X-Mailer": "git-send-email 2.7.5", "Subject": "[dpdk-dev] [PATCH 1/2] power: add get capabilities API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 06 Jun 2018 10:53:58 -0000" }, "content": "New API added, rte_power_get_capabilities(), that allows the\napplication to query the power and performance capabilities\nof the CPU cores.\n\nSigned-off-by: Radu Nicolau <radu.nicolau@intel.com>\n---\n lib/librte_power/power_acpi_cpufreq.c | 21 +++++++++++++++++\n lib/librte_power/power_acpi_cpufreq.h | 17 ++++++++++++++\n lib/librte_power/power_kvm_vm.c | 8 +++++++\n lib/librte_power/power_kvm_vm.h | 17 ++++++++++++++\n lib/librte_power/rte_power.c | 3 +++\n lib/librte_power/rte_power.h | 33 ++++++++++++++++++++++++++\n lib/librte_power/rte_power_version.map | 7 ++++++\n test/test/test_power_acpi_cpufreq.c | 43 ++++++++++++++++++++++++++++++++++\n 8 files changed, 149 insertions(+)", "diff": "diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c\nindex bce933e..cd5978d 100644\n--- a/lib/librte_power/power_acpi_cpufreq.c\n+++ b/lib/librte_power/power_acpi_cpufreq.c\n@@ -623,3 +623,24 @@ power_acpi_disable_turbo(unsigned int lcore_id)\n \n \treturn 0;\n }\n+\n+int power_acpi_get_capabilities(unsigned int lcore_id,\n+\t\tstruct rte_power_core_capabilities *caps)\n+{\n+\tstruct rte_power_info *pi;\n+\n+\tif (lcore_id >= RTE_MAX_LCORE) {\n+\t\tRTE_LOG(ERR, POWER, \"Invalid lcore ID\\n\");\n+\t\treturn -1;\n+\t}\n+\tif (caps == NULL) {\n+\t\tRTE_LOG(ERR, POWER, \"Invalid argument\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tpi = &lcore_power_info[lcore_id];\n+\tcaps->capabilities = 0;\n+\tcaps->turbo = !!(pi->turbo_available);\n+\n+\treturn 0;\n+}\ndiff --git a/lib/librte_power/power_acpi_cpufreq.h b/lib/librte_power/power_acpi_cpufreq.h\nindex edeeb27..77701a9 100644\n--- a/lib/librte_power/power_acpi_cpufreq.h\n+++ b/lib/librte_power/power_acpi_cpufreq.h\n@@ -14,6 +14,7 @@\n #include <rte_byteorder.h>\n #include <rte_log.h>\n #include <rte_string_fns.h>\n+#include \"rte_power.h\"\n \n #ifdef __cplusplus\n extern \"C\" {\n@@ -196,6 +197,22 @@ int power_acpi_enable_turbo(unsigned int lcore_id);\n */\n int power_acpi_disable_turbo(unsigned int lcore_id);\n \n+/**\n+ * Returns power capabilities for a specific lcore.\n+ *\n+ * @param lcore_id\n+ * lcore id.\n+ * @param caps\n+ * pointer to rte_power_core_capabilities object.\n+ *\n+ * @return\n+ * - 0 on success.\n+ * - Negative on error.\n+ */\n+int power_acpi_get_capabilities(unsigned int lcore_id,\n+\t\tstruct rte_power_core_capabilities *caps);\n+\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_power/power_kvm_vm.c b/lib/librte_power/power_kvm_vm.c\nindex 38e9066..20659b7 100644\n--- a/lib/librte_power/power_kvm_vm.c\n+++ b/lib/librte_power/power_kvm_vm.c\n@@ -124,3 +124,11 @@ power_kvm_vm_disable_turbo(unsigned int lcore_id)\n {\n \treturn send_msg(lcore_id, CPU_POWER_DISABLE_TURBO);\n }\n+\n+struct rte_power_core_capabilities;\n+int power_kvm_vm_get_capabilities(__rte_unused unsigned int lcore_id,\n+\t\t__rte_unused struct rte_power_core_capabilities *caps)\n+{\n+\tRTE_LOG(ERR, POWER, \"rte_power_get_capabilities is not implemented for Virtual Machine Power Management\\n\");\n+\treturn -ENOTSUP;\n+}\ndiff --git a/lib/librte_power/power_kvm_vm.h b/lib/librte_power/power_kvm_vm.h\nindex 446d699..94d4aa1 100644\n--- a/lib/librte_power/power_kvm_vm.h\n+++ b/lib/librte_power/power_kvm_vm.h\n@@ -14,6 +14,7 @@\n #include <rte_byteorder.h>\n #include <rte_log.h>\n #include <rte_string_fns.h>\n+#include \"rte_power.h\"\n \n #ifdef __cplusplus\n extern \"C\" {\n@@ -177,6 +178,22 @@ int power_kvm_vm_enable_turbo(unsigned int lcore_id);\n * - Negative on error.\n */\n int power_kvm_vm_disable_turbo(unsigned int lcore_id);\n+\n+/**\n+ * Returns power capabilities for a specific lcore.\n+ *\n+ * @param lcore_id\n+ * lcore id.\n+ * @param caps\n+ * pointer to rte_power_core_capabilities object.\n+ *\n+ * @return\n+ * - 0 on success.\n+ * - Negative on error.\n+ */\n+int power_kvm_vm_get_capabilities(unsigned int lcore_id,\n+\t\tstruct rte_power_core_capabilities *caps);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_power/rte_power.c b/lib/librte_power/rte_power.c\nindex 6c8fb40..208b791 100644\n--- a/lib/librte_power/rte_power.c\n+++ b/lib/librte_power/rte_power.c\n@@ -24,6 +24,7 @@ rte_power_freq_change_t rte_power_freq_min = NULL;\n rte_power_freq_change_t rte_power_turbo_status;\n rte_power_freq_change_t rte_power_freq_enable_turbo;\n rte_power_freq_change_t rte_power_freq_disable_turbo;\n+rte_power_get_capabilities_t rte_power_get_capabilities;\n \n int\n rte_power_set_env(enum power_management_env env)\n@@ -42,6 +43,7 @@ rte_power_set_env(enum power_management_env env)\n \t\trte_power_turbo_status = power_acpi_turbo_status;\n \t\trte_power_freq_enable_turbo = power_acpi_enable_turbo;\n \t\trte_power_freq_disable_turbo = power_acpi_disable_turbo;\n+\t\trte_power_get_capabilities = power_acpi_get_capabilities;\n \t} else if (env == PM_ENV_KVM_VM) {\n \t\trte_power_freqs = power_kvm_vm_freqs;\n \t\trte_power_get_freq = power_kvm_vm_get_freq;\n@@ -53,6 +55,7 @@ rte_power_set_env(enum power_management_env env)\n \t\trte_power_turbo_status = power_kvm_vm_turbo_status;\n \t\trte_power_freq_enable_turbo = power_kvm_vm_enable_turbo;\n \t\trte_power_freq_disable_turbo = power_kvm_vm_disable_turbo;\n+\t\trte_power_get_capabilities = power_kvm_vm_get_capabilities;\n \t} else {\n \t\tRTE_LOG(ERR, POWER, \"Invalid Power Management Environment(%d) set\\n\",\n \t\t\t\tenv);\ndiff --git a/lib/librte_power/rte_power.h b/lib/librte_power/rte_power.h\nindex b4b7357..0a34b6f 100644\n--- a/lib/librte_power/rte_power.h\n+++ b/lib/librte_power/rte_power.h\n@@ -247,6 +247,39 @@ extern rte_power_freq_change_t rte_power_freq_enable_turbo;\n */\n extern rte_power_freq_change_t rte_power_freq_disable_turbo;\n \n+/**\n+ * Power capabilities summary.\n+ */\n+struct rte_power_core_capabilities {\n+\tRTE_STD_C11\n+\tunion {\n+\t\tuint64_t capabilities;\n+\t\tRTE_STD_C11\n+\t\tstruct {\n+\t\t\tuint64_t turbo:1;\t/**< Turbo can be enabled. */\n+\t\t};\n+\t};\n+};\n+\n+/**\n+ * Returns power capabilities for a specific lcore.\n+ * Function pointer definition. Review each environments\n+ * specific documentation for usage.\n+ *\n+ * @param lcore_id\n+ * lcore id.\n+ * @param caps\n+ * pointer to rte_power_core_capabilities object.\n+ *\n+ * @return\n+ * - 0 on success.\n+ * - Negative on error.\n+ */\n+typedef int (*rte_power_get_capabilities_t)(unsigned int lcore_id,\n+\t\tstruct rte_power_core_capabilities *caps);\n+\n+extern rte_power_get_capabilities_t rte_power_get_capabilities;\n+\n \n #ifdef __cplusplus\n }\ndiff --git a/lib/librte_power/rte_power_version.map b/lib/librte_power/rte_power_version.map\nindex 96dc42e..1c577fe 100644\n--- a/lib/librte_power/rte_power_version.map\n+++ b/lib/librte_power/rte_power_version.map\n@@ -25,4 +25,11 @@ DPDK_17.11 {\n \trte_power_freq_enable_turbo;\n \trte_power_turbo_status;\n \n+} DPDK_2.0;\n+\n+DPDK_18.05 {\n+\tglobal:\n+\n+\trte_power_get_capabilities;\n+\n } DPDK_2.0;\n\\ No newline at end of file\ndiff --git a/test/test/test_power_acpi_cpufreq.c b/test/test/test_power_acpi_cpufreq.c\nindex 8da2dcc..89ee51e 100644\n--- a/test/test/test_power_acpi_cpufreq.c\n+++ b/test/test/test_power_acpi_cpufreq.c\n@@ -18,6 +18,12 @@ test_power_acpi_cpufreq(void)\n \tprintf(\"Power management library not supported, skipping test\\n\");\n \treturn TEST_SKIPPED;\n }\n+static int\n+test_power_acpi_caps(void)\n+{\n+\tprintf(\"Power management library not supported, skipping test\\n\");\n+\treturn TEST_SKIPPED;\n+}\n \n #else\n #include <rte_power.h>\n@@ -517,6 +523,43 @@ test_power_acpi_cpufreq(void)\n \trte_power_unset_env();\n \treturn -1;\n }\n+\n+static int\n+test_power_acpi_caps(void)\n+{\n+\tstruct rte_power_core_capabilities caps;\n+\tint ret;\n+\n+\tret = rte_power_set_env(PM_ENV_ACPI_CPUFREQ);\n+\tif (ret) {\n+\t\tprintf(\"Error setting ACPI environment\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tret = rte_power_init(TEST_POWER_LCORE_ID);\n+\tif (ret < 0) {\n+\t\tprintf(\"Cannot initialise power management for lcore %u, this \"\n+\t\t\t\t\"may occur if environment is not configured \"\n+\t\t\t\t\"correctly(APCI cpufreq) or operating in another valid \"\n+\t\t\t\t\"Power management environment\\n\", TEST_POWER_LCORE_ID);\n+\t\trte_power_unset_env();\n+\t\treturn -1;\n+\t}\n+\n+\tret = rte_power_get_capabilities(TEST_POWER_LCORE_ID, &caps);\n+\tif (ret) {\n+\t\tprintf(\"ACPI: Error getting capabilities\\n\");\n+\t\treturn -1;\n+\t} else {\n+\t\tprintf(\"ACPI: Capabilities %lx\\n\", caps.capabilities);\n+\t}\n+\n+\n+\trte_power_unset_env();\n+\treturn 0;\n+}\n+\n #endif\n \n REGISTER_TEST_COMMAND(power_acpi_cpufreq_autotest, test_power_acpi_cpufreq);\n+REGISTER_TEST_COMMAND(power_acpi_caps_autotest, test_power_acpi_caps);\n", "prefixes": [ "dpdk-dev", "1/2" ] }