Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40238/?format=api
{ "id": 40238, "url": "https://patches.dpdk.org/api/patches/40238/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1526845978-19222-1-git-send-email-rami.rosen@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1526845978-19222-1-git-send-email-rami.rosen@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1526845978-19222-1-git-send-email-rami.rosen@intel.com", "date": "2018-05-20T19:52:58", "name": "[dpdk-dev] pci: remove unused function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7d872e90c8dd0c6b1f92bd778337ac506d784587", "submitter": { "id": 436, "url": "https://patches.dpdk.org/api/people/436/?format=api", "name": "Rami Rosen", "email": "rami.rosen@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1526845978-19222-1-git-send-email-rami.rosen@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/40238/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/40238/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0259B8DB2;\n\tSun, 20 May 2018 21:53:06 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 5DB978DAB\n\tfor <dev@dpdk.org>; Sun, 20 May 2018 21:53:04 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 May 2018 12:53:03 -0700", "from imail001.iil.intel.com ([10.184.207.12])\n\tby orsmga003.jf.intel.com with ESMTP; 20 May 2018 12:53:01 -0700", "from rr.iil.intel.com (rr.iil.intel.com [143.185.141.70])\n\tby imail001.iil.intel.com with ESMTP id w4KJqmBV011125;\n\tSun, 20 May 2018 22:52:48 +0300" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,423,1520924400\"; d=\"scan'208\";a=\"52394171\"", "From": "Rami Rosen <rami.rosen@intel.com>", "To": "dev@dpdk.org", "Cc": "Rami Rosen <rami.rosen@intel.com>", "Date": "Sun, 20 May 2018 22:52:58 +0300", "Message-Id": "<1526845978-19222-1-git-send-email-rami.rosen@intel.com>", "X-Mailer": "git-send-email 1.9.1", "Subject": "[dpdk-dev] [PATCH] pci: remove unused function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function rte_pci_detach() is private to PCI and is\nnot used anywhere in current code base. Remove dead code.\n\nSigned-off-by: Rami Rosen <rami.rosen@intel.com>\n---\n drivers/bus/pci/pci_common.c | 36 ------------------------------------\n drivers/bus/pci/private.h | 14 --------------\n 2 files changed, 50 deletions(-)", "diff": "diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c\nindex 7215aae..e6d2c1c 100644\n--- a/drivers/bus/pci/pci_common.c\n+++ b/drivers/bus/pci/pci_common.c\n@@ -292,42 +292,6 @@ static struct rte_devargs *pci_devargs_lookup(struct rte_pci_device *dev)\n \treturn -1;\n }\n \n-/*\n- * Detach device specified by its pci address.\n- */\n-int\n-rte_pci_detach(const struct rte_pci_addr *addr)\n-{\n-\tstruct rte_pci_device *dev = NULL;\n-\tint ret = 0;\n-\n-\tif (addr == NULL)\n-\t\treturn -1;\n-\n-\tFOREACH_DEVICE_ON_PCIBUS(dev) {\n-\t\tif (rte_pci_addr_cmp(&dev->addr, addr))\n-\t\t\tcontinue;\n-\n-\t\tret = rte_pci_detach_dev(dev);\n-\t\tif (ret < 0)\n-\t\t\t/* negative value is an error */\n-\t\t\tgoto err_return;\n-\t\tif (ret > 0)\n-\t\t\t/* positive value means driver doesn't support it */\n-\t\t\tcontinue;\n-\n-\t\trte_pci_remove_device(dev);\n-\t\tfree(dev);\n-\t\treturn 0;\n-\t}\n-\treturn -1;\n-\n-err_return:\n-\tRTE_LOG(WARNING, EAL, \"Requested device \" PCI_PRI_FMT\n-\t\t\t\" cannot be used\\n\", dev->addr.domain, dev->addr.bus,\n-\t\t\tdev->addr.devid, dev->addr.function);\n-\treturn -1;\n-}\n \n /*\n * Scan the content of the PCI bus, and call the probe() function for\ndiff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h\nindex 88fa587..63bd876 100644\n--- a/drivers/bus/pci/private.h\n+++ b/drivers/bus/pci/private.h\n@@ -47,20 +47,6 @@\n */\n int rte_pci_probe_one(const struct rte_pci_addr *addr);\n \n-/**\n- * Close the single PCI device.\n- *\n- * Scan the content of the PCI bus, and find the pci device specified by pci\n- * address, then call the remove() function for registered driver that has a\n- * matching entry in its id_table for discovered device.\n- *\n- * @param addr\n- *\tThe PCI Bus-Device-Function address to close.\n- * @return\n- * - 0 on success.\n- * - Negative on error.\n- */\n-int rte_pci_detach(const struct rte_pci_addr *addr);\n \n /**\n * Find the name of a PCI device.\n", "prefixes": [ "dpdk-dev" ] }