Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 4012,
    "url": "https://patches.dpdk.org/api/patches/4012/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1426214303-12207-1-git-send-email-yong.liu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1426214303-12207-1-git-send-email-yong.liu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1426214303-12207-1-git-send-email-yong.liu@intel.com",
    "date": "2015-03-13T02:38:23",
    "name": "[dpdk-dev] app/testpmd: Fix not set need_reconfig flag when port id is RTE_PORT_ALL",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "d1ca02e83d6b35b21ca8c911f7a99cbb627e3012",
    "submitter": {
        "id": 17,
        "url": "https://patches.dpdk.org/api/people/17/?format=api",
        "name": "Marvin Liu",
        "email": "yong.liu@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1426214303-12207-1-git-send-email-yong.liu@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/4012/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/4012/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id DF033594E;\n\tFri, 13 Mar 2015 03:38:33 +0100 (CET)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id CDE165938\n\tfor <dev@dpdk.org>; Fri, 13 Mar 2015 03:38:31 +0100 (CET)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga101.jf.intel.com with ESMTP; 12 Mar 2015 19:38:30 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 12 Mar 2015 19:38:29 -0700",
            "from shecgisg003.sh.intel.com (shecgisg003.sh.intel.com\n\t[10.239.29.90])\n\tby shvmail01.sh.intel.com with ESMTP id t2D2cRuJ002163;\n\tFri, 13 Mar 2015 10:38:27 +0800",
            "from shecgisg003.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t2D2cOZ2012244; Fri, 13 Mar 2015 10:38:26 +0800",
            "(from yliu84x@localhost)\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/Submit) id t2D2cOxG012240; \n\tFri, 13 Mar 2015 10:38:24 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.11,392,1422950400\"; d=\"scan'208\";a=\"679461866\"",
        "From": "Yong Liu <yong.liu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri, 13 Mar 2015 10:38:23 +0800",
        "Message-Id": "<1426214303-12207-1-git-send-email-yong.liu@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "Subject": "[dpdk-dev] [PATCH] app/testpmd: Fix not set need_reconfig flag when\n\tport id is RTE_PORT_ALL",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When port id is RTE_PORT_ALL, port_id_is_invalid will also return zero.\nSo this function will only set ports[255] need_reconfig flag, other ports will\nbe skipped.\n\nSigned-off-by: Marvin liu <yong.liu@intel.com>",
    "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 5b16a69..077d7a4 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -8874,14 +8874,7 @@ prompt(void)\n static void\n cmd_reconfig_device_queue(portid_t id, uint8_t dev, uint8_t queue)\n {\n-\tif (!port_id_is_invalid(id, DISABLED_WARN)) {\n-\t\t/* check if need_reconfig has been set to 1 */\n-\t\tif (ports[id].need_reconfig == 0)\n-\t\t\tports[id].need_reconfig = dev;\n-\t\t/* check if need_reconfig_queues has been set to 1 */\n-\t\tif (ports[id].need_reconfig_queues == 0)\n-\t\t\tports[id].need_reconfig_queues = queue;\n-\t} else {\n+\tif (id == (portid_t)RTE_PORT_ALL) {\n \t\tportid_t pid;\n \n \t\tFOREACH_PORT(pid, ports) {\n@@ -8892,6 +8885,13 @@ cmd_reconfig_device_queue(portid_t id, uint8_t dev, uint8_t queue)\n \t\t\tif (ports[pid].need_reconfig_queues == 0)\n \t\t\t\tports[pid].need_reconfig_queues = queue;\n \t\t}\n+\t} else if (!port_id_is_invalid(id, DISABLED_WARN)) {\n+\t\t/* check if need_reconfig has been set to 1 */\n+\t\tif (ports[id].need_reconfig == 0)\n+\t\t\tports[id].need_reconfig = dev;\n+\t\t/* check if need_reconfig_queues has been set to 1 */\n+\t\tif (ports[id].need_reconfig_queues == 0)\n+\t\t\tports[id].need_reconfig_queues = queue;\n \t}\n }\n \n",
    "prefixes": [
        "dpdk-dev"
    ]
}