List comments

GET /api/patches/4/comments/?order=id
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 715,
        "web_url": "https://patches.dpdk.org/comment/715/",
        "msgid": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A78D4F8@SHSMSX104.ccr.corp.intel.com>",
        "date": "2014-09-10T01:28:55",
        "subject": "Re: [dpdk-dev] [PATCH] igb_ethdev.c: complete switches for i211 NC",
        "submitter": {
            "id": 14,
            "url": "https://patches.dpdk.org/api/people/14/",
            "name": "Helin Zhang",
            "email": "helin.zhang@intel.com"
        },
        "content": "> -----Original Message-----\n> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergey Mironov\n> Sent: Thursday, September 4, 2014 4:35 PM\n> To: dev@dpdk.org\n> Subject: [dpdk-dev] [PATCH] igb_ethdev.c: complete switches for i211 NC\n> \n> Hi! I have got an update for my \"i212 problem\". First of all, I found that I have\n> made a mistake. My controller is named i211, not i212 :) Next, i211 controller is\n> controlled by the lib_pmd_e1000 driver.\n> Unfortunately, looks like it's support is pure. For example, igb_ethdev.c\n> contains function eth_igb_infos_get() which should set number of tx/rx queues\n> supported by the hardware. It contains huge [switch] but there is no i211 case!\n> That is why I see zeros every time I try to start this NC. Also, there are few\n> other places which mention i210, but not mention i211. I've attached a patch\n> which adds necessary\n> i211 support, but I didn't check it enough to say it is totally correct. For now I\n> see that it just able to send and receive some packets.\n> \n> Could you please review/correct it?\n> ---\n>  lib/librte_pmd_e1000/igb_ethdev.c | 11 +++++++++--\n>  1 file changed, 9 insertions(+), 2 deletions(-)\n> \n> diff --git a/lib/librte_pmd_e1000/igb_ethdev.c\n> b/lib/librte_pmd_e1000/igb_ethdev.c\n> index f93a460..23e638d 100644\n> --- a/lib/librte_pmd_e1000/igb_ethdev.c\n> +++ b/lib/librte_pmd_e1000/igb_ethdev.c\n> @@ -689,7 +689,8 @@ eth_igb_start(struct rte_eth_dev *dev)\n>  \t * value of Write-Back Threshold registers.\n>  \t */\n>  \tif ((hw->mac.type == e1000_82576) || (hw->mac.type == e1000_82580) ||\n> -\t\t(hw->mac.type == e1000_i350) || (hw->mac.type == e1000_i210)) {\n> +\t\t(hw->mac.type == e1000_i350) || (hw->mac.type == e1000_i210) ||\n> +    (hw->mac.type == e1000_i211)) {\n>  \t\tuint32_t ivar;\n> \n>  \t\t/* Enable all RX & TX queues in the IVAR registers */ @@ -837,7\n> +838,7 @@ igb_get_rx_buffer_size(struct e1000_hw *hw)\n>  \t\trx_buf_size = (E1000_READ_REG(hw, E1000_RXPBS) & 0xf);\n>  \t\trx_buf_size = (uint32_t) e1000_rxpbs_adjust_82580(rx_buf_size);\n>  \t\trx_buf_size = (rx_buf_size << 10);\n> -\t} else if (hw->mac.type == e1000_i210) {\n> +\t} else if (hw->mac.type == e1000_i210 || hw->mac.type == e1000_i211) {\n>  \t\trx_buf_size = (E1000_READ_REG(hw, E1000_RXPBS) & 0x3f) << 10;\n>  \t} else {\n>  \t\trx_buf_size = (E1000_READ_REG(hw, E1000_PBA) & 0xffff) << 10;\n> @@ -1179,6 +1180,12 @@ eth_igb_infos_get(struct rte_eth_dev *dev,\n>  \t\tdev_info->max_vmdq_pools = 0;\n>  \t\tbreak;\n> \n> +\tcase e1000_i211:\n> +\t\tdev_info->max_rx_queues = 2;\n> +\t\tdev_info->max_tx_queues = 2;\n> +\t\tdev_info->max_vmdq_pools = 0;\n> +\t\tbreak;\n> +\n>  \tcase e1000_vfadapt:\n>  \t\tdev_info->max_rx_queues = 2;\n>  \t\tdev_info->max_tx_queues = 2;\n> --\n> 1.8.4.3\n\n\nReviewed-by: Helin Zhang <helin.zhang@intel.com>\n\nReally good to have this patch of supporting i211! Thank you very much!\n\nRegards,\nHelin",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "X-MS-TNEF-Correlator": "",
            "X-ExtLoop1": "1",
            "Thread-Topic": "[dpdk-dev] [PATCH] igb_ethdev.c: complete switches for i211 NC",
            "x-originating-ip": "[10.239.127.40]",
            "Received": [
                "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B45CD68A7;\n\tWed, 10 Sep 2014 03:24:02 +0200 (CEST)",
                "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id CC10B688C\n\tfor <dev@dpdk.org>; Wed, 10 Sep 2014 03:24:00 +0200 (CEST)",
                "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 09 Sep 2014 18:29:06 -0700",
                "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n\tby fmsmga001.fm.intel.com with ESMTP; 09 Sep 2014 18:29:05 -0700",
                "from fmsmsx114.amr.corp.intel.com (10.18.116.8) by\n\tFMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Tue, 9 Sep 2014 18:29:01 -0700",
                "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n\tFMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server\n\t(TLS) id 14.3.195.1; Tue, 9 Sep 2014 18:29:00 -0700",
                "from shsmsx104.ccr.corp.intel.com ([169.254.5.230]) by\n\tshsmsx102.ccr.corp.intel.com ([169.254.2.192]) with mapi id\n\t14.03.0195.001; Wed, 10 Sep 2014 09:28:56 +0800"
            ],
            "References": "<1409819711-18718-1-git-send-email-grrwlf@gmail.com>",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "MIME-Version": "1.0",
            "Message-ID": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A78D4F8@SHSMSX104.ccr.corp.intel.com>",
            "Accept-Language": "en-US",
            "Thread-Index": "AQHPyBtJCF2a513oLk+MfPnjPBt4V5v5nKxA",
            "X-IronPort-AV": "E=Sophos;i=\"5.04,494,1406617200\"; d=\"scan'208\";a=\"588921919\"",
            "Content-Language": "en-US",
            "Content-Transfer-Encoding": "quoted-printable",
            "From": "\"Zhang, Helin\" <helin.zhang@intel.com>",
            "X-Original-To": "patchwork@dpdk.org",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-MS-Has-Attach": "",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<1409819711-18718-1-git-send-email-grrwlf@gmail.com>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "To": "Sergey Mironov <grrwlf@gmail.com>, \"dev@dpdk.org\" <dev@dpdk.org>",
            "Precedence": "list",
            "Delivered-To": "patchwork@dpdk.org",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Errors-To": "dev-bounces@dpdk.org",
            "X-BeenThere": "dev@dpdk.org",
            "Subject": "Re: [dpdk-dev] [PATCH] igb_ethdev.c: complete switches for i211 NC",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "Date": "Wed, 10 Sep 2014 01:28:55 +0000"
        }
    },
    {
        "id": 974,
        "web_url": "https://patches.dpdk.org/comment/974/",
        "msgid": "<2088737.Lh69b6AKpB@xps13>",
        "date": "2014-09-24T17:38:29",
        "subject": "Re: [dpdk-dev] [PATCH] igb_ethdev.c: complete switches for i211 NC",
        "submitter": {
            "id": 1,
            "url": "https://patches.dpdk.org/api/people/1/",
            "name": "Thomas Monjalon",
            "email": "thomas.monjalon@6wind.com"
        },
        "content": "2014-09-10 01:28, Zhang, Helin:\n> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergey Mironov\n> > Hi! I have got an update for my \"i212 problem\". First of all, I found that I have\n> > made a mistake. My controller is named i211, not i212 :) Next, i211 controller is\n> > controlled by the lib_pmd_e1000 driver.\n> > Unfortunately, looks like it's support is pure. For example, igb_ethdev.c\n> > contains function eth_igb_infos_get() which should set number of tx/rx queues\n> > supported by the hardware. It contains huge [switch] but there is no i211 case!\n> > That is why I see zeros every time I try to start this NC. Also, there are few\n> > other places which mention i210, but not mention i211. I've attached a patch\n> > which adds necessary\n> > i211 support, but I didn't check it enough to say it is totally correct. For now I\n> > see that it just able to send and receive some packets.\n> > \n> > Could you please review/correct it?\n\nThe funny thing is that the file igb_rxtx.c seems to already support i211,\nbut not igb_ethdev.c. Thanks for fixing that.\n\n> >  \tif ((hw->mac.type == e1000_82576) || (hw->mac.type == e1000_82580) ||\n> > -\t\t(hw->mac.type == e1000_i350) || (hw->mac.type == e1000_i210)) {\n> > +\t\t(hw->mac.type == e1000_i350) || (hw->mac.type == e1000_i210) ||\n> > +    (hw->mac.type == e1000_i211)) {\n\nWrong indent here.\n\n> Reviewed-by: Helin Zhang <helin.zhang@intel.com>\n> \n> Really good to have this patch of supporting i211! Thank you very much!\n\nAcked and applied with indent fix.\n\nThanks",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "Date": "Wed, 24 Sep 2014 19:38:29 +0200",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "In-Reply-To": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A78D4F8@SHSMSX104.ccr.corp.intel.com>",
            "Errors-To": "dev-bounces@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AE754137D;\n\tWed, 24 Sep 2014 19:32:24 +0200 (CEST)",
                "from mail-we0-f174.google.com (mail-we0-f174.google.com\n\t[74.125.82.174]) by dpdk.org (Postfix) with ESMTP id 8D73E1F5\n\tfor <dev@dpdk.org>; Wed, 24 Sep 2014 19:32:23 +0200 (CEST)",
                "by mail-we0-f174.google.com with SMTP id w62so6183614wes.33\n\tfor <dev@dpdk.org>; Wed, 24 Sep 2014 10:38:37 -0700 (PDT)",
                "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tet1sm20142869wjd.11.2014.09.24.10.38.36 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 24 Sep 2014 10:38:36 -0700 (PDT)"
            ],
            "References": "<1409819711-18718-1-git-send-email-grrwlf@gmail.com>\n\t<F35DEAC7BCE34641BA9FAC6BCA4A12E70A78D4F8@SHSMSX104.ccr.corp.intel.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "MIME-Version": "1.0",
            "X-Received": "by 10.180.206.230 with SMTP id lr6mr13434665wic.82.1411580317482;\n\tWed, 24 Sep 2014 10:38:37 -0700 (PDT)",
            "Message-ID": "<2088737.Lh69b6AKpB@xps13>",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=w8089YGmjIeINS5Hd7SPngXvUDXx0mNwCmqEOyNZo0Y=;\n\tb=A6yUcUn9s5naxAppFSvVJlCkNxDwjf3BV94Zn+2S+hHNXpr+7llrVGq5t03OIRndya\n\tD2OENI3m6VJW+rHlx+TKea3hwy30y+CeVrtp2XbUNGMf0z3Dg9lRT62Dlt99+evVDxE+\n\t8NhRTXOSOLzTfP/5BVLZFd1oQu66SRoNj5p9nsTyKoRh3GiGEf/HNUNQ238vGa9sqj0B\n\tSnnkhxq3tkkloWMUr4VVFgs4xydUqzMrstO3gN1XvsMSJ6t7MOuh+EmCuwilMVMtPx6d\n\tqpZNEOoDA0HRHQ7WQ5xrxIPNv2X07RrpZqvxgwzW8K8jDiTN1HnXJD9BWVZnr48uPMS3\n\tsIBQ==",
            "Delivered-To": "patchwork@dpdk.org",
            "Content-Transfer-Encoding": "7Bit",
            "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "X-Original-To": "patchwork@dpdk.org",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "Organization": "6WIND",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )",
            "List-Post": "<mailto:dev@dpdk.org>",
            "To": "Sergey Mironov <grrwlf@gmail.com>",
            "Precedence": "list",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-BeenThere": "dev@dpdk.org",
            "X-Gm-Message-State": "ALoCoQkouX0rNGQm/sWwEIeBErEJ/UCqh19p9Vka+FQQi00OVOUDRpjU79XuVyDAcoGuv9/wtea4",
            "Cc": "dev@dpdk.org",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "Subject": "Re: [dpdk-dev] [PATCH] igb_ethdev.c: complete switches for i211 NC"
        }
    }
]