Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 39905,
    "url": "https://patches.dpdk.org/api/patches/39905/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/152609037252.121661.1483829650676418151.stgit@localhost.localdomain/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<152609037252.121661.1483829650676418151.stgit@localhost.localdomain>",
    "list_archive_url": "https://inbox.dpdk.org/dev/152609037252.121661.1483829650676418151.stgit@localhost.localdomain",
    "date": "2018-05-12T01:59:32",
    "name": "[dpdk-dev,v3,10/24] rte_dev.h: stack declaration at top of own basic block",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "cb621674e85fb1902eca032d61ee27af02897a1e",
    "submitter": {
        "id": 1029,
        "url": "https://patches.dpdk.org/api/people/1029/?format=api",
        "name": "Andy Green",
        "email": "andy@warmcat.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/152609037252.121661.1483829650676418151.stgit@localhost.localdomain/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/39905/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/39905/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 719551CCA4;\n\tSat, 12 May 2018 03:59:37 +0200 (CEST)",
            "from mail.warmcat.com (mail.warmcat.com [163.172.24.82])\n\tby dpdk.org (Postfix) with ESMTP id 33EC91C761\n\tfor <dev@dpdk.org>; Sat, 12 May 2018 03:59:36 +0200 (CEST)"
        ],
        "From": "Andy Green <andy@warmcat.com>",
        "To": "dev@dpdk.org",
        "Date": "Sat, 12 May 2018 09:59:32 +0800",
        "Message-ID": "<152609037252.121661.1483829650676418151.stgit@localhost.localdomain>",
        "In-Reply-To": "<152609021699.121661.5295227351721865436.stgit@localhost.localdomain>",
        "References": "<152609021699.121661.5295227351721865436.stgit@localhost.localdomain>",
        "User-Agent": "StGit/unknown-version",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "Content-Transfer-Encoding": "7bit",
        "Subject": "[dpdk-dev] [PATCH v3 10/24] rte_dev.h: stack declaration at top of\n\town basic block",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "/projects/lagopus/src/dpdk/build/include/rte_dev.h:54:2:\nwarning: ISO C90 forbids mixed declarations and\ncode [-Wdeclaration-after-statement]\n  char buffer[vsnprintf(NULL, 0, fmt, ap) + 1];\n\nSigned-off-by: Andy Green <andy@warmcat.com>\n---\n lib/librte_eal/common/include/rte_dev.h |   15 +++++++++------\n 1 file changed, 9 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h\nindex 0955e9adb..3879ff3ca 100644\n--- a/lib/librte_eal/common/include/rte_dev.h\n+++ b/lib/librte_eal/common/include/rte_dev.h\n@@ -51,15 +51,18 @@ rte_pmd_debug_trace(const char *func_name, const char *fmt, ...)\n \n \tva_start(ap, fmt);\n \n-\tchar buffer[vsnprintf(NULL, 0, fmt, ap) + 1];\n+\t{\n+\t\tchar buffer[vsnprintf(NULL, 0, fmt, ap) + 1];\n \n-\tva_end(ap);\n+\t\tva_end(ap);\n \n-\tva_start(ap, fmt);\n-\tvsnprintf(buffer, sizeof(buffer), fmt, ap);\n-\tva_end(ap);\n+\t\tva_start(ap, fmt);\n+\t\tvsnprintf(buffer, sizeof(buffer), fmt, ap);\n+\t\tva_end(ap);\n \n-\trte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, \"%s: %s\", func_name, buffer);\n+\t\trte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, \"%s: %s\",\n+\t\t\tfunc_name, buffer);\n+\t}\n }\n \n /*\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "10/24"
    ]
}