Show a patch.

GET /api/patches/398/
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 398,
    "url": "https://patches.dpdk.org/api/patches/398/",
    "web_url": "https://patches.dpdk.org/patch/398/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk"
    },
    "msgid": "<1410961612-8571-2-git-send-email-david.marchand@6wind.com>",
    "date": "2014-09-17T13:46:33",
    "name": "[dpdk-dev,v3,01/20] ixgbe: use the right debug macro",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "c41f0cc9e354fe64c7909641f81c05c24781f680",
    "submitter": {
        "id": 3,
        "url": "https://patches.dpdk.org/api/people/3/",
        "name": "David Marchand",
        "email": "david.marchand@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/patch/398/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/398/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/398/checks/",
    "tags": {},
    "headers": {
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "X-Original-To": "patchwork@dpdk.org",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=VPnvhmw1xM5WiWwtVh/yKm4SmmD1U3StM11JHzD2+pE=;\n\tb=GlUAHPaT/DKkaxCiKw8LZTEq0lfcjEBA1Lq5YJdbVoZu7f++LUlNjFnkviYx8gHNDJ\n\tMFL9V2fzRpLoYzCRmnyDJIuHsncTyQMYuKf9NwpE6HDMjFbtm6yiWmZXErbSI4N1EHtP\n\tCazZVqs/87Qs+2z0aPXrKdAkQ0cJqocIRBSCEh8M+DSVoQ+yQEW4xiw6/+lrvYFkRbcd\n\tR5qKG5G2Q+ynXWi6UtPe6NLSmBPz/NluNzf5BxoQAZ46a1+vTPkGhcMnWaxE8kIKnwyG\n\tpkvWdABXeRM24m/Cs2cdHlmdumomKqbRw1USh+K4Vftm9X3RQj9DvmPzt8DEoT4PBKt1\n\thQ0A==",
        "In-Reply-To": "<1410961612-8571-1-git-send-email-david.marchand@6wind.com>",
        "Precedence": "list",
        "Date": "Wed, 17 Sep 2014 15:46:33 +0200",
        "References": "<1410961612-8571-1-git-send-email-david.marchand@6wind.com>",
        "X-Mailer": "git-send-email 1.7.10.4",
        "X-Gm-Message-State": "ALoCoQmvKQKJCFWN05J7cWjqGrW94WSIE78dptSqKByaTnR2XSKkS4FVUg5ULKzcKxrOFvG78xIX",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "To": "dev@dpdk.org",
        "Errors-To": "dev-bounces@dpdk.org",
        "X-BeenThere": "dev@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 19243B3A0;\n\tWed, 17 Sep 2014 15:41:23 +0200 (CEST)",
            "from mail-wi0-f181.google.com (mail-wi0-f181.google.com\n\t[209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 20B07B39B\n\tfor <dev@dpdk.org>; Wed, 17 Sep 2014 15:41:20 +0200 (CEST)",
            "by mail-wi0-f181.google.com with SMTP id bs8so1269241wib.2\n\tfor <dev@dpdk.org>; Wed, 17 Sep 2014 06:47:01 -0700 (PDT)",
            "from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tfa20sm5712872wic.1.2014.09.17.06.46.59 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 17 Sep 2014 06:47:00 -0700 (PDT)"
        ],
        "From": "David Marchand <david.marchand@6wind.com>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "Message-Id": "<1410961612-8571-2-git-send-email-david.marchand@6wind.com>",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "Subject": "[dpdk-dev] [PATCH v3 01/20] ixgbe: use the right debug macro",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "Return-Path": "<dev-bounces@dpdk.org>",
        "Delivered-To": "patchwork@dpdk.org",
        "X-Received": "by 10.194.58.41 with SMTP id n9mr2765285wjq.20.1410961621224;\n\tWed, 17 Sep 2014 06:47:01 -0700 (PDT)",
        "X-Mailman-Version": "2.1.15"
    },
    "content": "- We should not use DEBUGOUT*/DEBUGFUNC macros in non-shared code.\nThese macros come as compat wrappers for shared code.\n- We should avoid calling RTE_LOG directly as pmd provides a wrapper for logs.\n- Replace some PMD_INIT_LOG(DEBUG, \"some_func\") with PMD_INIT_FUNC_TRACE().\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\nv2 Reviewed-by: Jay Rolette <rolette@infiniteio.com>\nv2 Acked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c |   14 ++++----\n lib/librte_pmd_ixgbe/ixgbe_bypass.c       |   26 +++++++-------\n lib/librte_pmd_ixgbe/ixgbe_ethdev.c       |   37 ++++++++++----------\n lib/librte_pmd_ixgbe/ixgbe_pf.c           |    4 +--\n lib/librte_pmd_ixgbe/ixgbe_rxtx.c         |   53 +++++++++++++++--------------\n 5 files changed, 68 insertions(+), 66 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c\nindex 0f0000c..2623419 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c\n@@ -63,7 +63,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed)\n \t\trs = IXGBE_SFF_SOFT_RS_SELECT_1G;\n \t\tbreak;\n \tdefault:\n-\t\tDEBUGOUT(\"Invalid fixed module speed\\n\");\n+\t\tPMD_DRV_LOG(\"Invalid fixed module speed\");\n \t\treturn;\n \t}\n \n@@ -72,7 +72,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed)\n \t\t\t\t\t   IXGBE_I2C_EEPROM_DEV_ADDR2,\n \t\t\t\t\t   &eeprom_data);\n \tif (status) {\n-\t\tDEBUGOUT(\"Failed to read Rx Rate Select RS0\\n\");\n+\t\tPMD_DRV_LOG(\"Failed to read Rx Rate Select RS0\");\n \t\tgoto out;\n \t}\n \n@@ -82,7 +82,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed)\n \t\t\t\t\t    IXGBE_I2C_EEPROM_DEV_ADDR2,\n \t\t\t\t\t    eeprom_data);\n \tif (status) {\n-\t\tDEBUGOUT(\"Failed to write Rx Rate Select RS0\\n\");\n+\t\tPMD_DRV_LOG(\"Failed to write Rx Rate Select RS0\");\n \t\tgoto out;\n \t}\n \n@@ -91,7 +91,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed)\n \t\t\t\t\t   IXGBE_I2C_EEPROM_DEV_ADDR2,\n \t\t\t\t\t   &eeprom_data);\n \tif (status) {\n-\t\tDEBUGOUT(\"Failed to read Rx Rate Select RS1\\n\");\n+\t\tPMD_DRV_LOG(\"Failed to read Rx Rate Select RS1\");\n \t\tgoto out;\n \t}\n \n@@ -101,7 +101,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed)\n \t\t\t\t\t    IXGBE_I2C_EEPROM_DEV_ADDR2,\n \t\t\t\t\t    eeprom_data);\n \tif (status) {\n-\t\tDEBUGOUT(\"Failed to write Rx Rate Select RS1\\n\");\n+\t\tPMD_DRV_LOG(\"Failed to write Rx Rate Select RS1\");\n \t\tgoto out;\n \t}\n out:\n@@ -130,7 +130,7 @@ ixgbe_setup_mac_link_multispeed_fixed_fiber(struct ixgbe_hw *hw,\n \tbool link_up = false;\n \tbool negotiation;\n \n-\tDEBUGFUNC(\"\");\n+\tPMD_INIT_FUNC_TRACE();\n \n \t/* Mask off requested but non-supported speeds */\n \tstatus = ixgbe_get_link_capabilities(hw, &link_speed, &negotiation);\n@@ -261,7 +261,7 @@ ixgbe_bypass_get_media_type(struct ixgbe_hw *hw)\n {\n \tenum ixgbe_media_type media_type;\n \n-\tDEBUGFUNC(\"\");\n+\tPMD_INIT_FUNC_TRACE();\n \n \tif (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {\n \t\tmedia_type = ixgbe_media_type_fiber;\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_bypass.c b/lib/librte_pmd_ixgbe/ixgbe_bypass.c\nindex 1d21dc0..1a980b8 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_bypass.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_bypass.c\n@@ -40,20 +40,20 @@\n #define\tBYPASS_STATUS_OFF_MASK\t3\n \n /* Macros to check for invlaid function pointers. */\n-#define\tFUNC_PTR_OR_ERR_RET(func, retval) do {             \\\n-\tif ((func) == NULL) {                              \\\n-\t\tDEBUGOUT(\"%s:%d function not supported\\n\", \\\n-\t\t\t__func__, __LINE__);               \\\n-\t\treturn (retval);                           \\\n-\t}                                                  \\\n+#define\tFUNC_PTR_OR_ERR_RET(func, retval) do {              \\\n+\tif ((func) == NULL) {                               \\\n+\t\tPMD_DRV_LOG(\"%s:%d function not supported\", \\\n+\t\t\t    __func__, __LINE__);            \\\n+\t\treturn retval;                            \\\n+\t}                                                   \\\n } while(0)\n \n-#define\tFUNC_PTR_OR_RET(func) do {                         \\\n-\tif ((func) == NULL) {                              \\\n-\t\tDEBUGOUT(\"%s:%d function not supported\\n\", \\\n-\t\t\t__func__, __LINE__);               \\\n-\t\treturn;                                    \\\n-\t}                                                  \\\n+#define\tFUNC_PTR_OR_RET(func) do {                          \\\n+\tif ((func) == NULL) {                               \\\n+\t\tPMD_DRV_LOG(\"%s:%d function not supported\", \\\n+\t\t\t    __func__, __LINE__);            \\\n+\t\treturn;                                     \\\n+\t}                                                   \\\n } while(0)\n \n \n@@ -114,7 +114,7 @@ ixgbe_bypass_init(struct rte_eth_dev *dev)\n \t/* Only allow BYPASS ops on the first port */\n \tif (hw->device_id != IXGBE_DEV_ID_82599_BYPASS ||\n \t\t\thw->bus.func != 0) {\n-\t\tDEBUGOUT(\"bypass function is not supported on that device\\n\");\n+\t\tPMD_DRV_LOG(\"bypass function is not supported on that device\");\n \t\treturn;\n \t}\n \ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\nindex 59122a1..f914405 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\n@@ -667,7 +667,7 @@ ixgbe_swfw_lock_reset(struct ixgbe_hw *hw)\n \t */\n \tmask = IXGBE_GSSR_PHY0_SM << hw->bus.func;\n \tif (ixgbe_acquire_swfw_semaphore(hw, mask) < 0) {\n-\t\t   DEBUGOUT1(\"SWFW phy%d lock released\", hw->bus.func);\n+\t\tPMD_DRV_LOG(DEBUG, \"SWFW phy%d lock released\", hw->bus.func);\n \t}\n \tixgbe_release_swfw_semaphore(hw, mask);\n \n@@ -679,7 +679,7 @@ ixgbe_swfw_lock_reset(struct ixgbe_hw *hw)\n \t */\n \tmask = IXGBE_GSSR_EEP_SM | IXGBE_GSSR_MAC_CSR_SM | IXGBE_GSSR_SW_MNG_SM;\n \tif (ixgbe_acquire_swfw_semaphore(hw, mask) < 0) {\n-\t\t   DEBUGOUT(\"SWFW common locks released\");\n+\t\tPMD_DRV_LOG(DEBUG, \"SWFW common locks released\");\n \t}\n \tixgbe_release_swfw_semaphore(hw, mask);\n }\n@@ -933,7 +933,7 @@ eth_ixgbevf_dev_init(__attribute__((unused)) struct eth_driver *eth_drv,\n \t\tIXGBE_DEV_PRIVATE_TO_HWSTRIP_BITMAP(eth_dev->data->dev_private);\n \tstruct ether_addr *perm_addr = (struct ether_addr *) hw->mac.perm_addr;\n \n-\tPMD_INIT_LOG(DEBUG, \"eth_ixgbevf_dev_init\");\n+\tPMD_INIT_FUNC_TRACE();\n \n \teth_dev->dev_ops = &ixgbevf_eth_dev_ops;\n \teth_dev->rx_pkt_burst = &ixgbe_recv_pkts;\n@@ -1012,16 +1012,15 @@ eth_ixgbevf_dev_init(__attribute__((unused)) struct eth_driver *eth_drv,\n \t\t\teth_dev->data->mac_addrs = NULL;\n \t\t\treturn diag;\n \t\t}\n-\t\tRTE_LOG(INFO, PMD,\n-\t\t\t\"\\tVF MAC address not assigned by Host PF\\n\"\n-\t\t\t\"\\tAssign randomly generated MAC address \"\n-\t\t\t\"%02x:%02x:%02x:%02x:%02x:%02x\\n\",\n-\t\t\tperm_addr->addr_bytes[0],\n-\t\t\tperm_addr->addr_bytes[1],\n-\t\t\tperm_addr->addr_bytes[2],\n-\t\t\tperm_addr->addr_bytes[3],\n-\t\t\tperm_addr->addr_bytes[4],\n-\t\t\tperm_addr->addr_bytes[5]);\n+\t\tPMD_INIT_LOG(INFO, \"\\tVF MAC address not assigned by Host PF\");\n+\t\tPMD_INIT_LOG(INFO, \"\\tAssign randomly generated MAC address \"\n+\t\t\t     \"%02x:%02x:%02x:%02x:%02x:%02x\",\n+\t\t\t     perm_addr->addr_bytes[0],\n+\t\t\t     perm_addr->addr_bytes[1],\n+\t\t\t     perm_addr->addr_bytes[2],\n+\t\t\t     perm_addr->addr_bytes[3],\n+\t\t\t     perm_addr->addr_bytes[4],\n+\t\t\t     perm_addr->addr_bytes[5]);\n \t}\n \n \t/* Copy the permanent MAC address */\n@@ -1090,7 +1089,7 @@ rte_ixgbe_pmd_init(const char *name __rte_unused, const char *params __rte_unuse\n static int\n rte_ixgbevf_pmd_init(const char *name __rte_unused, const char *param __rte_unused)\n {\n-\tDEBUGFUNC(\"rte_ixgbevf_pmd_init\");\n+\tPMD_INIT_FUNC_TRACE();\n \n \trte_eth_driver_register(&rte_ixgbevf_pmd);\n \treturn (0);\n@@ -2515,7 +2514,7 @@ ixgbe_dcb_pfc_enable_generic(struct ixgbe_hw *hw,uint8_t tc_num)\n \t\tfccfg_reg |= IXGBE_FCCFG_TFCE_PRIORITY;\n \t\tbreak;\n \tdefault:\n-\t\tDEBUGOUT(\"Flow control param set incorrectly\\n\");\n+\t\tPMD_DRV_LOG(DEBUG, \"Flow control param set incorrectly\");\n \t\tret_val = IXGBE_ERR_CONFIG;\n \t\tgoto out;\n \t\tbreak;\n@@ -2765,7 +2764,7 @@ ixgbe_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n static void\n ixgbevf_intr_disable(struct ixgbe_hw *hw)\n {\n-\tPMD_INIT_LOG(DEBUG, \"ixgbevf_intr_disable\");\n+\tPMD_INIT_FUNC_TRACE();\n \n \t/* Clear interrupt mask to stop from interrupts being generated */\n \tIXGBE_WRITE_REG(hw, IXGBE_VTEIMC, IXGBE_VF_IRQ_CLEAR_MASK);\n@@ -2807,7 +2806,7 @@ ixgbevf_dev_start(struct rte_eth_dev *dev)\n \t\tIXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tint err, mask = 0;\n \n-\tPMD_INIT_LOG(DEBUG, \"ixgbevf_dev_start\");\n+\tPMD_INIT_FUNC_TRACE();\n \n \thw->mac.ops.reset_hw(hw);\n \n@@ -2842,7 +2841,7 @@ ixgbevf_dev_stop(struct rte_eth_dev *dev)\n {\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n-\tPMD_INIT_LOG(DEBUG, \"ixgbevf_dev_stop\");\n+\tPMD_INIT_FUNC_TRACE();\n \n \thw->adapter_stopped = TRUE;\n \tixgbe_stop_adapter(hw);\n@@ -2861,7 +2860,7 @@ ixgbevf_dev_close(struct rte_eth_dev *dev)\n {\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n-\tPMD_INIT_LOG(DEBUG, \"ixgbevf_dev_close\");\n+\tPMD_INIT_FUNC_TRACE();\n \n \tixgbe_reset_hw(hw);\n \ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c\nindex 170944d..59fb58b 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_pf.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c\n@@ -478,7 +478,7 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)\n \n \tretval = ixgbe_read_mbx(hw, msgbuf, mbx_size, vf);\n \tif (retval) {\n-\t\tRTE_LOG(ERR, PMD, \"Error mbx recv msg from VF %d\\n\", vf);\n+\t\tPMD_DRV_LOG(ERR, \"Error mbx recv msg from VF %d\", vf);\n \t\treturn retval;\n \t}\n \n@@ -511,7 +511,7 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)\n \t\tretval = ixgbe_vf_set_vlan(dev, vf, msgbuf);\n \t\tbreak;\n \tdefault:\n-\t\tRTE_LOG(DEBUG, PMD, \"Unhandled Msg %8.8x\\n\", (unsigned)  msgbuf[0]);\n+\t\tPMD_DRV_LOG(DEBUG, \"Unhandled Msg %8.8x\", (unsigned)msgbuf[0]);\n \t\tretval = IXGBE_ERR_MBX;\n \t\tbreak;\n \t}\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\nindex 575a014..765b4e0 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n@@ -1763,33 +1763,36 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \ttx_free_thresh = (uint16_t)((tx_conf->tx_free_thresh) ?\n \t\t\ttx_conf->tx_free_thresh : DEFAULT_TX_FREE_THRESH);\n \tif (tx_rs_thresh >= (nb_desc - 2)) {\n-\t\tRTE_LOG(ERR, PMD, \"tx_rs_thresh must be less than the number \"\n-\t\t\t\"of TX descriptors minus 2. (tx_rs_thresh=%u port=%d \"\n-\t\t\t\t\"queue=%d)\\n\", (unsigned int)tx_rs_thresh,\n-\t\t\t\t(int)dev->data->port_id, (int)queue_idx);\n+\t\tPMD_INIT_LOG(ERR, \"tx_rs_thresh must be less than the number \"\n+\t\t\t     \"of TX descriptors minus 2. (tx_rs_thresh=%u \"\n+\t\t\t     \"port=%d queue=%d)\", (unsigned int)tx_rs_thresh,\n+\t\t\t     (int)dev->data->port_id, (int)queue_idx);\n \t\treturn -(EINVAL);\n \t}\n \tif (tx_free_thresh >= (nb_desc - 3)) {\n-\t\tRTE_LOG(ERR, PMD, \"tx_rs_thresh must be less than the \"\n-\t\t\t\"tx_free_thresh must be less than the number of TX \"\n-\t\t\t\"descriptors minus 3. (tx_free_thresh=%u port=%d \"\n-\t\t\t\t\"queue=%d)\\n\", (unsigned int)tx_free_thresh,\n-\t\t\t\t(int)dev->data->port_id, (int)queue_idx);\n+\t\tPMD_INIT_LOG(ERR, \"tx_rs_thresh must be less than the \"\n+\t\t\t     \"tx_free_thresh must be less than the number of \"\n+\t\t\t     \"TX descriptors minus 3. (tx_free_thresh=%u \"\n+\t\t\t     \"port=%d queue=%d)\",\n+\t\t\t     (unsigned int)tx_free_thresh,\n+\t\t\t     (int)dev->data->port_id, (int)queue_idx);\n \t\treturn -(EINVAL);\n \t}\n \tif (tx_rs_thresh > tx_free_thresh) {\n-\t\tRTE_LOG(ERR, PMD, \"tx_rs_thresh must be less than or equal to \"\n-\t\t\t\"tx_free_thresh. (tx_free_thresh=%u tx_rs_thresh=%u \"\n-\t\t\t\"port=%d queue=%d)\\n\", (unsigned int)tx_free_thresh,\n-\t\t\t(unsigned int)tx_rs_thresh, (int)dev->data->port_id,\n-\t\t\t\t\t\t\t(int)queue_idx);\n+\t\tPMD_INIT_LOG(ERR, \"tx_rs_thresh must be less than or equal to \"\n+\t\t\t     \"tx_free_thresh. (tx_free_thresh=%u \"\n+\t\t\t     \"tx_rs_thresh=%u port=%d queue=%d)\",\n+\t\t\t     (unsigned int)tx_free_thresh,\n+\t\t\t     (unsigned int)tx_rs_thresh,\n+\t\t\t     (int)dev->data->port_id,\n+\t\t\t     (int)queue_idx);\n \t\treturn -(EINVAL);\n \t}\n \tif ((nb_desc % tx_rs_thresh) != 0) {\n-\t\tRTE_LOG(ERR, PMD, \"tx_rs_thresh must be a divisor of the \"\n-\t\t\t\"number of TX descriptors. (tx_rs_thresh=%u port=%d \"\n-\t\t\t\t\"queue=%d)\\n\", (unsigned int)tx_rs_thresh,\n-\t\t\t\t(int)dev->data->port_id, (int)queue_idx);\n+\t\tPMD_INIT_LOG(ERR, \"tx_rs_thresh must be a divisor of the \"\n+\t\t\t     \"number of TX descriptors. (tx_rs_thresh=%u \"\n+\t\t\t     \"port=%d queue=%d)\", (unsigned int)tx_rs_thresh,\n+\t\t\t     (int)dev->data->port_id, (int)queue_idx);\n \t\treturn -(EINVAL);\n \t}\n \n@@ -1800,10 +1803,10 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \t * accumulates WTHRESH descriptors.\n \t */\n \tif ((tx_rs_thresh > 1) && (tx_conf->tx_thresh.wthresh != 0)) {\n-\t\tRTE_LOG(ERR, PMD, \"TX WTHRESH must be set to 0 if \"\n-\t\t\t\"tx_rs_thresh is greater than 1. (tx_rs_thresh=%u \"\n-\t\t\t\"port=%d queue=%d)\\n\", (unsigned int)tx_rs_thresh,\n-\t\t\t\t(int)dev->data->port_id, (int)queue_idx);\n+\t\tPMD_INIT_LOG(ERR, \"TX WTHRESH must be set to 0 if \"\n+\t\t\t     \"tx_rs_thresh is greater than 1. (tx_rs_thresh=%u \"\n+\t\t\t     \"port=%d queue=%d)\", (unsigned int)tx_rs_thresh,\n+\t\t\t     (int)dev->data->port_id, (int)queue_idx);\n \t\treturn -(EINVAL);\n \t}\n \n@@ -3276,7 +3279,7 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)\n \t\t\tIXGBE_WRITE_REG(hw, IXGBE_MRQC, IXGBE_MRQC_VMDQRT8TCEN);\n \t\t\tbreak;\n \t\tdefault:\n-\t\t\tRTE_LOG(ERR, PMD, \"invalid pool number in IOV mode\\n\");\n+\t\t\tPMD_INIT_LOG(ERR, \"invalid pool number in IOV mode\");\n \t\t}\n \t}\n \n@@ -3329,7 +3332,7 @@ ixgbe_dev_mq_tx_configure(struct rte_eth_dev *dev)\n \t\t\tbreak;\n \t\tdefault:\n \t\t\tmtqc = IXGBE_MTQC_64Q_1PB;\n-\t\t\tRTE_LOG(ERR, PMD, \"invalid pool number in IOV mode\\n\");\n+\t\t\tPMD_INIT_LOG(ERR, \"invalid pool number in IOV mode\");\n \t\t}\n \t\tIXGBE_WRITE_REG(hw, IXGBE_MTQC, mtqc);\n \t}\n@@ -3592,7 +3595,7 @@ ixgbe_dev_tx_init(struct rte_eth_dev *dev)\n static inline void\n ixgbe_setup_loopback_link_82599(struct ixgbe_hw *hw)\n {\n-\tDEBUGFUNC(\"ixgbe_setup_loopback_link_82599\");\n+\tPMD_INIT_FUNC_TRACE();\n \n \tif (ixgbe_verify_lesm_fw_enabled_82599(hw)) {\n \t\tif (hw->mac.ops.acquire_swfw_sync(hw, IXGBE_GSSR_MAC_CSR_SM) !=\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "01/20"
    ]
}