Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/39764/?format=api
{ "id": 39764, "url": "https://patches.dpdk.org/api/patches/39764/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180510235836.1099-12-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180510235836.1099-12-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20180510235836.1099-12-thomas@monjalon.net", "date": "2018-05-10T23:58:36", "name": "[dpdk-dev,v3,11/11] ethdev: fix port removal notification timing", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4743adf8348cc20628b6f0f1adeebd712d3ad3bb", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180510235836.1099-12-thomas@monjalon.net/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/39764/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/39764/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 62C041BC69;\n\tFri, 11 May 2018 01:59:12 +0200 (CEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CCE5F1BBCF\n\tfor <dev@dpdk.org>; Fri, 11 May 2018 01:58:54 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 7C9A420DD3;\n\tThu, 10 May 2018 19:58:54 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Thu, 10 May 2018 19:58:54 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 9160DE4393;\n\tThu, 10 May 2018 19:58:53 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tcc:date:from:in-reply-to:message-id:references:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=H+LiDW/mkitAPc\n\tbZb9MjKfVuDVxzOFwCrzH7Lj5iKG8=; b=RjY5gS1QS795i6IrNJA8BB5VZO10/l\n\tLxRmcRUuYGFoFBdu+qMG9ikgt+s6tVwerHizgwp41wJ4+7tdbxNsKV1YA1GltLrq\n\tievXcNsO8DdipA1dCoL1VxCb+N1N/qwCo5s9opR5eHWBcIQblGTWlhfTroC7cgkx\n\tfwhiItziMmG1k=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:in-reply-to:message-id\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm2; bh=H+LiDW/mkitAPcbZb9MjKfVuDVxzOFwCrzH7Lj5iKG8=; b=RU8Qe0aI\n\tz84S/Q0oDw3bkhZidrCa5mfL5z+KVCbFLJmBOHT1ZV02mr8sOT1x47a8cpQZncdN\n\tKnSepnbGVbMLvsgiDytijFP+4tLerVbjvGRiDDjyC4raNOn8X2wze9SZK1HH3VPn\n\tFfF//O9HBmtndgquzVZ61f/Vvh+Mc9lTHRjfGXHf9ucGRIkB7Xs/q/p8MSb5DDCB\n\tFGNnYM4ns0uXFSGuuOJJDJjbPkEPfKHsJ4o6UrqfH2sM30TReBNxJJUyaaUThEVS\n\tevkvdXVYND46TX0NZhjwau3+lezO1JWNJh2VaBlVeT8tlHJol3tGTYWEw+0gg2u5\n\tgl5n+BAAy3mXuQ==" ], "X-ME-Sender": "<xms:vtz0WlZbZXHuyALi24Y6Jmg7E6J8iWMwBjR04UpR812geA2jwATKAg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "matan@mellanox.com, arybchenko@solarflare.com, stephen@networkplumber.org,\n\tferruh.yigit@intel.com", "Date": "Fri, 11 May 2018 01:58:36 +0200", "Message-Id": "<20180510235836.1099-12-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20180510235836.1099-1-thomas@monjalon.net>", "References": "<20180509094337.26112-1-thomas@monjalon.net>\n\t<20180510235836.1099-1-thomas@monjalon.net>", "Subject": "[dpdk-dev] [PATCH v3 11/11] ethdev: fix port removal notification\n\ttiming", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Matan Azrad <matan@mellanox.com>\n\nWhen an ethdev port is released, a destroy event is triggered to notify\nthe users about the released port.\n\nA bit before the destroy event is triggered, the port becomes invalid\nby changing its state to UNUSED and cleaning its data. Therefore, the\nport is invalid for the destroy event callback process and the users\nmay get a wrong information of the port.\n\nMove the destroy event emitting to be called before the port\ninvalidation.\n\nFixes: 133b54779aa1 (\"ethdev: fix port data reset timing\")\nFixes: 29aa41e36de7 (\"ethdev: add notifications for probing and removal\")\nCc: stable@dpdk.org\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\nAcked-by: Thomas Monjalon <thomas@monjalon.net>\nReviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>\nReviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_ethdev/rte_ethdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 54439cd64..3ddf3accb 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -366,6 +366,8 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)\n \n \trte_eth_dev_shared_data_prepare();\n \n+\t_rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_DESTROY, NULL);\n+\n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n \n \teth_dev->state = RTE_ETH_DEV_UNUSED;\n@@ -374,8 +376,6 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)\n \n \trte_spinlock_unlock(&rte_eth_dev_shared_data->ownership_lock);\n \n-\t_rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_DESTROY, NULL);\n-\n \treturn 0;\n }\n \n", "prefixes": [ "dpdk-dev", "v3", "11/11" ] }