Show a patch.

GET /api/patches/397/
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 397,
    "url": "https://patches.dpdk.org/api/patches/397/",
    "web_url": "https://patches.dpdk.org/patch/397/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk"
    },
    "msgid": "<1410948102-12740-3-git-send-email-bruce.richardson@intel.com>",
    "date": "2014-09-17T10:01:39",
    "name": "[dpdk-dev,2/5] ixgbe: add prefetch to improve slow-path tx perf",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "42ea264c2e05f86a01dfa1dea3930e6c5b5ffac7",
    "submitter": {
        "id": 20,
        "url": "https://patches.dpdk.org/api/people/20/",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/patch/397/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/397/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/397/checks/",
    "tags": {},
    "headers": {
        "Delivered-To": "patchwork@dpdk.org",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "X-Original-To": "patchwork@dpdk.org",
        "Date": "Wed, 17 Sep 2014 11:01:39 +0100",
        "In-Reply-To": "<1410948102-12740-1-git-send-email-bruce.richardson@intel.com>",
        "Precedence": "list",
        "X-BeenThere": "dev@dpdk.org",
        "References": "<1410948102-12740-1-git-send-email-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "To": "dev@dpdk.org",
        "Errors-To": "dev-bounces@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D2314B3A8;\n\tWed, 17 Sep 2014 11:57:05 +0200 (CEST)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id D15F4B39E\n\tfor <dev@dpdk.org>; Wed, 17 Sep 2014 11:57:02 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 17 Sep 2014 03:02:41 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 17 Sep 2014 03:01:43 -0700",
            "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ts8HA1giJ017171; Wed, 17 Sep 2014 11:01:42 +0100",
            "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id s8HA1grK015534;\n\tWed, 17 Sep 2014 11:01:42 +0100",
            "(from bricha3@localhost)\n\tby sivswdev02.ir.intel.com with  id s8HA1gtP015524;\n\tWed, 17 Sep 2014 11:01:42 +0100"
        ],
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "X-ExtLoop1": "1",
        "Message-Id": "<1410948102-12740-3-git-send-email-bruce.richardson@intel.com>",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "Subject": "[dpdk-dev] [PATCH 2/5] ixgbe: add prefetch to improve slow-path tx\n\tperf",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-IronPort-AV": "E=Sophos;i=\"5.04,540,1406617200\"; d=\"scan'208\";a=\"600872926\"",
        "List-Post": "<mailto:dev@dpdk.org>",
        "X-Mailman-Version": "2.1.15"
    },
    "content": "Make a small improvement to slow path TX performance by adding in a\nprefetch for the second mbuf cache line.\nAlso move assignment of l2/l3 length values only when needed.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\nindex 6f702b3..c0bb49f 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n@@ -565,25 +565,26 @@ ixgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\tixgbe_xmit_cleanup(txq);\n \t}\n \n+\trte_prefetch0(&txe->mbuf->pool);\n+\n \t/* TX loop */\n \tfor (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) {\n \t\tnew_ctx = 0;\n \t\ttx_pkt = *tx_pkts++;\n \t\tpkt_len = tx_pkt->pkt_len;\n \n-\t\tRTE_MBUF_PREFETCH_TO_FREE(txe->mbuf);\n-\n \t\t/*\n \t\t * Determine how many (if any) context descriptors\n \t\t * are needed for offload functionality.\n \t\t */\n \t\tol_flags = tx_pkt->ol_flags;\n-\t\tvlan_macip_lens.f.vlan_tci = tx_pkt->vlan_tci;\n-\t\tvlan_macip_lens.f.l2_l3_len = tx_pkt->l2_l3_len;\n \n \t\t/* If hardware offload required */\n \t\ttx_ol_req = ol_flags & PKT_TX_OFFLOAD_MASK;\n \t\tif (tx_ol_req) {\n+\t\t\tvlan_macip_lens.f.vlan_tci = tx_pkt->vlan_tci;\n+\t\t\tvlan_macip_lens.f.l2_l3_len = tx_pkt->l2_l3_len;\n+\n \t\t\t/* If new context need be built or reuse the exist ctx. */\n \t\t\tctx = what_advctx_update(txq, tx_ol_req,\n \t\t\t\tvlan_macip_lens.data);\n@@ -720,7 +721,7 @@ ixgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t\t    &txr[tx_id];\n \n \t\t\t\ttxn = &sw_ring[txe->next_id];\n-\t\t\t\tRTE_MBUF_PREFETCH_TO_FREE(txn->mbuf);\n+\t\t\t\trte_prefetch0(&txn->mbuf->pool);\n \n \t\t\t\tif (txe->mbuf != NULL) {\n \t\t\t\t\trte_pktmbuf_free_seg(txe->mbuf);\n@@ -749,6 +750,7 @@ ixgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\tdo {\n \t\t\ttxd = &txr[tx_id];\n \t\t\ttxn = &sw_ring[txe->next_id];\n+\t\t\trte_prefetch0(&txn->mbuf->pool);\n \n \t\t\tif (txe->mbuf != NULL)\n \t\t\t\trte_pktmbuf_free_seg(txe->mbuf);\n",
    "prefixes": [
        "dpdk-dev",
        "2/5"
    ]
}