Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/39461/?format=api
{ "id": 39461, "url": "https://patches.dpdk.org/api/patches/39461/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1525782363-426-1-git-send-email-ophirmu@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1525782363-426-1-git-send-email-ophirmu@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1525782363-426-1-git-send-email-ophirmu@mellanox.com", "date": "2018-05-08T12:26:03", "name": "[dpdk-dev,v2] net/mlx4: fix CRC stripping capability report", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c1347427ca4a9ccb317f52cb69b6e75f6251ce4c", "submitter": { "id": 793, "url": "https://patches.dpdk.org/api/people/793/?format=api", "name": "Ophir Munk", "email": "ophirmu@mellanox.com" }, "delegate": { "id": 6624, "url": "https://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1525782363-426-1-git-send-email-ophirmu@mellanox.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/39461/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/39461/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D6C697EE4;\n\tTue, 8 May 2018 14:26:15 +0200 (CEST)", "from EUR01-HE1-obe.outbound.protection.outlook.com\n\t(mail-he1eur01on0074.outbound.protection.outlook.com [104.47.0.74])\n\tby dpdk.org (Postfix) with ESMTP id E724F7D0E;\n\tTue, 8 May 2018 14:26:13 +0200 (CEST)", "from mellanox.com (37.142.13.130) by\n\tAM4PR0501MB2307.eurprd05.prod.outlook.com (2603:10a6:200:53::20) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.735.17;\n\tTue, 8 May 2018 12:26:11 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=WDo5ApWEgfNiyjJn0Vx1gof50Yx+LPX7HG9BWPdrkzY=;\n\tb=yUNem/TtUvNrHzMqeLSOzq/8k9uHjGut6F22IhaRSeZ5ILipHRda4L8pnz5gxDYPeJsM2S3SmuCM6t6OKxqzJVKUvb9dTuBhVPdCl1XePbVb2DN+uleHIZSncwrSMo4ERybPSkuim8ZPfNyF/r7h8nDtWOd2FIj3pMZFQVfpo5Y=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=ophirmu@mellanox.com; ", "From": "Ophir Munk <ophirmu@mellanox.com>", "To": "dev@dpdk.org,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>", "Cc": "Thomas Monjalon <thomas@monjalon.net>, Olga Shern <olgas@mellanox.com>, \n\tOphir Munk <ophirmu@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>, \n\tstable@dpdk.org", "Date": "Tue, 8 May 2018 12:26:03 +0000", "Message-Id": "<1525782363-426-1-git-send-email-ophirmu@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1525091101-10782-1-git-send-email-ophirmu@mellanox.com>", "References": "<1525091101-10782-1-git-send-email-ophirmu@mellanox.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[37.142.13.130]", "X-ClientProxiedBy": "AM4PR0101CA0074.eurprd01.prod.exchangelabs.com\n\t(2603:10a6:200:41::42) To AM4PR0501MB2307.eurprd05.prod.outlook.com\n\t(2603:10a6:200:53::20)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);\n\tSRVR:AM4PR0501MB2307; ", "X-Microsoft-Exchange-Diagnostics": [ "1; AM4PR0501MB2307;\n\t3:upZ4hNp1Zn2z/4eCVBjwHwITT1P+Q053199fUusWJ5PUto/AstHmRqnlLfj7Z7msWUGRswPBDXF9IVUB3LlxpFgNCC9TLRarh2ynjp9Z8QDXEOTPLyG+1/4A8s7hLI8CjRVJebTrQ5ZytaOb1ZZkIrksLUvIHLjK7JP4SxotDsPpIcl1ZSvJk/6iXKSIghxBCFKBcxzKjv86Lxtmm6fh5HSGcrX1kqnP3DllfCI2GwKa9QAklJk2FLOHK9eBhpap;\n\t25:jv+S00zuKHVFK7V52s3qLFCUy49sGXGW1oQ3YzEOZB+Bo21FF/r8srFqdnutR3Z36keXZ8V3nQ8dV0p2JGe4b+JrHhcUCV19J8OTOL8Ch5e7KMLE4VvZWMZPTISXGUZVOEfITw06J7r4XZJAjZ/UpPd+Z/8q/5RCkUQsOvu61hwfKesRTrywjBhcPHyTv/llfba4uH8oyQrrjSa//3TSVj52ZlK2DScO13EPOA6Z4KnhvCEUEaF4ZMAuN4lKe8RiT4OL+iC/A37INJn92PIzvHb3Ej3rPqisvG6Vk47xPUVWfHP42VdXuMYn9i0X3l50mBRxr8AuTJKXwPnENNqSJg==;\n\t31:olW3PRGH9dM/yKvnxpfJzGD4t0h1Yl4zdnlHVaj9ErF3vTasbmV2DJyIb9SuvFfxyqy0jNdoT3AhKEj4XHMPxzrZoLDVJCkvZ1ZMvYZP0HAu1id04DjipgIagoNvcRvmPbvFm1Wi9HBYfuN5KdgOT6ofnFQki78Vv3osPyFB38IP0/qTpACvOJtC/EfkHnnVRbgwahvZ7CawIBzbq5Sap7VRjyKxBxEXWILarhL293k=", "1; AM4PR0501MB2307;\n\t20:shhG4ds4nHDX0nEAQQX7u8xk2DbdL3GA2kpnRXy2UsHGtaYLgJbamdxvqeJJyRHvVPK+oaoIgrT3szlRnh9ZTwJWQIwKrSbPgiCpcXOrxTI/YIwOEmt2L04CbwjRlc4Xlp2HSj451DXhqtzEjn8JTCCy6yAa0M3KkZ+zg8K7BaM0nd8q0ySM3OYaTHc+z/J1zAnyBQKbjiG7CWE3b1hHkX+7+gsNbDdqvNxohs4ZG+sPpqs/1Pmnj0jaG3JZDTyhbRxXsKObVYny64pStRALAOezVuKTbNDnrXiEuIh4zxZjfzhPYUL0o4xwPighWos5iKSMKsVSCPx1Nlm4TG4j/WXPQzga9Jp8deIGcPFVFHH5iSez6L8GbF8DTPvduNQmargehUGS0jJdc5jF4Hec1jra4WPQO9ralKeohkEzF/VMM/dEjxfF5rrhSNZPDF7ZuRAmjzFbaIbYjt/kqINLjA+iRKlWDJ0xquMel2AoiU95lFa7U8e+l6aLlDmwgTL3;\n\t4:JsslVC+o9xoplbsLzsFOm0AduN5/5ikF++I6T9QBiJG/a443VIKeGuZrUUKayXYuOxb2hKruXuJ5hrN6e5/Y546169IEFnzEDAQvL5IutCm3vMNjO0HudEwEpSxO/WnPivxEdQh50vkldF7ZYU2ceLIygJUzKMGkI7og3lvmi5ImMjGsalM8W5CoBtMCJNA3QjbENulPnfhVW4GfzP7q5rMF/qbHWnwGHTcTLxyVGDx2xzJxS/y6J3xfk+eRbe1tQFM9NzFYGQAJ/1BSvyo8gQ==", "=?us-ascii?Q?1; AM4PR0501MB2307;\n\t23:OSX62JEVbrJETmtfg+9cDUOdoL5J63Xi3F7jyIb?=\n\tBnyaOzRVxrepnaAfAaNjRzXk9UN7NKrcmZiswXfIN+Zi/znYIbUNC6yTSDWDjNCLAyLOORL51kmvuWIPJfRJ9qqdXF27ZZDwpkmLhwFLHgNXD2Av2i6Y1vLc0vGpy/CcJLVOGdFd2A3+uDDvi3ZnmjXX5BAHHotEhPf2YMOUbiylKyX5gb7ZxaDHcaVHsL1v8BkPTapIoEoxJFB1U/Fo+c+7hNId0SzwsLO88HY4cneDFVNbfPqzT8Jqi76lay/c3YwLqHlzKK8wN8wP/qNxeR81rag68A6UaVrM2qpay3bKw7X4s3c8XAWzOCA15mYh2aDgqmQLdtQwrEnxtd231kDr0QcHAFIca5i18EWT9l6Jrt8mUZbBtHkOpT6sBApbxKEN7gzGmxzmtKYOdEKdRgkA4EocBaQXroJGOv1xkXI0csAQrcGHABp46ZPzp9BvKk9UuO23BqWWGUiBtpm1rZpsmTYXc/ldO2DFWBwG9vsjgRme+RzA4nkW/TmBLHy3nSKXYX1YxT/Sbt7NV4n5U5xSDCvw6OGu2ZBkEwh73l8hZljVX+mdBRTI0bUBnY1UvU5oMn9cu4kWrynXaw/nyfYj36zQkl+Is+ekypU8HQbVbHELsGiGS1Dgaw8C4xrewJdnDpMlCOwlZnp2z8ONQpKKEH2DQAdMMuc8Hd5Z2icm/d6hjfRmQMpCnEFO08tYvHvXTZAxI1hp7OmfuRtSClk/k8YJxWlvyyAEXcBP8pedIar7//1k/mOla4NSzk4IyD3kRKJ1ntnQHe8NJcZDBW50jcaRTOg9ISZ010xMbEm3dlbvy46yAUWj/juAKx/KQNwBFVQb8FCbNkJNgv059B6qh4vLzPkjTaEYfXbG62sdjZNP9/iTwDZACSaWbXmquNTmlbtkhXADC35emF8Cp2c39l/NGWMwJDetbudab0HM4jZopwDm+sBF9fQ++v0WAJatZx/7ggnGE/D2jPSecxp74VjkijUOl/Tp5BDGhYL2mx8MgJUErM4XE1PeTOyBpSa1kAcT24Ko1NO4Is5pHCIZI0GLEMCfXZsPjDB2Fk8gDxK7B3r9c2gdKlFKWUSwAV5GcPQpioyIVtASwiF9M9eEsxT9bWRO+zLZVUSLd/NjKCaNKHQuYCqKNU7aUKylhT0FyJ/JkilZBlW/IiGOnUL/5dJ8M8rCNFIhs8SJMTMO7rCV0T6+khBd+L7UUAhbkFCdtmsA4+ROKIx3cZOvXb7SsjKzW1wK5dRTz+wx0rOZsFYcpNQQU9hQ2XvPWMx1v3QQ=", "1; AM4PR0501MB2307;\n\t6:ZJPFb3KYMD2TrZCvvU1vbYr9KBs8Z8O0fgmO3mZIpHzQZu2uBJ57qLn/Q1PhwxUVoCKsOWZuskUVfggjdtDdmz14PvvM0psy6XAviZN5JM2Nag0813s9y2aQ9nNW8qtwtt2g1dVTmb3BNtLSufi6sy/IWHu64KfwJknOKAHeq/eJgPidNtLauAJsYikH6Khhf9i4PQdk/z/82Ar52TBP4RpKP6i1mOHRrf76yQKU4NpezXI5su8E6CAU3Hz50vXr9f/sMR0kjR2P0sichtRtGGNwg/T1BnDS27QKHv31zoFP6NWlv7ccgAGR4lIQlwHF0ydlHrpCQNHNYp526qMCsO8Lfm8ijznxYDoLAnUShv4WqGYOv2MtYfHlyb221U0ASvf68apgIo/taD/G6TGRGM2A9xlHcMf7uQCilqw3U3wTUIJq1rUB/u9xyoW5WKeaxoth7t84RaGBm1UUx/dlhQ==;\n\t5:VdLC/TxIBVIlNPYj1JfMT3zeo5KLEh6NU5Z4+pQF2SFvcn8qD21d/I9Fqb1XfIgVrOeJp/GdqZq5e7eZymFApA0+vAtziDbG4bBzEVftnpAcdmI7303Fn+PmZMQBceT+bwRlUTQ5xmjqwdvCGq1Glqp4vfT9vFajqeEkUJGLXuM=;\n\t24:E69y96ybde7uSS8Z1krxPNqjZieEO6FIuygCkv0OxH8oGXrTWBQWvdnK5XemAgfczGCHkBHS4Vhdnova9WChiHOisi2KW5jmh2PGPj5dXis=", "1; AM4PR0501MB2307;\n\t7:+BAbw2enUqNIkBJILwah36R0yG2xNtlwPlqehzrST8I+PYT/IPnutVuKhn9ci9q6HbRT3u49euFrPku7pK7AtFeEAGR+V50KjEf8/rdziFcy11NjSjEB9f72u/3SzMf4qVuWkeyPKSOeVi+bb4nPlwfUGYOiOB/XysHmTBZBkW1NJFXn0sIkUFWwLzIRm/1f58+3aj1YlKJLPi416KcTuQgVwXoSO5JOX3e8QlBlvA1I8HvXubn7AmV42iIxGJve" ], "X-MS-TrafficTypeDiagnostic": "AM4PR0501MB2307:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "X-Microsoft-Antispam-PRVS": "<AM4PR0501MB23079E38CB1DD4C9BA2EECF2D19A0@AM4PR0501MB2307.eurprd05.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011);\n\tSRVR:AM4PR0501MB2307; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0501MB2307; ", "X-Forefront-PRVS": "0666E15D35", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(346002)(396003)(376002)(366004)(39860400002)(39380400002)(199004)(189003)(7736002)(5660300001)(26005)(6666003)(6916009)(386003)(66066001)(68736007)(25786009)(59450400001)(86362001)(69596002)(8676002)(305945005)(48376002)(36756003)(76176011)(4720700003)(52116002)(51416003)(7696005)(6116002)(3846002)(2906002)(8936002)(33026002)(105586002)(81166006)(55016002)(50226002)(53936002)(81156014)(106356001)(2616005)(486006)(956004)(97736004)(186003)(4326008)(54906003)(16586007)(478600001)(316002)(11346002)(16526019)(446003)(21086003)(47776003)(476003)(50466002)(168613001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB2307; H:mellanox.com; FPR:;\n\tSPF:None; \n\tLANG:en; PTR:InfoNoRecords; A:1; MX:1; ", "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "I2ltLmxBOjd1NQ+eGm0njiCckJJXqEpEnBDb+w3zwvVPgZMDCPhM7rJqnzRDt9AXmKIZQlFuCP4rWr33n0xeUviOkxYmQg0Hzlff8jTgdxjYkho44snyf7A3danm1laC9L37ZiIY+mE5LWZnj4ql7kLaqhHOYdeXQ5jVhoawKQd5HekgRG1kTHLbbJ/cW3k3", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-MS-Office365-Filtering-Correlation-Id": "52fc3134-f339-4246-b302-08d5b4dee313", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "08 May 2018 12:26:11.9032\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "52fc3134-f339-4246-b302-08d5b4dee313", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM4PR0501MB2307", "Subject": "[dpdk-dev] [PATCH v2] net/mlx4: fix CRC stripping capability report", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There are two capabilities related to CRC stripping:\n1. mlx4 HW capability to perform CRC stripping on a received packet.\nThis capability is built in mlx4 HW. It should be returned by the API\ncall mlx4_get_rx_queue_offloads().\n2. mlx4 driver capability to enable/disable HW CRC stripping. This\ncapability is dependent on the driver version.\nBefore this commit the second capability was falsely returned by\nthe mentioned API. This commit fixes it by returning the first\ncapability.\n\nmlx4 HW performs CRC stripping by default and this capability is\nalways reported as \"true\".\nThe ability to enable/disable CRC stripping is supported since this\ncommit and requires OFED version 4.3-1.5.0.0 or rdma-core version v18.\nCRC stripping will be done by default regardless of its configuration\nwhen working with OFED or rdma-core versions earlier than those\npreviously specified or before this commit.\n\nFixes: de1df14e6e6ec (\"net/mlx4: support CRC strip toggling\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ophir Munk <ophirmu@mellanox.com>\n---\nv1:\nInitial version\nv2:\nUpdate commit log message based on reviews\n\n drivers/net/mlx4/mlx4_rxq.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4_rxq.c b/drivers/net/mlx4/mlx4_rxq.c\nindex 65f0994..0650b10 100644\n--- a/drivers/net/mlx4/mlx4_rxq.c\n+++ b/drivers/net/mlx4/mlx4_rxq.c\n@@ -665,10 +665,9 @@ mlx4_rxq_detach(struct rxq *rxq)\n uint64_t\n mlx4_get_rx_queue_offloads(struct priv *priv)\n {\n-\tuint64_t offloads = DEV_RX_OFFLOAD_SCATTER;\n+\tuint64_t offloads = DEV_RX_OFFLOAD_SCATTER |\n+\t\t\t DEV_RX_OFFLOAD_CRC_STRIP;\n \n-\tif (priv->hw_fcs_strip)\n-\t\toffloads |= DEV_RX_OFFLOAD_CRC_STRIP;\n \tif (priv->hw_csum)\n \t\toffloads |= DEV_RX_OFFLOAD_CHECKSUM;\n \treturn offloads;\n", "prefixes": [ "dpdk-dev", "v2" ] }