Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/394/?format=api
{ "id": 394, "url": "https://patches.dpdk.org/api/patches/394/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1410948102-12740-2-git-send-email-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1410948102-12740-2-git-send-email-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1410948102-12740-2-git-send-email-bruce.richardson@intel.com", "date": "2014-09-17T10:01:38", "name": "[dpdk-dev,1/5] mbuf: ensure next pointer is set to null on free", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d1d60f28c90d885157d0f4342bdaadadc1e2cc87", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1410948102-12740-2-git-send-email-bruce.richardson@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/394/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/394/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 26466B39E;\n\tWed, 17 Sep 2014 11:56:40 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 23437B39B\n\tfor <dev@dpdk.org>; Wed, 17 Sep 2014 11:56:37 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP; 17 Sep 2014 03:02:16 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga002.jf.intel.com with ESMTP; 17 Sep 2014 03:01:43 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ts8HA1goC017168; Wed, 17 Sep 2014 11:01:42 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id s8HA1grJ015449;\n\tWed, 17 Sep 2014 11:01:42 +0100", "(from bricha3@localhost)\n\tby sivswdev02.ir.intel.com with id s8HA1ga5015440;\n\tWed, 17 Sep 2014 11:01:42 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,540,1406617200\"; d=\"scan'208\";a=\"604080464\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 17 Sep 2014 11:01:38 +0100", "Message-Id": "<1410948102-12740-2-git-send-email-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1410948102-12740-1-git-send-email-bruce.richardson@intel.com>", "References": "<1410948102-12740-1-git-send-email-bruce.richardson@intel.com>", "Subject": "[dpdk-dev] [PATCH 1/5] mbuf: ensure next pointer is set to null on\n\tfree", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The receive functions for packets do not modify the next pointer so\nthe next pointer should always be cleared on mbuf free, just in case.\nThe slow-path TX needs to clear it, and the standard mbuf free function\nalso needs to clear it. Fast path TX does not handle chained mbufs so\nis unaffected\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_mbuf/rte_mbuf.h | 4 +++-\n lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 1 +\n 2 files changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex 1c6e115..8e27d2e 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -682,8 +682,10 @@ __rte_pktmbuf_prefree_seg(struct rte_mbuf *m)\n static inline void __attribute__((always_inline))\n rte_pktmbuf_free_seg(struct rte_mbuf *m)\n {\n-\tif (likely(NULL != (m = __rte_pktmbuf_prefree_seg(m))))\n+\tif (likely(NULL != (m = __rte_pktmbuf_prefree_seg(m)))) {\n+\t\tm->next = NULL;\n \t\t__rte_mbuf_raw_free(m);\n+\t}\n }\n \n /**\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\nindex a80cade..6f702b3 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n@@ -145,6 +145,7 @@ ixgbe_tx_free_bufs(struct igb_tx_queue *txq)\n \t/* free buffers one at a time */\n \tif ((txq->txq_flags & (uint32_t)ETH_TXQ_FLAGS_NOREFCOUNT) != 0) {\n \t\tfor (i = 0; i < txq->tx_rs_thresh; ++i, ++txep) {\n+\t\t\ttxep->mbuf->next = NULL;\n \t\t\trte_mempool_put(txep->mbuf->pool, txep->mbuf);\n \t\t\ttxep->mbuf = NULL;\n \t\t}\n", "prefixes": [ "dpdk-dev", "1/5" ] }