Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 39363,
    "url": "https://patches.dpdk.org/api/patches/39363/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180503193713.20622-5-johndale@cisco.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180503193713.20622-5-johndale@cisco.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180503193713.20622-5-johndale@cisco.com",
    "date": "2018-05-03T19:37:12",
    "name": "[dpdk-dev,5/6] net/enic: fix RSS hash type advertisement",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "c76a28c1fb9228275b4329fd3077eb2cdf6502a5",
    "submitter": {
        "id": 359,
        "url": "https://patches.dpdk.org/api/people/359/?format=api",
        "name": "John Daley (johndale)",
        "email": "johndale@cisco.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180503193713.20622-5-johndale@cisco.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/39363/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/39363/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AD97F2BA3;\n\tThu,  3 May 2018 21:46:12 +0200 (CEST)",
            "from rcdn-iport-1.cisco.com (rcdn-iport-1.cisco.com [173.37.86.72])\n\tby dpdk.org (Postfix) with ESMTP id 1AE1E20BD\n\tfor <dev@dpdk.org>; Thu,  3 May 2018 21:46:10 +0200 (CEST)",
            "from alln-core-4.cisco.com ([173.36.13.137])\n\tby rcdn-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 May 2018 19:46:10 +0000",
            "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby alln-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id w43JkArR024348;\n\tThu, 3 May 2018 19:46:10 GMT",
            "by cisco.com (Postfix, from userid 392789)\n\tid 2737420F2001; Thu,  3 May 2018 12:46:10 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=4409; q=dns/txt; s=iport;\n\tt=1525376771; x=1526586371;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=AJ3rm5D5uhQj/wyiGZ3udhQlNwcD9VFSLE1pTPrgVSI=;\n\tb=E7PIGXF3CZIKQbtV+N4BQ50GM5OYqrXCb7TT0o3AkgQiKGATkCGaGIx4\n\tEBqUD2cy4my/iGJpXF5JIBZ+Y8q/T8lonptYin5btcg8YIhUhkf0pu6Fk\n\tz2LoCDTdJCAgwX20TD+rpbSlRghjDAphytGqmQoAjD6c41ZKAW3jAf8A6 k=;",
        "X-IronPort-AV": "E=Sophos;i=\"5.49,359,1520899200\"; d=\"scan'208\";a=\"390009907\"",
        "From": "John Daley <johndale@cisco.com>",
        "To": "ferruh.yigit@intel.com",
        "Cc": "dev@dpdk.org, Hyong Youb Kim <hyonkim@cisco.com>",
        "Date": "Thu,  3 May 2018 12:37:12 -0700",
        "Message-Id": "<20180503193713.20622-5-johndale@cisco.com>",
        "X-Mailer": "git-send-email 2.16.2",
        "In-Reply-To": "<20180503193713.20622-1-johndale@cisco.com>",
        "References": "<20180503193713.20622-1-johndale@cisco.com>",
        "Subject": "[dpdk-dev] [PATCH 5/6] net/enic: fix RSS hash type advertisement",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Hyong Youb Kim <hyonkim@cisco.com>\n\nThe NIC can hash these RSS packet types, but they are not advertised\nvia flow_type_rss_offloads. So add them.\n- Part of the IPv4 hash:\n  ETH_RSS_FRAG_IPV4\n  ETH_RSS_NONFRAG_IPV4_OTHER\n- Part of the IPv6 hash:\n  ETH_RSS_FRAG_IPV6\n  ETH_RSS_NONFRAG_IPV6_OTHER\n- Part of the UDP hash:\n  ETH_RSS_IPV6_UDP_EX\n\nAlso, do not use NIC_CFG_RSS_HASH_TYPE_IPV6_EX and\nNIC_CFG_RSS_HASH_TYPE_TCP_IPV6_EX, as they are not needed to enable\nRSS over IPv6 with extension headers.\n\nFixes: c2fec27b5cb0 (\"net/enic: allow to change RSS settings\")\n\nSigned-off-by: Hyong Youb Kim <hyonkim@cisco.com>\nReviewed-by: John Daley <johndale@cisco.com>\nReviewed-by: Aaron Conole <aconole@redhat.com>\n---\n drivers/net/enic/enic_main.c | 14 ++++++--------\n drivers/net/enic/enic_res.c  | 26 ++++++++++++++++++--------\n 2 files changed, 24 insertions(+), 16 deletions(-)",
    "diff": "diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c\nindex b3b4e9626..2b1c1347c 100644\n--- a/drivers/net/enic/enic_main.c\n+++ b/drivers/net/enic/enic_main.c\n@@ -1190,7 +1190,8 @@ int enic_set_rss_conf(struct enic *enic, struct rte_eth_rss_conf *rss_conf)\n \t    (eth_dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) &&\n \t    rss_hf != 0) {\n \t\trss_enable = 1;\n-\t\tif (rss_hf & ETH_RSS_IPV4)\n+\t\tif (rss_hf & (ETH_RSS_IPV4 | ETH_RSS_FRAG_IPV4 |\n+\t\t\t      ETH_RSS_NONFRAG_IPV4_OTHER))\n \t\t\trss_hash_type |= NIC_CFG_RSS_HASH_TYPE_IPV4;\n \t\tif (rss_hf & ETH_RSS_NONFRAG_IPV4_TCP)\n \t\t\trss_hash_type |= NIC_CFG_RSS_HASH_TYPE_TCP_IPV4;\n@@ -1202,18 +1203,15 @@ int enic_set_rss_conf(struct enic *enic, struct rte_eth_rss_conf *rss_conf)\n \t\t\t */\n \t\t\trss_hash_type |= NIC_CFG_RSS_HASH_TYPE_TCP_IPV4;\n \t\t}\n-\t\tif (rss_hf & ETH_RSS_IPV6)\n+\t\tif (rss_hf & (ETH_RSS_IPV6 | ETH_RSS_IPV6_EX |\n+\t\t\t      ETH_RSS_FRAG_IPV6 | ETH_RSS_NONFRAG_IPV6_OTHER))\n \t\t\trss_hash_type |= NIC_CFG_RSS_HASH_TYPE_IPV6;\n-\t\tif (rss_hf & ETH_RSS_NONFRAG_IPV6_TCP)\n+\t\tif (rss_hf & (ETH_RSS_NONFRAG_IPV6_TCP | ETH_RSS_IPV6_TCP_EX))\n \t\t\trss_hash_type |= NIC_CFG_RSS_HASH_TYPE_TCP_IPV6;\n-\t\tif (rss_hf & ETH_RSS_NONFRAG_IPV6_UDP) {\n+\t\tif (rss_hf & (ETH_RSS_NONFRAG_IPV6_UDP | ETH_RSS_IPV6_UDP_EX)) {\n \t\t\t/* Again, 'TCP' is not a typo. */\n \t\t\trss_hash_type |= NIC_CFG_RSS_HASH_TYPE_TCP_IPV6;\n \t\t}\n-\t\tif (rss_hf & ETH_RSS_IPV6_EX)\n-\t\t\trss_hash_type |= NIC_CFG_RSS_HASH_TYPE_IPV6_EX;\n-\t\tif (rss_hf & ETH_RSS_IPV6_TCP_EX)\n-\t\t\trss_hash_type |= NIC_CFG_RSS_HASH_TYPE_TCP_IPV6_EX;\n \t} else {\n \t\trss_enable = 0;\n \t\trss_hf = 0;\ndiff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c\nindex de17a31d0..bdda2c564 100644\n--- a/drivers/net/enic/enic_res.c\n+++ b/drivers/net/enic/enic_res.c\n@@ -138,20 +138,30 @@ int enic_get_vnic_config(struct enic *enic)\n \tenic->hash_key_size = ENIC_RSS_HASH_KEY_SIZE;\n \tenic->flow_type_rss_offloads = 0;\n \tif (ENIC_SETTING(enic, RSSHASH_IPV4))\n-\t\tenic->flow_type_rss_offloads |= ETH_RSS_IPV4;\n+\t\t/*\n+\t\t * IPV4 hash type handles both non-frag and frag packet types.\n+\t\t * TCP/UDP is controlled via a separate flag below.\n+\t\t */\n+\t\tenic->flow_type_rss_offloads |= ETH_RSS_IPV4 |\n+\t\t\tETH_RSS_FRAG_IPV4 | ETH_RSS_NONFRAG_IPV4_OTHER;\n \tif (ENIC_SETTING(enic, RSSHASH_TCPIPV4))\n \t\tenic->flow_type_rss_offloads |= ETH_RSS_NONFRAG_IPV4_TCP;\n \tif (ENIC_SETTING(enic, RSSHASH_IPV6))\n-\t\tenic->flow_type_rss_offloads |= ETH_RSS_IPV6;\n+\t\t/*\n+\t\t * The VIC adapter can perform RSS on IPv6 packets with and\n+\t\t * without extension headers. An IPv6 \"fragment\" is an IPv6\n+\t\t * packet with the fragment extension header.\n+\t\t */\n+\t\tenic->flow_type_rss_offloads |= ETH_RSS_IPV6 |\n+\t\t\tETH_RSS_IPV6_EX | ETH_RSS_FRAG_IPV6 |\n+\t\t\tETH_RSS_NONFRAG_IPV6_OTHER;\n \tif (ENIC_SETTING(enic, RSSHASH_TCPIPV6))\n-\t\tenic->flow_type_rss_offloads |= ETH_RSS_NONFRAG_IPV6_TCP;\n-\tif (ENIC_SETTING(enic, RSSHASH_IPV6_EX))\n-\t\tenic->flow_type_rss_offloads |= ETH_RSS_IPV6_EX;\n-\tif (ENIC_SETTING(enic, RSSHASH_TCPIPV6_EX))\n-\t\tenic->flow_type_rss_offloads |= ETH_RSS_IPV6_TCP_EX;\n+\t\tenic->flow_type_rss_offloads |= ETH_RSS_NONFRAG_IPV6_TCP |\n+\t\t\tETH_RSS_IPV6_TCP_EX;\n \tif (vnic_dev_capable_udp_rss(enic->vdev)) {\n \t\tenic->flow_type_rss_offloads |=\n-\t\t\tETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP;\n+\t\t\tETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP |\n+\t\t\tETH_RSS_IPV6_UDP_EX;\n \t}\n \n \t/* Zero offloads if RSS is not enabled */\n",
    "prefixes": [
        "dpdk-dev",
        "5/6"
    ]
}