Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/39037/?format=api
{ "id": 39037, "url": "https://patches.dpdk.org/api/patches/39037/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180426133008.12388-12-kamilx.chalupnik@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180426133008.12388-12-kamilx.chalupnik@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180426133008.12388-12-kamilx.chalupnik@intel.com", "date": "2018-04-26T13:30:06", "name": "[dpdk-dev,12/13] bbdev: split queue groups", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "81ccf2583bfef7b0452d3d87533c270bac28f31e", "submitter": { "id": 1010, "url": "https://patches.dpdk.org/api/people/1010/?format=api", "name": "Kamil Chalupnik", "email": "kamilx.chalupnik@intel.com" }, "delegate": { "id": 22, "url": "https://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180426133008.12388-12-kamilx.chalupnik@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/39037/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/39037/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ED3278DAF;\n\tThu, 26 Apr 2018 15:32:47 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 027548D8F\n\tfor <dev@dpdk.org>; Thu, 26 Apr 2018 15:32:34 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Apr 2018 06:32:33 -0700", "from kchalupx-mobl.ger.corp.intel.com ([10.103.104.151])\n\tby orsmga001.jf.intel.com with ESMTP; 26 Apr 2018 06:32:32 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,330,1520924400\"; d=\"scan'208\";a=\"51014438\"", "From": "Kamil Chalupnik <kamilx.chalupnik@intel.com>", "To": "dev@dpdk.org", "Cc": "amr.mokhtar@intel.com, pablo.de.lara.guarch@intel.com,\n\tKamilX Chalupnik <kamilx.chalupnik@intel.com>", "Date": "Thu, 26 Apr 2018 15:30:06 +0200", "Message-Id": "<20180426133008.12388-12-kamilx.chalupnik@intel.com>", "X-Mailer": "git-send-email 2.9.0.windows.1", "In-Reply-To": "<20180426133008.12388-1-kamilx.chalupnik@intel.com>", "References": "<20180426133008.12388-1-kamilx.chalupnik@intel.com>", "Subject": "[dpdk-dev] [PATCH 12/13] bbdev: split queue groups", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: KamilX Chalupnik <kamilx.chalupnik@intel.com>\n\nSplitting Queue Groups into UL/DL Groups in Turbo Software\nDriver. They are independent for Decode/Encode.\nRelease note updated accordingly.\n\nSigned-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com>\n---\n app/test-bbdev/test_bbdev.c | 11 ++---------\n doc/guides/rel_notes/release_18_05.rst | 5 +++++\n drivers/baseband/null/bbdev_null.c | 3 ++-\n drivers/baseband/turbo_sw/bbdev_turbo_software.c | 3 ++-\n lib/librte_bbdev/rte_bbdev.c | 13 +++++++++++--\n lib/librte_bbdev/rte_bbdev.h | 6 ++++--\n 6 files changed, 26 insertions(+), 15 deletions(-)", "diff": "diff --git a/app/test-bbdev/test_bbdev.c b/app/test-bbdev/test_bbdev.c\nindex 10579ea..5d325b6 100644\n--- a/app/test-bbdev/test_bbdev.c\n+++ b/app/test-bbdev/test_bbdev.c\n@@ -273,7 +273,7 @@ test_bbdev_configure_stop_queue(void)\n \n \t/* Valid queue configuration */\n \tts_params->qconf.queue_size = info.drv.queue_size_lim;\n-\tts_params->qconf.priority = info.drv.max_queue_priority;\n+\tts_params->qconf.priority = info.drv.max_ul_queue_priority;\n \n \t/* Device - started; queue - started */\n \trte_bbdev_start(dev_id);\n@@ -413,14 +413,7 @@ test_bbdev_configure_invalid_queue_configure(void)\n \t\t\tts_params->qconf.queue_size);\n \n \tts_params->qconf.queue_size = info.drv.queue_size_lim;\n-\tts_params->qconf.priority = info.drv.max_queue_priority + 1;\n-\tTEST_ASSERT_FAIL(rte_bbdev_queue_configure(dev_id, queue_id,\n-\t\t\t&ts_params->qconf),\n-\t\t\t\"Failed test for rte_bbdev_queue_configure: \"\n-\t\t\t\"invalid value qconf.queue_size: %u\",\n-\t\t\tts_params->qconf.queue_size);\n-\n-\tts_params->qconf.priority = info.drv.max_queue_priority;\n+\tts_params->qconf.priority = info.drv.max_ul_queue_priority;\n \tqueue_id = info.num_queues;\n \tTEST_ASSERT_FAIL(rte_bbdev_queue_configure(dev_id, queue_id,\n \t\t\t&ts_params->qconf),\ndiff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst\nindex 3923dc2..116c3d4 100644\n--- a/doc/guides/rel_notes/release_18_05.rst\n+++ b/doc/guides/rel_notes/release_18_05.rst\n@@ -69,6 +69,11 @@ ABI Changes\n Also, make sure to start the actual text at the margin.\n =========================================================\n \n+* **Queue Groups split into UL/DL Groups**\n+\n+ Queue Groups have been split into UL/DL Groups in Turbo Software Driver.\n+ They are independent for Decode/Encode. ``rte_bbdev_driver_info`` reflects\n+ introduced changes.\n \n Removed Items\n -------------\ndiff --git a/drivers/baseband/null/bbdev_null.c b/drivers/baseband/null/bbdev_null.c\nindex 6bc8491..e8e541f 100644\n--- a/drivers/baseband/null/bbdev_null.c\n+++ b/drivers/baseband/null/bbdev_null.c\n@@ -71,7 +71,8 @@ info_get(struct rte_bbdev *dev, struct rte_bbdev_driver_info *dev_info)\n \tdev_info->max_num_queues = internals->max_nb_queues;\n \tdev_info->queue_size_lim = RTE_BBDEV_QUEUE_SIZE_LIMIT;\n \tdev_info->hardware_accelerated = false;\n-\tdev_info->max_queue_priority = 0;\n+\tdev_info->max_dl_queue_priority = 0;\n+\tdev_info->max_ul_queue_priority = 0;\n \tdev_info->default_queue_conf = default_queue_conf;\n \tdev_info->capabilities = bbdev_capabilities;\n \tdev_info->cpu_flag_reqs = NULL;\ndiff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c\nindex af484fc..39b597b 100644\n--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c\n+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c\n@@ -175,7 +175,8 @@ info_get(struct rte_bbdev *dev, struct rte_bbdev_driver_info *dev_info)\n \tdev_info->max_num_queues = internals->max_nb_queues;\n \tdev_info->queue_size_lim = RTE_BBDEV_QUEUE_SIZE_LIMIT;\n \tdev_info->hardware_accelerated = false;\n-\tdev_info->max_queue_priority = 0;\n+\tdev_info->max_dl_queue_priority = 0;\n+\tdev_info->max_ul_queue_priority = 0;\n \tdev_info->default_queue_conf = default_queue_conf;\n \tdev_info->capabilities = bbdev_capabilities;\n \tdev_info->cpu_flag_reqs = &cpu_flag;\ndiff --git a/lib/librte_bbdev/rte_bbdev.c b/lib/librte_bbdev/rte_bbdev.c\nindex 74ecc49..28434e0 100644\n--- a/lib/librte_bbdev/rte_bbdev.c\n+++ b/lib/librte_bbdev/rte_bbdev.c\n@@ -495,11 +495,20 @@ rte_bbdev_queue_configure(uint16_t dev_id, uint16_t queue_id,\n \t\t\t\t\tconf->queue_size, queue_id, dev_id);\n \t\t\treturn -EINVAL;\n \t\t}\n-\t\tif (conf->priority > dev_info.max_queue_priority) {\n+\t\tif (conf->op_type == RTE_BBDEV_OP_TURBO_DEC &&\n+\t\t\tconf->priority > dev_info.max_ul_queue_priority) {\n \t\t\trte_bbdev_log(ERR,\n \t\t\t\t\t\"Priority (%u) of queue %u of bdev %u must be <= %u\",\n \t\t\t\t\tconf->priority, queue_id, dev_id,\n-\t\t\t\t\tdev_info.max_queue_priority);\n+\t\t\t\t\tdev_info.max_ul_queue_priority);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\t\tif (conf->op_type == RTE_BBDEV_OP_TURBO_ENC &&\n+\t\t\tconf->priority > dev_info.max_dl_queue_priority) {\n+\t\t\trte_bbdev_log(ERR,\n+\t\t\t\t\t\"Priority (%u) of queue %u of bdev %u must be <= %u\",\n+\t\t\t\t\tconf->priority, queue_id, dev_id,\n+\t\t\t\t\tdev_info.max_dl_queue_priority);\n \t\t\treturn -EINVAL;\n \t\t}\n \t}\ndiff --git a/lib/librte_bbdev/rte_bbdev.h b/lib/librte_bbdev/rte_bbdev.h\nindex bd0ec24..9906488 100644\n--- a/lib/librte_bbdev/rte_bbdev.h\n+++ b/lib/librte_bbdev/rte_bbdev.h\n@@ -283,8 +283,10 @@ struct rte_bbdev_driver_info {\n \tuint32_t queue_size_lim;\n \t/** Set if device off-loads operation to hardware */\n \tbool hardware_accelerated;\n-\t/** Max value supported by queue priority */\n-\tuint8_t max_queue_priority;\n+\t/** Max value supported by queue priority for DL */\n+\tuint8_t max_dl_queue_priority;\n+\t/** Max value supported by queue priority for UL */\n+\tuint8_t max_ul_queue_priority;\n \t/** Set if device supports per-queue interrupts */\n \tbool queue_intr_supported;\n \t/** Minimum alignment of buffers, in bytes */\n", "prefixes": [ "dpdk-dev", "12/13" ] }