Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/38987/?format=api
{ "id": 38987, "url": "https://patches.dpdk.org/api/patches/38987/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1524723664-30510-9-git-send-email-arnon@qwilt.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1524723664-30510-9-git-send-email-arnon@qwilt.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1524723664-30510-9-git-send-email-arnon@qwilt.com", "date": "2018-04-26T06:21:02", "name": "[dpdk-dev,v9,08/10] eal: replace rte_panic instances in ethdev", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9d4827b9b03067043deee1e86ff0e89f6afa1b89", "submitter": { "id": 986, "url": "https://patches.dpdk.org/api/people/986/?format=api", "name": "Arnon Warshavsky", "email": "arnon@qwilt.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1524723664-30510-9-git-send-email-arnon@qwilt.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/38987/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/38987/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8286172FD;\n\tThu, 26 Apr 2018 08:21:39 +0200 (CEST)", "from mta.qwilt.com (mta.qwilt.com [52.9.191.255])\n\tby dpdk.org (Postfix) with ESMTP id 376DB6D81\n\tfor <dev@dpdk.org>; Thu, 26 Apr 2018 08:21:33 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby mta.qwilt.com (Postfix) with ESMTP id A5C4180C4DD;\n\tThu, 26 Apr 2018 06:21:32 +0000 (UTC)", "from mta.qwilt.com ([127.0.0.1])\n\tby localhost (mta.qwilt.com [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Him_6CT1OeJz; Thu, 26 Apr 2018 06:21:32 +0000 (UTC)", "from rd01.it.qwilt.com.qwilt.com (80.179.204.39.cable.012.net.il\n\t[80.179.204.39])\n\tby mta.qwilt.com (Postfix) with ESMTPSA id F1EF280C4D2;\n\tThu, 26 Apr 2018 06:21:29 +0000 (UTC)" ], "X-Virus-Scanned": "amavisd-new at qwilt.com", "From": "Arnon Warshavsky <arnon@qwilt.com>", "To": "thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com,\n\tdeclan.doherty@intel.com, jerin.jacob@caviumnetworks.com,\n\tbruce.richardson@intel.com, ferruh.yigit@intel.com", "Cc": "dev@dpdk.org,\n\tarnon@qwilt.com", "Date": "Thu, 26 Apr 2018 09:21:02 +0300", "Message-Id": "<1524723664-30510-9-git-send-email-arnon@qwilt.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1524723664-30510-1-git-send-email-arnon@qwilt.com>", "References": "<1524663944-30376-11-git-send-email-arnon@qwilt.com>\n\t<1524723664-30510-1-git-send-email-arnon@qwilt.com>", "Subject": "[dpdk-dev] [PATCH v9 08/10] eal: replace rte_panic instances in\n\tethdev", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Local function to this file,\nchanging from void to int is non-abi-breaking\n\nSigned-off-by: Arnon Warshavsky <arnon@qwilt.com>\n---\n lib/librte_ether/rte_ethdev.c | 42 ++++++++++++++++++++++++++++++------------\n lib/librte_ether/rte_ethdev.h | 4 +++-\n 2 files changed, 33 insertions(+), 13 deletions(-)", "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex f0f53d4..940de15 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -194,7 +194,7 @@ enum {\n \treturn port_id;\n }\n \n-static void\n+static int\n rte_eth_dev_shared_data_prepare(void)\n {\n \tconst unsigned flags = 0;\n@@ -210,8 +210,12 @@ enum {\n \t\t\t\t\trte_socket_id(), flags);\n \t\t} else\n \t\t\tmz = rte_memzone_lookup(MZ_RTE_ETH_DEV_DATA);\n-\t\tif (mz == NULL)\n-\t\t\trte_panic(\"Cannot allocate ethdev shared data\\n\");\n+\t\tif (mz == NULL) {\n+\t\t\trte_spinlock_unlock(&rte_eth_shared_data_lock);\n+\t\t\tRTE_LOG(CRIT, EAL, \"%s(): Cannot allocate ethdev shared data\\n\",\n+\t\t\t\t\t__func__);\n+\t\t\treturn -1;\n+\t\t}\n \n \t\trte_eth_dev_shared_data = mz->addr;\n \t\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n@@ -224,6 +228,8 @@ enum {\n \t}\n \n \trte_spinlock_unlock(&rte_eth_shared_data_lock);\n+\n+\treturn 0;\n }\n \n struct rte_eth_dev *\n@@ -274,7 +280,8 @@ struct rte_eth_dev *\n \tuint16_t port_id;\n \tstruct rte_eth_dev *eth_dev = NULL;\n \n-\trte_eth_dev_shared_data_prepare();\n+\tif (rte_eth_dev_shared_data_prepare() != 0)\n+\t\treturn NULL;\n \n \t/* Synchronize port creation between primary and secondary threads. */\n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n@@ -317,7 +324,8 @@ struct rte_eth_dev *\n \tuint16_t i;\n \tstruct rte_eth_dev *eth_dev = NULL;\n \n-\trte_eth_dev_shared_data_prepare();\n+\tif (rte_eth_dev_shared_data_prepare() != 0)\n+\t\treturn NULL;\n \n \t/* Synchronize port attachment to primary port creation and release. */\n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n@@ -345,7 +353,8 @@ struct rte_eth_dev *\n \tif (eth_dev == NULL)\n \t\treturn -EINVAL;\n \n-\trte_eth_dev_shared_data_prepare();\n+\tif (rte_eth_dev_shared_data_prepare() != 0)\n+\t\treturn -1;\n \n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n \n@@ -399,7 +408,8 @@ struct rte_eth_dev *\n int __rte_experimental\n rte_eth_dev_owner_new(uint64_t *owner_id)\n {\n-\trte_eth_dev_shared_data_prepare();\n+\tif (rte_eth_dev_shared_data_prepare() != 0)\n+\t\treturn -1;\n \n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n \n@@ -450,7 +460,8 @@ struct rte_eth_dev *\n {\n \tint ret;\n \n-\trte_eth_dev_shared_data_prepare();\n+\tif (rte_eth_dev_shared_data_prepare() != 0)\n+\t\treturn -1;\n \n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n \n@@ -467,7 +478,8 @@ struct rte_eth_dev *\n \t\t\t{.id = RTE_ETH_DEV_NO_OWNER, .name = \"\"};\n \tint ret;\n \n-\trte_eth_dev_shared_data_prepare();\n+\tif (rte_eth_dev_shared_data_prepare() != 0)\n+\t\treturn -1;\n \n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n \n@@ -477,12 +489,15 @@ struct rte_eth_dev *\n \treturn ret;\n }\n \n-void __rte_experimental\n+int __rte_experimental\n rte_eth_dev_owner_delete(const uint64_t owner_id)\n {\n \tuint16_t port_id;\n+\tint error;\n \n-\trte_eth_dev_shared_data_prepare();\n+\terror = rte_eth_dev_shared_data_prepare();\n+\tif (error != 0)\n+\t\treturn error;\n \n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n \n@@ -495,6 +510,8 @@ struct rte_eth_dev *\n \t}\n \n \trte_spinlock_unlock(&rte_eth_dev_shared_data->ownership_lock);\n+\n+\treturn 0;\n }\n \n int __rte_experimental\n@@ -502,7 +519,8 @@ struct rte_eth_dev *\n {\n \tint ret = 0;\n \n-\trte_eth_dev_shared_data_prepare();\n+\tif (rte_eth_dev_shared_data_prepare() != 0)\n+\t\treturn -1;\n \n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n \ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex b9eb8ae..46e5947 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -1354,8 +1354,10 @@ int __rte_experimental rte_eth_dev_owner_unset(const uint16_t port_id,\n *\n * @param\towner_id\n * The owner identifier.\n+ * @return\n+ * 0 on success, negative errno value on error.\n */\n-void __rte_experimental rte_eth_dev_owner_delete(const uint64_t owner_id);\n+int __rte_experimental rte_eth_dev_owner_delete(const uint64_t owner_id);\n \n /**\n * @warning\n", "prefixes": [ "dpdk-dev", "v9", "08/10" ] }