Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3874/?format=api
{ "id": 3874, "url": "https://patches.dpdk.org/api/patches/3874/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/533710CFB86FA344BFBF2D6802E60286CEEEC5@SHSMSX101.ccr.corp.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<533710CFB86FA344BFBF2D6802E60286CEEEC5@SHSMSX101.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/533710CFB86FA344BFBF2D6802E60286CEEEC5@SHSMSX101.ccr.corp.intel.com", "date": "2015-03-05T13:33:10", "name": "[dpdk-dev] testpmd: Fix port validation code of \"port stop all\" command", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "02bf6ded63656d1b2893fd8e4cb2c250ad0f491a", "submitter": { "id": 101, "url": "https://patches.dpdk.org/api/people/101/?format=api", "name": "Michael Qiu", "email": "michael.qiu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/533710CFB86FA344BFBF2D6802E60286CEEEC5@SHSMSX101.ccr.corp.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/3874/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/3874/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7C19E5A8A;\n\tThu, 5 Mar 2015 14:33:16 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 296C45A85\n\tfor <dev@dpdk.org>; Thu, 5 Mar 2015 14:33:13 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 05 Mar 2015 05:33:12 -0800", "from pgsmsx102.gar.corp.intel.com ([10.221.44.80])\n\tby fmsmga002.fm.intel.com with ESMTP; 05 Mar 2015 05:33:11 -0800", "from shsmsx152.ccr.corp.intel.com (10.239.6.52) by\n\tPGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Thu, 5 Mar 2015 21:33:11 +0800", "from shsmsx101.ccr.corp.intel.com ([169.254.1.192]) by\n\tSHSMSX152.ccr.corp.intel.com ([169.254.6.46]) with mapi id\n\t14.03.0195.001; Thu, 5 Mar 2015 21:33:09 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,347,1422950400\"; d=\"scan'208\";a=\"687341924\"", "From": "\"Qiu, Michael\" <michael.qiu@intel.com>", "To": "Tetsuya Mukawa <mukawa@igel.co.jp>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH] testpmd: Fix port validation code of \"port\n\tstop\tall\" command", "Thread-Index": "AQHQVxZUkeUi1+JMQE6Z/J1a0wvVMQ==", "Date": "Thu, 5 Mar 2015 13:33:10 +0000", "Message-ID": "<533710CFB86FA344BFBF2D6802E60286CEEEC5@SHSMSX101.ccr.corp.intel.com>", "References": "<1425540606-12554-1-git-send-email-mukawa@igel.co.jp>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH] testpmd: Fix port validation code of \"port\n\tstop\tall\" command", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Hi, Tetsuya and Pablo\nThis is not a full fix, I have generate the full fix patch two days ago,\nSee below:", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 49be819..ec53923 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -384,6 +384,9 @@ port_infos_display(portid_t port_id)\n int\n port_id_is_invalid(portid_t port_id, enum print_warning warning)\n {\n+ if (port_id == (portid_t)RTE_PORT_ALL)\n+ return 0;\n+\n if (ports[port_id].enabled)\n return 0;\n\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex e556b4c..1c4c651 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -1326,6 +1326,9 @@ start_port(portid_t pid)\n return -1;\n }\n\n+ if (port_id_is_invalid(pid, ENABLED_WARN))\n+ return 0;\n+\n if (init_fwd_streams() < 0) {\n printf(\"Fail from init_fwd_streams()\\n\");\n return -1;\n@@ -1482,10 +1485,14 @@ stop_port(portid_t pid)\n dcb_test = 0;\n dcb_config = 0;\n }\n+\n+ if (port_id_is_invalid(pid, ENABLED_WARN))\n+ return;\n+\n printf(\"Stopping ports...\\n\");\n\n FOREACH_PORT(pi, ports) {\n- if (!port_id_is_invalid(pid, DISABLED_WARN) && pid != pi)\n+ if (pid != pi && pid != (portid_t)RTE_PORT_ALL)\n continue;\n\n port = &ports[pi];\n@@ -1517,10 +1524,13 @@ close_port(portid_t pid)\n return;\n }\n\n+ if (port_id_is_invalid(pid, ENABLED_WARN))\n+ return;\n+\n printf(\"Closing ports...\\n\");\n\n FOREACH_PORT(pi, ports) {\n- if (!port_id_is_invalid(pid, DISABLED_WARN) && pid != pi)\n+ if (pid != pi && pid != (portid_t)RTE_PORT_ALL)\n continue;\n\n port = &ports[pi];\n", "prefixes": [ "dpdk-dev" ] }