Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3858/?format=api
{ "id": 3858, "url": "https://patches.dpdk.org/api/patches/3858/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1425505810-9269-10-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1425505810-9269-10-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1425505810-9269-10-git-send-email-david.marchand@6wind.com", "date": "2015-03-04T21:50:09", "name": "[dpdk-dev,09/10] tailq: remove static slots", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b6ff5f2b7463795982244e9bc331c54e6c8107d1", "submitter": { "id": 3, "url": "https://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1425505810-9269-10-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/3858/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/3858/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E915E9AA2;\n\tWed, 4 Mar 2015 22:50:31 +0100 (CET)", "from mail-we0-f178.google.com (mail-we0-f178.google.com\n\t[74.125.82.178]) by dpdk.org (Postfix) with ESMTP id E02EF9A9B\n\tfor <dev@dpdk.org>; Wed, 4 Mar 2015 22:50:30 +0100 (CET)", "by wesq59 with SMTP id q59so12201697wes.3\n\tfor <dev@dpdk.org>; Wed, 04 Mar 2015 13:50:30 -0800 (PST)", "from alcyon.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237])\n\tby mx.google.com with ESMTPSA id\n\tbf8sm6037947wjb.37.2015.03.04.13.50.28 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 04 Mar 2015 13:50:28 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=EGSUSInqJGig1Jm12UYWsh4AwhvF03IFI/WQK6QKWPI=;\n\tb=e6nprZOqRn8ksHnmT9UCTnsXdVmm8kFm6bUNL/qcti5Y3u4OVMzJwaZhD7RpTA86GO\n\tOQ69PzRmOvmsrorz3eFobKVyYlbQB+/rR+CAOZz85UcxYMbDksdmLR9w5fPy3LODST0X\n\t3kHdVcX4Ww2ezlQTbLpnD0L+bWOOoAPSIGSUh4tvqXce3HSQz/pMmTHtmozVK0UZryhR\n\tk48x447TXUnkAAA51KBxDUew+THwoisS2XdVy/8M7c5xVJ74kSOSpWzF/rkYlGb1C4DG\n\t9fMSdvKxIUXoS2q3ZaLcPWL7CTbkvOsCBvdq0DtlXW3vN+mI0L7F7tiyXL+MIw/uyL9V\n\tSWcw==", "X-Gm-Message-State": "ALoCoQkC1gh9oNbG3BE3SrQcSI8gtiKtV8+40FyIN7ik9cjXvxgT5IMazzPMhUAu/SZhQcBle9TE", "X-Received": "by 10.180.198.101 with SMTP id jb5mr58090207wic.92.1425505830814;\n\tWed, 04 Mar 2015 13:50:30 -0800 (PST)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Date": "Wed, 4 Mar 2015 22:50:09 +0100", "Message-Id": "<1425505810-9269-10-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.7.10.4", "In-Reply-To": "<1425505810-9269-1-git-send-email-david.marchand@6wind.com>", "References": "<1425505810-9269-1-git-send-email-david.marchand@6wind.com>", "Subject": "[dpdk-dev] [PATCH 09/10] tailq: remove static slots", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "No static entry remaining, the rte_tailq api is for \"internal use\" only, get rid\nof the static slots.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 -\n lib/librte_eal/common/Makefile | 2 +-\n lib/librte_eal/common/eal_common_tailqs.c | 47 +-------------\n lib/librte_eal/common/include/rte_eal_memconfig.h | 9 ---\n lib/librte_eal/common/include/rte_tailq.h | 34 ----------\n lib/librte_eal/common/include/rte_tailq_elem.h | 70 ---------------------\n lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 -\n 7 files changed, 3 insertions(+), 161 deletions(-)\n delete mode 100644 lib/librte_eal/common/include/rte_tailq_elem.h", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map\nindex e42ea74..67b6a6c 100644\n--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map\n+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map\n@@ -44,7 +44,6 @@ DPDK_2.0 {\n \trte_eal_process_type;\n \trte_eal_remote_launch;\n \trte_eal_tailq_lookup;\n-\trte_eal_tailq_lookup_by_idx;\n \trte_eal_tailq_register;\n \trte_eal_wait_lcore;\n \trte_exit;\ndiff --git a/lib/librte_eal/common/Makefile b/lib/librte_eal/common/Makefile\nindex 52c1a5f..cf961a7 100644\n--- a/lib/librte_eal/common/Makefile\n+++ b/lib/librte_eal/common/Makefile\n@@ -36,7 +36,7 @@ INC += rte_debug.h rte_eal.h rte_errno.h rte_launch.h rte_lcore.h\n INC += rte_log.h rte_memory.h rte_memzone.h rte_pci.h\n INC += rte_pci_dev_ids.h rte_per_lcore.h rte_random.h\n INC += rte_rwlock.h rte_tailq.h rte_interrupts.h rte_alarm.h\n-INC += rte_string_fns.h rte_version.h rte_tailq_elem.h\n+INC += rte_string_fns.h rte_version.h\n INC += rte_eal_memconfig.h rte_malloc_heap.h\n INC += rte_hexdump.h rte_devargs.h rte_dev.h\n INC += rte_common_vect.h\ndiff --git a/lib/librte_eal/common/eal_common_tailqs.c b/lib/librte_eal/common/eal_common_tailqs.c\nindex 3c4e70d..d9551cd 100644\n--- a/lib/librte_eal/common/eal_common_tailqs.c\n+++ b/lib/librte_eal/common/eal_common_tailqs.c\n@@ -55,14 +55,6 @@\n \n #include \"eal_private.h\"\n \n-/**\n- * Name of tailq_head\n- */\n-const char* rte_tailq_names[RTE_MAX_TAILQ] = {\n-#define rte_tailq_elem(idx, name) name,\n-#include <rte_tailq_elem.h>\n-};\n-\n TAILQ_HEAD(rte_tailq_elem_head, rte_tailq_elem);\n /* local tailq list */\n static struct rte_tailq_elem_head rte_tailq_elem_head =\n@@ -81,11 +73,6 @@ rte_eal_tailq_lookup(const char *name)\n \t\treturn NULL;\n \n \tfor (i = 0; i < RTE_MAX_TAILQ; i++) {\n-\t\tif (i < RTE_TAILQ_NUM &&\n-\t\t !strncmp(name, rte_tailq_names[i], RTE_TAILQ_NAMESIZE-1))\n-\t\t\treturn &mcfg->tailq_head[i];\n-\n-\t\t/* if past static entries, look at shared mem for names */\n \t\tif (!strncmp(name, mcfg->tailq_head[i].name,\n \t\t\t RTE_TAILQ_NAMESIZE-1))\n \t\t\treturn &mcfg->tailq_head[i];\n@@ -94,19 +81,6 @@ rte_eal_tailq_lookup(const char *name)\n \treturn NULL;\n }\n \n-inline struct rte_tailq_head *\n-rte_eal_tailq_lookup_by_idx(const unsigned tailq_idx)\n-{\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n-\n-\tif (tailq_idx >= RTE_MAX_TAILQ) {\n-\t\tRTE_LOG(ERR, EAL, \"%s(): No more room in config\\n\", __func__);\n-\t\treturn NULL;\n-\t}\n-\n-\treturn &mcfg->tailq_head[tailq_idx];\n-}\n-\n void\n rte_dump_tailq(FILE *f)\n {\n@@ -119,15 +93,9 @@ rte_dump_tailq(FILE *f)\n \tfor (i = 0; i < RTE_MAX_TAILQ; i++) {\n \t\tconst struct rte_tailq_head *tailq = &mcfg->tailq_head[i];\n \t\tconst struct rte_tailq_entry_head *head = &tailq->tailq_head;\n-\t\tconst char *name = \"nil\";\n-\n-\t\tif (rte_tailq_names[i])\n-\t\t\tname = rte_tailq_names[i];\n-\t\telse if (tailq->name)\n-\t\t\tname = tailq->name;\n \n \t\tfprintf(f, \"Tailq %u: qname:<%s>, tqh_first:%p, tqh_last:%p\\n\",\n-\t\t\ti, name, head->tqh_first, head->tqh_last);\n+\t\t\ti, tailq->name, head->tqh_first, head->tqh_last);\n \t}\n \trte_rwlock_read_unlock(&mcfg->qlock);\n }\n@@ -209,20 +177,9 @@ error:\n int\n rte_eal_tailqs_init(void)\n {\n-\tunsigned i;\n-\tstruct rte_mem_config *mcfg = NULL;\n \tstruct rte_tailq_elem *t;\n \n-\tRTE_BUILD_BUG_ON(RTE_MAX_TAILQ < RTE_TAILQ_NUM);\n-\n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n-\t\tmcfg = rte_eal_get_configuration()->mem_config;\n-\t\tfor (i = 0; i < RTE_TAILQ_NUM; i++)\n-\t\t\tTAILQ_INIT(&mcfg->tailq_head[i].tailq_head);\n-\t}\n-\n-\t/* mark those static entries as already taken */\n-\trte_tailqs_count = RTE_TAILQ_NUM;\n+\trte_tailqs_count = 0;\n \n \tTAILQ_FOREACH(t, &rte_tailq_elem_head, next) {\n \t\t/* second part of register job for \"early\" tailqs, see\ndiff --git a/lib/librte_eal/common/include/rte_eal_memconfig.h b/lib/librte_eal/common/include/rte_eal_memconfig.h\nindex d6359e5..34f5abc 100644\n--- a/lib/librte_eal/common/include/rte_eal_memconfig.h\n+++ b/lib/librte_eal/common/include/rte_eal_memconfig.h\n@@ -45,15 +45,6 @@ extern \"C\" {\n #endif\n \n /**\n- * Index type of tailq_head\n- */\n-enum rte_tailq_t {\n-#define rte_tailq_elem(idx, name) idx,\n-#define rte_tailq_end(idx) idx\n-#include <rte_tailq_elem.h>\n-};\n-\n-/**\n * the structure for the memory configuration for the RTE.\n * Used by the rte_config structure. It is separated out, as for multi-process\n * support, the memory details should be shared across instances\ndiff --git a/lib/librte_eal/common/include/rte_tailq.h b/lib/librte_eal/common/include/rte_tailq.h\nindex df11183..4a686e6 100644\n--- a/lib/librte_eal/common/include/rte_tailq.h\n+++ b/lib/librte_eal/common/include/rte_tailq.h\n@@ -107,25 +107,6 @@ struct rte_tailq_elem {\n \tRTE_TAILQ_CAST(rte_eal_tailq_lookup(name), struct_name)\n \n /**\n- * Utility macro to make looking up a tailqueue for a particular struct easier.\n- *\n- * @param idx\n- * The tailq idx defined in rte_tail_t to be given to the tail queue.\n- *\n- * @param struct_name\n- * The name of the list type we are using. (Generally this is the same as the\n- * first parameter passed to TAILQ_HEAD macro)\n- *\n- * @return\n- * The return value from rte_eal_tailq_lookup, typecast to the appropriate\n- * structure pointer type.\n- * NULL on error, since the tailq_head is the first\n- * element in the rte_tailq_head structure.\n- */\n-#define RTE_TAILQ_LOOKUP_BY_IDX(idx, struct_name) \\\n-\tRTE_TAILQ_CAST(rte_eal_tailq_lookup_by_idx(idx), struct_name)\n-\n-/**\n * Dump tail queues to the console.\n *\n * @param f\n@@ -149,21 +130,6 @@ void rte_dump_tailq(FILE *f);\n struct rte_tailq_head *rte_eal_tailq_lookup(const char *name);\n \n /**\n- * Lookup for a tail queue.\n- *\n- * Get a pointer to a tail queue header of a tail\n- * queue identified by the name given as an argument.\n- * Note: this function is not multi-thread safe, and should only be called from\n- * a single thread at a time\n- *\n- * @param idx\n- * The tailq idx defined in rte_tail_t to be given to the tail queue.\n- * @return\n- * A pointer to the tail queue head structure.\n- */\n-struct rte_tailq_head *rte_eal_tailq_lookup_by_idx(const unsigned idx);\n-\n-/**\n * Register a tail queue.\n *\n * Register a tail queue from shared memory.\ndiff --git a/lib/librte_eal/common/include/rte_tailq_elem.h b/lib/librte_eal/common/include/rte_tailq_elem.h\ndeleted file mode 100644\nindex e88211c..0000000\n--- a/lib/librte_eal/common/include/rte_tailq_elem.h\n+++ /dev/null\n@@ -1,70 +0,0 @@\n-/*-\n- * BSD LICENSE\n- *\n- * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.\n- * All rights reserved.\n- *\n- * Redistribution and use in source and binary forms, with or without\n- * modification, are permitted provided that the following conditions\n- * are met:\n- *\n- * * Redistributions of source code must retain the above copyright\n- * notice, this list of conditions and the following disclaimer.\n- * * Redistributions in binary form must reproduce the above copyright\n- * notice, this list of conditions and the following disclaimer in\n- * the documentation and/or other materials provided with the\n- * distribution.\n- * * Neither the name of Intel Corporation nor the names of its\n- * contributors may be used to endorse or promote products derived\n- * from this software without specific prior written permission.\n- *\n- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n- * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n- */\n-\n-/**\n- * @file\n- *\n- * This file contains the type of the tailq elem recognised by DPDK, which\n- * can be used to fill out an array of structures describing the tailq.\n- *\n- * In order to populate an array, the user of this file must define this macro:\n- * rte_tailq_elem(idx, name). For example:\n- *\n- * @code\n- * enum rte_tailq_t {\n- * #define rte_tailq_elem(idx, name) idx,\n- * #define rte_tailq_end(idx) idx\n- * #include <rte_tailq_elem.h>\n- * };\n- *\n- * const char* rte_tailq_names[RTE_MAX_TAILQ] = {\n- * #define rte_tailq_elem(idx, name) name,\n- * #include <rte_tailq_elem.h>\n- * };\n- * @endcode\n- *\n- * Note that this file can be included multiple times within the same file.\n- */\n-\n-#ifndef rte_tailq_elem\n-#define rte_tailq_elem(idx, name)\n-#endif /* rte_tailq_elem */\n-\n-#ifndef rte_tailq_end\n-#define rte_tailq_end(idx)\n-#endif /* rte_tailq_end */\n-\n-rte_tailq_end(RTE_TAILQ_NUM)\n-\n-#undef rte_tailq_elem\n-#undef rte_tailq_end\ndiff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map\nindex 3db5856..7e850a9 100644\n--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map\n+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map\n@@ -48,7 +48,6 @@ DPDK_2.0 {\n \trte_eal_process_type;\n \trte_eal_remote_launch;\n \trte_eal_tailq_lookup;\n-\trte_eal_tailq_lookup_by_idx;\n \trte_eal_tailq_register;\n \trte_eal_vdev_init;\n \trte_eal_vdev_uninit;\n", "prefixes": [ "dpdk-dev", "09/10" ] }