Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 38520,
    "url": "https://patches.dpdk.org/api/patches/38520/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180419110418.8099-1-kevin.laatz@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180419110418.8099-1-kevin.laatz@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180419110418.8099-1-kevin.laatz@intel.com",
    "date": "2018-04-19T11:04:18",
    "name": "[dpdk-dev] examples/ip_pipeline: fix resource leak",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "5f768a85ecfb62d3cda0d1f94a68fd21bd6bba60",
    "submitter": {
        "id": 921,
        "url": "https://patches.dpdk.org/api/people/921/?format=api",
        "name": "Kevin Laatz",
        "email": "kevin.laatz@intel.com"
    },
    "delegate": {
        "id": 10018,
        "url": "https://patches.dpdk.org/api/users/10018/?format=api",
        "username": "cristian_dumitrescu",
        "first_name": "Cristian",
        "last_name": "Dumitrescu",
        "email": "cristian.dumitrescu@intel.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180419110418.8099-1-kevin.laatz@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/38520/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/38520/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2B7D17CC3;\n\tThu, 19 Apr 2018 13:04:23 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id D6F587CC3\n\tfor <dev@dpdk.org>; Thu, 19 Apr 2018 13:04:21 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Apr 2018 04:04:20 -0700",
            "from silpixa00397517.ir.intel.com (HELO\n\tsilpixa00397517.ger.corp.intel.com) ([10.237.222.54])\n\tby orsmga001.jf.intel.com with ESMTP; 19 Apr 2018 04:04:19 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.48,468,1517904000\"; d=\"scan'208\";a=\"49129883\"",
        "From": "Kevin Laatz <kevin.laatz@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "cristian.dumitrescu@intel.com, Kevin Laatz <kevin.laatz@intel.com>,\n\tjasvinder.singh@intel.com",
        "Date": "Thu, 19 Apr 2018 12:04:18 +0100",
        "Message-Id": "<20180419110418.8099-1-kevin.laatz@intel.com>",
        "X-Mailer": "git-send-email 2.9.5",
        "Subject": "[dpdk-dev] [PATCH] examples/ip_pipeline: fix resource leak",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Closing the fd_server file descriptor on error to fix the resource leak.\n\nCoverity issue: 272587\nFixes: 4bbf8e30aa5e (\"examples/ip_pipeline: add CLI interface\")\nCc: jasvinder.singh@intel.com\n\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\n---\n examples/ip_pipeline/conn.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/examples/ip_pipeline/conn.c b/examples/ip_pipeline/conn.c\nindex 9338942..6b08e9e 100644\n--- a/examples/ip_pipeline/conn.c\n+++ b/examples/ip_pipeline/conn.c\n@@ -96,12 +96,14 @@ conn_init(struct conn_params *p)\n \t\tsizeof(server_address));\n \tif (status == -1) {\n \t\tconn_free(conn);\n+\t\tclose(fd_server);\n \t\treturn NULL;\n \t}\n \n \tstatus = listen(fd_server, 16);\n \tif (status == -1) {\n \t\tconn_free(conn);\n+\t\tclose(fd_server);\n \t\treturn NULL;\n \t}\n \n@@ -109,6 +111,7 @@ conn_init(struct conn_params *p)\n \tfd_client_group = epoll_create(1);\n \tif (fd_client_group == -1) {\n \t\tconn_free(conn);\n+\t\tclose(fd_server);\n \t\treturn NULL;\n \t}\n \n",
    "prefixes": [
        "dpdk-dev"
    ]
}