Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/38489/?format=api
https://patches.dpdk.org/api/patches/38489/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180419100204.5728-2-adrien.mazarguil@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180419100204.5728-2-adrien.mazarguil@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180419100204.5728-2-adrien.mazarguil@6wind.com", "date": "2018-04-19T10:07:25", "name": "[dpdk-dev,v6,01/11] net/mlx4: fix RSS resource leak in case of error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d65a7f3c555d52ecb712639b44280250d50bfd37", "submitter": { "id": 165, "url": "https://patches.dpdk.org/api/people/165/?format=api", "name": "Adrien Mazarguil", "email": "adrien.mazarguil@6wind.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180419100204.5728-2-adrien.mazarguil@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/38489/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/38489/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3C2D57D0A;\n\tThu, 19 Apr 2018 12:07:46 +0200 (CEST)", "from mail-wr0-f196.google.com (mail-wr0-f196.google.com\n\t[209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 5DA917CEA\n\tfor <dev@dpdk.org>; Thu, 19 Apr 2018 12:07:40 +0200 (CEST)", "by mail-wr0-f196.google.com with SMTP id f14-v6so12429568wre.4\n\tfor <dev@dpdk.org>; Thu, 19 Apr 2018 03:07:40 -0700 (PDT)", "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tu36-v6sm6445155wrf.87.2018.04.19.03.07.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 19 Apr 2018 03:07:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to;\n\tbh=f3yKAIbsfootN2Trc/wvgUrGMz8JLiGPVYKwDcXwD0o=;\n\tb=zUZurLct/IZdG2xkCJNpv3iudTT/fPQlaPbtUSGTfe39gwa6lO+c3b0VzPMAyRHpNW\n\tKj4MXKbwMqaHqI8gmqkDBCTnc6h+/f77OaNeQPuW9YrEqu+ZpnGFMbaaScyOvdxH8lPQ\n\tEt8ZOwzDFF3v6o7hirldtWBZ0svcbxdAVOG8XLPBwqwn66TQbkC5O8d+PlVZ9haWVouf\n\tbu7g2m3BlLGRcrduEhty0fufsTC/t8B36uwSL7CSlr7jGG1dx9YnS4TxLZKgStzS3Vz5\n\tnr9YEeau3zWY2COnkvKC220y6iSSQnf/kjo7xSDVOfATmUwgB4fVhOImoePRsXyLOR7W\n\t51Og==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to;\n\tbh=f3yKAIbsfootN2Trc/wvgUrGMz8JLiGPVYKwDcXwD0o=;\n\tb=UAC2aERReGUrPVCcQfjEoEESwo03mK3U7j49luDlA2dT94RCx2IvoZ3X9w5HvFo4zv\n\t77wrxuCV/xmaPGm00jOiakXkn/IGJdhRlV2WroCbEqu9Ra0RvMrMedULklgt4U3OKbBs\n\taQinAwI3L16ljJx+P9Hj05FogaHtMSrHVMRqxQsV8dF4v3QH4UtT9EyozgRC6AIGWHPV\n\tSC+09Od8kZaSkZV8jO1pXhcfF1EXSj5FKm7jEEvBRv0uwh1AZMVdgs+ST58JihEmCuUx\n\tf3fYZoZp1UGDHhVyUjToqz/i9r98+1hI9uOcpWkH3G3LLH+3Q/y/K25MhF8jYF8ylCCA\n\tHh7w==", "X-Gm-Message-State": "ALQs6tBtV/mz0z852N5pyCFB/TJaTTKeRWJxxjY5x/aIkZrgYsZQRn2x\n\t2cuyp9Fxk64gIOcyfhT7kDr24QeX", "X-Google-Smtp-Source": "AIpwx481kNvWKKO+oEuBAIvPEbHAGcWkQy8K8H0F7wIXItfu14E4KFwbB2bwTir6iLAqtgwyehOBgg==", "X-Received": "by 2002:adf:90c3:: with SMTP id\n\ti61-v6mr4302319wri.227.1524132460028; \n\tThu, 19 Apr 2018 03:07:40 -0700 (PDT)", "Date": "Thu, 19 Apr 2018 12:07:25 +0200", "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>", "Message-ID": "<20180419100204.5728-2-adrien.mazarguil@6wind.com>", "References": "<20180416150058.2620-1-adrien.mazarguil@6wind.com>\n\t<20180419100204.5728-1-adrien.mazarguil@6wind.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<20180419100204.5728-1-adrien.mazarguil@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[dpdk-dev] [PATCH v6 01/11] net/mlx4: fix RSS resource leak in case\n\tof error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When memory cannot be allocated for a flow rule, its RSS context reference\nis not dropped.\n\nFixes: 078b8b452e6b (\"net/mlx4: add RSS flow rule action support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\nAcked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\nCc: Shahaf Shuler <shahafs@mellanox.com>\n---\n drivers/net/mlx4/mlx4_flow.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c\nindex f3063ee8a..2b4bf7094 100644\n--- a/drivers/net/mlx4/mlx4_flow.c\n+++ b/drivers/net/mlx4/mlx4_flow.c\n@@ -820,11 +820,14 @@ mlx4_flow_prepare(struct priv *priv,\n \t\t\t},\n \t\t};\n \n-\t\tif (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec)))\n+\t\tif (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) {\n+\t\t\tif (temp.rss)\n+\t\t\t\tmlx4_rss_put(temp.rss);\n \t\t\treturn rte_flow_error_set\n \t\t\t\t(error, -rte_errno,\n \t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n \t\t\t\t \"flow rule handle allocation failure\");\n+\t\t}\n \t\t/* Most fields will be updated by second pass. */\n \t\t*flow = (struct rte_flow){\n \t\t\t.ibv_attr = temp.ibv_attr,\n", "prefixes": [ "dpdk-dev", "v6", "01/11" ] }{ "id": 38489, "url": "