Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3830/?format=api
{ "id": 3830, "url": "https://patches.dpdk.org/api/patches/3830/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1425396230-13379-8-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1425396230-13379-8-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1425396230-13379-8-git-send-email-thomas.monjalon@6wind.com", "date": "2015-03-03T15:23:50", "name": "[dpdk-dev,7/7] bond: remove debug function to fix link with shared lib", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "09740689212654319f224e7680e92e6312fc470e", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1425396230-13379-8-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/3830/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/3830/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 173B39A8C;\n\tTue, 3 Mar 2015 16:24:43 +0100 (CET)", "from mail-wi0-f173.google.com (mail-wi0-f173.google.com\n\t[209.85.212.173]) by dpdk.org (Postfix) with ESMTP id A4C649A88\n\tfor <dev@dpdk.org>; Tue, 3 Mar 2015 16:24:41 +0100 (CET)", "by widex7 with SMTP id ex7so23644927wid.4\n\tfor <dev@dpdk.org>; Tue, 03 Mar 2015 07:24:41 -0800 (PST)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by mx.google.com with ESMTPSA id\n\tgf11sm2889236wic.18.2015.03.03.07.24.39 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 03 Mar 2015 07:24:39 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Riusdj4fTESGMBJIWnleNnvUam9UwlsgF44VLWNEY6U=;\n\tb=Uml8IRmBVyP+WgdjqC3pYTxgnFPqBnruPMprFjVm66KtSckL10GOrdVHtfO/U/1hIl\n\tDht2w6f9C8Dx5FZ8rYNMD6o0aKV+QQxLJO9zuYB1wJQbet1oo5IisYISxrxVT+hFN9S2\n\tXpRWw56Ambz+Ro3N7a9lfeNi0Ri/VuJCkMpPfbtdA6X8G9KQmeG8+01681rTXVTbsPWu\n\tL3RjGdbvzzSa44ILRJk414ZBS8dt0IMjxzY9E9dsjj0MwGlCQpFsxa1AhO4MSZGgFEyr\n\tDLKfEprKyFXzorbAOKp3FSFrZj1QFP/rFzhDW+IgQl3OU+vaBF33zR4Xo+7YVbFYvWmx\n\traTA==", "X-Gm-Message-State": "ALoCoQmq2Ioca10t/ot6/jyKcAOuSG/ktf2RITE5IRaPaTnzx7crQukUU3Ul0h5MMisFVqpiEqZQ", "X-Received": "by 10.181.13.42 with SMTP id ev10mr3719743wid.69.1425396281328; \n\tTue, 03 Mar 2015 07:24:41 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Tue, 3 Mar 2015 16:23:50 +0100", "Message-Id": "<1425396230-13379-8-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.2.2", "In-Reply-To": "<1425396230-13379-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1425396230-13379-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH 7/7] bond: remove debug function to fix link with\n\tshared lib", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function print_client_stats was used in the example without being\nclearly exported in the map file. So it breaks linking with shared library\nwhen debug is enabled.\nIt's better to remove this function as it probably could be implemented\nwith statistics API.\n\nFixes: cc7e8ae84faa (\"add example application for link bonding mode 6\")\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n examples/bond/main.c | 5 -----\n lib/librte_pmd_bond/rte_eth_bond_pmd.c | 13 -------------\n 2 files changed, 18 deletions(-)", "diff": "diff --git a/examples/bond/main.c b/examples/bond/main.c\nindex e4457f2..7da6bfc 100644\n--- a/examples/bond/main.c\n+++ b/examples/bond/main.c\n@@ -650,7 +650,6 @@ cmdline_parse_inst_t cmd_quit = {\n \t},\n };\n \n-extern void print_client_stats(void);\n struct cmd_show_result {\n \tcmdline_fixed_string_t show;\n };\n@@ -680,10 +679,6 @@ static void cmd_show_parsed(__attribute__((unused)) void *parsed_result,\n \t\t\tglobal_flag_stru_p->port_packets[1],\n \t\t\tglobal_flag_stru_p->port_packets[2]);\n \trte_spinlock_unlock(&global_flag_stru_p->lock);\n-\n-#if defined(RTE_LIBRTE_BOND_DEBUG_ALB_L1) || defined(RTE_LIBRTE_BOND_DEBUG_ALB)\n-\tprint_client_stats();\n-#endif\n }\n \n cmdline_parse_token_string_t cmd_show_show =\ndiff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c\nindex 7dee5f2..af8113e 100644\n--- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c\n+++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c\n@@ -279,19 +279,6 @@ update_client_stats(uint32_t addr, uint8_t port, uint32_t *TXorRXindicator)\n \n }\n \n-void print_client_stats(void);\n-void print_client_stats(void)\n-{\n-\tint i = 0;\n-\tchar buf[MaxIPv4String];\n-\n-\tfor (; i < active_clients; i++)\t{\n-\t\tipv4_addr_to_dot(client_stats[i].ipv4_addr, buf, MaxIPv4String);\n-\t\tprintf(\"port:%d client:%s RX:%d TX:%d\\n\", client_stats[i].port,\tbuf,\n-\t\t\t\tclient_stats[i].ipv4_rx_packets,\n-\t\t\t\tclient_stats[i].ipv4_tx_packets);\n-\t}\n-}\n #ifdef RTE_LIBRTE_BOND_DEBUG_ALB\n #define MODE6_DEBUG(info, src_ip, dst_ip, eth_h, arp_op, port, burstnumber)\t\\\n \t\tRTE_LOG(DEBUG, PMD, \\\n", "prefixes": [ "dpdk-dev", "7/7" ] }