Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 3768,
    "url": "https://patches.dpdk.org/api/patches/3768/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1425035919-21060-1-git-send-email-pablo.de.lara.guarch@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1425035919-21060-1-git-send-email-pablo.de.lara.guarch@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1425035919-21060-1-git-send-email-pablo.de.lara.guarch@intel.com",
    "date": "2015-02-27T11:18:39",
    "name": "[dpdk-dev] testpmd: stop pkt forwarding when quitting testpmd",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "454c30d859a45f60028dec05e296f94ecc2f02d4",
    "submitter": {
        "id": 9,
        "url": "https://patches.dpdk.org/api/people/9/?format=api",
        "name": "De Lara Guarch, Pablo",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1425035919-21060-1-git-send-email-pablo.de.lara.guarch@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/3768/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/3768/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A8B3B3208;\n\tFri, 27 Feb 2015 12:18:44 +0100 (CET)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 44D3D3005\n\tfor <dev@dpdk.org>; Fri, 27 Feb 2015 12:18:42 +0100 (CET)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 27 Feb 2015 03:18:40 -0800",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 27 Feb 2015 03:18:40 -0800",
            "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt1RBIdOi022260 for <dev@dpdk.org>; Fri, 27 Feb 2015 11:18:39 GMT",
            "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t1RBIdaG021096\n\tfor <dev@dpdk.org>; Fri, 27 Feb 2015 11:18:39 GMT",
            "(from pdelarax@localhost)\n\tby sivswdev02.ir.intel.com with  id t1RBId3B021092\n\tfor dev@dpdk.org; Fri, 27 Feb 2015 11:18:39 GMT"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.09,659,1418112000\"; d=\"scan'208\";a=\"684318363\"",
        "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri, 27 Feb 2015 11:18:39 +0000",
        "Message-Id": "<1425035919-21060-1-git-send-email-pablo.de.lara.guarch@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "Subject": "[dpdk-dev] [PATCH] testpmd: stop pkt forwarding when quitting\n\ttestpmd",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When user quits testpmd, and there is traffic being forwarded,\nthat may produce a segmentation fault, due to ports being closed,\nwhile they are still transmitting packets.\n\nThis patch prevents the issue from happening,\nby stopping packet forwarding before closing the ports.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n app/test-pmd/testpmd.c |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)",
    "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 61291be..7be96ad 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -1623,6 +1623,9 @@ pmd_test_exit(void)\n {\n \tportid_t pt_id;\n \n+\tif (test_done == 0)\n+\t\tstop_packet_forwarding();\n+\n \tFOREACH_PORT(pt_id, ports) {\n \t\tprintf(\"Stopping port %d...\", pt_id);\n \t\tfflush(stdout);\n",
    "prefixes": [
        "dpdk-dev"
    ]
}