Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/37563/?format=api
{ "id": 37563, "url": "https://patches.dpdk.org/api/patches/37563/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/9c47f8ca01a4f32b54945c14402caf3ee8f699b9.1523218215.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<9c47f8ca01a4f32b54945c14402caf3ee8f699b9.1523218215.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9c47f8ca01a4f32b54945c14402caf3ee8f699b9.1523218215.git.anatoly.burakov@intel.com", "date": "2018-04-08T20:18:00", "name": "[dpdk-dev,v4,27/70] bus/pci: use memseg walk instead of iteration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "029ecb8e02f5d8596c1134e6e476257f3b30f941", "submitter": { "id": 4, "url": "https://patches.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/9c47f8ca01a4f32b54945c14402caf3ee8f699b9.1523218215.git.anatoly.burakov@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/37563/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/37563/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5BDB21B715;\n\tSun, 8 Apr 2018 22:19:53 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id E2ECD1B692\n\tfor <dev@dpdk.org>; Sun, 8 Apr 2018 22:18:53 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Apr 2018 13:18:53 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga003.jf.intel.com with ESMTP; 08 Apr 2018 13:18:49 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw38KIntu021148; Sun, 8 Apr 2018 21:18:49 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w38KInYI011073;\n\tSun, 8 Apr 2018 21:18:49 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w38KInCR011069;\n\tSun, 8 Apr 2018 21:18:49 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,424,1517904000\"; d=\"scan'208\";a=\"41706559\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "keith.wiles@intel.com, jianfeng.tan@intel.com, andras.kovacs@ericsson.com,\n\tlaszlo.vadkeri@ericsson.com, benjamin.walker@intel.com,\n\tbruce.richardson@intel.com, thomas@monjalon.net,\n\tkonstantin.ananyev@intel.com, kuralamudhan.ramakrishnan@intel.com,\n\tlouise.m.daly@intel.com, nelio.laranjeiro@6wind.com,\n\tyskoh@mellanox.com, pepperjo@japf.ch, jerin.jacob@caviumnetworks.com, \n\themant.agrawal@nxp.com, olivier.matz@6wind.com, shreyansh.jain@nxp.com,\n\tgowrishankar.m@linux.vnet.ibm.com", "Date": "Sun, 8 Apr 2018 21:18:00 +0100", "Message-Id": "<9c47f8ca01a4f32b54945c14402caf3ee8f699b9.1523218215.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1523218215.git.anatoly.burakov@intel.com>", "<cover.1523218215.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1523218215.git.anatoly.burakov@intel.com>", "<cover.1522797505.git.anatoly.burakov@intel.com>\n\t<cover.1523218215.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v4 27/70] bus/pci: use memseg walk instead of\n\titeration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Reduce dependency on internal details of EAL memory subsystem, and\nsimplify code.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n drivers/bus/pci/Makefile | 3 +++\n drivers/bus/pci/linux/pci.c | 26 ++++++++++++++------------\n drivers/bus/pci/meson.build | 3 +++\n 3 files changed, 20 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile\nindex f3df1c4..804a198 100644\n--- a/drivers/bus/pci/Makefile\n+++ b/drivers/bus/pci/Makefile\n@@ -49,6 +49,9 @@ CFLAGS += -I$(RTE_SDK)/drivers/bus/pci/$(SYSTEM)\n CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common\n CFLAGS += -I$(RTE_SDK)/lib/librte_eal/$(SYSTEM)app/eal\n \n+# memseg walk is not part of stable API yet\n+CFLAGS += -DALLOW_EXPERIMENTAL_API\n+\n LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring\n LDLIBS += -lrte_ethdev -lrte_pci\n \ndiff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex abde641..6dda054 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -116,22 +116,24 @@ rte_pci_unmap_device(struct rte_pci_device *dev)\n \t}\n }\n \n-void *\n-pci_find_max_end_va(void)\n+static int\n+find_max_end_va(const struct rte_memseg *ms, void *arg)\n {\n-\tconst struct rte_memseg *seg = rte_eal_get_physmem_layout();\n-\tconst struct rte_memseg *last = seg;\n-\tunsigned i = 0;\n+\tvoid *end_va = RTE_PTR_ADD(ms->addr, ms->len);\n+\tvoid **max_va = arg;\n \n-\tfor (i = 0; i < RTE_MAX_MEMSEG; i++, seg++) {\n-\t\tif (seg->addr == NULL)\n-\t\t\tbreak;\n+\tif (*max_va < end_va)\n+\t\t*max_va = end_va;\n+\treturn 0;\n+}\n \n-\t\tif (seg->addr > last->addr)\n-\t\t\tlast = seg;\n+void *\n+pci_find_max_end_va(void)\n+{\n+\tvoid *va = NULL;\n \n-\t}\n-\treturn RTE_PTR_ADD(last->addr, last->len);\n+\trte_memseg_walk(find_max_end_va, &va);\n+\treturn va;\n }\n \n /* parse one line of the \"resource\" sysfs file (note that the 'line'\ndiff --git a/drivers/bus/pci/meson.build b/drivers/bus/pci/meson.build\nindex 12756a4..72939e5 100644\n--- a/drivers/bus/pci/meson.build\n+++ b/drivers/bus/pci/meson.build\n@@ -14,3 +14,6 @@ else\n \tsources += files('bsd/pci.c')\n \tincludes += include_directories('bsd')\n endif\n+\n+# memseg walk is not part of stable API yet\n+allow_experimental_apis = true\n", "prefixes": [ "dpdk-dev", "v4", "27/70" ] }