Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 37159,
    "url": "https://patches.dpdk.org/api/patches/37159/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180404144805.11966-8-adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180404144805.11966-8-adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180404144805.11966-8-adrien.mazarguil@6wind.com",
    "date": "2018-04-04T14:57:58",
    "name": "[dpdk-dev,v2,07/13] app/testpmd: fix lack of flow action configuration",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "4b6b43372bdf6f824bb62e6a21fd0fd9ae0ee294",
    "submitter": {
        "id": 165,
        "url": "https://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180404144805.11966-8-adrien.mazarguil@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/37159/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/37159/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AADFC1C742;\n\tWed,  4 Apr 2018 16:58:16 +0200 (CEST)",
            "from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 1088F1C704\n\tfor <dev@dpdk.org>; Wed,  4 Apr 2018 16:58:12 +0200 (CEST)",
            "by mail-wm0-f67.google.com with SMTP id t67so22247672wmt.0\n\tfor <dev@dpdk.org>; Wed, 04 Apr 2018 07:58:12 -0700 (PDT)",
            "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tn143sm5349354wmd.29.2018.04.04.07.58.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 04 Apr 2018 07:58:11 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to;\n\tbh=eb/7AXisvGSFa+a8kVlxHErkl0arni+/Vbc1tg32RaY=;\n\tb=UL0SPORo7s2UaRURBhxZAzUuUmyOMCdiX2PDf4cIQK1Va2VSB4bAbgYGS+D/5xrBeL\n\tXMGrW02MhmfG7nZiDu/F4gkVjC9DVhgUCDUEzHYdZeYW1uRBBYbB+6O8nPnCuLxxiXJR\n\t8g/Un5nPYjcAZ11ltrxsKClmrXUz0d6HebwzRp5g1PHVbfaorWSYLgp4Dm2haY1NaHJn\n\t8C40HoIyN8B6BB3+nXA6Jad/MVMzcQgd4S1/AEzgT6cwdJItCxN997IFobps5gB9O6JS\n\t/eE5gozX9e54GD56Mcq5K1+VWg1YjMo9g/e0DtUqjwsrU5fcOGjOAUI6hcjCI83AV8a0\n\tE2kA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to;\n\tbh=eb/7AXisvGSFa+a8kVlxHErkl0arni+/Vbc1tg32RaY=;\n\tb=GeQOyxMuG5jHEqK1hFW9XkuIjzA4mh/sNf0tnimziFoJvSyBwtvuk2WNyCQHDTb85y\n\tGswzNCwoSjnNJ/aevr+wvxkSBeXJRaopOQUKA8V89dhyqeH3YVGtgCF7JPw259KZaSlL\n\tVj8zvh4eSaUjG3PIAAQY6/fq/wgQRov05UlPgKV90o3+jdiSsAEdoID5Sczth03e3neD\n\tIaoxvDq4RB507ng/epEQknGHaUUNVNU0uz25LoMxcgT41dWnRtqWc+zbvdxm699nCMCt\n\tN57QKjWRuZBUW3slJKAd6joWDSkcz/qQXdSCta1rJQ4G/sXLnGTYj5zc5euvqi1/sQO4\n\tubaw==",
        "X-Gm-Message-State": "ALQs6tA1WgGsgFM5MDjWiOfhVWX8Xw9kfejIXhTbAvKoJ5oXP7a1PoLC\n\thq7PbFoC4Mh+LnPHfdwrGKyO+7L6",
        "X-Google-Smtp-Source": "AIpwx4+CiiCuwXyU1cu2l4dGUMfZMRGhZrhEG8N7EcGGT6kaDunrA2JCPvtwNjhWVcegbNle5KES5w==",
        "X-Received": "by 10.28.213.12 with SMTP id m12mr7396040wmg.98.1522853891638;\n\tWed, 04 Apr 2018 07:58:11 -0700 (PDT)",
        "Date": "Wed, 4 Apr 2018 16:57:58 +0200",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "stable@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,\n\tJingjing Wu <jingjing.wu@intel.com>",
        "Message-ID": "<20180404144805.11966-8-adrien.mazarguil@6wind.com>",
        "References": "<20180323124725.15806-1-adrien.mazarguil@6wind.com>\n\t<20180404144805.11966-1-adrien.mazarguil@6wind.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=us-ascii",
        "Content-Disposition": "inline",
        "In-Reply-To": "<20180404144805.11966-1-adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.11.0",
        "Subject": "[dpdk-dev] [PATCH v2 07/13] app/testpmd: fix lack of flow action\n\tconfiguration",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Configuration structure is not optional with flow rule actions that expect\none; this pointer is not supposed to be NULL and PMDs should not have to\nverify it.\n\nLike pattern item spec/last/mask fields, it is currently set when at least\none configuration parameter is provided on the command line. This patch\nsets it as soon as an action is created instead.\n\nFixes: 7a91969ad35e (\"app/testpmd: add various actions to flow command\")\nCc: stable@dpdk.org\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\nCc: Wenzhuo Lu <wenzhuo.lu@intel.com>\nCc: Jingjing Wu <jingjing.wu@intel.com>\n---\n app/test-pmd/cmdline_flow.c | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)",
    "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 9cac8e9bf..c2cf415ef 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -1909,6 +1909,7 @@ parse_vc(struct context *ctx, const struct token *token,\n \t\t\treturn -1;\n \t\t*action = (struct rte_flow_action){\n \t\t\t.type = priv->type,\n+\t\t\t.conf = data_size ? data : NULL,\n \t\t};\n \t\t++out->args.vc.actions_n;\n \t\tctx->object = action;\n@@ -1989,7 +1990,6 @@ parse_vc_conf(struct context *ctx, const struct token *token,\n \t      void *buf, unsigned int size)\n {\n \tstruct buffer *out = buf;\n-\tstruct rte_flow_action *action;\n \n \t(void)size;\n \t/* Token name must match. */\n@@ -1998,14 +1998,9 @@ parse_vc_conf(struct context *ctx, const struct token *token,\n \t/* Nothing else to do if there is no buffer. */\n \tif (!out)\n \t\treturn len;\n-\tif (!out->args.vc.actions_n)\n-\t\treturn -1;\n-\taction = &out->args.vc.actions[out->args.vc.actions_n - 1];\n \t/* Point to selected object. */\n \tctx->object = out->args.vc.data;\n \tctx->objmask = NULL;\n-\t/* Update configuration pointer. */\n-\taction->conf = ctx->object;\n \treturn len;\n }\n \n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "07/13"
    ]
}