Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3676/?format=api
https://patches.dpdk.org/api/patches/3676/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1424784647-19367-4-git-send-email-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1424784647-19367-4-git-send-email-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1424784647-19367-4-git-send-email-bruce.richardson@intel.com", "date": "2015-02-24T13:30:47", "name": "[dpdk-dev,v4,3/3] eal: remove unnecessary check for primary instance", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2d628bab1a568e29c5b46a1acb7814916dd6b95d", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1424784647-19367-4-git-send-email-bruce.richardson@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/3676/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/3676/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5A8D5ADAA;\n\tTue, 24 Feb 2015 14:30:59 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 57EA59A8D\n\tfor <dev@dpdk.org>; Tue, 24 Feb 2015 14:30:52 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP; 24 Feb 2015 05:26:33 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga002.jf.intel.com with ESMTP; 24 Feb 2015 05:30:49 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt1ODUmvU021026; Tue, 24 Feb 2015 13:30:48 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id t1ODUmfT019428;\n\tTue, 24 Feb 2015 13:30:48 GMT", "(from bricha3@localhost)\n\tby sivswdev01.ir.intel.com with id t1ODUmG1019424;\n\tTue, 24 Feb 2015 13:30:48 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,638,1418112000\"; d=\"scan'208\";a=\"690000607\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 24 Feb 2015 13:30:47 +0000", "Message-Id": "<1424784647-19367-4-git-send-email-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1424784647-19367-1-git-send-email-bruce.richardson@intel.com>", "References": "<1424703444-30761-1-git-send-email-bruce.richardson@intel.com>\n\t<1424784647-19367-1-git-send-email-bruce.richardson@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 3/3] eal: remove unnecessary check for primary\n\tinstance", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In pci_uio_map_resource we check that we are in a primary process\nbefore calling pci_uio_set_bus_master. However, there is already\nan earlier check which means that we are always in a primary instance\nat this point in the code, so the check can be removed.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c\nindex c12794e..0a95376 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c\n@@ -304,11 +304,9 @@ pci_uio_map_resource(struct rte_pci_device *dev)\n \t}\n \n \t/* set bus master that is not done by uio_pci_generic */\n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n-\t\tif (pci_uio_set_bus_master(dev->intr_handle.uio_cfg_fd)) {\n-\t\t\tRTE_LOG(ERR, EAL, \"Cannot set up bus mastering!\\n\");\n-\t\t\treturn -1;\n-\t\t}\n+\tif (pci_uio_set_bus_master(dev->intr_handle.uio_cfg_fd)) {\n+\t\tRTE_LOG(ERR, EAL, \"Cannot set up bus mastering!\\n\");\n+\t\treturn -1;\n \t}\n \n \t/* allocate the mapping details for secondary processes*/\n", "prefixes": [ "dpdk-dev", "v4", "3/3" ] }{ "id": 3676, "url": "