Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/36555/?format=api
{ "id": 36555, "url": "https://patches.dpdk.org/api/patches/36555/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/91999be303191e0c971b01f4b728b1f262c5abcb.1522105876.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<91999be303191e0c971b01f4b728b1f262c5abcb.1522105876.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/91999be303191e0c971b01f4b728b1f262c5abcb.1522105876.git.gaetan.rivet@6wind.com", "date": "2018-03-26T23:18:39", "name": "[dpdk-dev,v3,15/20] bus/vdev: fix find device implementation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1993f63e9889ea4eb4b3a4676f1ee7475f549ecd", "submitter": { "id": 269, "url": "https://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/91999be303191e0c971b01f4b728b1f262c5abcb.1522105876.git.gaetan.rivet@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/36555/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/36555/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 29E02AAD6;\n\tTue, 27 Mar 2018 01:19:35 +0200 (CEST)", "from mail-wr0-f193.google.com (mail-wr0-f193.google.com\n\t[209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 814CFA499\n\tfor <dev@dpdk.org>; Tue, 27 Mar 2018 01:19:23 +0200 (CEST)", "by mail-wr0-f193.google.com with SMTP id d1so8494541wrj.13\n\tfor <dev@dpdk.org>; Mon, 26 Mar 2018 16:19:23 -0700 (PDT)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id 67sm343712wra.9.2018.03.26.16.19.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 26 Mar 2018 16:19:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=CBizV8xnImk9YXYqDoufto1j5SZuj7CwPr21XNTDnPg=;\n\tb=TqwOvaxmM1Ayb71uDb/TUDSK4MW+bfXtWJzn0aljLGu1nNkKRKkJCDtlcPoDZ+VrUS\n\tAdStCg5L+lOoNuTOhdeLWPOaI1pIdF/E6ohCi/dcQflQfGWv9S2xJlNk2JV2YogFJGii\n\tcB7/FSXjsagcLsB5F6WQzatkiKxblHvbkL+s6WxN/nu943fLrH4Og1VgRQhKqqCBLJ2Y\n\ti+SJ92LfQT//3TaukINZwcINcDlAJM8otO48YmywbYJICsVHdZ2hDn3ITRQnnxorDnLO\n\t2+xDrHvmCUdW2pRLUIObrU1r5tb9V5rvGYVmFIlD+YAWpCU2GBzPVH0QseMkzgx5ue9D\n\tVvaQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=CBizV8xnImk9YXYqDoufto1j5SZuj7CwPr21XNTDnPg=;\n\tb=cdRfCaTdYXDrc5+xXUnjsvDHKFkH1ZYgNCQFFQPz5R4BnyFoO7qQoYIF9LziBbD0vS\n\tKUL/SovAH8OnhhkzKPUKd9Rixhc8VcKBk/FJEWcVCfjMcyeJwTnwLNeWslsWRHXusCu9\n\t9vv+1lzb4JCbofhcw9XwA+TQDFeATMi/eieHwXoxiMG+bAd+A4y4IaKPCQlEqsYVKigK\n\t9VO8PiIs0L+nhD6Hc8c9QSyYh6Myb80xCi2U28qDRrrV1Hk/zlrIUqvJ8bZ2ZK8P/0YR\n\tkMvwj4Z+VhUwXPp9mh2uBIIuLFnvQ5qm09Hdo1I5U9d74WURiOLG0KfleySO/FXpxFc1\n\tnECA==", "X-Gm-Message-State": "AElRT7E6rcte43R592DQUgLnrGUdCLci7ZNzMzzPvOREj36LRmSexf6N\n\tz6e4oVFxlFpW04yYN+o6XCsW8kK7", "X-Google-Smtp-Source": "AG47ELvADsABs5u1qrOq6ioI3Ye+Wf3eXYjSOyIdBw89xA3dWuRzvOSZH8n9StR+jUmkDewl7dKZkg==", "X-Received": "by 10.223.199.10 with SMTP id k10mr31413693wrg.186.1522106362855;\n\tMon, 26 Mar 2018 16:19:22 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>,\n\tstable@dpdk.org", "Date": "Tue, 27 Mar 2018 01:18:39 +0200", "Message-Id": "<91999be303191e0c971b01f4b728b1f262c5abcb.1522105876.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": [ "<cover.1522105876.git.gaetan.rivet@6wind.com>", "<cover.1522105876.git.gaetan.rivet@6wind.com>" ], "References": [ "<cover.1521652453.git.gaetan.rivet@6wind.com>\n\t<cover.1522105876.git.gaetan.rivet@6wind.com>", "<cover.1522105876.git.gaetan.rivet@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH v3 15/20] bus/vdev: fix find device implementation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If start is set and a device before it matches the data,\nthis device is returned.\n\nThis induces potentially infinite loops.\n\nFixes: c7fe1eea8a74 (\"bus: simplify finding starting point\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n drivers/bus/vdev/rte_bus_vdev.h | 3 +++\n drivers/bus/vdev/vdev.c | 14 +++++++++-----\n 2 files changed, 12 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/bus/vdev/rte_bus_vdev.h b/drivers/bus/vdev/rte_bus_vdev.h\nindex f9d8a2383..4da9967c6 100644\n--- a/drivers/bus/vdev/rte_bus_vdev.h\n+++ b/drivers/bus/vdev/rte_bus_vdev.h\n@@ -53,6 +53,9 @@ struct rte_vdev_device {\n #define RTE_DEV_TO_VDEV(ptr) \\\n \tcontainer_of(ptr, struct rte_vdev_device, device)\n \n+#define RTE_DEV_TO_VDEV_CONST(ptr) \\\n+\tcontainer_of(ptr, const struct rte_vdev_device, device)\n+\n static inline const char *\n rte_vdev_device_name(const struct rte_vdev_device *dev)\n {\ndiff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex e4bc72463..68306f4eb 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -386,15 +386,19 @@ static struct rte_device *\n vdev_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,\n \t\t const void *data)\n {\n+\tconst struct rte_vdev_device *vstart;\n \tstruct rte_vdev_device *dev;\n \n-\tTAILQ_FOREACH(dev, &vdev_device_list, next) {\n-\t\tif (start && &dev->device == start) {\n-\t\t\tstart = NULL;\n-\t\t\tcontinue;\n-\t\t}\n+\tif (start != NULL) {\n+\t\tvstart = RTE_DEV_TO_VDEV_CONST(start);\n+\t\tdev = TAILQ_NEXT(vstart, next);\n+\t} else {\n+\t\tdev = TAILQ_FIRST(&vdev_device_list);\n+\t}\n+\twhile (dev != NULL) {\n \t\tif (cmp(&dev->device, data) == 0)\n \t\t\treturn &dev->device;\n+\t\tdev = TAILQ_NEXT(dev, next);\n \t}\n \treturn NULL;\n }\n", "prefixes": [ "dpdk-dev", "v3", "15/20" ] }