Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/36351/?format=api
{ "id": 36351, "url": "https://patches.dpdk.org/api/patches/36351/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180321072807.268266-2-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180321072807.268266-2-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180321072807.268266-2-qi.z.zhang@intel.com", "date": "2018-03-21T07:28:05", "name": "[dpdk-dev,v3,1/3] ether: support runtime queue setup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a992c4d4fab3035addc618395074dabfbc13a25e", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180321072807.268266-2-qi.z.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/36351/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/36351/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 903CF7CF1;\n\tWed, 21 Mar 2018 08:28:08 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 506515F34\n\tfor <dev@dpdk.org>; Wed, 21 Mar 2018 08:28:06 +0100 (CET)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Mar 2018 00:28:05 -0700", "from dpdk51.sh.intel.com ([10.67.110.184])\n\tby fmsmga007.fm.intel.com with ESMTP; 21 Mar 2018 00:28:04 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,339,1517904000\"; d=\"scan'208\";a=\"25741695\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "thomas@monjalon.net,\n\tkonstantin.ananyev@intel.com", "Cc": "dev@dpdk.org, beilei.xing@intel.com, jingjing.wu@intel.com,\n\twenzhuo.lu@intel.com, Qi Zhang <qi.z.zhang@intel.com>", "Date": "Wed, 21 Mar 2018 15:28:05 +0800", "Message-Id": "<20180321072807.268266-2-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20180321072807.268266-1-qi.z.zhang@intel.com>", "References": "<20180212045314.171616-1-qi.z.zhang@intel.com>\n\t<20180321072807.268266-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 1/3] ether: support runtime queue setup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The patch let etherdev driver expose the capability flag through\nrte_eth_dev_info_get when it support runtime queue configuraiton,\nthen base on the flag rte_eth_[rx|tx]_queue_setup could decide\ncontinue to setup the queue or just return fail when device already\nstarted.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\nv3:\n- not overload deferred start\n- rename deferred setup to runtime setup\n\nv2:\n- enhance comment\n\n doc/guides/nics/features.rst | 8 ++++++++\n lib/librte_ether/rte_ethdev.c | 30 ++++++++++++++++++------------\n lib/librte_ether/rte_ethdev.h | 7 +++++++\n 3 files changed, 33 insertions(+), 12 deletions(-)", "diff": "diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst\nindex 1b4fb979f..6983faa4e 100644\n--- a/doc/guides/nics/features.rst\n+++ b/doc/guides/nics/features.rst\n@@ -892,7 +892,15 @@ Documentation describes performance values.\n \n See ``dpdk.org/doc/perf/*``.\n \n+.. _nic_features_queue_runtime_setup_capabilities:\n \n+Queue runtime setup capabilities\n+---------------------------------\n+\n+Supports queue setup / release after device started.\n+\n+* **[provides] rte_eth_dev_info**: ``runtime_queue_config_capa:DEV_RUNTIME_RX_QUEUE_SETUP,DEV_RUNTIME_TX_QUEUE_SETUP``.\n+* **[related] API**: ``rte_eth_dev_info_get()``.\n \n .. _nic_features_other:\n \ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 0590f0c10..343b1a6c0 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -1425,12 +1425,6 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,\n \t\treturn -EINVAL;\n \t}\n \n-\tif (dev->data->dev_started) {\n-\t\tRTE_PMD_DEBUG_TRACE(\n-\t\t \"port %d must be stopped to allow configuration\\n\", port_id);\n-\t\treturn -EBUSY;\n-\t}\n-\n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);\n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_setup, -ENOTSUP);\n \n@@ -1474,6 +1468,15 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,\n \t\treturn -EINVAL;\n \t}\n \n+\tif (dev->data->dev_started &&\n+\t\t!(dev_info.runtime_queue_setup_capa &\n+\t\t\tDEV_RUNTIME_RX_QUEUE_SETUP))\n+\t\treturn -EBUSY;\n+\n+\tif (dev->data->rx_queue_state[rx_queue_id] !=\n+\t\tRTE_ETH_QUEUE_STATE_STOPPED)\n+\t\treturn -EBUSY;\n+\n \trxq = dev->data->rx_queues;\n \tif (rxq[rx_queue_id]) {\n \t\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release,\n@@ -1573,12 +1576,6 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id,\n \t\treturn -EINVAL;\n \t}\n \n-\tif (dev->data->dev_started) {\n-\t\tRTE_PMD_DEBUG_TRACE(\n-\t\t \"port %d must be stopped to allow configuration\\n\", port_id);\n-\t\treturn -EBUSY;\n-\t}\n-\n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);\n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_setup, -ENOTSUP);\n \n@@ -1596,6 +1593,15 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id,\n \t\treturn -EINVAL;\n \t}\n \n+\tif (dev->data->dev_started &&\n+\t\t!(dev_info.runtime_queue_setup_capa &\n+\t\t\tDEV_RUNTIME_TX_QUEUE_SETUP))\n+\t\treturn -EBUSY;\n+\n+\tif (dev->data->rx_queue_state[tx_queue_id] !=\n+\t\tRTE_ETH_QUEUE_STATE_STOPPED)\n+\t\treturn -EBUSY;\n+\n \ttxq = dev->data->tx_queues;\n \tif (txq[tx_queue_id]) {\n \t\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release,\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex 036153306..4e2088458 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -981,6 +981,11 @@ struct rte_eth_conf {\n */\n #define DEV_TX_OFFLOAD_SECURITY 0x00020000\n \n+#define DEV_RUNTIME_RX_QUEUE_SETUP 0x00000001\n+/**< Deferred setup rx queue */\n+#define DEV_RUNTIME_TX_QUEUE_SETUP 0x00000002\n+/**< Deferred setup tx queue */\n+\n /*\n * If new Tx offload capabilities are defined, they also must be\n * mentioned in rte_tx_offload_names in rte_ethdev.c file.\n@@ -1029,6 +1034,8 @@ struct rte_eth_dev_info {\n \t/** Configured number of rx/tx queues */\n \tuint16_t nb_rx_queues; /**< Number of RX queues. */\n \tuint16_t nb_tx_queues; /**< Number of TX queues. */\n+\tuint64_t runtime_queue_setup_capa;\n+\t/**< queues can be setup after dev_start (DEV_DEFERRED_). */\n };\n \n /**\n", "prefixes": [ "dpdk-dev", "v3", "1/3" ] }