Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/36335/?format=api
{ "id": 36335, "url": "https://patches.dpdk.org/api/patches/36335/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/d7da7ebc1e0fa6e5b06a24638b3d300ba45b6fda.1521587199.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d7da7ebc1e0fa6e5b06a24638b3d300ba45b6fda.1521587199.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d7da7ebc1e0fa6e5b06a24638b3d300ba45b6fda.1521587199.git.gaetan.rivet@6wind.com", "date": "2018-03-20T23:20:10", "name": "[dpdk-dev,v3,09/10] devargs: use proper namespace prefix", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "02398b4e6034bef83193fa30de3e5b6949fa9b80", "submitter": { "id": 269, "url": "https://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/d7da7ebc1e0fa6e5b06a24638b3d300ba45b6fda.1521587199.git.gaetan.rivet@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/36335/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/36335/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3C1777CFA;\n\tWed, 21 Mar 2018 00:20:48 +0100 (CET)", "from mail-wr0-f193.google.com (mail-wr0-f193.google.com\n\t[209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 61C484C93\n\tfor <dev@dpdk.org>; Wed, 21 Mar 2018 00:20:45 +0100 (CET)", "by mail-wr0-f193.google.com with SMTP id o1so3390403wro.10\n\tfor <dev@dpdk.org>; Tue, 20 Mar 2018 16:20:45 -0700 (PDT)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tm135sm3983479wma.2.2018.03.20.16.20.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 20 Mar 2018 16:20:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=Up7ZWcGHackg8cVymmNBqL8aGIzQZWOKPsxbxtkhAv8=;\n\tb=qJ1h16u4gLJTnwefT/wJx5Hp07WD6RS5/ElmlE96qVZAXMcMdDI7ix4fvvqrQlbO/c\n\tZrilSQxHT/oPbUZ/f8ZoVgG49H5VVZvFXgEUJ151+DfrcGZq0vx7aTo8Km5cQDH3RUN1\n\tXWMM3WbwXvQNVhMxxqthkKQKbg5B01jHDs8PcbGS1htsjwQz/U2NQ3xqf+LCbYaMmM8B\n\t/q5ZwE/7vmDA+MNXi95GPDIynNCciPBQTKeVpYctGpV8kjPlnSJWp/YVNtnDiZR9jvSg\n\tM+9G7jbhtB/6eEWkkHleKJB0tk6rWWgN672gC7dzEApyhL5LYPrX9CMrIobGyHIgUmuI\n\tFYmQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=Up7ZWcGHackg8cVymmNBqL8aGIzQZWOKPsxbxtkhAv8=;\n\tb=nnDK8IIGcKzNL33Pd0ggiy0mUioJ8k3SthXM+qLqRpslDfmOolxrZKaO+aOBCLoNOi\n\t6hsmOl9F2nKOqMEvmaMTAxj17YCXDku3wZ3i8RKRpY0exMVU/8QJOaA/HW9b70l/x1mq\n\tc1KoVj2j7aXp//sWo3yw/25yvNx+NK0A8zTARlUR8P87oLfAW3jZZjakgsuRRaxN6Lq/\n\t7DzI2baX2BTSV+rAdskytHzXOE7Ss5rUi2aTRvoiTOWmimVJX7G9GdVJT6net8a73TBb\n\tQiTGAw1fzmq36lD0KY/M23cgdxVWnO1nk4aeb4KCAM5aV3ZWOScIneYz2tEpK5q05NSE\n\tqowA==", "X-Gm-Message-State": "AElRT7GTrPjF6qVRtgXXRHjiHvSM1yOmtSufrP6zvWhIcBPrLApKg+dR\n\tqeuaOLHk8o1bDWilzXim5tkPv+HB", "X-Google-Smtp-Source": "AG47ELuUG2rp7sO8vWtnwOtOtV7P4/ASyrWHb4qhSs7f1DcWgFRVkzca0OPvxGUbQ6YbZ6QfKBe5EQ==", "X-Received": "by 10.223.181.149 with SMTP id c21mr131411wre.233.1521588044568; \n\tTue, 20 Mar 2018 16:20:44 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Wed, 21 Mar 2018 00:20:10 +0100", "Message-Id": "<d7da7ebc1e0fa6e5b06a24638b3d300ba45b6fda.1521587199.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": [ "<cover.1521587199.git.gaetan.rivet@6wind.com>", "<cover.1521587199.git.gaetan.rivet@6wind.com>" ], "References": [ "<cover.1507796100.git.gaetan.rivet@6wind.com>\n\t<cover.1521587199.git.gaetan.rivet@6wind.com>", "<cover.1521587199.git.gaetan.rivet@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH v3 09/10] devargs: use proper namespace prefix", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_eal_devargs is useless, rte_devargs is sufficient.\n\nOnly experimental functions are changed for now.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n drivers/bus/vdev/vdev.c | 6 +++---\n drivers/net/failsafe/failsafe_args.c | 2 +-\n drivers/net/failsafe/failsafe_eal.c | 2 +-\n lib/librte_eal/common/eal_common_dev.c | 8 ++++----\n lib/librte_eal/common/eal_common_devargs.c | 12 ++++++------\n lib/librte_eal/common/include/rte_devargs.h | 23 +++++++++++++----------\n lib/librte_eal/rte_eal_version.map | 8 ++++----\n 7 files changed, 32 insertions(+), 29 deletions(-)", "diff": "diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex 8ee264baf..4fcbd9c79 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -256,7 +256,7 @@ rte_vdev_init(const char *name, const char *args)\n \t\tgoto fail;\n \t}\n \n-\trte_eal_devargs_insert(devargs);\n+\trte_devargs_insert(devargs);\n \n \tTAILQ_INSERT_TAIL(&vdev_device_list, dev, next);\n \treturn 0;\n@@ -306,7 +306,7 @@ rte_vdev_uninit(const char *name)\n \n \tTAILQ_REMOVE(&vdev_device_list, dev, next);\n \n-\trte_eal_devargs_remove(devargs->bus->name, devargs->name);\n+\trte_devargs_remove(devargs->bus->name, devargs->name);\n \n \tfree(dev);\n \treturn 0;\n@@ -325,7 +325,7 @@ vdev_scan(void)\n \t\tif (custom_scan->callback != NULL)\n \t\t\t/*\n \t\t\t * the callback should update devargs list\n-\t\t\t * by calling rte_eal_devargs_insert() with\n+\t\t\t * by calling rte_devargs_insert() with\n \t\t\t * devargs.bus = rte_bus_find_by_name(\"vdev\");\n \t\t\t * devargs.type = RTE_DEVTYPE_VIRTUAL;\n \t\t\t * devargs.policy = RTE_DEV_WHITELISTED;\ndiff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c\nindex f303668bb..05773556c 100644\n--- a/drivers/net/failsafe/failsafe_args.c\n+++ b/drivers/net/failsafe/failsafe_args.c\n@@ -62,7 +62,7 @@ fs_parse_device(struct sub_device *sdev, char *args)\n \n \td = &sdev->devargs;\n \tDEBUG(\"%s\", args);\n-\tret = rte_eal_devargs_parse(d, \"%s\", args);\n+\tret = rte_devargs_parse(d, \"%s\", args);\n \tif (ret) {\n \t\tDEBUG(\"devargs parsing failed with code %d\", ret);\n \t\treturn ret;\ndiff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c\nindex 5adaabfeb..f382f5709 100644\n--- a/drivers/net/failsafe/failsafe_eal.c\n+++ b/drivers/net/failsafe/failsafe_eal.c\n@@ -69,7 +69,7 @@ fs_bus_init(struct rte_eth_dev *dev)\n \t\t\telse\n \t\t\t\tsnprintf(devstr, sizeof(devstr), \"%s\",\n \t\t\t\t\t rte_eth_devices[pid].device->name);\n-\t\t\tret = rte_eal_devargs_parse(da, \"%s\", devstr);\n+\t\t\tret = rte_devargs_parse(da, \"%s\", devstr);\n \t\t\tif (ret) {\n \t\t\t\tERROR(\"Probed devargs parsing failed with code\"\n \t\t\t\t \" %d\", ret);\ndiff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c\nindex 43e1fb767..07e3e1647 100644\n--- a/lib/librte_eal/common/eal_common_dev.c\n+++ b/lib/librte_eal/common/eal_common_dev.c\n@@ -113,12 +113,12 @@ int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devn\n \tif (da == NULL)\n \t\treturn -ENOMEM;\n \n-\tret = rte_eal_devargs_parse(da, \"%s:%s,%s\",\n+\tret = rte_devargs_parse(da, \"%s:%s,%s\",\n \t\t\t\t busname, devname, devargs);\n \tif (ret)\n \t\tgoto err_devarg;\n \n-\tret = rte_eal_devargs_insert(da);\n+\tret = rte_devargs_insert(da);\n \tif (ret)\n \t\tgoto err_devarg;\n \n@@ -143,7 +143,7 @@ int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devn\n \treturn 0;\n \n err_devarg:\n-\tif (rte_eal_devargs_remove(busname, devname)) {\n+\tif (rte_devargs_remove(busname, devname)) {\n \t\tfree(da->args);\n \t\tfree(da);\n \t}\n@@ -179,6 +179,6 @@ rte_eal_hotplug_remove(const char *busname, const char *devname)\n \tif (ret)\n \t\tRTE_LOG(ERR, EAL, \"Driver cannot detach the device (%s)\\n\",\n \t\t\tdev->name);\n-\trte_eal_devargs_remove(busname, devname);\n+\trte_devargs_remove(busname, devname);\n \treturn ret;\n }\ndiff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex b251bb0a6..24d0f6f44 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -63,7 +63,7 @@ bus_name_cmp(const struct rte_bus *bus, const void *name)\n }\n \n int __rte_experimental\n-rte_eal_devargs_parse(struct rte_devargs *da, const char *format, ...)\n+rte_devargs_parse(struct rte_devargs *da, const char *format, ...)\n {\n \tstruct rte_bus *bus = NULL;\n \tva_list ap;\n@@ -125,11 +125,11 @@ rte_eal_devargs_parse(struct rte_devargs *da, const char *format, ...)\n }\n \n int __rte_experimental\n-rte_eal_devargs_insert(struct rte_devargs *da)\n+rte_devargs_insert(struct rte_devargs *da)\n {\n \tint ret;\n \n-\tret = rte_eal_devargs_remove(da->bus->name, da->name);\n+\tret = rte_devargs_remove(da->bus->name, da->name);\n \tif (ret < 0)\n \t\treturn ret;\n \tTAILQ_INSERT_TAIL(&devargs_list, da, next);\n@@ -149,7 +149,7 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n \tif (devargs == NULL)\n \t\tgoto fail;\n \n-\tif (rte_eal_devargs_parse(devargs, \"%s\", dev))\n+\tif (rte_devargs_parse(devargs, \"%s\", dev))\n \t\tgoto fail;\n \tdevargs->type = devtype;\n \tbus = devargs->bus;\n@@ -174,7 +174,7 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n }\n \n int __rte_experimental\n-rte_eal_devargs_remove(const char *busname, const char *devname)\n+rte_devargs_remove(const char *busname, const char *devname)\n {\n \tstruct rte_devargs *d;\n \tvoid *tmp;\n@@ -223,7 +223,7 @@ rte_eal_devargs_dump(FILE *f)\n /* bus-aware rte_devargs iterator. */\n __rte_experimental\n struct rte_devargs *\n-rte_eal_devargs_next(const char *busname, const struct rte_devargs *start)\n+rte_devargs_next(const char *busname, const struct rte_devargs *start)\n {\n \tstruct rte_devargs *da;\n \ndiff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h\nindex e261f7c69..07a4701b2 100644\n--- a/lib/librte_eal/common/include/rte_devargs.h\n+++ b/lib/librte_eal/common/include/rte_devargs.h\n@@ -105,9 +105,10 @@ int rte_eal_parse_devargs_str(const char *devargs_str,\n * - 0 on success.\n * - Negative errno on error.\n */\n-int __rte_experimental\n-rte_eal_devargs_parse(struct rte_devargs *da,\n-\t\t const char *format, ...)\n+__rte_experimental\n+int\n+rte_devargs_parse(struct rte_devargs *da,\n+\t\t const char *format, ...)\n __attribute__((format(printf, 2, 0)));\n \n /**\n@@ -120,8 +121,9 @@ __attribute__((format(printf, 2, 0)));\n * - 0 on success\n * - Negative on error.\n */\n-int __rte_experimental\n-rte_eal_devargs_insert(struct rte_devargs *da);\n+__rte_experimental\n+int\n+rte_devargs_insert(struct rte_devargs *da);\n \n /**\n * Add a device to the user device list\n@@ -162,8 +164,9 @@ int rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str);\n * <0 on error.\n * >0 if the devargs was not within the user device list.\n */\n-int __rte_experimental rte_eal_devargs_remove(const char *busname,\n-\t\t\t\t\t const char *devname);\n+__rte_experimental\n+int rte_devargs_remove(const char *busname,\n+\t\t const char *devname);\n \n /**\n * Count the number of user devices of a specified type\n@@ -203,15 +206,15 @@ void rte_eal_devargs_dump(FILE *f);\n */\n __rte_experimental\n struct rte_devargs *\n-rte_eal_devargs_next(const char *busname, const struct rte_devargs *start);\n+rte_devargs_next(const char *busname, const struct rte_devargs *start);\n \n /**\n * Iterate over all rte_devargs for a specific bus.\n */\n #define RTE_EAL_DEVARGS_FOREACH(busname, da) \\\n-\tfor (da = rte_eal_devargs_next(busname, NULL); \\\n+\tfor (da = rte_devargs_next(busname, NULL); \\\n \t da != NULL; \\\n-\t da = rte_eal_devargs_next(busname, da)) \\\n+\t da = rte_devargs_next(busname, da)) \\\n \n #ifdef __cplusplus\n }\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 8dab46ba6..1e614f088 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -214,10 +214,10 @@ EXPERIMENTAL {\n \tglobal:\n \n \trte_eal_cleanup;\n-\trte_eal_devargs_insert;\n-\trte_eal_devargs_next;\n-\trte_eal_devargs_parse;\n-\trte_eal_devargs_remove;\n+\trte_devargs_insert;\n+\trte_devargs_next;\n+\trte_devargs_parse;\n+\trte_devargs_remove;\n \trte_eal_hotplug_add;\n \trte_eal_hotplug_remove;\n \trte_eal_mbuf_user_pool_ops;\n", "prefixes": [ "dpdk-dev", "v3", "09/10" ] }