Patch Comment List
List patch comments
GET /api/patches/36/comments/?format=api&order=-id
[ { "id": 2305, "web_url": "https://patches.dpdk.org/comment/2305/", "msgid": "<B62C4979-6FDC-412D-B335-BCC1F88A4541@arbor.net>", "list_archive_url": "https://inbox.dpdk.org/dev/B62C4979-6FDC-412D-B335-BCC1F88A4541@arbor.net", "date": "2014-11-05T15:34:00", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 104, "url": "https://patches.dpdk.org/api/people/104/?format=api", "name": "Aaron Campbell", "email": "aaron@arbor.net" }, "content": "> On Nov 4, 2014, at 3:00 PM, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:\n> \n> 2014-11-03 13:02, Aaron Campbell:\n>>> On Jul 8, 2014, at 5:28 AM, Simon Kuenzer <simon.kuenzer@neclab.eu> wrote:\n>>> \n>>> +\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_MASTER_LCORE)) {\n>>> +\t\t\t\tif (!coremask_ok) {\n>>> +\t\t\t\t\tRTE_LOG(ERR, EAL, \"please specify the master \"\n>>> +\t\t\t\t\t\t\t\"lcore id after specifying \"\n>>> +\t\t\t\t\t\t\t\"the coremask\\n\");\n>>> +\t\t\t\t\teal_usage(prgname);\n>>> +\t\t\t\t\treturn -1;\n>>> +\t\t\t\t}\n>> \n>> \n>> Hi Simon,\n>> \n>> I think that forcing a particular command line order is not that clean.\n>> It might be better to remove the cfg->master_lcore setting from\n>> eal_parse_coremask(), and defer the selection of the master lcore until\n>> all of the command-line options have been parsed. If —master-lcore was\n>> specified, save the value and use that, otherwise\n>> rte_get_next_lcore(-1, 0, 0) can return the first bit set in the coremask.\n> \n> It's not sufficient: eal_parse_master_lcore() requires cfg->lcore_role\n> to be set. There is a real dependency between these 2 options.\n> I'm going to submit a v2. Feel free to improve it with another patch.\n\nI was nit-picking; although it might be nice if the new option is given, to verify the specified lcore is in the coremask. I will ack v2 though and this can be improved some other time.\n\n-Aaron", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A45787EC4;\n\tWed, 5 Nov 2014 16:24:40 +0100 (CET)", "from mail-ie0-f177.google.com (mail-ie0-f177.google.com\n\t[209.85.223.177]) by dpdk.org (Postfix) with ESMTP id 14B1C7E80\n\tfor <dev@dpdk.org>; Wed, 5 Nov 2014 16:24:39 +0100 (CET)", "by mail-ie0-f177.google.com with SMTP id tp5so917394ieb.22\n\tfor <dev@dpdk.org>; Wed, 05 Nov 2014 07:34:01 -0800 (PST)", "from [172.31.1.110]\n\t(hlfxns0187w-047055100128.dhcp-dynamic.FibreOp.ns.bellaliant.net.\n\t[47.55.100.128]) by mx.google.com with ESMTPSA id\n\t199sm1633229ion.7.2014.11.05.07.34.01 for <multiple recipients>\n\t(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);\n\tWed, 05 Nov 2014 07:34:01 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=arbor.net; s=m0;\n\th=content-type:mime-version:subject:from:in-reply-to:date:cc\n\t:content-transfer-encoding:message-id:references:to;\n\tbh=X8GBqyzO3n3JR5zJJD4wU+rYR2Gxwup62hUOGroPlLE=;\n\tb=Pb2T35jvqiWzPVHc9md9wCUJzn5cJiInilMQgL/5nb8BQ4lKetgGyhPJMhlO4FQBhh\n\t5Xn7t+fa9OmHIv8m3AljUClEtW0f1z/sm1D0skYN+uQ2avvmnwE12A4jwmFuz4NdCwKM\n\tW0PRJw7+EvwRWtzV0vec+GKbjH3Vf7qL0H9Ms=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:content-type:mime-version:subject:from\n\t:in-reply-to:date:cc:content-transfer-encoding:message-id:references\n\t:to; bh=X8GBqyzO3n3JR5zJJD4wU+rYR2Gxwup62hUOGroPlLE=;\n\tb=O7nydJWeU2ZI+c67shL6M5/WYpaWRUtjDThDm3dgMH03Rjx7CSG6HNRj6BB/vtMcnw\n\td3s+VtspKyUVAOS4aaEGIc0hRpaInRsu4jQKpn2eWXN3a0cn8deNnuBN01x+mnTGBrC6\n\tuowGmBrozdjjlE3ctgvzIj9tPKzvg25br3VB7K/dcdzoQ/4i/dkq+qDN/FAD62xowjRf\n\tMC7JiF/Y4xSFP0C0JsXdm/R0sJY09/7BcpfkGdjGhyWoO7C6ws5LNvkDMrQCPuc7fpVM\n\ttJbaXf5U1JVXPzmDphMEzWEfjHoq5YOnDeohKAgkGaepB1YU6bmuR5DPG7ZXTITDaSWY\n\tP29Q==", "X-Gm-Message-State": "ALoCoQnmZg/bliw0ZCsOcnooXHiZ1Y88/eZYQWOK6UUEAjsg08JY01ztOXRJOKr0qNYMj3sLtIoD", "X-Received": "by 10.43.129.196 with SMTP id hj4mr5316042icc.21.1415201641700; \n\tWed, 05 Nov 2014 07:34:01 -0800 (PST)", "Content-Type": "text/plain; charset=utf-8", "Mime-Version": "1.0 (Mac OS X Mail 8.0 \\(1990.1\\))", "From": "Aaron Campbell <aaron@arbor.net>", "In-Reply-To": "<3986981.sR7Aq8MzkS@xps13>", "Date": "Wed, 5 Nov 2014 11:34:00 -0400", "Content-Transfer-Encoding": "quoted-printable", "Message-Id": "<B62C4979-6FDC-412D-B335-BCC1F88A4541@arbor.net>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net>\n\t<3986981.sR7Aq8MzkS@xps13>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "X-Mailer": "Apple Mail (2.1990.1)", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 2267, "web_url": "https://patches.dpdk.org/comment/2267/", "msgid": "<3986981.sR7Aq8MzkS@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/3986981.sR7Aq8MzkS@xps13", "date": "2014-11-04T19:00:58", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-11-03 13:02, Aaron Campbell:\n> > On Jul 8, 2014, at 5:28 AM, Simon Kuenzer <simon.kuenzer@neclab.eu> wrote:\n> > \n> > +\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_MASTER_LCORE)) {\n> > +\t\t\t\tif (!coremask_ok) {\n> > +\t\t\t\t\tRTE_LOG(ERR, EAL, \"please specify the master \"\n> > +\t\t\t\t\t\t\t\"lcore id after specifying \"\n> > +\t\t\t\t\t\t\t\"the coremask\\n\");\n> > +\t\t\t\t\teal_usage(prgname);\n> > +\t\t\t\t\treturn -1;\n> > +\t\t\t\t}\n> \n> \n> Hi Simon,\n> \n> I think that forcing a particular command line order is not that clean.\n> It might be better to remove the cfg->master_lcore setting from\n> eal_parse_coremask(), and defer the selection of the master lcore until\n> all of the command-line options have been parsed. If —master-lcore was\n> specified, save the value and use that, otherwise\n> rte_get_next_lcore(-1, 0, 0) can return the first bit set in the coremask.\n\nIt's not sufficient: eal_parse_master_lcore() requires cfg->lcore_role\nto be set. There is a real dependency between these 2 options.\nI'm going to submit a v2. Feel free to improve it with another patch.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 18B2D7E97;\n\tTue, 4 Nov 2014 19:51:59 +0100 (CET)", "from mail-wi0-f171.google.com (mail-wi0-f171.google.com\n\t[209.85.212.171]) by dpdk.org (Postfix) with ESMTP id CB5717E92\n\tfor <dev@dpdk.org>; Tue, 4 Nov 2014 19:51:57 +0100 (CET)", "by mail-wi0-f171.google.com with SMTP id q5so10308554wiv.16\n\tfor <dev@dpdk.org>; Tue, 04 Nov 2014 11:01:17 -0800 (PST)", "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\twc7sm1515925wjc.8.2014.11.04.11.01.15 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 04 Nov 2014 11:01:16 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=6mhdIap9AK/16yH4nRX3cEw/MMiYcDAiN4O18WHnUh8=;\n\tb=IiBzyXxZIJcMFO07CUHWHWVVM/npDP5M4K2ft+jNh2Ah8/oiUg6nxk/Dugxp7MYkbx\n\tzWf76tXPnhXoZ0t/xGx94Lxios7n70kvmUEQfcnNE2ilbKXav8c1bnucur7R2hmIDQSA\n\ttTMrFXRYIzKedy1YnEAKkC8lXY9MHFy6lfo8k84ZqessqijLSAjXHRAHyO+UEoWD1olw\n\tScgdlpVsvvKKa5dtyw0fQ0nIUEfshY6GP+QvJkWEwwmL0kqIaDZxCSglAJOrQwXsPLvL\n\tPrLRGaRDTS7UjfA7UBEMpz5HboLZl8EwRfPrAw1UQc/YSQMwSIPP7JY9hwA5FNH9TGjD\n\t/Viw==", "X-Gm-Message-State": "ALoCoQmC6jYS5NuoW1qLVJAcWwkFLRbmxw1MjsH33lTeto3Gib4xSJsK0ZCKtPF/+EVbEvMPTCYY", "X-Received": "by 10.180.106.162 with SMTP id gv2mr26298516wib.26.1415127677372;\n\tTue, 04 Nov 2014 11:01:17 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Aaron Campbell <aaron@arbor.net>", "Date": "Tue, 04 Nov 2014 20:00:58 +0100", "Message-ID": "<3986981.sR7Aq8MzkS@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; )", "In-Reply-To": "<582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Content-Type": "text/plain; charset=\"utf-8\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 2212, "web_url": "https://patches.dpdk.org/comment/2212/", "msgid": "<1466122.G25iygG7Yz@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/1466122.G25iygG7Yz@xps13", "date": "2014-11-03T22:29:29", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-11-03 13:02, Aaron Campbell:\n> Hi Simon,\n> \n> Thanks for the patch, this will be useful for us. I responded separately to your original post with one suggestion.\n> \n> Our application currently assumes that DPDK will assign the first bit set in the coremask to the master lcore. As far as I can tell, this is hard-coded as of 1.7.1. But we would like the ability for our application to specify any bit from the coremask to serve as the master lcore.\n> \n> I don’t see any compatibility issues with this. Existing applications should behave as before.\n> \n> Thomas, could this be accepted for the 1.8 release? Or will that only happen if the BSD side can be patched as well?\n\nNo need for BSD side patch because option management is now common between\nBSD and Linux. I'm going to send an updated version of this patch.\n\n> > On Jul 23, 2014, at 9:10 AM, Simon Kuenzer <simon.kuenzer@neclab.eu> wrote:\n> > \n> > Hi all,\n> > \n> > the only issue I could imagine is that current DPDK applications are\n> > utilizing the implicit assumption that the master lcore is always set to\n> > the first available lcore. I would consider this as a \"bug\" in the\n> > application because it sets up its worker threads not \"properly\".\n> > \n> > However, as far I could check it, the DPDK framework seems to cope with\n> > it correctly.\n> > It would be nice if somebody else could confirm my statement.\n> > \n> > Thanks,\n> > \n> > Simon\n> > \n> > On 23.07.2014 10:53, Hiroshi Shimamoto wrote:\n> >> Hi,\n> >> \n> >>> Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id\n> >>> \n> >>> Hi Hiroshi,\n> >>> \n> >>> 2014-07-22 23:40, Hiroshi Shimamoto:\n> >>>> does anyone have interest in this functionality?\n> >>>> \n> >>>> I think this is important and useful.\n> >>>> Since we should care about core assignment to get high performance\n> >>>> and the master lcore thread is special in DPDK, we will want to\n> >>>> assign the master to the target core.\n> >>>> For example, with hyperthreading I'd like to make a pair of packet\n> >>>> processing threads into one physical core and separate the master\n> >>>> thread which does some management.\n> >>> \n> >>> Thank you for showing your interest.\n> >>> Does it mean you carefully reviewed this patch? In this case, I'd appreciate\n> >>> a note \"Reviewed-by:\".\n> >> \n> >> Not yet deeply, wait a bit, we're testing this patch in our application.\n> >> Will report if it works fine.\n> >> \n> >> By the way, we should add the same code into the BSD code, right?\n> >> \n> >> thanks,\n> >> Hiroshi", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E33FB590C;\n\tMon, 3 Nov 2014 23:20:34 +0100 (CET)", "from mail-wi0-f179.google.com (mail-wi0-f179.google.com\n\t[209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 7587958EE\n\tfor <dev@dpdk.org>; Mon, 3 Nov 2014 23:20:32 +0100 (CET)", "by mail-wi0-f179.google.com with SMTP id h11so7743398wiw.6\n\tfor <dev@dpdk.org>; Mon, 03 Nov 2014 14:29:48 -0800 (PST)", "from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net.\n\t[82.235.116.147]) by mx.google.com with ESMTPSA id\n\tfm10sm10183262wib.21.2014.11.03.14.29.46 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 03 Nov 2014 14:29:47 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=Bz/g7q3b+OaKorEK1C2BeeQ2lkLg2JU2O0+kp2+6w2U=;\n\tb=JfFxmnfqh9Yc+d4GWkLjViIp28DrxUIKaQKONAj/arVJJgyWvCLHZXus0uwWmlOYnl\n\tIPOlVJnThaImR4RN2o9dFlOHBiVDzvXYUcCmkVLeh24TrELvBZL8RdQKowWoIb+wx5Z0\n\tqECj3TAO3n5kgNWK8xlSOK7UskqguRA8wbNSWANTjsFV+JEplW/PpOnkoq4hshcli7qI\n\tL3Loj65MyjtHOIVylLYEetXc4RkJGX4kUhnQ6agnhfUsZtIkWiv2xfNBg2RQn6z7K7SG\n\td592D8UURkbesQBBuJ/DcvKirYc2cZ63PKwSxl/fG+KiRW0kg8M7b89CDkGGTTxRPgEx\n\tdPLg==", "X-Gm-Message-State": "ALoCoQlVTl5o43Kqx+BnMX2nuZs8gHkfHaIJMkQ7m2tQTmBVkBHai/AdyAGLuuyPHmzCjY+AQ7mU", "X-Received": "by 10.180.182.195 with SMTP id eg3mr19607314wic.31.1415053788187;\n\tMon, 03 Nov 2014 14:29:48 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Aaron Campbell <aaron@arbor.net>", "Date": "Mon, 03 Nov 2014 23:29:29 +0100", "Message-ID": "<1466122.G25iygG7Yz@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; )", "In-Reply-To": "<CDC4C356-008C-4099-A6BB-16D931CBBF52@arbor.net>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<53CFA637.1090706@neclab.eu>\n\t<CDC4C356-008C-4099-A6BB-16D931CBBF52@arbor.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Content-Type": "text/plain; charset=\"utf-8\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 2207, "web_url": "https://patches.dpdk.org/comment/2207/", "msgid": "<CDC4C356-008C-4099-A6BB-16D931CBBF52@arbor.net>", "list_archive_url": "https://inbox.dpdk.org/dev/CDC4C356-008C-4099-A6BB-16D931CBBF52@arbor.net", "date": "2014-11-03T17:02:08", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 104, "url": "https://patches.dpdk.org/api/people/104/?format=api", "name": "Aaron Campbell", "email": "aaron@arbor.net" }, "content": "Hi Simon,\n\nThanks for the patch, this will be useful for us. I responded separately to your original post with one suggestion.\n\nOur application currently assumes that DPDK will assign the first bit set in the coremask to the master lcore. As far as I can tell, this is hard-coded as of 1.7.1. But we would like the ability for our application to specify any bit from the coremask to serve as the master lcore.\n\nI don’t see any compatibility issues with this. Existing applications should behave as before.\n\nThomas, could this be accepted for the 1.8 release? Or will that only happen if the BSD side can be patched as well?\n\n-Aaron\n\n> On Jul 23, 2014, at 9:10 AM, Simon Kuenzer <simon.kuenzer@neclab.eu> wrote:\n> \n> Hi all,\n> \n> the only issue I could imagine is that current DPDK applications are\n> utilizing the implicit assumption that the master lcore is always set to\n> the first available lcore. I would consider this as a \"bug\" in the\n> application because it sets up its worker threads not \"properly\".\n> \n> However, as far I could check it, the DPDK framework seems to cope with\n> it correctly.\n> It would be nice if somebody else could confirm my statement.\n> \n> Thanks,\n> \n> Simon\n> \n> On 23.07.2014 10:53, Hiroshi Shimamoto wrote:\n>> Hi,\n>> \n>>> Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id\n>>> \n>>> Hi Hiroshi,\n>>> \n>>> 2014-07-22 23:40, Hiroshi Shimamoto:\n>>>> does anyone have interest in this functionality?\n>>>> \n>>>> I think this is important and useful.\n>>>> Since we should care about core assignment to get high performance\n>>>> and the master lcore thread is special in DPDK, we will want to\n>>>> assign the master to the target core.\n>>>> For example, with hyperthreading I'd like to make a pair of packet\n>>>> processing threads into one physical core and separate the master\n>>>> thread which does some management.\n>>> \n>>> Thank you for showing your interest.\n>>> Does it mean you carefully reviewed this patch? In this case, I'd appreciate\n>>> a note \"Reviewed-by:\".\n>> \n>> Not yet deeply, wait a bit, we're testing this patch in our application.\n>> Will report if it works fine.\n>> \n>> By the way, we should add the same code into the BSD code, right?\n>> \n>> thanks,\n>> Hiroshi\n>> \n>>> \n>>> Thanks\n>>> --\n>>> Thomas\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4976B7E00;\n\tMon, 3 Nov 2014 17:52:57 +0100 (CET)", "from mail-ig0-f176.google.com (mail-ig0-f176.google.com\n\t[209.85.213.176]) by dpdk.org (Postfix) with ESMTP id E4B917DFB\n\tfor <dev@dpdk.org>; Mon, 3 Nov 2014 17:52:54 +0100 (CET)", "by mail-ig0-f176.google.com with SMTP id l13so5466375iga.9\n\tfor <dev@dpdk.org>; Mon, 03 Nov 2014 09:02:09 -0800 (PST)", "from [172.31.1.110]\n\t(hlfxns0187w-047055100128.dhcp-dynamic.FibreOp.ns.bellaliant.net.\n\t[47.55.100.128]) by mx.google.com with ESMTPSA id\n\ti184sm1931905ioi.33.2014.11.03.09.02.08 for <multiple recipients>\n\t(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);\n\tMon, 03 Nov 2014 09:02:08 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=arbor.net; s=m0;\n\th=subject:mime-version:content-type:from:in-reply-to:date:cc\n\t:content-transfer-encoding:message-id:references:to;\n\tbh=/nXIj94hw2sj8XbKkWIs4ah2cHHIGS+9sib2SCUySzs=;\n\tb=F0mOD7qCVXkQm74ODnDzGje9ime7oXO/CODEKQmwti1Q5rqsCY6vtKWkEh0uc+iEu3\n\tuY3uYycGiG+1PB7J/73XRA2HX1Nv2raqwi8kay4VimZ9bKImqgHkYps1SNMfgd6O0dcH\n\tnTikiuUaHtRiwzWBqspC5waLIq1NqfoEFeFxI=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:mime-version:content-type:from\n\t:in-reply-to:date:cc:content-transfer-encoding:message-id:references\n\t:to; bh=/nXIj94hw2sj8XbKkWIs4ah2cHHIGS+9sib2SCUySzs=;\n\tb=QivwCOu94UIHyMXr2k83bSKXVKvlyqgOU3rPRSEnH7o9bk8H+3QhpiTtDOk1C9Bzrs\n\t1VPAd0uAesgmL33ss1opungoKBtHfjA6n/Wa7+9ivxFW/sOuqcSFFpwrfZW4QZ5vUdZC\n\tnNULJN/VXeEPz6ZBwgFnDZ4fNb33zFyXe99zdcF/42SFgBh+KHLYm4685Q2M2AtqDr2+\n\tk6rvaW5MMAOhDJak7NT0EnmfpTlLVy4D/gWRQS7807eriQkeJipqzCqxFabgdR5cgF+P\n\tAMszs7d/eLYyk5n6XcH/ao+NdKUFNK3nzngGGQwoVEBNqEQm5GM89LyquVpHTHXZbuIR\n\tCn4A==", "X-Gm-Message-State": "ALoCoQkT7FSAswnsnQEk7fBfrRYyQe2vA5zNffVuqSHsHtXfkLa7inxdECd7ibtfMFsSyGy+NtyN", "X-Received": "by 10.107.164.71 with SMTP id n68mr49293340ioe.17.1415034129178; \n\tMon, 03 Nov 2014 09:02:09 -0800 (PST)", "Mime-Version": "1.0 (Mac OS X Mail 8.0 \\(1990.1\\))", "Content-Type": "text/plain; charset=utf-8", "From": "Aaron Campbell <aaron@arbor.net>", "In-Reply-To": "<53CFA637.1090706@neclab.eu>", "Date": "Mon, 3 Nov 2014 13:02:08 -0400", "Content-Transfer-Encoding": "quoted-printable", "Message-Id": "<CDC4C356-008C-4099-A6BB-16D931CBBF52@arbor.net>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<53CD3E26.1060708@neclab.eu>\n\t<7F861DC0615E0C47A872E6F3C5FCDDBD01161242@BPXM14GP.gisp.nec.co.jp>\n\t<10116389.N4VFaZKECM@xps13>\n\t<7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp>\n\t<53CFA637.1090706@neclab.eu>", "To": "Simon Kuenzer <simon.kuenzer@neclab.eu>", "X-Mailer": "Apple Mail (2.1990.1)", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 2206, "web_url": "https://patches.dpdk.org/comment/2206/", "msgid": "<582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net>", "list_archive_url": "https://inbox.dpdk.org/dev/582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net", "date": "2014-11-03T17:02:02", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 104, "url": "https://patches.dpdk.org/api/people/104/?format=api", "name": "Aaron Campbell", "email": "aaron@arbor.net" }, "content": "> On Jul 8, 2014, at 5:28 AM, Simon Kuenzer <simon.kuenzer@neclab.eu> wrote:\n> \n> +\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_MASTER_LCORE)) {\n> +\t\t\t\tif (!coremask_ok) {\n> +\t\t\t\t\tRTE_LOG(ERR, EAL, \"please specify the master \"\n> +\t\t\t\t\t\t\t\"lcore id after specifying \"\n> +\t\t\t\t\t\t\t\"the coremask\\n\");\n> +\t\t\t\t\teal_usage(prgname);\n> +\t\t\t\t\treturn -1;\n> +\t\t\t\t}\n\n\nHi Simon,\n\nI think that forcing a particular command line order is not that clean. It might be better to remove the cfg->master_lcore setting from eal_parse_coremask(), and defer the selection of the master lcore until all of the command-line options have been parsed. If —master-lcore was specified, save the value and use that, otherwise rte_get_next_lcore(-1, 0, 0) can return the first bit set in the coremask.\n\n-Aaron", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6F8315965;\n\tMon, 3 Nov 2014 17:52:52 +0100 (CET)", "from mail-ie0-f170.google.com (mail-ie0-f170.google.com\n\t[209.85.223.170]) by dpdk.org (Postfix) with ESMTP id 93D2C590C\n\tfor <dev@dpdk.org>; Mon, 3 Nov 2014 17:52:50 +0100 (CET)", "by mail-ie0-f170.google.com with SMTP id tp5so5705069ieb.29\n\tfor <dev@dpdk.org>; Mon, 03 Nov 2014 09:02:04 -0800 (PST)", "from [172.31.1.110]\n\t(hlfxns0187w-047055100128.dhcp-dynamic.FibreOp.ns.bellaliant.net.\n\t[47.55.100.128]) by mx.google.com with ESMTPSA id\n\ti184sm1931905ioi.33.2014.11.03.09.02.03 for <multiple recipients>\n\t(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);\n\tMon, 03 Nov 2014 09:02:03 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=arbor.net; s=m0;\n\th=subject:mime-version:content-type:from:in-reply-to:date:cc\n\t:content-transfer-encoding:message-id:references:to;\n\tbh=2cjeTKXx/1OgHX3HNLZt1Ev8LBHd9YqBbq70eqt6iGg=;\n\tb=LUYhJIr9dEikGAmWbakiKNmPeDFywpjcVd8E07P2ZOsZllt6HADzMCmz00f23cKGqE\n\tXEGQr694Dbu/ANmQdxLAizwYb99EPylTjwSpbtpnKr9vMNumSlKx715BnCGqypnfkL48\n\tANfqtvHN00LxcPp+/36bzQRbfF8hEP2imHY8g=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:mime-version:content-type:from\n\t:in-reply-to:date:cc:content-transfer-encoding:message-id:references\n\t:to; bh=2cjeTKXx/1OgHX3HNLZt1Ev8LBHd9YqBbq70eqt6iGg=;\n\tb=EYOHDFIwLv+rLfFSPc6EpXKdYj0xOU7QOwef7ISSCNzU5pDjUfk4++NwJf6wNFW3XE\n\tDtrq1JmEQKE2aGPE/+XN6dRonf/oFt39PfsN25bTH/7FfquaMtGKdl31ErfW0e5gMSLt\n\tnPnnBpIc7hKm2DhcCigWZlSqEs3gRJwuNxojvMkXClpmXjQcNxFXaG+XkNP1Pz94zjlh\n\tIBVfDTJja72oa/RUtzTL0BDjXZmAOkui7LuksqNavM+lnr5+LKz6K1ahx5njCD7LxV/d\n\teylMSzGZb7zyd/mXv5CmoWaPPk2w3s8OjDnZ+2uhP3y0MLRI9h+xyCp1Nha4Rqvx0A3q\n\tT5+w==", "X-Gm-Message-State": "ALoCoQnH9xsbEmOKa1CHdFnr7L2XOk/TIk88clZTzu1g/yvnOvq5CH+xhkrVf0vTFIvP1m283OTI", "X-Received": "by 10.107.6.197 with SMTP id f66mr2693585ioi.81.1415034124489;\n\tMon, 03 Nov 2014 09:02:04 -0800 (PST)", "Mime-Version": "1.0 (Mac OS X Mail 8.0 \\(1990.1\\))", "Content-Type": "text/plain; charset=utf-8", "From": "Aaron Campbell <aaron@arbor.net>", "In-Reply-To": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>", "Date": "Mon, 3 Nov 2014 13:02:02 -0400", "Content-Transfer-Encoding": "quoted-printable", "Message-Id": "<582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>", "To": "Simon Kuenzer <simon.kuenzer@neclab.eu>", "X-Mailer": "Apple Mail (2.1990.1)", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 287, "web_url": "https://patches.dpdk.org/comment/287/", "msgid": "<7F861DC0615E0C47A872E6F3C5FCDDBD011767DF@BPXM14GP.gisp.nec.co.jp>", "list_archive_url": "https://inbox.dpdk.org/dev/7F861DC0615E0C47A872E6F3C5FCDDBD011767DF@BPXM14GP.gisp.nec.co.jp", "date": "2014-08-04T02:48:30", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 38, "url": "https://patches.dpdk.org/api/people/38/?format=api", "name": "Hiroshi Shimamoto", "email": "h-shimamoto@ct.jp.nec.com" }, "content": "Hi,\n\n> Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id\n> \n> 2014-07-23 08:53, Hiroshi Shimamoto:\n> > 2014-07-23 09:50, Thomas Monjalon:\n> > > 2014-07-22 23:40, Hiroshi Shimamoto:\n> > > > does anyone have interest in this functionality?\n> > > >\n> > > > I think this is important and useful.\n> > > > Since we should care about core assignment to get high performance\n> > > > and the master lcore thread is special in DPDK, we will want to\n> > > > assign the master to the target core.\n> > > > For example, with hyperthreading I'd like to make a pair of packet\n> > > > processing threads into one physical core and separate the master\n> > > > thread which does some management.\n> > >\n> > > Thank you for showing your interest.\n> > > Does it mean you carefully reviewed this patch? In this case, I'd appreciate\n> > > a note \"Reviewed-by:\".\n> >\n> > Not yet deeply, wait a bit, we're testing this patch in our application.\n> > Will report if it works fine.\n\nSorry a delay, I had confirmed the functionality.\nI'm fine to add\nReviewed-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>\n\nthanks,\nHiroshi\n\n> >\n> > By the way, we should add the same code into the BSD code, right?\n> \n> Right.\n> I'd prefer to reduce the duplicated footprint and have more common code\n> between BSD and Linux. But waiting this enhancement, we have to maintain\n> the duplicated code for BSD.\n> \n> --\n> Thomas", "headers": { "Return-Path": "<h-shimamoto@ct.jp.nec.com>", "Received": [ "from tyo201.gate.nec.co.jp (TYO201.gate.nec.co.jp [210.143.35.51])\n\tby dpdk.org (Postfix) with ESMTP id 84FE858DC\n\tfor <dev@dpdk.org>; Mon, 4 Aug 2014 04:46:44 +0200 (CEST)", "from mailgate3.nec.co.jp ([10.7.69.192])\n\tby tyo201.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s742mu7R016797;\n\tMon, 4 Aug 2014 11:48:56 +0900 (JST)", "from mailsv4.nec.co.jp (imss63.nec.co.jp [10.7.69.158]) by\n\tmailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP\n\tid s742muO23017; Mon, 4 Aug 2014 11:48:56 +0900 (JST)", "from mail02.kamome.nec.co.jp (mail02.kamome.nec.co.jp [10.25.43.5])\n\tby mailsv4.nec.co.jp (8.13.8/8.13.4) with ESMTP id s742mtZo012208;\n\tMon, 4 Aug 2014 11:48:55 +0900 (JST)", "from bpxc99gp.gisp.nec.co.jp ([10.38.151.145] [10.38.151.145]) by\n\tmail01b.kamome.nec.co.jp with ESMTP id BT-MMP-1000043;\n\tMon, 4 Aug 2014 11:48:31 +0900", "from BPXM14GP.gisp.nec.co.jp ([169.254.1.238]) by\n\tBPXC17GP.gisp.nec.co.jp ([10.38.151.145]) with mapi id 14.02.0328.011;\n\tMon, 4 Aug 2014 11:48:30 +0900" ], "From": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "Thread-Index": "AQHPpP/5HRcYWawLzUK9QPLwaiBbj5usvvzA///1kICAAKcWYP//bcMAgBMG1MA=", "Date": "Mon, 4 Aug 2014 02:48:30 +0000", "Message-ID": "<7F861DC0615E0C47A872E6F3C5FCDDBD011767DF@BPXM14GP.gisp.nec.co.jp>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<10116389.N4VFaZKECM@xps13>\n\t<7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp>\n\t<3356411.EsFcTdggfg@xps13>", "In-Reply-To": "<3356411.EsFcTdggfg@xps13>", "Accept-Language": "ja-JP, en-US", "Content-Language": "ja-JP", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.205.5.123]", "Content-Type": "text/plain; charset=\"iso-2022-jp\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Mon, 04 Aug 2014 02:46:46 -0000" }, "addressed": null }, { "id": 212, "web_url": "https://patches.dpdk.org/comment/212/", "msgid": "<53CFA637.1090706@neclab.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/53CFA637.1090706@neclab.eu", "date": "2014-07-23T12:10:31", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 22, "url": "https://patches.dpdk.org/api/people/22/?format=api", "name": "Simon Kuenzer", "email": "simon.kuenzer@neclab.eu" }, "content": "Hi all,\n\nthe only issue I could imagine is that current DPDK applications are\nutilizing the implicit assumption that the master lcore is always set to\nthe first available lcore. I would consider this as a \"bug\" in the\napplication because it sets up its worker threads not \"properly\".\n\nHowever, as far I could check it, the DPDK framework seems to cope with\nit correctly.\nIt would be nice if somebody else could confirm my statement.\n\nThanks,\n\nSimon\n\nOn 23.07.2014 10:53, Hiroshi Shimamoto wrote:\n> Hi,\n> \n>> Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id\n>>\n>> Hi Hiroshi,\n>>\n>> 2014-07-22 23:40, Hiroshi Shimamoto:\n>>> does anyone have interest in this functionality?\n>>>\n>>> I think this is important and useful.\n>>> Since we should care about core assignment to get high performance\n>>> and the master lcore thread is special in DPDK, we will want to\n>>> assign the master to the target core.\n>>> For example, with hyperthreading I'd like to make a pair of packet\n>>> processing threads into one physical core and separate the master\n>>> thread which does some management.\n>>\n>> Thank you for showing your interest.\n>> Does it mean you carefully reviewed this patch? In this case, I'd appreciate\n>> a note \"Reviewed-by:\".\n> \n> Not yet deeply, wait a bit, we're testing this patch in our application.\n> Will report if it works fine.\n> \n> By the way, we should add the same code into the BSD code, right?\n> \n> thanks,\n> Hiroshi\n> \n>>\n>> Thanks\n>> --\n>> Thomas", "headers": { "Return-Path": "<simon.kuenzer@neclab.eu>", "Received": [ "from mailer1.neclab.eu (mailer1.neclab.eu [195.37.70.40])\n\tby dpdk.org (Postfix) with ESMTP id ED3C86896\n\tfor <dev@dpdk.org>; Wed, 23 Jul 2014 14:09:23 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby mailer1.neclab.eu (Postfix) with ESMTP id 3EE221077D0;\n\tWed, 23 Jul 2014 14:10:47 +0200 (CEST)", "from mailer1.neclab.eu ([127.0.0.1])\n\tby localhost (atlas-a.office.hd [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id g9EJDBo1PyP9; Wed, 23 Jul 2014 14:10:47 +0200 (CEST)", "from METHONE.office.hd (methone.office.hd [192.168.24.54])\n\t(using TLSv1 with cipher AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mailer1.neclab.eu (Postfix) with ESMTPS id 1EDA41077C7;\n\tWed, 23 Jul 2014 14:10:32 +0200 (CEST)", "from [10.1.2.203] (10.1.2.203) by skoll.office.hd (192.168.125.11)\n\twith Microsoft SMTP Server (TLS) id 14.1.323.3;\n\tWed, 23 Jul 2014 14:10:31 +0200" ], "X-Virus-Scanned": "Amavisd on Debian GNU/Linux (netlab.nec.de)", "X-ENC": [ "Last-Hop-TLS-encrypted", "Last-Hop-TLS-encrypted" ], "Message-ID": "<53CFA637.1090706@neclab.eu>", "Date": "Wed, 23 Jul 2014 14:10:31 +0200", "From": "Simon Kuenzer <simon.kuenzer@neclab.eu>", "Organization": "NEC Laboratories Europe", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.0", "MIME-Version": "1.0", "To": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>, Thomas Monjalon\n\t<thomas.monjalon@6wind.com>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<53CD3E26.1060708@neclab.eu>\n\t<7F861DC0615E0C47A872E6F3C5FCDDBD01161242@BPXM14GP.gisp.nec.co.jp>\n\t<10116389.N4VFaZKECM@xps13>\n\t<7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp>", "In-Reply-To": "<7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp>", "Content-Type": "text/plain; charset=\"iso-2022-jp\"", "Content-Transfer-Encoding": "7bit", "X-Originating-IP": "[10.1.2.203]", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 23 Jul 2014 12:09:24 -0000" }, "addressed": null }, { "id": 211, "web_url": "https://patches.dpdk.org/comment/211/", "msgid": "<53CFA4FD.1060108@neclab.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/53CFA4FD.1060108@neclab.eu", "date": "2014-07-23T12:05:17", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 22, "url": "https://patches.dpdk.org/api/people/22/?format=api", "name": "Simon Kuenzer", "email": "simon.kuenzer@neclab.eu" }, "content": "On 23.07.2014 11:04, Thomas Monjalon wrote:\n> 2014-07-23 08:53, Hiroshi Shimamoto:\n>> 2014-07-23 09:50, Thomas Monjalon:\n>>> 2014-07-22 23:40, Hiroshi Shimamoto:\n>>>> does anyone have interest in this functionality?\n>>>>\n>>>> I think this is important and useful.\n>>>> Since we should care about core assignment to get high performance\n>>>> and the master lcore thread is special in DPDK, we will want to\n>>>> assign the master to the target core.\n>>>> For example, with hyperthreading I'd like to make a pair of packet\n>>>> processing threads into one physical core and separate the master\n>>>> thread which does some management.\n>>>\n>>> Thank you for showing your interest.\n>>> Does it mean you carefully reviewed this patch? In this case, I'd appreciate\n>>> a note \"Reviewed-by:\".\n>>\n>> Not yet deeply, wait a bit, we're testing this patch in our application.\n>> Will report if it works fine.\n>>\n>> By the way, we should add the same code into the BSD code, right?\n>\n> Right.\n> I'd prefer to reduce the duplicated footprint and have more common code\n> between BSD and Linux. But waiting this enhancement, we have to maintain\n> the duplicated code for BSD.\n>\n\nHi all,\n\nI can provide the same patch also for BSD. However, I do not have a \nmachine to test it. Interested?\n\nThanks,\n\nSimon", "headers": { "Return-Path": "<simon.kuenzer@neclab.eu>", "Received": [ "from mailer1.neclab.eu (mailer1.neclab.eu [195.37.70.40])\n\tby dpdk.org (Postfix) with ESMTP id CE393594D\n\tfor <dev@dpdk.org>; Wed, 23 Jul 2014 14:04:10 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby mailer1.neclab.eu (Postfix) with ESMTP id 10F941077D0;\n\tWed, 23 Jul 2014 14:05:34 +0200 (CEST)", "from mailer1.neclab.eu ([127.0.0.1])\n\tby localhost (atlas-a.office.hd [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nhnoYU8pBdci; Wed, 23 Jul 2014 14:05:33 +0200 (CEST)", "from METHONE.office.hd (methone.office.hd [192.168.24.54])\n\t(using TLSv1 with cipher AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mailer1.neclab.eu (Postfix) with ESMTPS id E5ED61077C7;\n\tWed, 23 Jul 2014 14:05:18 +0200 (CEST)", "from [10.1.2.203] (10.1.2.203) by skoll.office.hd (192.168.125.11)\n\twith Microsoft SMTP Server (TLS) id 14.1.323.3;\n\tWed, 23 Jul 2014 14:05:18 +0200" ], "X-Virus-Scanned": "Amavisd on Debian GNU/Linux (netlab.nec.de)", "X-ENC": [ "Last-Hop-TLS-encrypted", "Last-Hop-TLS-encrypted" ], "Message-ID": "<53CFA4FD.1060108@neclab.eu>", "Date": "Wed, 23 Jul 2014 14:05:17 +0200", "From": "Simon Kuenzer <simon.kuenzer@neclab.eu>", "Organization": "NEC Laboratories Europe", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.0", "MIME-Version": "1.0", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>, Hiroshi Shimamoto\n\t<h-shimamoto@ct.jp.nec.com>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<10116389.N4VFaZKECM@xps13>\n\t<7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp>\n\t<3356411.EsFcTdggfg@xps13>", "In-Reply-To": "<3356411.EsFcTdggfg@xps13>", "Content-Type": "text/plain; charset=\"windows-1252\"; format=flowed", "Content-Transfer-Encoding": "7bit", "X-Originating-IP": "[10.1.2.203]", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 23 Jul 2014 12:04:11 -0000" }, "addressed": null }, { "id": 210, "web_url": "https://patches.dpdk.org/comment/210/", "msgid": "<3356411.EsFcTdggfg@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/3356411.EsFcTdggfg@xps13", "date": "2014-07-23T09:04:40", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-07-23 08:53, Hiroshi Shimamoto:\n> 2014-07-23 09:50, Thomas Monjalon:\n> > 2014-07-22 23:40, Hiroshi Shimamoto:\n> > > does anyone have interest in this functionality?\n> > >\n> > > I think this is important and useful.\n> > > Since we should care about core assignment to get high performance\n> > > and the master lcore thread is special in DPDK, we will want to\n> > > assign the master to the target core.\n> > > For example, with hyperthreading I'd like to make a pair of packet\n> > > processing threads into one physical core and separate the master\n> > > thread which does some management.\n> > \n> > Thank you for showing your interest.\n> > Does it mean you carefully reviewed this patch? In this case, I'd appreciate\n> > a note \"Reviewed-by:\".\n> \n> Not yet deeply, wait a bit, we're testing this patch in our application.\n> Will report if it works fine.\n> \n> By the way, we should add the same code into the BSD code, right?\n\nRight.\nI'd prefer to reduce the duplicated footprint and have more common code\nbetween BSD and Linux. But waiting this enhancement, we have to maintain\nthe duplicated code for BSD.", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-wi0-f180.google.com (mail-wi0-f180.google.com\n\t[209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 2373D594D\n\tfor <dev@dpdk.org>; Wed, 23 Jul 2014 11:03:26 +0200 (CEST)", "by mail-wi0-f180.google.com with SMTP id n3so1835357wiv.1\n\tfor <dev@dpdk.org>; Wed, 23 Jul 2014 02:04:48 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tdn3sm6967563wib.12.2014.07.23.02.04.47 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 23 Jul 2014 02:04:48 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=yrSsNCMQIXCYYP9l6b2NoXena3AOOBGV3zbwJItbZaE=;\n\tb=bfoVynPR43Y0nzssmcd5ZotpNjG+tPS5wYpJPTVuowFwqypSW1uEb02Dc4f5O9KxX8\n\tyINfgNN6NgMxU429/2hBgnpqldtJsvaN05cgWOKGO8SA36gVnHGTantFApdXiKR1I/76\n\t2xucSifako4Yj7iwAiUKaKPMaCSudmN44kVAyYAsrOh2Ka5he1Ab3qJR2X988RSjm4yF\n\tDTB+2djjhjNjJUQrI3eGFrY/Aip/gFNV5PHiOtGX+pUGc8EzNWfAJ5/gA319rwcpg8zT\n\tNaC1U4KtJepKOjEn6+TYNOMnmc/CRQtib5J/dHyb/DI9DjWa4fqt959/UN6TxhEtvxg2\n\tPJNA==", "X-Gm-Message-State": "ALoCoQlFxWr6xMarLUE2Ao+EmG4c84hc8E1LleVbal+EV8+FRrdsa8/s1IPQG7gnDlk/4YH1x5SV", "X-Received": "by 10.194.24.2 with SMTP id q2mr41043626wjf.91.1406106288887;\n\tWed, 23 Jul 2014 02:04:48 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>", "Date": "Wed, 23 Jul 2014 11:04:40 +0200", "Message-ID": "<3356411.EsFcTdggfg@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; )", "In-Reply-To": "<7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<10116389.N4VFaZKECM@xps13>\n\t<7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 23 Jul 2014 09:03:26 -0000" }, "addressed": null }, { "id": 209, "web_url": "https://patches.dpdk.org/comment/209/", "msgid": "<7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp>", "list_archive_url": "https://inbox.dpdk.org/dev/7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp", "date": "2014-07-23T08:53:09", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 38, "url": "https://patches.dpdk.org/api/people/38/?format=api", "name": "Hiroshi Shimamoto", "email": "h-shimamoto@ct.jp.nec.com" }, "content": "Hi,\n\n> Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id\n> \n> Hi Hiroshi,\n> \n> 2014-07-22 23:40, Hiroshi Shimamoto:\n> > does anyone have interest in this functionality?\n> >\n> > I think this is important and useful.\n> > Since we should care about core assignment to get high performance\n> > and the master lcore thread is special in DPDK, we will want to\n> > assign the master to the target core.\n> > For example, with hyperthreading I'd like to make a pair of packet\n> > processing threads into one physical core and separate the master\n> > thread which does some management.\n> \n> Thank you for showing your interest.\n> Does it mean you carefully reviewed this patch? In this case, I'd appreciate\n> a note \"Reviewed-by:\".\n\nNot yet deeply, wait a bit, we're testing this patch in our application.\nWill report if it works fine.\n\nBy the way, we should add the same code into the BSD code, right?\n\nthanks,\nHiroshi\n\n> \n> Thanks\n> --\n> Thomas", "headers": { "Return-Path": "<h-shimamoto@ct.jp.nec.com>", "Received": [ "from tyo201.gate.nec.co.jp (TYO201.gate.nec.co.jp [210.143.35.51])\n\tby dpdk.org (Postfix) with ESMTP id B235D594D\n\tfor <dev@dpdk.org>; Wed, 23 Jul 2014 10:52:02 +0200 (CEST)", "from mailgate3.nec.co.jp ([10.7.69.193])\n\tby tyo201.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s6N8rLS0025636;\n\tWed, 23 Jul 2014 17:53:21 +0900 (JST)", "from mailsv4.nec.co.jp (imss63.nec.co.jp [10.7.69.158]) by\n\tmailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP\n\tid s6N8rLd03647; Wed, 23 Jul 2014 17:53:21 +0900 (JST)", "from mail03.kamome.nec.co.jp (mail03.kamome.nec.co.jp [10.25.43.7])\n\tby mailsv4.nec.co.jp (8.13.8/8.13.4) with ESMTP id s6N8rLv1006429;\n\tWed, 23 Jul 2014 17:53:21 +0900 (JST)", "from bpxc99gp.gisp.nec.co.jp ([10.38.151.146] [10.38.151.146]) by\n\tmail01b.kamome.nec.co.jp with ESMTP id BT-MMP-742148;\n\tWed, 23 Jul 2014 17:53:10 +0900", "from BPXM14GP.gisp.nec.co.jp ([169.254.1.238]) by\n\tBPXC18GP.gisp.nec.co.jp ([10.38.151.146]) with mapi id 14.02.0328.011;\n\tWed, 23 Jul 2014 17:53:09 +0900" ], "From": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "Thread-Index": "AQHPpP/5HRcYWawLzUK9QPLwaiBbj5usvvzA///1kICAAKcWYA==", "Date": "Wed, 23 Jul 2014 08:53:09 +0000", "Message-ID": "<7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<53CD3E26.1060708@neclab.eu>\n\t<7F861DC0615E0C47A872E6F3C5FCDDBD01161242@BPXM14GP.gisp.nec.co.jp>\n\t<10116389.N4VFaZKECM@xps13>", "In-Reply-To": "<10116389.N4VFaZKECM@xps13>", "Accept-Language": "ja-JP, en-US", "Content-Language": "ja-JP", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.205.5.123]", "Content-Type": "text/plain; charset=\"iso-2022-jp\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 23 Jul 2014 08:52:03 -0000" }, "addressed": null }, { "id": 206, "web_url": "https://patches.dpdk.org/comment/206/", "msgid": "<738D45BC1F695740A983F43CFE1B7EA92D6EFD32@IRSMSX102.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/738D45BC1F695740A983F43CFE1B7EA92D6EFD32@IRSMSX102.ger.corp.intel.com", "date": "2014-07-23T08:03:55", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 41, "url": "https://patches.dpdk.org/api/people/41/?format=api", "name": "Gray, Mark D", "email": "mark.d.gray@intel.com" }, "content": "> Hi all,\n> \n> does anyone have interest in this functionality?\n\nYes, I think this is useful for DPDK vSwitch.\n> \n> I think this is important and useful.\n> Since we should care about core assignment to get high performance and the\n> master lcore thread is special in DPDK, we will want to assign the master to\n> the target core.\n> For example, with hyperthreading I'd like to make a pair of packet processing\n> threads into one physical core and separate the master thread which does\n> some management.\n> \n> thanks,\n> Hiroshi\n>", "headers": { "Return-Path": "<mark.d.gray@intel.com>", "Received": [ "from mga03.intel.com (mga03.intel.com [143.182.124.21])\n\tby dpdk.org (Postfix) with ESMTP id 6BC81594D\n\tfor <dev@dpdk.org>; Wed, 23 Jul 2014 10:02:53 +0200 (CEST)", "from azsmga001.ch.intel.com ([10.2.17.19])\n\tby azsmga101.ch.intel.com with ESMTP; 23 Jul 2014 01:04:14 -0700", "from irsmsx103.ger.corp.intel.com ([163.33.3.157])\n\tby azsmga001.ch.intel.com with ESMTP; 23 Jul 2014 01:03:57 -0700", "from irsmsx105.ger.corp.intel.com (163.33.3.28) by\n\tIRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP\n\tServer (TLS) id 14.3.123.3; Wed, 23 Jul 2014 09:03:55 +0100", "from irsmsx102.ger.corp.intel.com ([169.254.2.76]) by\n\tIRSMSX105.ger.corp.intel.com ([169.254.7.76]) with mapi id\n\t14.03.0123.003; Wed, 23 Jul 2014 09:03:55 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.01,715,1400050800\"; d=\"scan'208\";a=\"460311865\"", "From": "\"Gray, Mark D\" <mark.d.gray@intel.com>", "To": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>, Simon Kuenzer\n\t<simon.kuenzer@neclab.eu>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "Thread-Index": "AQHPpQABomTZRpvILEul1rFPnUjeG5ussf+AgACdNYA=", "Date": "Wed, 23 Jul 2014 08:03:55 +0000", "Message-ID": "<738D45BC1F695740A983F43CFE1B7EA92D6EFD32@IRSMSX102.ger.corp.intel.com>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<53BBBCFC.1070907@neclab.eu> <53CD3E26.1060708@neclab.eu>\n\t<7F861DC0615E0C47A872E6F3C5FCDDBD01161242@BPXM14GP.gisp.nec.co.jp>", "In-Reply-To": "<7F861DC0615E0C47A872E6F3C5FCDDBD01161242@BPXM14GP.gisp.nec.co.jp>", "Accept-Language": "en-IE, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.181]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 23 Jul 2014 08:02:53 -0000" }, "addressed": null }, { "id": 205, "web_url": "https://patches.dpdk.org/comment/205/", "msgid": "<10116389.N4VFaZKECM@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/10116389.N4VFaZKECM@xps13", "date": "2014-07-23T07:50:03", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "Hi Hiroshi,\n\n2014-07-22 23:40, Hiroshi Shimamoto:\n> does anyone have interest in this functionality?\n> \n> I think this is important and useful.\n> Since we should care about core assignment to get high performance\n> and the master lcore thread is special in DPDK, we will want to\n> assign the master to the target core.\n> For example, with hyperthreading I'd like to make a pair of packet\n> processing threads into one physical core and separate the master\n> thread which does some management.\n\nThank you for showing your interest.\nDoes it mean you carefully reviewed this patch? In this case, I'd appreciate\na note \"Reviewed-by:\".\n\nThanks", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-wi0-f169.google.com (mail-wi0-f169.google.com\n\t[209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 3A033594D\n\tfor <dev@dpdk.org>; Wed, 23 Jul 2014 09:48:51 +0200 (CEST)", "by mail-wi0-f169.google.com with SMTP id n3so7065669wiv.2\n\tfor <dev@dpdk.org>; Wed, 23 Jul 2014 00:50:13 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\twd7sm3950022wjc.36.2014.07.23.00.50.11 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 23 Jul 2014 00:50:12 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=ome+6yAAfh3ePTcyNYjHWnmtBjB8LCwSInXnJeriSyw=;\n\tb=U4S3MnxH1jzt/oHN84sZdKV6NtP8yNzk/9kznCxzT8Msr4UpQT0rTi5RS9YPN2KElz\n\tumWyhcyGfFDvz5pFVPHfhqjrOqGBU79KRGMcK1N5TVul0akggfs968aef9gdvCs1lwHb\n\tDhOK1PZuWyIdK2/Lek/2EwQU5x4mgTldjxm0CB2Kqz4pVApUT8KX4UJBsVxnXRQtWPuJ\n\tC0gKXu4FGHXJkYbmKqALL+vjjaXBgBWq0ZNLE5vASAEtVYgNwMhh4rI52MSUDvNGArb2\n\tELAh0KiDPO5pjYrtzp+D5D+DuLx2Amhf3oVBoX6a7pxUGQH1tOUmIUg3bmStk2CRlM0C\n\tanSw==", "X-Gm-Message-State": "ALoCoQnYuvNyPnWHQO+55igu7eEaMo9IhYpqFVUdFzPl6d6NEvrjrNtMWUfm+ZMSNylWXd1ApBCl", "X-Received": "by 10.180.198.244 with SMTP id jf20mr681373wic.40.1406101813358; \n\tWed, 23 Jul 2014 00:50:13 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>", "Date": "Wed, 23 Jul 2014 09:50:03 +0200", "Message-ID": "<10116389.N4VFaZKECM@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; )", "In-Reply-To": "<7F861DC0615E0C47A872E6F3C5FCDDBD01161242@BPXM14GP.gisp.nec.co.jp>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<53CD3E26.1060708@neclab.eu>\n\t<7F861DC0615E0C47A872E6F3C5FCDDBD01161242@BPXM14GP.gisp.nec.co.jp>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 23 Jul 2014 07:48:51 -0000" }, "addressed": null }, { "id": 199, "web_url": "https://patches.dpdk.org/comment/199/", "msgid": "<7F861DC0615E0C47A872E6F3C5FCDDBD01161242@BPXM14GP.gisp.nec.co.jp>", "list_archive_url": "https://inbox.dpdk.org/dev/7F861DC0615E0C47A872E6F3C5FCDDBD01161242@BPXM14GP.gisp.nec.co.jp", "date": "2014-07-22T23:40:55", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 38, "url": "https://patches.dpdk.org/api/people/38/?format=api", "name": "Hiroshi Shimamoto", "email": "h-shimamoto@ct.jp.nec.com" }, "content": "Hi all,\n\ndoes anyone have interest in this functionality?\n\nI think this is important and useful.\nSince we should care about core assignment to get high performance\nand the master lcore thread is special in DPDK, we will want to\nassign the master to the target core.\nFor example, with hyperthreading I'd like to make a pair of packet\nprocessing threads into one physical core and separate the master\nthread which does some management.\n\nthanks,\nHiroshi\n\n> Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id\n> \n> Comments?\n> \n> On 08.07.2014 11:42, Simon Kuenzer wrote:\n> > Here are some comments about the use case of this patch:\n> >\n> > This patch is especially useful in cases where DPDK applications scale\n> > their CPU resources at runtime via starting and stopping slave lcores.\n> > Since the coremask defines the maximum scale-out for such a application,\n> > the master lcore becomes to the minimum scale-in.\n> > Imagine, running multiple primary processed of such DPDK applications,\n> > users might want to overlap the coremasks for scaling. However, it would\n> > still make sense to run the master lcores on different CPU cores.\n> >\n> > In DPDK vSwitch we might end up in such a scenario with a future release:\n> > https://lists.01.org/pipermail/dpdk-ovs/2014-March/000770.html\n> > https://lists.01.org/pipermail/dpdk-ovs/2014-March/000773.html\n> >\n> > Thanks,\n> >\n> > Simon\n> >\n> > On 08.07.2014 10:28, Simon Kuenzer wrote:\n> >> This commit enables users to specify the lcore id that\n> >> is used as master lcore.\n> >>\n> >> Signed-off-by: Simon Kuenzer <simon.kuenzer@neclab.eu>\n> >> ---\n> >> lib/librte_eal/linuxapp/eal/eal.c | 33\n> >> +++++++++++++++++++++++++++++++++\n> >> 1 file changed, 33 insertions(+)\n> >>\n> >> diff --git a/lib/librte_eal/linuxapp/eal/eal.c\n> >> b/lib/librte_eal/linuxapp/eal/eal.c\n> >> index 573fd06..4ad5b9b 100644\n> >> --- a/lib/librte_eal/linuxapp/eal/eal.c\n> >> +++ b/lib/librte_eal/linuxapp/eal/eal.c\n> >> @@ -101,6 +101,7 @@\n> >> #define OPT_XEN_DOM0 \"xen-dom0\"\n> >> #define OPT_CREATE_UIO_DEV \"create-uio-dev\"\n> >> #define OPT_VFIO_INTR \"vfio-intr\"\n> >> +#define OPT_MASTER_LCORE \"master-lcore\"\n> >>\n> >> #define RTE_EAL_BLACKLIST_SIZE 0x100\n> >>\n> >> @@ -336,6 +337,7 @@ eal_usage(const char *prgname)\n> >> \"[--proc-type primary|secondary|auto] \\n\\n\"\n> >> \"EAL options:\\n\"\n> >> \" -c COREMASK : A hexadecimal bitmask of cores to run\n> >> on\\n\"\n> >> + \" --\"OPT_MASTER_LCORE\" ID: Core ID that is used as master\\n\"\n> >> \" -n NUM : Number of memory channels\\n\"\n> >> \" -v : Display version information on startup\\n\"\n> >> \" -d LIB.so : add driver (can be used multiple times)\\n\"\n> >> @@ -468,6 +470,21 @@ eal_parse_coremask(const char *coremask)\n> >> return 0;\n> >> }\n> >>\n> >> +/* Changes the lcore id of the master thread */\n> >> +static int\n> >> +eal_parse_master_lcore(const char *arg)\n> >> +{\n> >> + struct rte_config *cfg = rte_eal_get_configuration();\n> >> + int master_lcore = atoi(arg);\n> >> +\n> >> + if (!(master_lcore >= 0 && master_lcore < RTE_MAX_LCORE))\n> >> + return -1;\n> >> + if (cfg->lcore_role[master_lcore] != ROLE_RTE)\n> >> + return -1;\n> >> + cfg->master_lcore = master_lcore;\n> >> + return 0;\n> >> +}\n> >> +\n> >> static int\n> >> eal_parse_syslog(const char *facility)\n> >> {\n> >> @@ -653,6 +670,7 @@ eal_parse_args(int argc, char **argv)\n> >> {OPT_HUGE_DIR, 1, 0, 0},\n> >> {OPT_NO_SHCONF, 0, 0, 0},\n> >> {OPT_PROC_TYPE, 1, 0, 0},\n> >> + {OPT_MASTER_LCORE, 1, 0, 0},\n> >> {OPT_FILE_PREFIX, 1, 0, 0},\n> >> {OPT_SOCKET_MEM, 1, 0, 0},\n> >> {OPT_PCI_WHITELIST, 1, 0, 0},\n> >> @@ -802,6 +820,21 @@ eal_parse_args(int argc, char **argv)\n> >> else if (!strcmp(lgopts[option_index].name,\n> >> OPT_PROC_TYPE)) {\n> >> internal_config.process_type =\n> >> eal_parse_proc_type(optarg);\n> >> }\n> >> + else if (!strcmp(lgopts[option_index].name,\n> >> OPT_MASTER_LCORE)) {\n> >> + if (!coremask_ok) {\n> >> + RTE_LOG(ERR, EAL, \"please specify the master \"\n> >> + \"lcore id after specifying \"\n> >> + \"the coremask\\n\");\n> >> + eal_usage(prgname);\n> >> + return -1;\n> >> + }\n> >> + if (eal_parse_master_lcore(optarg) < 0) {\n> >> + RTE_LOG(ERR, EAL, \"invalid parameter for --\"\n> >> + OPT_MASTER_LCORE \"\\n\");\n> >> + eal_usage(prgname);\n> >> + return -1;\n> >> + }\n> >> + }\n> >> else if (!strcmp(lgopts[option_index].name,\n> >> OPT_FILE_PREFIX)) {\n> >> internal_config.hugefile_prefix = optarg;\n> >> }\n> >>\n> >", "headers": { "Return-Path": "<h-shimamoto@ct.jp.nec.com>", "Received": [ "from tyo201.gate.nec.co.jp (TYO201.gate.nec.co.jp [210.143.35.51])\n\tby dpdk.org (Postfix) with ESMTP id B95C25930\n\tfor <dev@dpdk.org>; Wed, 23 Jul 2014 01:40:26 +0200 (CEST)", "from mailgate3.nec.co.jp ([10.7.69.195])\n\tby tyo201.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s6MNfjgv000013\n\tfor <dev@dpdk.org>; Wed, 23 Jul 2014 08:41:45 +0900 (JST)", "from mailsv3.nec.co.jp (imss63.nec.co.jp [10.7.69.158]) by\n\tmailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP\n\tid s6MNfja16102 for <dev@dpdk.org>;\n\tWed, 23 Jul 2014 08:41:45 +0900 (JST)", "from mail01b.kamome.nec.co.jp (mail01b.kamome.nec.co.jp\n\t[10.25.43.2])\n\tby mailsv3.nec.co.jp (8.13.8/8.13.4) with ESMTP id s6MNfiLo011207\n\tfor <dev@dpdk.org>; Wed, 23 Jul 2014 08:41:44 +0900 (JST)", "from bpxc99gp.gisp.nec.co.jp ([10.38.151.141] [10.38.151.141]) by\n\tmail02.kamome.nec.co.jp with ESMTP id BT-MMP-721503;\n\tWed, 23 Jul 2014 08:40:56 +0900", "from BPXM14GP.gisp.nec.co.jp ([169.254.1.238]) by\n\tBPXC13GP.gisp.nec.co.jp ([10.38.151.141]) with mapi id 14.02.0328.011;\n\tWed, 23 Jul 2014 08:40:56 +0900" ], "From": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>", "To": "Simon Kuenzer <simon.kuenzer@neclab.eu>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "Thread-Index": "AQHPpP/5HRcYWawLzUK9QPLwaiBbj5usvvzA", "Date": "Tue, 22 Jul 2014 23:40:55 +0000", "Message-ID": "<7F861DC0615E0C47A872E6F3C5FCDDBD01161242@BPXM14GP.gisp.nec.co.jp>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<53BBBCFC.1070907@neclab.eu> <53CD3E26.1060708@neclab.eu>", "In-Reply-To": "<53CD3E26.1060708@neclab.eu>", "Accept-Language": "ja-JP, en-US", "Content-Language": "ja-JP", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.205.5.123]", "Content-Type": "text/plain; charset=\"iso-2022-jp\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Tue, 22 Jul 2014 23:40:27 -0000" }, "addressed": null }, { "id": 181, "web_url": "https://patches.dpdk.org/comment/181/", "msgid": "<53CD3E26.1060708@neclab.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/53CD3E26.1060708@neclab.eu", "date": "2014-07-21T16:21:58", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 22, "url": "https://patches.dpdk.org/api/people/22/?format=api", "name": "Simon Kuenzer", "email": "simon.kuenzer@neclab.eu" }, "content": "Comments?\n\nOn 08.07.2014 11:42, Simon Kuenzer wrote:\n> Here are some comments about the use case of this patch:\n>\n> This patch is especially useful in cases where DPDK applications scale\n> their CPU resources at runtime via starting and stopping slave lcores.\n> Since the coremask defines the maximum scale-out for such a application,\n> the master lcore becomes to the minimum scale-in.\n> Imagine, running multiple primary processed of such DPDK applications,\n> users might want to overlap the coremasks for scaling. However, it would\n> still make sense to run the master lcores on different CPU cores.\n>\n> In DPDK vSwitch we might end up in such a scenario with a future release:\n> https://lists.01.org/pipermail/dpdk-ovs/2014-March/000770.html\n> https://lists.01.org/pipermail/dpdk-ovs/2014-March/000773.html\n>\n> Thanks,\n>\n> Simon\n>\n> On 08.07.2014 10:28, Simon Kuenzer wrote:\n>> This commit enables users to specify the lcore id that\n>> is used as master lcore.\n>>\n>> Signed-off-by: Simon Kuenzer <simon.kuenzer@neclab.eu>\n>> ---\n>> lib/librte_eal/linuxapp/eal/eal.c | 33\n>> +++++++++++++++++++++++++++++++++\n>> 1 file changed, 33 insertions(+)\n>>\n>> diff --git a/lib/librte_eal/linuxapp/eal/eal.c\n>> b/lib/librte_eal/linuxapp/eal/eal.c\n>> index 573fd06..4ad5b9b 100644\n>> --- a/lib/librte_eal/linuxapp/eal/eal.c\n>> +++ b/lib/librte_eal/linuxapp/eal/eal.c\n>> @@ -101,6 +101,7 @@\n>> #define OPT_XEN_DOM0 \"xen-dom0\"\n>> #define OPT_CREATE_UIO_DEV \"create-uio-dev\"\n>> #define OPT_VFIO_INTR \"vfio-intr\"\n>> +#define OPT_MASTER_LCORE \"master-lcore\"\n>>\n>> #define RTE_EAL_BLACKLIST_SIZE 0x100\n>>\n>> @@ -336,6 +337,7 @@ eal_usage(const char *prgname)\n>> \"[--proc-type primary|secondary|auto] \\n\\n\"\n>> \"EAL options:\\n\"\n>> \" -c COREMASK : A hexadecimal bitmask of cores to run\n>> on\\n\"\n>> + \" --\"OPT_MASTER_LCORE\" ID: Core ID that is used as master\\n\"\n>> \" -n NUM : Number of memory channels\\n\"\n>> \" -v : Display version information on startup\\n\"\n>> \" -d LIB.so : add driver (can be used multiple times)\\n\"\n>> @@ -468,6 +470,21 @@ eal_parse_coremask(const char *coremask)\n>> return 0;\n>> }\n>>\n>> +/* Changes the lcore id of the master thread */\n>> +static int\n>> +eal_parse_master_lcore(const char *arg)\n>> +{\n>> + struct rte_config *cfg = rte_eal_get_configuration();\n>> + int master_lcore = atoi(arg);\n>> +\n>> + if (!(master_lcore >= 0 && master_lcore < RTE_MAX_LCORE))\n>> + return -1;\n>> + if (cfg->lcore_role[master_lcore] != ROLE_RTE)\n>> + return -1;\n>> + cfg->master_lcore = master_lcore;\n>> + return 0;\n>> +}\n>> +\n>> static int\n>> eal_parse_syslog(const char *facility)\n>> {\n>> @@ -653,6 +670,7 @@ eal_parse_args(int argc, char **argv)\n>> {OPT_HUGE_DIR, 1, 0, 0},\n>> {OPT_NO_SHCONF, 0, 0, 0},\n>> {OPT_PROC_TYPE, 1, 0, 0},\n>> + {OPT_MASTER_LCORE, 1, 0, 0},\n>> {OPT_FILE_PREFIX, 1, 0, 0},\n>> {OPT_SOCKET_MEM, 1, 0, 0},\n>> {OPT_PCI_WHITELIST, 1, 0, 0},\n>> @@ -802,6 +820,21 @@ eal_parse_args(int argc, char **argv)\n>> else if (!strcmp(lgopts[option_index].name,\n>> OPT_PROC_TYPE)) {\n>> internal_config.process_type =\n>> eal_parse_proc_type(optarg);\n>> }\n>> + else if (!strcmp(lgopts[option_index].name,\n>> OPT_MASTER_LCORE)) {\n>> + if (!coremask_ok) {\n>> + RTE_LOG(ERR, EAL, \"please specify the master \"\n>> + \"lcore id after specifying \"\n>> + \"the coremask\\n\");\n>> + eal_usage(prgname);\n>> + return -1;\n>> + }\n>> + if (eal_parse_master_lcore(optarg) < 0) {\n>> + RTE_LOG(ERR, EAL, \"invalid parameter for --\"\n>> + OPT_MASTER_LCORE \"\\n\");\n>> + eal_usage(prgname);\n>> + return -1;\n>> + }\n>> + }\n>> else if (!strcmp(lgopts[option_index].name,\n>> OPT_FILE_PREFIX)) {\n>> internal_config.hugefile_prefix = optarg;\n>> }\n>>\n>", "headers": { "Return-Path": "<simon.kuenzer@neclab.eu>", "Received": [ "from mailer1.neclab.eu (mailer1.neclab.eu [195.37.70.40])\n\tby dpdk.org (Postfix) with ESMTP id 2F3735930\n\tfor <dev@dpdk.org>; Mon, 21 Jul 2014 18:21:11 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby mailer1.neclab.eu (Postfix) with ESMTP id 1D6FC1077C6\n\tfor <dev@dpdk.org>; Mon, 21 Jul 2014 18:22:26 +0200 (CEST)", "from mailer1.neclab.eu ([127.0.0.1])\n\tby localhost (atlas-a.office.hd [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KnVxwcSKIN78 for <dev@dpdk.org>;\n\tMon, 21 Jul 2014 18:22:26 +0200 (CEST)", "from METHONE.office.hd (methone.office.hd [192.168.24.54])\n\t(using TLSv1 with cipher AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mailer1.neclab.eu (Postfix) with ESMTPS id EDD5E1077C4\n\tfor <dev@dpdk.org>; Mon, 21 Jul 2014 18:22:20 +0200 (CEST)", "from [10.1.2.203] (10.1.2.203) by skoll.office.hd (192.168.125.11)\n\twith Microsoft SMTP Server (TLS) id 14.1.323.3;\n\tMon, 21 Jul 2014 18:21:59 +0200" ], "X-Virus-Scanned": "Amavisd on Debian GNU/Linux (netlab.nec.de)", "X-ENC": [ "Last-Hop-TLS-encrypted", "Last-Hop-TLS-encrypted" ], "Message-ID": "<53CD3E26.1060708@neclab.eu>", "Date": "Mon, 21 Jul 2014 18:21:58 +0200", "From": "Simon Kuenzer <simon.kuenzer@neclab.eu>", "Organization": "NEC Laboratories Europe", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64;\n\trv:24.0) Gecko/20100101 Thunderbird/24.6.0", "MIME-Version": "1.0", "To": "<dev@dpdk.org>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>\n\t<53BBBCFC.1070907@neclab.eu>", "In-Reply-To": "<53BBBCFC.1070907@neclab.eu>", "Content-Type": "text/plain; charset=\"ISO-8859-1\"; format=flowed", "Content-Transfer-Encoding": "7bit", "X-Originating-IP": "[10.1.2.203]", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Mon, 21 Jul 2014 16:21:11 -0000" }, "addressed": null }, { "id": 61, "web_url": "https://patches.dpdk.org/comment/61/", "msgid": "<53BBBCFC.1070907@neclab.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/53BBBCFC.1070907@neclab.eu", "date": "2014-07-08T09:42:20", "subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "submitter": { "id": 22, "url": "https://patches.dpdk.org/api/people/22/?format=api", "name": "Simon Kuenzer", "email": "simon.kuenzer@neclab.eu" }, "content": "Here are some comments about the use case of this patch:\n\nThis patch is especially useful in cases where DPDK applications scale \ntheir CPU resources at runtime via starting and stopping slave lcores. \nSince the coremask defines the maximum scale-out for such a application, \nthe master lcore becomes to the minimum scale-in.\nImagine, running multiple primary processed of such DPDK applications, \nusers might want to overlap the coremasks for scaling. However, it would \nstill make sense to run the master lcores on different CPU cores.\n\nIn DPDK vSwitch we might end up in such a scenario with a future release:\n https://lists.01.org/pipermail/dpdk-ovs/2014-March/000770.html\n https://lists.01.org/pipermail/dpdk-ovs/2014-March/000773.html\n\nThanks,\n\nSimon\n\nOn 08.07.2014 10:28, Simon Kuenzer wrote:\n> This commit enables users to specify the lcore id that\n> is used as master lcore.\n>\n> Signed-off-by: Simon Kuenzer <simon.kuenzer@neclab.eu>\n> ---\n> lib/librte_eal/linuxapp/eal/eal.c | 33 +++++++++++++++++++++++++++++++++\n> 1 file changed, 33 insertions(+)\n>\n> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\n> index 573fd06..4ad5b9b 100644\n> --- a/lib/librte_eal/linuxapp/eal/eal.c\n> +++ b/lib/librte_eal/linuxapp/eal/eal.c\n> @@ -101,6 +101,7 @@\n> #define OPT_XEN_DOM0 \"xen-dom0\"\n> #define OPT_CREATE_UIO_DEV \"create-uio-dev\"\n> #define OPT_VFIO_INTR \"vfio-intr\"\n> +#define OPT_MASTER_LCORE \"master-lcore\"\n>\n> #define RTE_EAL_BLACKLIST_SIZE\t0x100\n>\n> @@ -336,6 +337,7 @@ eal_usage(const char *prgname)\n> \t \"[--proc-type primary|secondary|auto] \\n\\n\"\n> \t \"EAL options:\\n\"\n> \t \" -c COREMASK : A hexadecimal bitmask of cores to run on\\n\"\n> +\t \" --\"OPT_MASTER_LCORE\" ID: Core ID that is used as master\\n\"\n> \t \" -n NUM : Number of memory channels\\n\"\n> \t\t \" -v : Display version information on startup\\n\"\n> \t \" -d LIB.so : add driver (can be used multiple times)\\n\"\n> @@ -468,6 +470,21 @@ eal_parse_coremask(const char *coremask)\n> \treturn 0;\n> }\n>\n> +/* Changes the lcore id of the master thread */\n> +static int\n> +eal_parse_master_lcore(const char *arg)\n> +{\n> +\tstruct rte_config *cfg = rte_eal_get_configuration();\n> +\tint master_lcore = atoi(arg);\n> +\n> +\tif (!(master_lcore >= 0 && master_lcore < RTE_MAX_LCORE))\n> +\t\treturn -1;\n> +\tif (cfg->lcore_role[master_lcore] != ROLE_RTE)\n> +\t\treturn -1;\n> +\tcfg->master_lcore = master_lcore;\n> +\treturn 0;\n> +}\n> +\n> static int\n> eal_parse_syslog(const char *facility)\n> {\n> @@ -653,6 +670,7 @@ eal_parse_args(int argc, char **argv)\n> \t\t{OPT_HUGE_DIR, 1, 0, 0},\n> \t\t{OPT_NO_SHCONF, 0, 0, 0},\n> \t\t{OPT_PROC_TYPE, 1, 0, 0},\n> +\t\t{OPT_MASTER_LCORE, 1, 0, 0},\n> \t\t{OPT_FILE_PREFIX, 1, 0, 0},\n> \t\t{OPT_SOCKET_MEM, 1, 0, 0},\n> \t\t{OPT_PCI_WHITELIST, 1, 0, 0},\n> @@ -802,6 +820,21 @@ eal_parse_args(int argc, char **argv)\n> \t\t\telse if (!strcmp(lgopts[option_index].name, OPT_PROC_TYPE)) {\n> \t\t\t\tinternal_config.process_type = eal_parse_proc_type(optarg);\n> \t\t\t}\n> +\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_MASTER_LCORE)) {\n> +\t\t\t\tif (!coremask_ok) {\n> +\t\t\t\t\tRTE_LOG(ERR, EAL, \"please specify the master \"\n> +\t\t\t\t\t\t\t\"lcore id after specifying \"\n> +\t\t\t\t\t\t\t\"the coremask\\n\");\n> +\t\t\t\t\teal_usage(prgname);\n> +\t\t\t\t\treturn -1;\n> +\t\t\t\t}\n> +\t\t\t\tif (eal_parse_master_lcore(optarg) < 0) {\n> +\t\t\t\t\tRTE_LOG(ERR, EAL, \"invalid parameter for --\"\n> +\t\t\t\t\t\t\tOPT_MASTER_LCORE \"\\n\");\n> +\t\t\t\t\teal_usage(prgname);\n> +\t\t\t\t\treturn -1;\n> +\t\t\t\t}\n> +\t\t\t}\n> \t\t\telse if (!strcmp(lgopts[option_index].name, OPT_FILE_PREFIX)) {\n> \t\t\t\tinternal_config.hugefile_prefix = optarg;\n> \t\t\t}\n>", "headers": { "Return-Path": "<simon.kuenzer@neclab.eu>", "Received": [ "from mailer1.neclab.eu (mailer1.neclab.eu [195.37.70.40])\n\tby dpdk.org (Postfix) with ESMTP id 47DF75960\n\tfor <dev@dpdk.org>; Tue, 8 Jul 2014 11:42:04 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby mailer1.neclab.eu (Postfix) with ESMTP id 484DDFFFEC\n\tfor <dev@dpdk.org>; Tue, 8 Jul 2014 11:42:26 +0200 (CEST)", "from mailer1.neclab.eu ([127.0.0.1])\n\tby localhost (atlas-a.office.hd [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id b9ElCrz9g9dQ for <dev@dpdk.org>;\n\tTue, 8 Jul 2014 11:42:26 +0200 (CEST)", "from METHONE.office.hd (methone.office.hd [192.168.24.54])\n\t(using TLSv1 with cipher AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mailer1.neclab.eu (Postfix) with ESMTPS id 26522FFFD7\n\tfor <dev@dpdk.org>; Tue, 8 Jul 2014 11:42:21 +0200 (CEST)", "from [10.1.2.203] (10.1.2.203) by skoll.office.hd (192.168.125.11)\n\twith Microsoft SMTP Server (TLS) id 14.1.323.3;\n\tTue, 8 Jul 2014 11:42:20 +0200" ], "X-Virus-Scanned": "Amavisd on Debian GNU/Linux (netlab.nec.de)", "X-ENC": [ "Last-Hop-TLS-encrypted", "Last-Hop-TLS-encrypted" ], "Message-ID": "<53BBBCFC.1070907@neclab.eu>", "Date": "Tue, 8 Jul 2014 11:42:20 +0200", "From": "Simon Kuenzer <simon.kuenzer@neclab.eu>", "Organization": "NEC Laboratories Europe", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64;\n\trv:24.0) Gecko/20100101 Thunderbird/24.6.0", "MIME-Version": "1.0", "To": "<dev@dpdk.org>", "References": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>", "In-Reply-To": "<1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>", "Content-Type": "text/plain; charset=\"ISO-8859-1\"; format=flowed", "Content-Transfer-Encoding": "7bit", "X-Originating-IP": "[10.1.2.203]", "Subject": "Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify\n\tmaster lcore id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Tue, 08 Jul 2014 09:42:04 -0000" }, "addressed": null } ]