Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35922/?format=api
https://patches.dpdk.org/api/patches/35922/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1520634518-3055-1-git-send-email-nprachan@vyatta.att-mail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1520634518-3055-1-git-send-email-nprachan@vyatta.att-mail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1520634518-3055-1-git-send-email-nprachan@vyatta.att-mail.com", "date": "2018-03-09T22:28:38", "name": "[dpdk-dev] vdev: fix name comparison in find_vdev", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "29242ee9abc88aff006e8eaebc2c7ddd92d56a1a", "submitter": { "id": 989, "url": "https://patches.dpdk.org/api/people/989/?format=api", "name": "Nachiketa Prachanda", "email": "nprachan@vyatta.att-mail.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1520634518-3055-1-git-send-email-nprachan@vyatta.att-mail.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/35922/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/35922/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7253A5F71;\n\tFri, 9 Mar 2018 23:29:40 +0100 (CET)", "from mx0a-00191d01.pphosted.com (mx0b-00191d01.pphosted.com\n\t[67.231.157.136]) by dpdk.org (Postfix) with ESMTP id 86DF15F54;\n\tFri, 9 Mar 2018 23:29:39 +0100 (CET)", "from pps.filterd (m0083689.ppops.net [127.0.0.1])\n\tby m0083689.ppops.net-00191d01. (8.16.0.21/8.16.0.21) with SMTP id\n\tw29MPNHC048672; Fri, 9 Mar 2018 17:29:38 -0500", "from tlpd255.enaf.dadc.sbc.com (sbcsmtp3.sbc.com [144.160.112.28])\n\tby m0083689.ppops.net-00191d01. with ESMTP id 2gm2ss8e9w-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Fri, 09 Mar 2018 17:29:38 -0500", "from enaf.dadc.sbc.com (localhost [127.0.0.1])\n\tby tlpd255.enaf.dadc.sbc.com (8.14.5/8.14.5) with ESMTP id\n\tw29MTboc089187; Fri, 9 Mar 2018 16:29:38 -0600", "from zlp30499.vci.att.com (zlp30499.vci.att.com [135.46.181.149])\n\tby tlpd255.enaf.dadc.sbc.com (8.14.5/8.14.5) with ESMTP id\n\tw29MTXQH089088; Fri, 9 Mar 2018 16:29:33 -0600", "from zlp30499.vci.att.com (zlp30499.vci.att.com [127.0.0.1])\n\tby zlp30499.vci.att.com (Service) with ESMTP id 0EB48400074D;\n\tFri, 9 Mar 2018 22:29:33 +0000 (GMT)", "from clpi183.sldc.sbc.com (unknown [135.41.1.46])\n\tby zlp30499.vci.att.com (Service) with ESMTP id E7D9540006FE;\n\tFri, 9 Mar 2018 22:29:32 +0000 (GMT)", "from sldc.sbc.com (localhost [127.0.0.1])\n\tby clpi183.sldc.sbc.com (8.14.5/8.14.5) with ESMTP id w29MTWMX011196; \n\tFri, 9 Mar 2018 16:29:32 -0600", "from mail.eng.vyatta.net (mail.eng.vyatta.net [10.156.50.82])\n\tby clpi183.sldc.sbc.com (8.14.5/8.14.5) with ESMTP id w29MTPjB010766; \n\tFri, 9 Mar 2018 16:29:25 -0600", "from np439h-Precision-7520.eng.vyatta.net (unknown [10.156.48.111])\n\tby mail.eng.vyatta.net (Postfix) with ESMTP id 21DE136004A;\n\tFri, 9 Mar 2018 14:29:25 -0800 (PST)" ], "From": "Nachiketa Prachanda <nprachan@vyatta.att-mail.com>", "To": "Jianfeng Tan <jianfeng.tan@intel.com>", "Cc": "dev@dpdk.org, Nachiketa Prachanda <nprachan@vyatta.att-mail.com>,\n\tjblunck@infradead.org, stable@dpdk.org", "Date": "Fri, 9 Mar 2018 14:28:38 -0800", "Message-Id": "<1520634518-3055-1-git-send-email-nprachan@vyatta.att-mail.com>", "X-Mailer": "git-send-email 2.7.4", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2018-03-09_11:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_policy_notspam\n\tpolicy=outbound_policy score=0\n\tpriorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0\n\tbulkscore=0\n\tspamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0\n\timpostorscore=0\n\tmlxlogscore=675 adultscore=0 classifier=spam adjust=0 reason=mlx\n\tscancount=1 engine=8.0.1-1711220000 definitions=main-1803090265", "Subject": "[dpdk-dev] [PATCH] vdev: fix name comparison in find_vdev", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use strcmp to compare device names as the strncmp in original code\ncauses find_vdev to return -EEXIST for names that are prefix\nof another. The creation of interfaces fails unpredictably based\non the order of their creation. An easy way hit this bug is to create\neth_vhost1 after eth_vhost11.\n\nSigned-off-by: Nachiketa Prachanda <nprachan@vyatta.att-mail.com>\n\nFixes: dda987315ca2 (\"vdev: make virtual bus use its device struct\")\nCc: jblunck@infradead.org\nCc: stable@dpdk.org\n---\n drivers/bus/vdev/vdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex e4bc724..7eae319 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -188,7 +188,7 @@ find_vdev(const char *name)\n \tTAILQ_FOREACH(dev, &vdev_device_list, next) {\n \t\tconst char *devname = rte_vdev_device_name(dev);\n \n-\t\tif (!strncmp(devname, name, strlen(name)))\n+\t\tif (!strcmp(devname, name))\n \t\t\treturn dev;\n \t}\n \n", "prefixes": [ "dpdk-dev" ] }{ "id": 35922, "url": "