Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/359/?format=api
{ "id": 359, "url": "https://patches.dpdk.org/api/patches/359/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1410457641-3540-4-git-send-email-balazs.nemeth@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1410457641-3540-4-git-send-email-balazs.nemeth@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1410457641-3540-4-git-send-email-balazs.nemeth@intel.com", "date": "2014-09-11T17:47:20", "name": "[dpdk-dev,3/4] lib/librte_table: Fix incorrect t->data_size_shl initialization", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "25ab638324834595b699b910a5b40ff4fe245a58", "submitter": { "id": 67, "url": "https://patches.dpdk.org/api/people/67/?format=api", "name": "Balazs Nemeth", "email": "balazs.nemeth@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1410457641-3540-4-git-send-email-balazs.nemeth@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/359/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/359/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5A1BCB3A3;\n\tThu, 11 Sep 2014 19:41:36 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id B0CA8B39A\n\tfor <dev@dpdk.org>; Thu, 11 Sep 2014 19:41:33 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP; 11 Sep 2014 10:40:13 -0700", "from bnemeth-mobl.ger.corp.intel.com (HELO localhost.localdomain)\n\t([172.22.195.53])\n\tby orsmga002.jf.intel.com with ESMTP; 11 Sep 2014 10:46:18 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,506,1406617200\"; d=\"scan'208\";a=\"601588457\"", "From": "Balazs Nemeth <balazs.nemeth@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 11 Sep 2014 19:47:20 +0200", "Message-Id": "<1410457641-3540-4-git-send-email-balazs.nemeth@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1410457641-3540-1-git-send-email-balazs.nemeth@intel.com>", "References": "<1410457641-3540-1-git-send-email-balazs.nemeth@intel.com>", "Cc": "Balazs Nemeth <balazs.nemeth@intel.com>", "Subject": "[dpdk-dev] [PATCH 3/4] lib/librte_table: Fix incorrect\n\tt->data_size_shl initialization", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "During initialization of rte_hash_table_ext and rte_hash_table_lru,\nt->data_size_shl is calculated. This member contains the number of\nbits to shift left during calculation of the location of entries in\nthe hash table. To determine the number of bits to shift left, the\nsize of the entry (as provided to the rte_table_hash_ext_create and\nrte_table_hash_lru_create) has to be used instead of the size of the\nkey.\n\nSigned-off-by: Balazs Nemeth <balazs.nemeth@intel.com>\n---\n lib/librte_table/rte_table_hash_ext.c | 2 +-\n lib/librte_table/rte_table_hash_lru.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte_table_hash_ext.c\nindex 17c16cd..fb3e6d2 100644\n--- a/lib/librte_table/rte_table_hash_ext.c\n+++ b/lib/librte_table/rte_table_hash_ext.c\n@@ -221,7 +221,7 @@ rte_table_hash_ext_create(void *params, int socket_id, uint32_t entry_size)\n \t/* Internal */\n \tt->bucket_mask = t->n_buckets - 1;\n \tt->key_size_shl = __builtin_ctzl(p->key_size);\n-\tt->data_size_shl = __builtin_ctzl(p->key_size);\n+\tt->data_size_shl = __builtin_ctzl(entry_size);\n \n \t/* Tables */\n \ttable_meta_offset = 0;\ndiff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte_table_hash_lru.c\nindex d1a4984..bf92e81 100644\n--- a/lib/librte_table/rte_table_hash_lru.c\n+++ b/lib/librte_table/rte_table_hash_lru.c\n@@ -192,7 +192,7 @@ rte_table_hash_lru_create(void *params, int socket_id, uint32_t entry_size)\n \t/* Internal */\n \tt->bucket_mask = t->n_buckets - 1;\n \tt->key_size_shl = __builtin_ctzl(p->key_size);\n-\tt->data_size_shl = __builtin_ctzl(p->key_size);\n+\tt->data_size_shl = __builtin_ctzl(entry_size);\n \n \t/* Tables */\n \ttable_meta_offset = 0;\n", "prefixes": [ "dpdk-dev", "3/4" ] }