Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35780/?format=api
{ "id": 35780, "url": "https://patches.dpdk.org/api/patches/35780/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180308135249.28187-3-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180308135249.28187-3-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180308135249.28187-3-qi.z.zhang@intel.com", "date": "2018-03-08T13:52:44", "name": "[dpdk-dev,RFC,v2,2/7] lib/mbuf: enable parse flags when create mempool", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "382124dd873c05d99801ffd0063080e1c944ea05", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180308135249.28187-3-qi.z.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/35780/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/35780/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8D9885F59;\n\tThu, 8 Mar 2018 14:52:53 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 7E7295B34\n\tfor <dev@dpdk.org>; Thu, 8 Mar 2018 14:52:51 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Mar 2018 05:52:50 -0800", "from dpdk51.sh.intel.com ([10.67.110.184])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Mar 2018 05:52:49 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.47,441,1515484800\"; d=\"scan'208\";a=\"26294155\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "dev@dpdk.org", "Cc": "magnus.karlsson@intel.com, bjorn.topel@intel.com,\n\tQi Zhang <qi.z.zhang@intel.com>", "Date": "Thu, 8 Mar 2018 21:52:44 +0800", "Message-Id": "<20180308135249.28187-3-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20180308135249.28187-1-qi.z.zhang@intel.com>", "References": "<20180308135249.28187-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [RFC v2 2/7] lib/mbuf: enable parse flags when create\n\tmempool", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This give the option that applicaiton can configure each\nmemory chunk's size precisely. (by MEMPOOL_F_NO_SPREAD).\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n lib/librte_mbuf/rte_mbuf.c | 15 ++++++++++++---\n lib/librte_mbuf/rte_mbuf.h | 8 +++++++-\n 2 files changed, 19 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex 091d388d3..5fd91c87c 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -125,7 +125,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,\n struct rte_mempool * __rte_experimental\n rte_pktmbuf_pool_create_by_ops(const char *name, unsigned int n,\n \tunsigned int cache_size, uint16_t priv_size, uint16_t data_room_size,\n-\tint socket_id, const char *ops_name)\n+\tunsigned int flags, int socket_id, const char *ops_name)\n {\n \tstruct rte_mempool *mp;\n \tstruct rte_pktmbuf_pool_private mbp_priv;\n@@ -145,7 +145,7 @@ rte_pktmbuf_pool_create_by_ops(const char *name, unsigned int n,\n \tmbp_priv.mbuf_priv_size = priv_size;\n \n \tmp = rte_mempool_create_empty(name, n, elt_size, cache_size,\n-\t\t sizeof(struct rte_pktmbuf_pool_private), socket_id, 0);\n+\t\t sizeof(struct rte_pktmbuf_pool_private), socket_id, flags);\n \tif (mp == NULL)\n \t\treturn NULL;\n \n@@ -179,9 +179,18 @@ rte_pktmbuf_pool_create(const char *name, unsigned int n,\n \tint socket_id)\n {\n \treturn rte_pktmbuf_pool_create_by_ops(name, n, cache_size, priv_size,\n-\t\t\tdata_room_size, socket_id, NULL);\n+\t\t\tdata_room_size, 0, socket_id, NULL);\n }\n \n+/* helper to create a mbuf pool with NO_SPREAD */\n+struct rte_mempool *\n+rte_pktmbuf_pool_create_with_flags(const char *name, unsigned int n,\n+\tunsigned int cache_size, uint16_t priv_size, uint16_t data_room_size,\n+\tunsigned int flags, int socket_id)\n+{\n+\treturn rte_pktmbuf_pool_create_by_ops(name, n, cache_size, priv_size,\n+\t\t\tdata_room_size, flags, socket_id, NULL);\n+}\n /* do some sanity checks on a mbuf: panic if it fails */\n void\n rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header)\ndiff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex 62740254d..6f6af42a8 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -1079,6 +1079,12 @@ rte_pktmbuf_pool_create(const char *name, unsigned n,\n \tunsigned cache_size, uint16_t priv_size, uint16_t data_room_size,\n \tint socket_id);\n \n+struct rte_mempool *\n+rte_pktmbuf_pool_create_with_flags(const char *name, unsigned int n,\n+\tunsigned cache_size, uint16_t priv_size, uint16_t data_room_size,\n+\tunsigned flags, int socket_id);\n+\n+\n /**\n * Create a mbuf pool with a given mempool ops name\n *\n@@ -1119,7 +1125,7 @@ rte_pktmbuf_pool_create(const char *name, unsigned n,\n struct rte_mempool * __rte_experimental\n rte_pktmbuf_pool_create_by_ops(const char *name, unsigned int n,\n \tunsigned int cache_size, uint16_t priv_size, uint16_t data_room_size,\n-\tint socket_id, const char *ops_name);\n+\tunsigned int flags, int socket_id, const char *ops_name);\n \n /**\n * Get the data room size of mbufs stored in a pktmbuf_pool\n", "prefixes": [ "dpdk-dev", "RFC", "v2", "2/7" ] }