Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 3547,
    "url": "https://patches.dpdk.org/api/patches/3547/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1424449085-82466-1-git-send-email-danielx.t.mrzyglod@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1424449085-82466-1-git-send-email-danielx.t.mrzyglod@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1424449085-82466-1-git-send-email-danielx.t.mrzyglod@intel.com",
    "date": "2015-02-20T16:18:05",
    "name": "[dpdk-dev] cmdline: fix type format from unsigned to size_t for buffer size",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "6cb3f4dcda6d1c932e9dc6e6e158c16a6d4d9b0b",
    "submitter": {
        "id": 23,
        "url": "https://patches.dpdk.org/api/people/23/?format=api",
        "name": "Daniel Mrzyglod",
        "email": "danielx.t.mrzyglod@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1424449085-82466-1-git-send-email-danielx.t.mrzyglod@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/3547/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/3547/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0A56EB725;\n\tFri, 20 Feb 2015 16:21:47 +0100 (CET)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 72D15B612\n\tfor <dev@dpdk.org>; Fri, 20 Feb 2015 16:21:45 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 20 Feb 2015 07:17:29 -0800",
            "from unknown (HELO Sent) ([10.217.248.227])\n\tby orsmga001.jf.intel.com with SMTP; 20 Feb 2015 07:21:36 -0800",
            "by Sent (sSMTP sendmail emulation); Fri, 20 Feb 2015 17:18:10 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.09,615,1418112000\"; d=\"scan'208\";a=\"654853914\"",
        "From": "Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri, 20 Feb 2015 17:18:05 +0100",
        "Message-Id": "<1424449085-82466-1-git-send-email-danielx.t.mrzyglod@intel.com>",
        "X-Mailer": "git-send-email 2.1.0",
        "Subject": "[dpdk-dev] [PATCH] cmdline: fix type format from unsigned to size_t\n\tfor buffer size",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Function match_inst is used to take buffor using sizeof() which is size_t type.\nThis modification also involved changing '%u' to '%zu' in printf function.\n\nSigned-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>\n---\n lib/librte_cmdline/cmdline_parse.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_cmdline/cmdline_parse.c b/lib/librte_cmdline/cmdline_parse.c\nindex dfc885c..0821791 100644\n--- a/lib/librte_cmdline/cmdline_parse.c\n+++ b/lib/librte_cmdline/cmdline_parse.c\n@@ -138,7 +138,7 @@ nb_common_chars(const char * s1, const char * s2)\n  */\n static int\n match_inst(cmdline_parse_inst_t *inst, const char *buf,\n-\t   unsigned int nb_match_token, void *resbuf, unsigned resbuf_size)\n+\t   unsigned int nb_match_token, void *resbuf, size_t resbuf_size)\n {\n \tunsigned int token_num=0;\n \tcmdline_parse_token_hdr_t * token_p;\n@@ -169,7 +169,7 @@ match_inst(cmdline_parse_inst_t *inst, const char *buf,\n \n \t\t\tif (token_hdr.offset > resbuf_size) {\n \t\t\t\tprintf(\"Parse error(%s:%d): Token offset(%u) \"\n-\t\t\t\t\t\"exceeds maximum size(%u)\\n\",\n+\t\t\t\t\t\"exceeds maximum size(%zu)\\n\",\n \t\t\t\t\t__FILE__, __LINE__,\n \t\t\t\t\ttoken_hdr.offset, resbuf_size);\n \t\t\t\treturn -ENOBUFS;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}