Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35376,
    "url": "https://patches.dpdk.org/api/patches/35376/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180223211752.28651-2-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180223211752.28651-2-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180223211752.28651-2-stephen@networkplumber.org",
    "date": "2018-02-23T21:17:50",
    "name": "[dpdk-dev,v2,1/3] eal: allow symbolic log levels",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "921b6852a6dc0e05eb9a2e1a501f52599b2f1800",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180223211752.28651-2-stephen@networkplumber.org/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/35376/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/35376/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3E3755F5D;\n\tFri, 23 Feb 2018 22:18:07 +0100 (CET)",
            "from mail-pg0-f65.google.com (mail-pg0-f65.google.com\n\t[74.125.83.65]) by dpdk.org (Postfix) with ESMTP id 30D415F3C\n\tfor <dev@dpdk.org>; Fri, 23 Feb 2018 22:18:05 +0100 (CET)",
            "by mail-pg0-f65.google.com with SMTP id l24so3824777pgc.5\n\tfor <dev@dpdk.org>; Fri, 23 Feb 2018 13:18:05 -0800 (PST)",
            "from xeon-e3.lan (204-195-71-95.wavecable.com. [204.195.71.95])\n\tby smtp.gmail.com with ESMTPSA id\n\tg67sm5496674pgc.60.2018.02.23.13.18.02\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 23 Feb 2018 13:18:02 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Le0WaQhXRxgMcnCS5ZFCTMkpCszGtnYtLoT2SBV4Lb4=;\n\tb=IBss/2ZJLsJtDdBzYkyMdMZqElOQCEIy0XWw8A/QTVQA5WnS9Injlo5e5bajOFkFcb\n\teFZ8LbJicwY7Rhp5TU3VSdk1OkjZk417UcW+e2XFSZvbvaLjwBi2KbjhnJ6mQXOYsYH0\n\tX4V++LvsuHCY+M+qz+Eli3ST7GYwzCIhZ2gCqi42YPmtCR0VjnBFyi4aTmg7TsouUMi6\n\tNFQ1N1e5AWrVNh7amxljOSJnlLUdpsusZuBL1c1FmmmDgi1TPgJORNTMGBz9shFaO4c0\n\t6QMDPx+Z2KRwj2pBNxvj6ZwikB5O1EY2D1w5J8NOhjdHxFMUI9LJ6yOqGOKwu9UE8Wtz\n\tFexQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Le0WaQhXRxgMcnCS5ZFCTMkpCszGtnYtLoT2SBV4Lb4=;\n\tb=ORxjbQDb/3ggScSraGNEnVM3cPYuX7nZ30Ax1gc8o5l3CrloDOyTW5NFnC5+1ajvnk\n\tJ5JJqkIQeUyvj1mP/cQPXz7SjvncraDH0MV7k4uNpPxWIvyJkPD+WqPibiUODSjtEScW\n\tpggm6CEpr7nSUx1/bW7Hs59urrBjuGx27V3a5fc/JZqEFS3gIJMVa0yGYYb2R9Ho4XzS\n\txtuL/oezpo2CPn2dRYSFr86ZH91WvnP52goVpaPXWbnt7rXROJTDDPw2NgeC430Ve31X\n\tS3eZ048XueQJOjgy+HZJFeIH7PT6pDImc7OWkdQmHW8sKZGLOuasQyPq04S0gxNk1px/\n\tvHkQ==",
        "X-Gm-Message-State": "APf1xPAdLU2LpIevHFzow8+i27mCZX9IMrVfZEZOZKwobfFcWxlzxbBC\n\tNuj+0xpqZYB3Nu48BXqAUdtsQ2WydCc=",
        "X-Google-Smtp-Source": "AH8x226wLCz/sGaar0CBO+g1kd+53SsaTNvtB02iXzyk3Vhal2HBDIqlEtyP0AlMD2juYMjCpLanww==",
        "X-Received": "by 10.99.146.3 with SMTP id o3mr2426318pgd.309.1519420683937;\n\tFri, 23 Feb 2018 13:18:03 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Fri, 23 Feb 2018 13:17:50 -0800",
        "Message-Id": "<20180223211752.28651-2-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.16.1",
        "In-Reply-To": "<20180223211752.28651-1-stephen@networkplumber.org>",
        "References": "<20180223205648.18690-1-stephen@networkplumber.org>\n\t<20180223211752.28651-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH v2 1/3] eal: allow symbolic log levels",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Much easeier to remember names than numbers. Allows\n\t--log-level=pmd.net.ixgbe.*,debug\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/common/eal_common_options.c | 66 ++++++++++++++++++++++--------\n 1 file changed, 50 insertions(+), 16 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex 9f2f8d25afd9..19069638ea05 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -911,10 +911,52 @@ eal_parse_syslog(const char *facility, struct internal_config *conf)\n }\n \n static int\n-eal_parse_log_level(const char *arg)\n+eal_parse_log_priority(const char *level)\n {\n-\tchar *end, *str, *type, *level;\n+\tstatic const char *levels[] = {\n+\t\t[RTE_LOG_EMERG]   = \"emergency\",\n+\t\t[RTE_LOG_ALERT]   = \"alert\",\n+\t\t[RTE_LOG_CRIT]    = \"critical\",\n+\t\t[RTE_LOG_ERR]     = \"error\",\n+\t\t[RTE_LOG_WARNING] = \"warning\",\n+\t\t[RTE_LOG_NOTICE]  = \"notice\",\n+\t\t[RTE_LOG_INFO]    = \"info\",\n+\t\t[RTE_LOG_DEBUG]   = \"debug\",\n+\t};\n+\tsize_t len = strlen(level);\n \tunsigned long tmp;\n+\tchar *end;\n+\tunsigned int i;\n+\n+\tif (len == 0)\n+\t\treturn -1;\n+\n+\t/* look for named values, skip 0 which is not a valid level */\n+\tfor (i = 1; i < sizeof(levels) / sizeof(levels[0]); i++) {\n+\t\tif (strncmp(levels[i], level, len) == 0)\n+\t\t\treturn i;\n+\t}\n+\n+\t/* not a string, maybe it is numeric */\n+\terrno = 0;\n+\ttmp = strtoul(level, &end, 0);\n+\n+\t/* check for errors */\n+\tif (errno != 0 || end == NULL || *end != '\\0')\n+\t\treturn -1;\n+\n+\t/* log_level is a uint32_t */\n+\tif (tmp >= UINT32_MAX)\n+\t\treturn -1;\n+\n+\treturn tmp;\n+}\n+\n+static int\n+eal_parse_log_level(const char *arg)\n+{\n+\tchar *str, *type, *level;\n+\tint priority;\n \n \tstr = strdup(arg);\n \tif (str == NULL)\n@@ -928,23 +970,15 @@ eal_parse_log_level(const char *arg)\n \t\tlevel = strsep(&str, \",\");\n \t}\n \n-\terrno = 0;\n-\ttmp = strtoul(level, &end, 0);\n-\n-\t/* check for errors */\n-\tif ((errno != 0) || (level[0] == '\\0') ||\n-\t\t    end == NULL || (*end != '\\0'))\n-\t\tgoto fail;\n-\n-\t/* log_level is a uint32_t */\n-\tif (tmp >= UINT32_MAX)\n+\tpriority = eal_parse_log_priority(level);\n+\tif (priority < 0)\n \t\tgoto fail;\n \n \tif (type == NULL) {\n-\t\trte_log_set_global_level(tmp);\n-\t} else if (rte_log_set_level_regexp(type, tmp) < 0) {\n-\t\tprintf(\"cannot set log level %s,%lu\\n\",\n-\t\t\ttype, tmp);\n+\t\trte_log_set_global_level(priority);\n+\t} else if (rte_log_set_level_regexp(type, priority) < 0) {\n+\t\tfprintf(stderr, \"cannot set log level %s,%d\\n\",\n+\t\t\ttype, priority);\n \t\tgoto fail;\n \t}\n \n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "1/3"
    ]
}