Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3499/?format=api
{ "id": 3499, "url": "https://patches.dpdk.org/api/patches/3499/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1424361289-30718-4-git-send-email-pawelx.wodkowski@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1424361289-30718-4-git-send-email-pawelx.wodkowski@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1424361289-30718-4-git-send-email-pawelx.wodkowski@intel.com", "date": "2015-02-19T15:54:45", "name": "[dpdk-dev,v4,3/7] pmd: igb/ixgbe split nb_q_per_pool to rx and tx nb_q_per_pool", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1eca1f58442b1576903dd9ff1edfab6a3c0ac8cc", "submitter": { "id": 58, "url": "https://patches.dpdk.org/api/people/58/?format=api", "name": "Wodkowski, PawelX", "email": "pawelx.wodkowski@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1424361289-30718-4-git-send-email-pawelx.wodkowski@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/3499/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/3499/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E79EDB673;\n\tThu, 19 Feb 2015 17:08:05 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id B08B4B661\n\tfor <dev@dpdk.org>; Thu, 19 Feb 2015 17:08:03 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 19 Feb 2015 08:03:11 -0800", "from unknown (HELO Sent) ([10.217.248.233])\n\tby orsmga001.jf.intel.com with SMTP; 19 Feb 2015 08:07:13 -0800", "by Sent (sSMTP sendmail emulation); Thu, 19 Feb 2015 17:03:50 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,609,1418112000\"; d=\"scan'208\";a=\"654407817\"", "From": "Pawel Wodkowski <pawelx.wodkowski@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 19 Feb 2015 16:54:45 +0100", "Message-Id": "<1424361289-30718-4-git-send-email-pawelx.wodkowski@intel.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1424361289-30718-1-git-send-email-pawelx.wodkowski@intel.com>", "References": "<1421672551-11652-1-git-send-email-pawelx.wodkowski@intel.com>\n\t<1424361289-30718-1-git-send-email-pawelx.wodkowski@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 3/7] pmd: igb/ixgbe split nb_q_per_pool to rx\n\tand tx nb_q_per_pool", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rx and tx number of queue might be different if RX and TX are\nconfigured in different mode. This allow to inform VF about\nproper number of queues.\n\nSigned-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>\n---\n lib/librte_ether/rte_ethdev.c | 12 ++++++------\n lib/librte_ether/rte_ethdev.h | 3 ++-\n lib/librte_pmd_e1000/igb_pf.c | 3 ++-\n lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 2 +-\n lib/librte_pmd_ixgbe/ixgbe_pf.c | 9 +++++----\n 5 files changed, 16 insertions(+), 13 deletions(-)", "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 2e814db..4007054 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -520,7 +520,7 @@ rte_eth_dev_check_vf_rss_rxq_num(uint8_t port_id, uint16_t nb_rx_q)\n \t\treturn -EINVAL;\n \t}\n \n-\tRTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = nb_rx_q;\n+\tRTE_ETH_DEV_SRIOV(dev).nb_rx_q_per_pool = nb_rx_q;\n \tRTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =\n \t\tdev->pci_dev->max_vfs * nb_rx_q;\n \n@@ -567,7 +567,7 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\t\t\t\tdev->data->dev_conf.rxmode.mq_mode);\n \t\tcase ETH_MQ_RX_VMDQ_RSS:\n \t\t\tdev->data->dev_conf.rxmode.mq_mode = ETH_MQ_RX_VMDQ_RSS;\n-\t\t\tif (nb_rx_q <= RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool)\n+\t\t\tif (nb_rx_q <= RTE_ETH_DEV_SRIOV(dev).nb_rx_q_per_pool)\n \t\t\t\tif (rte_eth_dev_check_vf_rss_rxq_num(port_id, nb_rx_q) != 0) {\n \t\t\t\t\tPMD_DEBUG_TRACE(\"ethdev port_id=%d\"\n \t\t\t\t\t\t\" SRIOV active, invalid queue\"\n@@ -580,8 +580,8 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\tdefault: /* ETH_MQ_RX_VMDQ_ONLY or ETH_MQ_RX_NONE */\n \t\t\t/* if nothing mq mode configure, use default scheme */\n \t\t\tdev->data->dev_conf.rxmode.mq_mode = ETH_MQ_RX_VMDQ_ONLY;\n-\t\t\tif (RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool > 1)\n-\t\t\t\tRTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = 1;\n+\t\t\tif (RTE_ETH_DEV_SRIOV(dev).nb_rx_q_per_pool > 1)\n+\t\t\t\tRTE_ETH_DEV_SRIOV(dev).nb_rx_q_per_pool = 1;\n \t\t\tbreak;\n \t\t}\n \n@@ -600,8 +600,8 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\t}\n \n \t\t/* check valid queue number */\n-\t\tif ((nb_rx_q > RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool) ||\n-\t\t (nb_tx_q > RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool)) {\n+\t\tif ((nb_rx_q > RTE_ETH_DEV_SRIOV(dev).nb_tx_q_per_pool) ||\n+\t\t (nb_tx_q > RTE_ETH_DEV_SRIOV(dev).nb_tx_q_per_pool)) {\n \t\t\tPMD_DEBUG_TRACE(\"ethdev port_id=%d SRIOV active, \"\n \t\t\t\t \"queue number must less equal to %d\\n\",\n \t\t\t\t\tport_id, RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool);\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex 84160c3..af86401 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -1544,7 +1544,8 @@ struct rte_eth_dev {\n \n struct rte_eth_dev_sriov {\n \tuint8_t active; /**< SRIOV is active with 16, 32 or 64 pools */\n-\tuint8_t nb_q_per_pool; /**< rx queue number per pool */\n+\tuint8_t nb_rx_q_per_pool; /**< rx queue number per pool */\n+\tuint8_t nb_tx_q_per_pool; /**< tx queue number per pool */\n \tuint16_t def_vmdq_idx; /**< Default pool num used for PF */\n \tuint16_t def_pool_q_idx; /**< Default pool queue start reg index */\n };\ndiff --git a/lib/librte_pmd_e1000/igb_pf.c b/lib/librte_pmd_e1000/igb_pf.c\nindex bc3816a..9d2f858 100644\n--- a/lib/librte_pmd_e1000/igb_pf.c\n+++ b/lib/librte_pmd_e1000/igb_pf.c\n@@ -115,7 +115,8 @@ void igb_pf_host_init(struct rte_eth_dev *eth_dev)\n \t\trte_panic(\"Cannot allocate memory for private VF data\\n\");\n \n \tRTE_ETH_DEV_SRIOV(eth_dev).active = ETH_8_POOLS;\n-\tRTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool = nb_queue;\n+\tRTE_ETH_DEV_SRIOV(eth_dev).nb_rx_q_per_pool = nb_queue;\n+\tRTE_ETH_DEV_SRIOV(eth_dev).nb_tx_q_per_pool = nb_queue;\n \tRTE_ETH_DEV_SRIOV(eth_dev).def_vmdq_idx = vf_num;\n \tRTE_ETH_DEV_SRIOV(eth_dev).def_pool_q_idx = (uint16_t)(vf_num * nb_queue);\n \ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\nindex d6d408e..02b9cda 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\n@@ -3564,7 +3564,7 @@ static int ixgbe_set_vf_rate_limit(struct rte_eth_dev *dev, uint16_t vf,\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct ixgbe_vf_info *vfinfo =\n \t\t*(IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private));\n-\tuint8_t nb_q_per_pool = RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;\n+\tuint8_t nb_q_per_pool = RTE_ETH_DEV_SRIOV(dev).nb_tx_q_per_pool;\n \tuint32_t queue_stride =\n \t\tIXGBE_MAX_RX_QUEUE_NUM / RTE_ETH_DEV_SRIOV(dev).active;\n \tuint32_t queue_idx = vf * queue_stride, idx = 0, vf_idx;\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c\nindex dbda9b5..4103e97 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_pf.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c\n@@ -129,7 +129,8 @@ void ixgbe_pf_host_init(struct rte_eth_dev *eth_dev)\n \t\tRTE_ETH_DEV_SRIOV(eth_dev).active = ETH_16_POOLS;\n \t}\n \n-\tRTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool = nb_queue;\n+\tRTE_ETH_DEV_SRIOV(eth_dev).nb_rx_q_per_pool = nb_queue;\n+\tRTE_ETH_DEV_SRIOV(eth_dev).nb_tx_q_per_pool = nb_queue;\n \tRTE_ETH_DEV_SRIOV(eth_dev).def_vmdq_idx = vf_num;\n \tRTE_ETH_DEV_SRIOV(eth_dev).def_pool_q_idx = (uint16_t)(vf_num * nb_queue);\n \n@@ -497,7 +498,7 @@ ixgbe_get_vf_queues(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)\n {\n \tstruct ixgbe_vf_info *vfinfo =\n \t\t*IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private);\n-\tuint32_t default_q = vf * RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;\n+\tuint32_t default_q = vf * RTE_ETH_DEV_SRIOV(dev).nb_tx_q_per_pool;\n \n \t/* Verify if the PF supports the mbox APIs version or not */\n \tswitch (vfinfo[vf].api_version) {\n@@ -509,8 +510,8 @@ ixgbe_get_vf_queues(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)\n \t}\n \n \t/* Notify VF of Rx and Tx queue number */\n-\tmsgbuf[IXGBE_VF_RX_QUEUES] = RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;\n-\tmsgbuf[IXGBE_VF_TX_QUEUES] = RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;\n+\tmsgbuf[IXGBE_VF_RX_QUEUES] = RTE_ETH_DEV_SRIOV(dev).nb_rx_q_per_pool;\n+\tmsgbuf[IXGBE_VF_TX_QUEUES] = RTE_ETH_DEV_SRIOV(dev).nb_tx_q_per_pool;\n \n \t/* Notify VF of default queue */\n \tmsgbuf[IXGBE_VF_DEF_QUEUE] = default_q;\n", "prefixes": [ "dpdk-dev", "v4", "3/7" ] }