Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 34667,
    "url": "https://patches.dpdk.org/api/patches/34667/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1517243852-34142-3-git-send-email-harry.van.haaren@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1517243852-34142-3-git-send-email-harry.van.haaren@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1517243852-34142-3-git-send-email-harry.van.haaren@intel.com",
    "date": "2018-01-29T16:37:31",
    "name": "[dpdk-dev,v5,3/4] app/pdump: call eal cleanup before exit",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a63147bad48ea0e6e354a5a1f2ecaa0717b3f73c",
    "submitter": {
        "id": 317,
        "url": "https://patches.dpdk.org/api/people/317/?format=api",
        "name": "Van Haaren, Harry",
        "email": "harry.van.haaren@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1517243852-34142-3-git-send-email-harry.van.haaren@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/34667/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/34667/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3778A1BA2A;\n\tMon, 29 Jan 2018 17:37:44 +0100 (CET)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id AA1B51B824\n\tfor <dev@dpdk.org>; Mon, 29 Jan 2018 17:37:39 +0100 (CET)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Jan 2018 08:37:38 -0800",
            "from silpixa00398672.ir.intel.com ([10.237.223.111])\n\tby fmsmga002.fm.intel.com with ESMTP; 29 Jan 2018 08:37:37 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.46,431,1511856000\"; d=\"scan'208\";a=\"15245395\"",
        "From": "Harry van Haaren <harry.van.haaren@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Harry van Haaren <harry.van.haaren@intel.com>, thomas@monjalon.net,\n\tvipin.varghese@intel.com",
        "Date": "Mon, 29 Jan 2018 16:37:31 +0000",
        "Message-Id": "<1517243852-34142-3-git-send-email-harry.van.haaren@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1517243852-34142-1-git-send-email-harry.van.haaren@intel.com>",
        "References": "<1517241642-161397-1-git-send-email-harry.van.haaren@intel.com>\n\t<1517243852-34142-1-git-send-email-harry.van.haaren@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v5 3/4] app/pdump: call eal cleanup before exit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch adds a call to the newly introduced cleanup()\nfunction just before quitting the pdump app.\n\nAdding this function call before quitting from a secondary processes\nis important, as otherwise it will leak hugepage memory. For a secondary\nprocess that is run multiple times, this could cause hugepage memory\nto become depleted and stop a secondary process from starting.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\nAcked-by: Vipin Varghese <vipin.varghese@intel.com>\n\n---\n\nv4:\n- Include Ack\n\nv3:\n- Rework to new cleanup() function name (Thomas)\n\nCc: thomas@monjalon.net\nCc: vipin.varghese@intel.com\n---\n app/pdump/main.c | 5 +++++\n 1 file changed, 5 insertions(+)",
    "diff": "diff --git a/app/pdump/main.c b/app/pdump/main.c\nindex 0f70c75..50772cb 100644\n--- a/app/pdump/main.c\n+++ b/app/pdump/main.c\n@@ -882,5 +882,10 @@ main(int argc, char **argv)\n \t/* dump debug stats */\n \tprint_pdump_stats();\n \n+\tret = rte_eal_cleanup();\n+\tif (ret)\n+\t\tprintf(\"Error from rte_eal_cleanup(), %d\\n\", ret);\n+\n+\n \treturn 0;\n }\n",
    "prefixes": [
        "dpdk-dev",
        "v5",
        "3/4"
    ]
}