Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34525/?format=api
{ "id": 34525, "url": "https://patches.dpdk.org/api/patches/34525/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180126020151.979-9-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180126020151.979-9-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20180126020151.979-9-stephen@networkplumber.org", "date": "2018-01-26T02:01:44", "name": "[dpdk-dev,v8,08/15] net/ixgbe: use rte_eth_linkstatus functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ae4dbe742313efab7c05dc0598c048a14f73dba1", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180126020151.979-9-stephen@networkplumber.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/34525/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/34525/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4603F1B2CA;\n\tFri, 26 Jan 2018 03:02:15 +0100 (CET)", "from mail-pf0-f194.google.com (mail-pf0-f194.google.com\n\t[209.85.192.194]) by dpdk.org (Postfix) with ESMTP id 142611B29E\n\tfor <dev@dpdk.org>; Fri, 26 Jan 2018 03:02:03 +0100 (CET)", "by mail-pf0-f194.google.com with SMTP id m26so7197112pfj.11\n\tfor <dev@dpdk.org>; Thu, 25 Jan 2018 18:02:03 -0800 (PST)", "from xeon-e3.lan (204-195-18-133.wavecable.com. [204.195.18.133])\n\tby smtp.gmail.com with ESMTPSA id\n\td5sm22141492pfk.2.2018.01.25.18.02.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 25 Jan 2018 18:02:01 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=8Zsy2ammgZwa4MrDkKB8GF/HzW/zBW176tnrjV7zyjw=;\n\tb=bsy0C2MbMVYhRfW0iHfCCtvkt8LhO3S6dg8T2IPeXu6AXz22j6J0J46DPfL0u6Zyi4\n\t/O/ck0/D+b6bb+b5Aiwdh0ElZiJ6rrBVOP7CaIZkoRZlOMJ6S4TPywsb1BDv2Q9SDOF7\n\tGcrKXtlw3Z4o+QeNFeI5Ov40RCKPE8aX38NVVcFSycsz+aJuEMctVRHC6UcRxfFzLfze\n\tnpUlQi2DkBpU9aKqHgMP0IcN1WX8hPAypqn05HXj6LNvtp+c7YY+cghAsWMdlz5iOzOE\n\t6+GWUlzaySX81ROPGFaAUvmL0Jvh4t7CO4pafOyD0oBh/YtEASBvBjdxZ5LHtldZHMPs\n\t/Rfw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=8Zsy2ammgZwa4MrDkKB8GF/HzW/zBW176tnrjV7zyjw=;\n\tb=TZ3ANXvlL198jEbDlQLHnYayybalPm+I+rMzWKm2HBrPl4ApZlzNnoua7ghRmEMvKQ\n\tFwsWxnLEDoMI693nC8XwDqLfUtbYnEu4T1IBiWiSc2z4prKEtmIhAgS9PfUUv4E5bl/F\n\tDKoaWxUAweutiUJZoVv5Bac5nUsjDDaoOMSj0k5coMXHtF8TxPaBLejk9+rBmHeNqzMq\n\txkcCE7HBT4/+96Z++H5i5wPuHf4/NO9mGUiSQf3fBIK0EBcNsiJLwlOLDEjHUG3Gb0xx\n\t4yIYKEkiVDZyvrzrVYo1TnugaoJteC5ICB0OZXVusADtSKbZQ/I8oTW5L6C2Hsc1PhUd\n\tc3cg==", "X-Gm-Message-State": "AKwxytdWkpXCFRJVhtH7NLveA5lABNDJivzrteVTEIm4CbUWzhR+u/wH\n\tFxWwGYepFlTHRDclMvEP8d6SbKdSp9c=", "X-Google-Smtp-Source": "AH8x2256/Czd4i508XlualzkIpHdifr2wI5x9/P70etfLEJXt8vggEVtMAtwC9+v5U+rsQJSs/LjGg==", "X-Received": "by 2002:a17:902:b70e:: with SMTP id\n\td14-v6mr13316830pls.224.1516932121722; \n\tThu, 25 Jan 2018 18:02:01 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 25 Jan 2018 18:01:44 -0800", "Message-Id": "<20180126020151.979-9-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.15.1", "In-Reply-To": "<20180126020151.979-1-stephen@networkplumber.org>", "References": "<20180126020151.979-1-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH v8 08/15] net/ixgbe: use rte_eth_linkstatus\n\tfunctions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use the new helper functions from eth_dev for\nhandling atomic link_info update.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 90 ++++++----------------------------------\n 1 file changed, 13 insertions(+), 77 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 58217680c29c..231a29185e08 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -20,7 +20,6 @@\n #include <rte_debug.h>\n #include <rte_pci.h>\n #include <rte_bus_pci.h>\n-#include <rte_atomic.h>\n #include <rte_branch_prediction.h>\n #include <rte_memory.h>\n #include <rte_eal.h>\n@@ -787,58 +786,6 @@ static const struct rte_ixgbe_xstats_name_off rte_ixgbevf_stats_strings[] = {\n #define IXGBEVF_NB_XSTATS (sizeof(rte_ixgbevf_stats_strings) /\t\\\n \t\tsizeof(rte_ixgbevf_stats_strings[0]))\n \n-/**\n- * Atomically reads the link status information from global\n- * structure rte_eth_dev.\n- *\n- * @param dev\n- * - Pointer to the structure rte_eth_dev to read from.\n- * - Pointer to the buffer to be saved with the link status.\n- *\n- * @return\n- * - On success, zero.\n- * - On failure, negative value.\n- */\n-static inline int\n-rte_ixgbe_dev_atomic_read_link_status(struct rte_eth_dev *dev,\n-\t\t\t\tstruct rte_eth_link *link)\n-{\n-\tstruct rte_eth_link *dst = link;\n-\tstruct rte_eth_link *src = &(dev->data->dev_link);\n-\n-\tif (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,\n-\t\t\t\t\t*(uint64_t *)src) == 0)\n-\t\treturn -1;\n-\n-\treturn 0;\n-}\n-\n-/**\n- * Atomically writes the link status information into global\n- * structure rte_eth_dev.\n- *\n- * @param dev\n- * - Pointer to the structure rte_eth_dev to read from.\n- * - Pointer to the buffer to be saved with the link status.\n- *\n- * @return\n- * - On success, zero.\n- * - On failure, negative value.\n- */\n-static inline int\n-rte_ixgbe_dev_atomic_write_link_status(struct rte_eth_dev *dev,\n-\t\t\t\tstruct rte_eth_link *link)\n-{\n-\tstruct rte_eth_link *dst = &(dev->data->dev_link);\n-\tstruct rte_eth_link *src = link;\n-\n-\tif (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,\n-\t\t\t\t\t*(uint64_t *)src) == 0)\n-\t\treturn -1;\n-\n-\treturn 0;\n-}\n-\n /*\n * This function is the same as ixgbe_is_sfp() in base/ixgbe.h.\n */\n@@ -2758,7 +2705,7 @@ ixgbe_dev_stop(struct rte_eth_dev *dev)\n \n \t/* Clear recorded link status */\n \tmemset(&link, 0, sizeof(link));\n-\trte_ixgbe_dev_atomic_write_link_status(dev, &link);\n+\trte_eth_linkstatus_set(dev, &link);\n \n \tif (!rte_intr_allow_others(intr_handle))\n \t\t/* resume to the default handler */\n@@ -3943,7 +3890,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \t\t\t int wait_to_complete, int vf)\n {\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct rte_eth_link link, old;\n+\tstruct rte_eth_link link;\n \tixgbe_link_speed link_speed = IXGBE_LINK_SPEED_UNKNOWN;\n \tstruct ixgbe_interrupt *intr =\n \t\tIXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private);\n@@ -3953,12 +3900,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \tint wait = 1;\n \tbool autoneg = false;\n \n+\tmemset(&link, 0, sizeof(link));\n \tlink.link_status = ETH_LINK_DOWN;\n \tlink.link_speed = 0;\n \tlink.link_duplex = ETH_LINK_HALF_DUPLEX;\n \tlink.link_autoneg = ETH_LINK_AUTONEG;\n-\tmemset(&old, 0, sizeof(old));\n-\trte_ixgbe_dev_atomic_read_link_status(dev, &old);\n \n \thw->mac.get_link_status = true;\n \n@@ -3982,19 +3928,14 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \tif (diag != 0) {\n \t\tlink.link_speed = ETH_SPEED_NUM_100M;\n \t\tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n-\t\trte_ixgbe_dev_atomic_write_link_status(dev, &link);\n-\t\tif (link.link_status == old.link_status)\n-\t\t\treturn -1;\n-\t\treturn 0;\n+\t\treturn rte_eth_linkstatus_set(dev, &link);\n \t}\n \n \tif (link_up == 0) {\n-\t\trte_ixgbe_dev_atomic_write_link_status(dev, &link);\n \t\tintr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;\n-\t\tif (link.link_status == old.link_status)\n-\t\t\treturn -1;\n-\t\treturn 0;\n+\t\treturn rte_eth_linkstatus_set(dev, &link);\n \t}\n+\n \tintr->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG;\n \tlink.link_status = ETH_LINK_UP;\n \tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n@@ -4026,12 +3967,8 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \t\tlink.link_speed = ETH_SPEED_NUM_10G;\n \t\tbreak;\n \t}\n-\trte_ixgbe_dev_atomic_write_link_status(dev, &link);\n \n-\tif (link.link_status == old.link_status)\n-\t\treturn -1;\n-\n-\treturn 0;\n+\treturn rte_eth_linkstatus_set(dev, &link);\n }\n \n static int\n@@ -4230,8 +4167,8 @@ ixgbe_dev_link_status_print(struct rte_eth_dev *dev)\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n \tstruct rte_eth_link link;\n \n-\tmemset(&link, 0, sizeof(link));\n-\trte_ixgbe_dev_atomic_read_link_status(dev, &link);\n+\trte_eth_linkstatus_get(dev, &link);\n+\n \tif (link.link_status) {\n \t\tPMD_INIT_LOG(INFO, \"Port %d: Link Up - speed %u Mbps - %s\",\n \t\t\t\t\t(int)(dev->data->port_id),\n@@ -4266,7 +4203,6 @@ ixgbe_dev_interrupt_action(struct rte_eth_dev *dev,\n \tstruct ixgbe_interrupt *intr =\n \t\tIXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private);\n \tint64_t timeout;\n-\tstruct rte_eth_link link;\n \tstruct ixgbe_hw *hw =\n \t\tIXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n@@ -4283,9 +4219,10 @@ ixgbe_dev_interrupt_action(struct rte_eth_dev *dev,\n \t}\n \n \tif (intr->flags & IXGBE_FLAG_NEED_LINK_UPDATE) {\n+\t\tstruct rte_eth_link link;\n+\n \t\t/* get the link status before link update, for predicting later */\n-\t\tmemset(&link, 0, sizeof(link));\n-\t\trte_ixgbe_dev_atomic_read_link_status(dev, &link);\n+\t\trte_eth_linkstatus_get(dev, &link);\n \n \t\tixgbe_dev_link_update(dev, 0);\n \n@@ -6804,9 +6741,8 @@ ixgbe_start_timecounters(struct rte_eth_dev *dev)\n \tuint32_t shift = 0;\n \n \t/* Get current link speed. */\n-\tmemset(&link, 0, sizeof(link));\n \tixgbe_dev_link_update(dev, 1);\n-\trte_ixgbe_dev_atomic_read_link_status(dev, &link);\n+\trte_eth_linkstatus_get(dev, &link);\n \n \tswitch (link.link_speed) {\n \tcase ETH_SPEED_NUM_100M:\n", "prefixes": [ "dpdk-dev", "v8", "08/15" ] }