Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 3412,
    "url": "https://patches.dpdk.org/api/patches/3412/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1424156374-21768-11-git-send-email-helin.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1424156374-21768-11-git-send-email-helin.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1424156374-21768-11-git-send-email-helin.zhang@intel.com",
    "date": "2015-02-17T06:59:28",
    "name": "[dpdk-dev,v3,10/16] app/testpmd: support of unified packet type",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "970225aa5266831c9dffe948acc829f9253d2d30",
    "submitter": {
        "id": 14,
        "url": "https://patches.dpdk.org/api/people/14/?format=api",
        "name": "Zhang, Helin",
        "email": "helin.zhang@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1424156374-21768-11-git-send-email-helin.zhang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/3412/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/3412/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id DA8BFB6B8;\n\tTue, 17 Feb 2015 08:00:06 +0100 (CET)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 41201B6B8\n\tfor <dev@dpdk.org>; Tue, 17 Feb 2015 08:00:05 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 16 Feb 2015 22:56:03 -0800",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 16 Feb 2015 23:00:03 -0800",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t1H700Bg014837;\n\tTue, 17 Feb 2015 15:00:00 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t1H6xvJZ021872; Tue, 17 Feb 2015 14:59:59 +0800",
            "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t1H6xvmu021868; \n\tTue, 17 Feb 2015 14:59:57 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.09,593,1418112000\"; d=\"scan'208\";a=\"653104582\"",
        "From": "Helin Zhang <helin.zhang@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue, 17 Feb 2015 14:59:28 +0800",
        "Message-Id": "<1424156374-21768-11-git-send-email-helin.zhang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1424156374-21768-1-git-send-email-helin.zhang@intel.com>",
        "References": "<1422501365-12643-1-git-send-email-helin.zhang@intel.com>\n\t<1424156374-21768-1-git-send-email-helin.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3 10/16] app/testpmd: support of unified packet\n\ttype",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "To unify packet types among all PMDs, bit masks of packet type for\n'ol_flags' are replaced by unified packet type.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\nSigned-off-by: Jijiang Liu <jijiang.liu@intel.com>\n---\n app/test-pmd/csumonly.c | 10 +++++-----\n app/test-pmd/rxonly.c   |  9 +++------\n 2 files changed, 8 insertions(+), 11 deletions(-)\n\nv2 changes:\n* Used redefined packet types and enlarged packet_type field in mbuf.",
    "diff": "diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c\nindex 0a7af79..ad877c2 100644\n--- a/app/test-pmd/csumonly.c\n+++ b/app/test-pmd/csumonly.c\n@@ -199,8 +199,9 @@ parse_ethernet(struct ether_hdr *eth_hdr, struct testpmd_offload_info *info)\n \n /* Parse a vxlan header */\n static void\n-parse_vxlan(struct udp_hdr *udp_hdr, struct testpmd_offload_info *info,\n-\tuint64_t mbuf_olflags)\n+parse_vxlan(struct udp_hdr *udp_hdr,\n+\t    struct testpmd_offload_info *info,\n+\t    uint32_t pkt_type)\n {\n \tstruct ether_hdr *eth_hdr;\n \n@@ -208,8 +209,7 @@ parse_vxlan(struct udp_hdr *udp_hdr, struct testpmd_offload_info *info,\n \t * (rfc7348) or that the rx offload flag is set (i40e only\n \t * currently) */\n \tif (udp_hdr->dst_port != _htons(4789) &&\n-\t\t(mbuf_olflags & (PKT_RX_TUNNEL_IPV4_HDR |\n-\t\t\tPKT_RX_TUNNEL_IPV6_HDR)) == 0)\n+\t\tRTE_ETH_IS_TUNNEL_PKT(pkt_type) == 0)\n \t\treturn;\n \n \tinfo->is_tunnel = 1;\n@@ -543,7 +543,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)\n \t\t\t\tstruct udp_hdr *udp_hdr;\n \t\t\t\tudp_hdr = (struct udp_hdr *)((char *)l3_hdr +\n \t\t\t\t\tinfo.l3_len);\n-\t\t\t\tparse_vxlan(udp_hdr, &info, m->ol_flags);\n+\t\t\t\tparse_vxlan(udp_hdr, &info, m->packet_type);\n \t\t\t} else if (info.l4_proto == IPPROTO_GRE) {\n \t\t\t\tstruct simple_gre_hdr *gre_hdr;\n \t\t\t\tgre_hdr = (struct simple_gre_hdr *)\ndiff --git a/app/test-pmd/rxonly.c b/app/test-pmd/rxonly.c\nindex fdfe990..8eb68c4 100644\n--- a/app/test-pmd/rxonly.c\n+++ b/app/test-pmd/rxonly.c\n@@ -92,7 +92,7 @@ pkt_burst_receive(struct fwd_stream *fs)\n \tuint64_t ol_flags;\n \tuint16_t nb_rx;\n \tuint16_t i, packet_type;\n-\tuint64_t is_encapsulation;\n+\tuint16_t is_encapsulation;\n \n #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES\n \tuint64_t start_tsc;\n@@ -135,10 +135,7 @@ pkt_burst_receive(struct fwd_stream *fs)\n \t\teth_type = RTE_BE_TO_CPU_16(eth_hdr->ether_type);\n \t\tol_flags = mb->ol_flags;\n \t\tpacket_type = mb->packet_type;\n-\n-\t\tis_encapsulation = ol_flags & (PKT_RX_TUNNEL_IPV4_HDR |\n-\t\t\t\tPKT_RX_TUNNEL_IPV6_HDR);\n-\n+\t\tis_encapsulation = RTE_ETH_IS_TUNNEL_PKT(packet_type);\n \t\tprint_ether_addr(\"  src=\", &eth_hdr->s_addr);\n \t\tprint_ether_addr(\" - dst=\", &eth_hdr->d_addr);\n \t\tprintf(\" - type=0x%04x - length=%u - nb_segs=%d\",\n@@ -174,7 +171,7 @@ pkt_burst_receive(struct fwd_stream *fs)\n \t\t\tl2_len  = sizeof(struct ether_hdr);\n \n \t\t\t /* Do not support ipv4 option field */\n-\t\t\tif (ol_flags & PKT_RX_TUNNEL_IPV4_HDR) {\n+\t\t\tif (RTE_ETH_IS_IPV4_HDR(packet_type)) {\n \t\t\t\tl3_len = sizeof(struct ipv4_hdr);\n \t\t\t\tipv4_hdr = (struct ipv4_hdr *) (rte_pktmbuf_mtod(mb,\n \t\t\t\t\t\tunsigned char *) + l2_len);\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "10/16"
    ]
}