Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/33991/?format=api
{ "id": 33991, "url": "https://patches.dpdk.org/api/patches/33991/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1516268671-29894-3-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1516268671-29894-3-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1516268671-29894-3-git-send-email-arybchenko@solarflare.com", "date": "2018-01-18T09:44:27", "name": "[dpdk-dev,v4,2/6] ethdev: add a function to look up Tx offload names", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3bf242809d29691f6516efe233749e55a9582b5d", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1516268671-29894-3-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/33991/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/33991/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1E28B1B2C9;\n\tThu, 18 Jan 2018 10:45:00 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 4F6C81B2A3\n\tfor <dev@dpdk.org>; Thu, 18 Jan 2018 10:44:46 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 5C0BEB0005C; Thu, 18 Jan 2018 09:44:45 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Thu, 18 Jan 2018 01:44:39 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Thu, 18 Jan 2018 01:44:39 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw0I9iekk023641; Thu, 18 Jan 2018 09:44:40 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw0I9ieqC029942; Thu, 18 Jan 2018 09:44:40 GMT" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ivan Malov <ivan.malov@oktetlabs.ru>, Thomas Monjalon\n\t<thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>,\n\tShahaf Shuler <shahafs@mellanox.com>", "Date": "Thu, 18 Jan 2018 09:44:27 +0000", "Message-ID": "<1516268671-29894-3-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1516268671-29894-1-git-send-email-arybchenko@solarflare.com>", "References": "<1515658359-1041-1-git-send-email-arybchenko@solarflare.com>\n\t<1516268671-29894-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MDID": "1516268685-qgsSsjhUTDdS", "Subject": "[dpdk-dev] [PATCH v4 2/6] ethdev: add a function to look up Tx\n\toffload names", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nCommonly, drivers converted to the new offload API\nmay need to log unsupported offloads as a response\nto wrong settings. From this perspective, it would\nbe convenient to have generic functions to look up\noffload names. The patch adds such a helper for Tx.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>\n\nCc: Thomas Monjalon <thomas@monjalon.net>\nCc: Ferruh Yigit <ferruh.yigit@intel.com>\nCc: Shahaf Shuler <shahafs@mellanox.com>\n---\n lib/librte_ether/rte_ethdev.c | 45 +++++++++++++++++++++++++++++++++\n lib/librte_ether/rte_ethdev.h | 18 +++++++++++++\n lib/librte_ether/rte_ethdev_version.map | 1 +\n 3 files changed, 64 insertions(+)", "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 9e9ef83..cd4a3ed 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -116,6 +116,35 @@ static const struct {\n \n #undef RTE_RX_OFFLOAD_BIT2STR\n \n+#define RTE_TX_OFFLOAD_BIT2STR(_name)\t\\\n+\t{ DEV_TX_OFFLOAD_##_name, #_name }\n+\n+static const struct {\n+\tuint64_t offload;\n+\tconst char *name;\n+} rte_tx_offload_names[] = {\n+\tRTE_TX_OFFLOAD_BIT2STR(VLAN_INSERT),\n+\tRTE_TX_OFFLOAD_BIT2STR(IPV4_CKSUM),\n+\tRTE_TX_OFFLOAD_BIT2STR(UDP_CKSUM),\n+\tRTE_TX_OFFLOAD_BIT2STR(TCP_CKSUM),\n+\tRTE_TX_OFFLOAD_BIT2STR(SCTP_CKSUM),\n+\tRTE_TX_OFFLOAD_BIT2STR(TCP_TSO),\n+\tRTE_TX_OFFLOAD_BIT2STR(UDP_TSO),\n+\tRTE_TX_OFFLOAD_BIT2STR(OUTER_IPV4_CKSUM),\n+\tRTE_TX_OFFLOAD_BIT2STR(QINQ_INSERT),\n+\tRTE_TX_OFFLOAD_BIT2STR(VXLAN_TNL_TSO),\n+\tRTE_TX_OFFLOAD_BIT2STR(GRE_TNL_TSO),\n+\tRTE_TX_OFFLOAD_BIT2STR(IPIP_TNL_TSO),\n+\tRTE_TX_OFFLOAD_BIT2STR(GENEVE_TNL_TSO),\n+\tRTE_TX_OFFLOAD_BIT2STR(MACSEC_INSERT),\n+\tRTE_TX_OFFLOAD_BIT2STR(MT_LOCKFREE),\n+\tRTE_TX_OFFLOAD_BIT2STR(MULTI_SEGS),\n+\tRTE_TX_OFFLOAD_BIT2STR(MBUF_FAST_FREE),\n+\tRTE_TX_OFFLOAD_BIT2STR(SECURITY),\n+};\n+\n+#undef RTE_TX_OFFLOAD_BIT2STR\n+\n /**\n * The user application callback description.\n *\n@@ -788,6 +817,22 @@ rte_eth_dev_rx_offload_name(uint64_t offload)\n \treturn name;\n }\n \n+const char *\n+rte_eth_dev_tx_offload_name(uint64_t offload)\n+{\n+\tconst char *name = \"UNKNOWN\";\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < RTE_DIM(rte_tx_offload_names); ++i) {\n+\t\tif (offload == rte_tx_offload_names[i].offload) {\n+\t\t\tname = rte_tx_offload_names[i].name;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\treturn name;\n+}\n+\n int\n rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\t const struct rte_eth_conf *dev_conf)\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex f37a5b8..8f26f50 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -981,6 +981,11 @@ struct rte_eth_conf {\n */\n #define DEV_TX_OFFLOAD_SECURITY 0x00020000\n \n+/*\n+ * If new Tx offload capabilities are defined, they also must be\n+ * mentioned in rte_tx_offload_names in rte_ethdev.c file.\n+ */\n+\n struct rte_pci_device;\n \n /**\n@@ -1941,6 +1946,19 @@ uint32_t rte_eth_speed_bitflag(uint32_t speed, int duplex);\n const char *rte_eth_dev_rx_offload_name(uint64_t offload);\n \n /**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice\n+ *\n+ * Get DEV_TX_OFFLOAD_* flag name.\n+ *\n+ * @param offload\n+ * Offload flag.\n+ * @return\n+ * Offload name or 'UNKNOWN' if the flag cannot be recognised.\n+ */\n+const char *rte_eth_dev_tx_offload_name(uint64_t offload);\n+\n+/**\n * Configure an Ethernet device.\n * This function must be invoked first before any other function in the\n * Ethernet API. This function can also be re-invoked when a device is in the\ndiff --git a/lib/librte_ether/rte_ethdev_version.map b/lib/librte_ether/rte_ethdev_version.map\nindex 83a9926..4e166a7 100644\n--- a/lib/librte_ether/rte_ethdev_version.map\n+++ b/lib/librte_ether/rte_ethdev_version.map\n@@ -202,6 +202,7 @@ EXPERIMENTAL {\n \tglobal:\n \n \trte_eth_dev_rx_offload_name;\n+\trte_eth_dev_tx_offload_name;\n \trte_mtr_capabilities_get;\n \trte_mtr_create;\n \trte_mtr_destroy;\n", "prefixes": [ "dpdk-dev", "v4", "2/6" ] }