Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 33865,
    "url": "https://patches.dpdk.org/api/patches/33865/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180116182558.6254-11-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180116182558.6254-11-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180116182558.6254-11-stephen@networkplumber.org",
    "date": "2018-01-16T18:25:53",
    "name": "[dpdk-dev,v4,10/15] net/i40e: use rte_eth_linkstatus functions",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "5ba40f828632566e9c9fe8b19e122bdce4366dc8",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180116182558.6254-11-stephen@networkplumber.org/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/33865/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/33865/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 86D041B021;\n\tTue, 16 Jan 2018 19:26:26 +0100 (CET)",
            "from mail-pg0-f68.google.com (mail-pg0-f68.google.com\n\t[74.125.83.68]) by dpdk.org (Postfix) with ESMTP id 41B181B37A\n\tfor <dev@dpdk.org>; Tue, 16 Jan 2018 19:26:16 +0100 (CET)",
            "by mail-pg0-f68.google.com with SMTP id r19so4152212pgn.1\n\tfor <dev@dpdk.org>; Tue, 16 Jan 2018 10:26:16 -0800 (PST)",
            "from xeon-e3.lan (204-195-18-133.wavecable.com. [204.195.18.133])\n\tby smtp.gmail.com with ESMTPSA id\n\tx17sm3940497pge.50.2018.01.16.10.26.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 16 Jan 2018 10:26:14 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=RsltqttZrmWueDTX7IoPklMpTsZ+kFMiZozVRX9vBkM=;\n\tb=oM3Oxrsk1nIiZDIfTh71w8J6JDPMHyWqd8tbPaRVBUne0G/eKlVoob+ErV5h0dlkmU\n\tyhEb4/csA26MyZ1k6R5YGLf/0TMiRQHhZqkmc4c/jHhyBVfpX5rTz639vWZBXayh3uMr\n\tPht1fpu1NE4fSg7G3ugZkc9cvyOdY/bb3tcFWo0tTiYJOPWGM7J3FgOo7whqTe7Kt67p\n\toOZGmeSYpDQiQeJv8qLFLVz0SNKJ5TiAluufw8MeBBHY7NqxmodV91WVdqwqdgPrx+kd\n\tmNKUrsU058cUvYWBgj9yPn5gDrpRI2zVkW+zrWYiVh5Jn4fLPLuczS4SAA77rFDXZ8EC\n\tYtSw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=RsltqttZrmWueDTX7IoPklMpTsZ+kFMiZozVRX9vBkM=;\n\tb=L23gQDJClh8d/YzkzIDF3oHAZfUdjOiu/bau7jvVqXcQqAA3rexrB3DUWvPGNfmomC\n\teKZMuHM2X8ab9U3uEHaOZ6OZQ6dTsbMBgPvBTLsv/ApTHFhYcWYTB5cg2GXHGdNY2lmv\n\tNnjGCWft4ZngMMGGL2R5U5bCpMut5yQ4LFV3O2XfkC6MDI5MA2Oezk+m5/C5vft9Je8e\n\t2qN4qP/SjjN6j9WX11L9HAqwXU+cDQi7N9zXMNTWxfyKl6TIHukz9IlMneI+uc1z0IFt\n\tQErclAWfDjYaRQLst/Z161ky+cOUvx/kSyKjOHc0M2qr75ttgi66aELy2/uQquHoZ4zb\n\tHoxA==",
        "X-Gm-Message-State": "AKGB3mK821t/amJ8YVkcy2llOUI6vxzqXvjn4XkXbWateuCyf4AZRfLS\n\t6ClZ3khjObb13v6pjyYnZseW455a5WU=",
        "X-Google-Smtp-Source": "ACJfBotbnDmUV13OFdUBlVJs6ZLYb7yFfyhSsCwsWCLq2dzj/OPPvySuAdMZMGXXCluFdjlbSVO3/Q==",
        "X-Received": "by 10.101.81.7 with SMTP id f7mr30260870pgq.439.1516127175046;\n\tTue, 16 Jan 2018 10:26:15 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Tue, 16 Jan 2018 10:25:53 -0800",
        "Message-Id": "<20180116182558.6254-11-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.15.1",
        "In-Reply-To": "<20180116182558.6254-1-stephen@networkplumber.org>",
        "References": "<20180116182558.6254-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH v4 10/15] net/i40e: use rte_eth_linkstatus\n\tfunctions",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Use new rte_linkstatus update API\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/i40e/i40e_ethdev.c    | 43 +++++----------------------------------\n drivers/net/i40e/i40e_ethdev_vf.c | 18 ++--------------\n 2 files changed, 7 insertions(+), 54 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex fc386154f0b9..517918624658 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -627,34 +627,6 @@ static struct rte_pci_driver rte_i40e_pmd = {\n \t.remove = eth_i40e_pci_remove,\n };\n \n-static inline int\n-rte_i40e_dev_atomic_read_link_status(struct rte_eth_dev *dev,\n-\t\t\t\t     struct rte_eth_link *link)\n-{\n-\tstruct rte_eth_link *dst = link;\n-\tstruct rte_eth_link *src = &(dev->data->dev_link);\n-\n-\tif (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,\n-\t\t\t\t\t*(uint64_t *)src) == 0)\n-\t\treturn -1;\n-\n-\treturn 0;\n-}\n-\n-static inline int\n-rte_i40e_dev_atomic_write_link_status(struct rte_eth_dev *dev,\n-\t\t\t\t      struct rte_eth_link *link)\n-{\n-\tstruct rte_eth_link *dst = &(dev->data->dev_link);\n-\tstruct rte_eth_link *src = link;\n-\n-\tif (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,\n-\t\t\t\t\t*(uint64_t *)src) == 0)\n-\t\treturn -1;\n-\n-\treturn 0;\n-}\n-\n RTE_PMD_REGISTER_PCI(net_i40e, rte_i40e_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(net_i40e, pci_id_i40e_map);\n RTE_PMD_REGISTER_KMOD_DEP(net_i40e, \"* igb_uio | uio_pci_generic | vfio-pci\");\n@@ -2327,17 +2299,16 @@ i40e_dev_link_update(struct rte_eth_dev *dev,\n #define MAX_REPEAT_TIME 10  /* 1s (10 * 100ms) in total */\n \tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct i40e_link_status link_status;\n-\tstruct rte_eth_link link, old;\n+\tstruct rte_eth_link link;\n \tint status;\n \tunsigned rep_cnt = MAX_REPEAT_TIME;\n \tbool enable_lse = dev->data->dev_conf.intr_conf.lsc ? true : false;\n \n \tmemset(&link, 0, sizeof(link));\n-\tmemset(&old, 0, sizeof(old));\n-\tmemset(&link_status, 0, sizeof(link_status));\n-\trte_i40e_dev_atomic_read_link_status(dev, &old);\n \n \tdo {\n+\t\tmemset(&link_status, 0, sizeof(link_status));\n+\n \t\t/* Get link status information from hardware */\n \t\tstatus = i40e_aq_get_link_info(hw, enable_lse,\n \t\t\t\t\t\t&link_status, NULL);\n@@ -2390,10 +2361,7 @@ i40e_dev_link_update(struct rte_eth_dev *dev,\n \t\t\tETH_LINK_SPEED_FIXED);\n \n out:\n-\trte_i40e_dev_atomic_write_link_status(dev, &link);\n-\tif (link.link_status == old.link_status)\n-\t\treturn -1;\n-\n+\trte_eth_linkstatus_set(dev, &link);\n \ti40e_notify_all_vfs_link_status(dev);\n \n \treturn 0;\n@@ -9854,9 +9822,8 @@ i40e_start_timecounters(struct rte_eth_dev *dev)\n \tuint32_t tsync_inc_h;\n \n \t/* Get current link speed. */\n-\tmemset(&link, 0, sizeof(link));\n \ti40e_dev_link_update(dev, 1);\n-\trte_i40e_dev_atomic_read_link_status(dev, &link);\n+\trte_eth_linkstatus_get(dev, &link);\n \n \tswitch (link.link_speed) {\n \tcase ETH_SPEED_NUM_40G:\ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex b96d77a0caed..0605fc107240 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -1034,20 +1034,6 @@ static const struct rte_pci_id pci_id_i40evf_map[] = {\n \t{ .vendor_id = 0, /* sentinel */ },\n };\n \n-static inline int\n-i40evf_dev_atomic_write_link_status(struct rte_eth_dev *dev,\n-\t\t\t\t    struct rte_eth_link *link)\n-{\n-\tstruct rte_eth_link *dst = &(dev->data->dev_link);\n-\tstruct rte_eth_link *src = link;\n-\n-\tif (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,\n-\t\t\t\t\t*(uint64_t *)src) == 0)\n-\t\treturn -1;\n-\n-\treturn 0;\n-}\n-\n /* Disable IRQ0 */\n static inline void\n i40evf_disable_irq0(struct i40e_hw *hw)\n@@ -2069,6 +2055,7 @@ i40evf_dev_link_update(struct rte_eth_dev *dev,\n \t * while Linux driver does not\n \t */\n \n+\tmemset(&new_link, 0, sizeof(new_link));\n \t/* Linux driver PF host */\n \tswitch (vf->link_speed) {\n \tcase I40E_LINK_SPEED_100MB:\n@@ -2100,8 +2087,7 @@ i40evf_dev_link_update(struct rte_eth_dev *dev,\n \tnew_link.link_autoneg =\n \t\tdev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED;\n \n-\ti40evf_dev_atomic_write_link_status(dev, &new_link);\n-\n+\trte_eth_linkstatus_set(dev, &new_link);\n \treturn 0;\n }\n \n",
    "prefixes": [
        "dpdk-dev",
        "v4",
        "10/15"
    ]
}